@query-doctor/core 0.2.0 → 0.2.1

package/dist/index.js

@@ -879,7 +879,13 @@ var _PgIdentifier = class _PgIdentifier {
    */
   static fromParts(...identifiers) {
     return new _PgIdentifier(
-      identifiers.map((identifier) => _PgIdentifier.fromString(identifier)).join("."),
+      identifiers.map((identifier) => {
+        if (typeof identifier === "string") {
+          return _PgIdentifier.fromString(identifier);
+        } else {
+          return identifier;
+        }
+      }).join("."),
       false
     );
   }
@@ -1092,7 +1098,7 @@ var _IndexOptimizer = class _IndexOptimizer {
       }
       for (const permutation of toCreate) {
         const createIndex = PostgresQueryBuilder.createIndex(
-          this.toDefinition(permutation).raw,
+          permutation.definition,
           permutation.name
         ).introspect().build();
         await tx.exec(createIndex);
@@ -1122,7 +1128,11 @@ var _IndexOptimizer = class _IndexOptimizer {
       finalCost,
       newIndexes: finalIndexes.newIndexes,
       existingIndexes: baseIndexes.existingIndexes,
-      triedIndexes: new Map(toCreate.map((index) => [index.name, index])),
+      triedIndexes: new Map(
+        // TODO: don't prematurely stringify PgIdentifier here
+        // (requires more work)
+        toCreate.map((index) => [index.name.toString(), index])
+      ),
       baseExplainPlan: baseExplain.Plan,
       explainPlan: finalExplain.Plan
     };
@@ -1156,7 +1166,8 @@ var _IndexOptimizer = class _IndexOptimizer {
    * overflow that limit.
    */
   indexName() {
-    return _IndexOptimizer.prefix + Math.random().toString(36).substring(2, 16);
+    const indexName = _IndexOptimizer.prefix + Math.random().toString(36).substring(2, 16);
+    return PgIdentifier.fromString(indexName);
   }
   // TODO: this doesn't belong in the optimizer
   indexAlreadyExists(table, columns) {
@@ -1187,7 +1198,7 @@ var _IndexOptimizer = class _IndexOptimizer {
           continue;
         }
         const indexName = this.indexName();
-        const definition = this.toDefinition(permutation).raw;
+        const definition = this.toDefinition({ table, schema, columns: columns2 }).raw;
         iter = permutations.next(PROCEED);
         nextStage.push({
           name: indexName,
@@ -1200,18 +1211,19 @@ var _IndexOptimizer = class _IndexOptimizer {
     }
     return nextStage;
   }
-  toDefinition(permuted) {
+  toDefinition({
+    schema,
+    table,
+    columns
+  }) {
     const make = (col, order, where, keyword) => {
       let fullyQualifiedTable;
-      if (permuted.schema.toString() === "public") {
-        fullyQualifiedTable = PgIdentifier.fromString(permuted.table);
+      if (schema.toString() === "public") {
+        fullyQualifiedTable = table;
       } else {
-        fullyQualifiedTable = PgIdentifier.fromParts(
-          permuted.schema,
-          permuted.table
-        );
+        fullyQualifiedTable = PgIdentifier.fromParts(schema, table);
       }
-      const baseColumn = `${fullyQualifiedTable}(${permuted.columns.map((c) => {
+      const baseColumn = `${fullyQualifiedTable}(${columns.map((c) => {
         const column = PgIdentifier.fromString(c.column);
         const direction = c.sort && this.sortDirection(c.sort);
         const nulls = c.sort && this.nullsOrder(c.sort);