@query-doctor/core 0.1.7 → 0.1.10

package/dist/index.js

@@ -139,6 +139,23 @@ function parseNudges(node, stack) {
       });
     }
   }
+  if (is(node, "A_Expr")) {
+    if (node.A_Expr.kind === "AEXPR_IN") {
+      let list;
+      if (node.A_Expr.lexpr && is(node.A_Expr.lexpr, "List")) {
+        list = node.A_Expr.lexpr.List;
+      } else if (node.A_Expr.rexpr && is(node.A_Expr.rexpr, "List")) {
+        list = node.A_Expr.rexpr.List;
+      }
+      if (list?.items && list.items.length >= 10) {
+        nudges.push({
+          kind: "REPLACE_LARGE_IN_TUPLE_WITH_ANY_ARRAY",
+          message: "`in (...)` queries with large tuples can often be replaced with `= ANY($1)` using a single parameter",
+          severity: "INFO"
+        });
+      }
+    }
+  }
   return nudges;
 }
 function containsColumnRef(args) {
@@ -294,9 +311,12 @@ var Walker = class _Walker {
             part.schema = node.RangeVar.schemaname;
           }
           if (existingMapping) {
-            console.warn(
-              `Ignoring alias ${aliasName} as it shadows an existing mapping for ${existingMapping.text}. We currently do not support alias shadowing.`
-            );
+            const isSystemCatalog = node.RangeVar.relname?.startsWith("pg_") ?? false;
+            if (!isSystemCatalog) {
+              console.warn(
+                `Ignoring alias ${aliasName} as it shadows an existing mapping for ${existingMapping.text}. We currently do not support alias shadowing.`
+              );
+            }
             this.shadowedAliases.push(part);
             return;
           }
@@ -694,7 +714,7 @@ var Analyzer = class {
       return { tags: [], queryWithoutTags: trimmedQuery };
     }
     const queryWithoutTags = trimmedQuery.slice(0, startPosition);
-    const tagString = trimmedQuery.slice(startPosition + 2, endPosition);
+    const tagString = trimmedQuery.slice(startPosition + 2, endPosition).trim();
     if (!tagString || typeof tagString !== "string") {
       return { tags: [], queryWithoutTags };
     }
@@ -702,7 +722,11 @@ var Analyzer = class {
     for (const match of tagString.split(",")) {
       const [key, value] = match.split("=");
       if (!key || !value) {
-        console.warn(`Invalid sqlcommenter tag: ${match}. Ignoring`);
+        if (tags.length > 0) {
+          console.warn(
+            `Invalid sqlcommenter tag: ${match} in comment: ${tagString}. Ignoring`
+          );
+        }
         continue;
       }
       try {
@@ -1108,6 +1132,24 @@ var _IndexOptimizer = class _IndexOptimizer {
       await this.dropExistingIndexes(tx);
     });
   }
+  /**
+   * Given the current indexes in the optimizer, transform them in some
+   * way to change which indexes will be assumed to exist when optimizing
+   *
+   * @example
+   * ```
+   * // resets indexes
+   * optimizer.transformIndexes(() => [])
+   *
+   * // adds new index
+   * optimizer.transformIndexes(indexes => [...indexes, newIndex])
+   * ```
+   */
+  transformIndexes(f) {
+    const newIndexes = f(this.existingIndexes);
+    this.existingIndexes = newIndexes;
+    return this;
+  }
   /**
    * Postgres has a limit of 63 characters for index names.
    * So we use this to make sure we don't derive it from a list of columns that can