@quereus/quereus 4.20.2 → 4.21.0

package/test/logic/50.2.1-declare-schema-index-renames.sqllogic

@@ -1,173 +1,210 @@
--- 50.2.1-declare-schema-index-renames.sqllogic
---
--- requires-capability: standalone-index-ddl
---
--- Carved out of 50.2-declare-schema-renames: the declarative-schema rename/diff engine
--- treats tables, views and indexes as three parallel object kinds, and 50.2 exercises the
--- whole engine (hint resolution, drop+create ordering, in-diff column and table renames,
--- rename policies, ambiguity guards) on the table and view kinds with no index DDL.
--- These four sections are the INDEX-kind instances, so they live here.
---
--- Section numbers keep their original 50.2 labels so cross-references still resolve.
---
--- Subject: a hinted index rename becomes DROP INDEX + recreate, orders correctly against
--- an in-diff column or table rename of its source, and does not trip the require-hint
--- guard.
-
--- ===================================
--- 17. Hinted INDEX rename, body unchanged → drop + recreate
--- ===================================
-
-create table ir_t (id integer primary key, category text);
-create index ix_old on ir_t (category);
+-- 50.2.1-declare-schema-index-renames.sqllogic
+--
+-- requires-capability: standalone-index-ddl
+--
+-- Carved out of 50.2-declare-schema-renames: the declarative-schema rename/diff engine
+-- treats tables, views and indexes as three parallel object kinds, and 50.2 exercises the
+-- whole engine (hint resolution, drop+create ordering, in-diff column and table renames,
+-- rename policies, ambiguity guards) on the table and view kinds with no index DDL.
+-- These four sections are the INDEX-kind instances, so they live here.
+--
+-- Section numbers keep their original 50.2 labels so cross-references still resolve.
+--
+-- Subject: a hinted index rename becomes DROP INDEX + recreate, orders correctly against
+-- an in-diff column or table rename of its source, and does not trip the require-hint
+-- guard.
+
+-- ===================================
+-- 17. Hinted INDEX rename, body unchanged → drop + recreate
+-- ===================================
+
+create table ir_t (id integer primary key, category text);
+create index ix_old on ir_t (category);
+
+declare schema main {
+	table ir_t {
+		id integer primary key,
+		category text
+	}
+
+	index ix_new on ir_t (category) with tags ("quereus.previous_name" = 'ix_old')
+}
+
+-- run
+
+diff schema main;
+→ [{"ddl": "DROP INDEX IF EXISTS ix_old"}, {"ddl": "create index ix_new on ir_t (category) with tags (\"quereus.previous_name\" = 'ix_old')"}]
+
+apply schema main;
+
+-- run
+
+select name, tbl_name from schema() where type = 'index';
+→ [{"name": "ix_new", "tbl_name": "ir_t"}]
+
+diff schema main;
+→ []
+
+drop index ix_new;
+drop table ir_t;
+
+-- ===================================
+-- 20. Hinted INDEX rename + in-diff COLUMN rename of its table
+-- ===================================
+
+create table irc_t (id integer primary key, amount integer not null);
+create index irc_old on irc_t (amount);
+
+declare schema main {
+	table irc_t {
+		id integer primary key,
+		qty integer not null with tags ("quereus.previous_name" = 'amount')
+	}
+
+	index irc_new on irc_t (qty) with tags ("quereus.previous_name" = 'irc_old')
+}
+
+-- run
+
+-- The recreate names the NEW column (index creates run after RENAME COLUMN).
+diff schema main;
+→ [{"ddl": "DROP INDEX IF EXISTS irc_old"}, {"ddl": "ALTER TABLE irc_t RENAME COLUMN amount TO qty"}, {"ddl": "create index irc_new on irc_t (qty) with tags (\"quereus.previous_name\" = 'irc_old')"}]
+
+apply schema main;
+
+-- run
+
+select name from schema() where type = 'index';
+→ [{"name": "irc_new"}]
+
+diff schema main;
+→ []
+
+drop index irc_new;
+drop table irc_t;
+
+-- ===================================
+-- 21. require-hint: hinted view + index renames apply cleanly
+-- ===================================
+
+-- A hinted rename's drop+create pair is deliberate, not an ambiguous unhinted
+-- rename — it must not trip the require-hint guard (excluded from the counts,
+-- like the body-change recreates of §14).
+
+create table rh2_t (id integer primary key, v integer);
+create view rh2_vold as select id, v from rh2_t;
+create index rh2_ixold on rh2_t (v);
+
+declare schema main {
+	table rh2_t {
+		id integer primary key,
+		v integer
+	}
+
+	view rh2_vnew as select id, v from rh2_t with tags ("quereus.previous_name" = 'rh2_vold')
+
+	index rh2_ixnew on rh2_t (v) with tags ("quereus.previous_name" = 'rh2_ixold')
+}
+
+-- run
+
+apply schema main options (rename_policy = 'require-hint');
+
+-- run
+
+diff schema main;
+→ []
+
+select name from schema() where type = 'view';
+→ [{"name": "rh2_vnew"}]
+
+select name from schema() where type = 'index';
+→ [{"name": "rh2_ixnew"}]
+
+drop view rh2_vnew;
+drop index rh2_ixnew;
+drop table rh2_t;
+
+-- ===================================
+-- 22. Hinted VIEW + INDEX rename + in-diff TABLE rename of their source
+-- ===================================
+
+-- The recreates keep the DECLARED table name (no inverse table pass): table
+-- renames emit FIRST in migration order, so the new name is live by the time
+-- the view/index creates plan their bodies.
+
+create table src_old (id integer primary key, v integer);
+create view trv_old as select id, v from src_old;
+create index tri_old on src_old (v);
+insert into src_old values (1, 10);
+
+declare schema main {
+	table src_new {
+		id integer primary key,
+		v integer
+	} with tags ("quereus.previous_name" = 'src_old')
+
+	view trv_new as select id, v from src_new with tags ("quereus.previous_name" = 'trv_old')
+
+	index tri_new on src_new (v) with tags ("quereus.previous_name" = 'tri_old')
+}
+
+-- run
+
+diff schema main;
+→ [{"ddl": "ALTER TABLE src_old RENAME TO src_new"}, {"ddl": "DROP VIEW IF EXISTS trv_old"}, {"ddl": "DROP INDEX IF EXISTS tri_old"}, {"ddl": "create view trv_new as select id, v from src_new with tags (\"quereus.previous_name\" = 'trv_old')"}, {"ddl": "create index tri_new on src_new (v) with tags (\"quereus.previous_name\" = 'tri_old')"}]
+
+apply schema main;
+
+-- run
+
+select * from trv_new order by id;
+→ [{"id": 1, "v": 10}]
+
+select name, tbl_name from schema() where type = 'index';
+→ [{"name": "tri_new", "tbl_name": "src_new"}]
+
+diff schema main;
+→ []
+
+drop view trv_new;
+drop index tri_new;
+drop table src_new;
+
+-- Index creates run after the table-alter block, so one round can add a column
+-- and index it (the create used to run before ADD COLUMN and failed with
+-- "Column not found").
+
+create table aci_t (id integer primary key);
+insert into aci_t values (1);
 
 declare schema main {
-	table ir_t {
+	table aci_t {
 		id integer primary key,
-		category text
+		b text null
 	}
 
-	index ix_new on ir_t (category) with tags ("quereus.previous_name" = 'ix_old')
+	index aci_b on aci_t (b)
 }
 
 -- run
 
 diff schema main;
-→ [{"ddl": "DROP INDEX IF EXISTS ix_old"}, {"ddl": "create index ix_new on ir_t (category) with tags (\"quereus.previous_name\" = 'ix_old')"}]
+→ [{"ddl": "ALTER TABLE aci_t ADD COLUMN b text null"}, {"ddl": "create index aci_b on aci_t (b)"}]
 
 apply schema main;
 
 -- run
 
 select name, tbl_name from schema() where type = 'index';
-→ [{"name": "ix_new", "tbl_name": "ir_t"}]
-
-diff schema main;
-→ []
-
-drop index ix_new;
-drop table ir_t;
-
--- ===================================
--- 20. Hinted INDEX rename + in-diff COLUMN rename of its table
--- ===================================
-
-create table irc_t (id integer primary key, amount integer not null);
-create index irc_old on irc_t (amount);
-
-declare schema main {
-	table irc_t {
-		id integer primary key,
-		qty integer not null with tags ("quereus.previous_name" = 'amount')
-	}
-
-	index irc_new on irc_t (qty) with tags ("quereus.previous_name" = 'irc_old')
-}
-
--- run
-
--- The recreate names the OLD column (RENAME COLUMN runs after creates); the
--- propagation rewrites the fresh index's columns.
-diff schema main;
-→ [{"ddl": "DROP INDEX IF EXISTS irc_old"}, {"ddl": "create index irc_new on irc_t (amount) with tags (\"quereus.previous_name\" = 'irc_old')"}, {"ddl": "ALTER TABLE irc_t RENAME COLUMN amount TO qty"}]
-
-apply schema main;
-
--- run
-
-select name from schema() where type = 'index';
-→ [{"name": "irc_new"}]
-
-diff schema main;
-→ []
-
-drop index irc_new;
-drop table irc_t;
-
--- ===================================
--- 21. require-hint: hinted view + index renames apply cleanly
--- ===================================
-
--- A hinted rename's drop+create pair is deliberate, not an ambiguous unhinted
--- rename — it must not trip the require-hint guard (excluded from the counts,
--- like the body-change recreates of §14).
-
-create table rh2_t (id integer primary key, v integer);
-create view rh2_vold as select id, v from rh2_t;
-create index rh2_ixold on rh2_t (v);
-
-declare schema main {
-	table rh2_t {
-		id integer primary key,
-		v integer
-	}
+→ [{"name": "aci_b", "tbl_name": "aci_t"}]
 
-	view rh2_vnew as select id, v from rh2_t with tags ("quereus.previous_name" = 'rh2_vold')
-
-	index rh2_ixnew on rh2_t (v) with tags ("quereus.previous_name" = 'rh2_ixold')
-}
-
--- run
-
-apply schema main options (rename_policy = 'require-hint');
-
--- run
-
-diff schema main;
-→ []
-
-select name from schema() where type = 'view';
-→ [{"name": "rh2_vnew"}]
-
-select name from schema() where type = 'index';
-→ [{"name": "rh2_ixnew"}]
-
-drop view rh2_vnew;
-drop index rh2_ixnew;
-drop table rh2_t;
-
--- ===================================
--- 22. Hinted VIEW + INDEX rename + in-diff TABLE rename of their source
--- ===================================
-
--- The recreates keep the DECLARED table name (no inverse table pass): table
--- renames emit FIRST in migration order, so the new name is live by the time
--- the view/index creates plan their bodies.
-
-create table src_old (id integer primary key, v integer);
-create view trv_old as select id, v from src_old;
-create index tri_old on src_old (v);
-insert into src_old values (1, 10);
-
-declare schema main {
-	table src_new {
-		id integer primary key,
-		v integer
-	} with tags ("quereus.previous_name" = 'src_old')
-
-	view trv_new as select id, v from src_new with tags ("quereus.previous_name" = 'trv_old')
-
-	index tri_new on src_new (v) with tags ("quereus.previous_name" = 'tri_old')
-}
-
--- run
-
-diff schema main;
-→ [{"ddl": "ALTER TABLE src_old RENAME TO src_new"}, {"ddl": "DROP VIEW IF EXISTS trv_old"}, {"ddl": "DROP INDEX IF EXISTS tri_old"}, {"ddl": "create view trv_new as select id, v from src_new with tags (\"quereus.previous_name\" = 'trv_old')"}, {"ddl": "create index tri_new on src_new (v) with tags (\"quereus.previous_name\" = 'tri_old')"}]
-
-apply schema main;
-
--- run
-
-select * from trv_new order by id;
-→ [{"id": 1, "v": 10}]
-
-select name, tbl_name from schema() where type = 'index';
-→ [{"name": "tri_new", "tbl_name": "src_new"}]
+insert into aci_t values (2, 'x');
+select id from aci_t where b = 'x';
+→ [{"id": 2}]
 
 diff schema main;
 → []
 
-drop view trv_new;
-drop index tri_new;
-drop table src_new;
+drop index aci_b;
+drop table aci_t;