@quenty/valueobject 9.0.0 → 10.0.0

package/CHANGELOG.md

@@ -3,6 +3,58 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [10.0.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/valueobject@9.0.0...@quenty/valueobject@10.0.0) (2024-02-13)
+
+
+### Features
+
+* New loader (breaking changes), fixing loader issues  ([#439](https://github.com/Quenty/NevermoreEngine/issues/439)) ([3534345](https://github.com/Quenty/NevermoreEngine/commit/353434522918812953bd9f13fece73e27a4d034d))
+
+
+### BREAKING CHANGES
+
+* Standard loader
+
+Adds new loader version which replicates full structure instead of some partial structure. This allows us to have hot-reloading (in the future), as well as generally do less computation, handle dependencies more carefully, and other changes.
+
+This means you'll need to change you how require client-side modules, as we export a simple `loader` module instead of all modules available.
+
+Signed-off-by: James Onnen <jonnen0@gmail.com>
+
+* fix: Fix missing dependency in ResetService
+
+* feat: Add RxPhysicsUtils.observePartMass
+
+* fix: Fix package discovery for games
+
+* feat: Add UIAlignmentUtils.verticalToHorizontalAlignment(verticalAlignment) and UIAlignmentUtils.horizontalToVerticalAlignment(horizontalAlignment)
+
+* feat: AdorneeData:InitAttributes() does not require data as a  secondparameter
+
+* ci: Upgrade to new rojo 7.4.0
+
+* fix: Update loader to handle hoarcekat properly
+
+* docs: Fix spacing in Maid
+
+* fix: Add new ragdoll constants
+
+* fix: Compress influxDB sends
+
+* style: Errors use string.format
+
+* fix: Handle motor animations
+
+* ci: Upgrade rojo version
+
+* feat!: Maid no longer is includd in ValueObject.Changed event
+
+* docs: Fix docs
+
+
+
+
+
 # [9.0.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/valueobject@8.4.0...@quenty/valueobject@9.0.0) (2024-01-10)
 
 **Note:** Version bump only for package @quenty/valueobject

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/valueobject",
-  "version": "9.0.0",
+  "version": "10.0.0",
   "description": "To work like value objects in Roblox and track a single item with .Changed events",
   "keywords": [
     "Roblox",
@@ -26,15 +26,16 @@
     "Quenty"
   ],
   "dependencies": {
-    "@quenty/brio": "^10.0.0",
-    "@quenty/loader": "^7.3.0",
-    "@quenty/maid": "^2.6.0",
-    "@quenty/rx": "^9.0.0",
-    "@quenty/signal": "^4.0.0",
-    "@quenty/valuebaseutils": "^9.0.0"
+    "@quenty/brio": "^11.0.0",
+    "@quenty/ducktype": "^3.0.0",
+    "@quenty/loader": "^8.0.0",
+    "@quenty/maid": "^3.0.0",
+    "@quenty/rx": "^10.0.0",
+    "@quenty/signal": "^5.0.0",
+    "@quenty/valuebaseutils": "^10.0.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "bf8135721716c976201cb82133e0186ea606b166"
+  "gitHead": "5736b108e4d23cd4c9e761bbe4cc9fed6fb32dfa"
 }

package/src/Shared/ValueObject.lua

@@ -12,6 +12,7 @@ local Observable = require("Observable")
 local ValueBaseUtils = require("ValueBaseUtils")
 local RxValueBaseUtils = require("RxValueBaseUtils")
 local Brio = require("Brio")
+local DuckTypeUtils = require("DuckTypeUtils")
 
 local EMPTY_FUNCTION = function() end
 
@@ -40,8 +41,7 @@ function ValueObject.new(baseValue, checkType)
 	@prop Changed Signal<T> -- fires with oldValue, newValue, ...
 	@within ValueObject
 ]=]
-	self.Changed = GoodSignal.new() -- :Fire(newValue, oldValue, maid, ...)
-	self._maid:GiveTask(self.Changed)
+	self.Changed = self._maid:Add(GoodSignal.new()) -- :Fire(newValue, oldValue, ...)
 
 	return setmetatable(self, ValueObject)
 end
@@ -75,7 +75,7 @@ end
 	@return boolean
 ]=]
 function ValueObject.isValueObject(value)
-	return type(value) == "table" and getmetatable(value) == ValueObject
+	return DuckTypeUtils.isImplementation(ValueObject, value)
 end
 
 function ValueObject:_toMountableObservable(value)
@@ -150,7 +150,7 @@ function ValueObject:Observe()
 
 		local maid = Maid.new()
 
-		maid:GiveTask(self.Changed:Connect(function(newValue, _, _, ...)
+		maid:GiveTask(self.Changed:Connect(function(newValue, _, ...)
 			sub:Fire(newValue, ...)
 		end))
 
@@ -194,7 +194,7 @@ function ValueObject:ObserveBrio(condition)
 			end
 		end
 
-		maid:GiveTask(self.Changed:Connect(function(newValue, _, _, ...)
+		maid:GiveTask(self.Changed:Connect(function(newValue, _, ...)
 			handleNewValue(newValue, ...)
 		end))
 
@@ -216,7 +216,7 @@ end
 	```lua
 	self.IsVisible:SetValue(isVisible, true)
 
-	print(self.IsVisible.Changed:Connect(function(isVisible, _, _, doNotAnimate)
+	print(self.IsVisible.Changed:Connect(function(isVisible, _, doNotAnimate)
 		print(doNotAnimate)
 	end))
 	```
@@ -241,11 +241,7 @@ function ValueObject:SetValue(value, ...)
 
 		rawset(self, "_value", value)
 
-		local maid = Maid.new()
-
-		self.Changed:Fire(value, previous, maid, ...)
-
-		self._maid._valueMaid = maid
+		self.Changed:Fire(value, previous, ...)
 	end
 end
 
@@ -269,7 +265,7 @@ function ValueObject:__index(index)
 	elseif index == "_value" then
 		return nil -- Edge case
 	else
-		error(("%q is not a member of ValueObject"):format(tostring(index)))
+		error(string.format("%q is not a member of ValueObject", tostring(index)))
 	end
 end
 
@@ -278,9 +274,9 @@ function ValueObject:__newindex(index, value)
 		-- Avoid deoptimization
 		ValueObject.SetValue(self, value)
 	elseif index == "LastEventContext" or ValueObject[index] then
-		error(("%q cannot be set in ValueObject"):format(tostring(index)))
+		error(string.format("%q cannot be set in ValueObject", tostring(index)))
 	else
-		error(("%q is not a member of ValueObject"):format(tostring(index)))
+		error(string.format("%q is not a member of ValueObject", tostring(index)))
 	end
 end