@quenty/valueobject 3.2.0 → 3.4.0

package/CHANGELOG.md

@@ -3,6 +3,28 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [3.4.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/valueobject@3.3.0...@quenty/valueobject@3.4.0) (2021-12-14)
+
+
+### Features
+
+* ValueObject does not fire .Changed on cleanup. ([ffd1a82](https://github.com/Quenty/NevermoreEngine/commit/ffd1a82e9db55891672a439285731dbf99d19ad1))
+
+
+
+
+
+# [3.3.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/valueobject@3.2.0...@quenty/valueobject@3.3.0) (2021-11-20)
+
+
+### Bug Fixes
+
+* Support MacOS syncing ([#225](https://github.com/Quenty/NevermoreEngine/issues/225)) ([03f9183](https://github.com/Quenty/NevermoreEngine/commit/03f918392c6a5bdd33f8a17c38de371d1e06c67a))
+
+
+
+
+
 # [3.2.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/valueobject@3.1.2...@quenty/valueobject@3.2.0) (2021-10-30)
 
 **Note:** Version bump only for package @quenty/valueobject

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/valueobject",
-  "version": "3.2.0",
+  "version": "3.4.0",
   "description": "To work like value objects in Roblox and track a single item with .Changed events",
   "keywords": [
     "Roblox",
@@ -26,14 +26,14 @@
     "Quenty"
   ],
   "dependencies": {
-    "@quenty/brio": "^3.2.0",
+    "@quenty/brio": "^3.4.0",
     "@quenty/loader": "^3.1.1",
     "@quenty/maid": "^2.0.1",
-    "@quenty/rx": "^3.2.0",
+    "@quenty/rx": "^3.4.0",
     "@quenty/signal": "^2.0.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "010eff28095b349f39e02d08844d33f9f733b31f"
+  "gitHead": "8a33939501e25cf227e96f7eb0d1a23b86f10f3c"
 }

package/src/Shared/ValueObject.lua

@@ -35,6 +35,10 @@ function ValueObject.new(baseValue)
 	return setmetatable(self, ValueObject)
 end
 
+function ValueObject.isValueObject(value)
+	return type(value) == "table" and getmetatable(value) == ValueObject
+end
+
 function ValueObject:__index(index)
 	if index == "Value" then
 		return self._value
@@ -54,8 +58,10 @@ function ValueObject:__newindex(index, value)
 			rawset(self, "_value", value)
 
 			local maid = Maid.new()
-			self._maid._valueMaid = maid
+
 			self.Changed:Fire(value, previous, maid)
+
+			self._maid._valueMaid = maid
 		end
 	else
 		error(("%q is not a member of ValueObject"):format(tostring(index)))
@@ -64,8 +70,9 @@ end
 
 --- Forces the value to be nil on cleanup, cleans up the Maid
 function ValueObject:Destroy()
-	self.Value = nil
+	rawset(self, "_value", nil)
 	self._maid:DoCleaning()
+	setmetatable(self, nil)
 end
 
 return ValueObject

package/src/Shared/ValueObjectUtils.lua

@@ -6,6 +6,7 @@ local require = require(script.Parent.loader).load(script)
 local Maid = require("Maid")
 local Brio = require("Brio")
 local Observable = require("Observable")
+local ValueObject = require("ValueObject")
 
 local ValueObjectUtils = {}
 
@@ -21,9 +22,15 @@ function ValueObjectUtils.syncValue(from, to)
 end
 
 function ValueObjectUtils.observeValue(valueObject)
-	assert(valueObject, "Bad valueObject")
+	assert(ValueObject.isValueObject(valueObject), "Bad valueObject")
 
 	return Observable.new(function(sub)
+		if not valueObject.Destroy then
+			warn("[ValueObjectUtils.observeValue] - Connecting to dead ValueObject")
+			-- No firing, we're dead
+			return
+		end
+
 		local maid = Maid.new()
 
 		maid:GiveTask(valueObject.Changed:Connect(function()

package/src/node_modules.project.json

@@ -2,6 +2,6 @@
   "name": "node_modules",
   "globIgnorePaths": [ "**/.package-lock.json" ],
   "tree": {
-    "$path": { "optional": "..\\node_modules" }
+    "$path": { "optional": "../node_modules" }
   }
 }