@quenty/timesyncservice 13.18.3 → 13.18.4-canary.11a5dcf.0

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [13.18.4-canary.11a5dcf.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/timesyncservice@13.18.3...@quenty/timesyncservice@13.18.4-canary.11a5dcf.0) (2025-05-10)
+
+
+### Bug Fixes
+
+* Additional type checking updates ([05ba29a](https://github.com/Quenty/NevermoreEngine/commit/05ba29a03efc9f3feed74b34f1d9dfb237496214))
+
+
+
+
+
 ## [13.18.3](https://github.com/Quenty/NevermoreEngine/compare/@quenty/timesyncservice@13.18.2...@quenty/timesyncservice@13.18.3) (2025-04-10)
 
 **Note:** Version bump only for package @quenty/timesyncservice

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/timesyncservice",
-  "version": "13.18.3",
+  "version": "13.18.4-canary.11a5dcf.0",
   "description": "Quenty's TimeSyncService keeps time synchronized between all clients and the server",
   "keywords": [
     "Roblox",
@@ -26,18 +26,18 @@
     "Quenty"
   ],
   "dependencies": {
-    "@quenty/baseobject": "^10.8.3",
-    "@quenty/loader": "^10.8.3",
-    "@quenty/maid": "^3.4.3",
-    "@quenty/promise": "^10.10.4",
-    "@quenty/remoting": "^12.18.3",
-    "@quenty/rx": "^13.17.3",
-    "@quenty/signal": "^7.10.3",
-    "@quenty/table": "^3.7.4",
-    "@quenty/valueobject": "^13.17.3"
+    "@quenty/baseobject": "10.8.4-canary.11a5dcf.0",
+    "@quenty/loader": "10.8.4-canary.11a5dcf.0",
+    "@quenty/maid": "3.4.4-canary.11a5dcf.0",
+    "@quenty/promise": "10.10.5-canary.11a5dcf.0",
+    "@quenty/remoting": "12.18.4-canary.11a5dcf.0",
+    "@quenty/rx": "13.17.4-canary.11a5dcf.0",
+    "@quenty/signal": "7.10.4-canary.11a5dcf.0",
+    "@quenty/table": "3.7.5-canary.11a5dcf.0",
+    "@quenty/valueobject": "13.17.4-canary.11a5dcf.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "b06c070ae91d5dab7bd8de6e290ad2caabb15d8f"
+  "gitHead": "11a5dcf7d4c7a0bfbf3337e97d30e8346ea09d3f"
 }

package/src/Shared/Clocks/BaseClock.lua

@@ -0,0 +1,17 @@
+--!strict
+
+local require = require(script.Parent.loader).load(script)
+
+local Observable = require("Observable")
+
+export type ClockFunction = () -> number
+
+export type BaseClock = {
+	GetTime: (self: BaseClock) -> number,
+	GetPing: (self: BaseClock) -> number,
+	IsSynced: (self: BaseClock) -> boolean,
+	ObservePing: (self: BaseClock) -> Observable.Observable<number>,
+	GetClockFunction: (self: BaseClock) -> ClockFunction,
+}
+
+return {}

package/src/Shared/Clocks/MasterClock.lua

@@ -6,24 +6,23 @@
 
 local require = require(script.Parent.loader).load(script)
 
+local BaseClock = require("BaseClock")
 local BaseObject = require("BaseObject")
+local Observable = require("Observable")
 local Rx = require("Rx")
-local _Observable = require("Observable")
 
 local MasterClock = setmetatable({}, BaseObject)
 MasterClock.__index = MasterClock
 MasterClock.ClassName = "MasterClock"
 
-export type ClockFunction = () -> number
-
 export type MasterClock = typeof(setmetatable(
 	{} :: {
 		_remoteEvent: RemoteEvent,
 		_remoteFunction: RemoteFunction,
-		_clockFunction: ClockFunction,
+		_clockFunction: BaseClock.ClockFunction,
 	},
 	{} :: typeof({ __index = MasterClock })
-)) & BaseObject.BaseObject
+)) & BaseObject.BaseObject & BaseClock.BaseClock
 
 --[=[
 	Constructs a new MasterClock
@@ -69,7 +68,7 @@ end
 
 	@return function
 ]=]
-function MasterClock.GetClockFunction(self: MasterClock): ClockFunction
+function MasterClock.GetClockFunction(self: MasterClock): BaseClock.ClockFunction
 	return self._clockFunction
 end
 
@@ -78,7 +77,7 @@ end
 
 	@return Observable<number>
 ]=]
-function MasterClock.ObservePing(_self: MasterClock): _Observable.Observable<number>
+function MasterClock.ObservePing(_self: MasterClock): Observable.Observable<number>
 	return Rx.of(0) :: any
 end
 

package/src/Shared/Clocks/SlaveClock.lua

@@ -6,22 +6,21 @@
 
 local require = require(script.Parent.loader).load(script)
 
+local BaseClock = require("BaseClock")
 local BaseObject = require("BaseObject")
+local Observable = require("Observable")
 local ValueObject = require("ValueObject")
-local _Observable = require("Observable")
 
 local SlaveClock = setmetatable({}, BaseObject)
 SlaveClock.__index = SlaveClock
 SlaveClock.ClassName = "SlaveClock"
 SlaveClock._offset = -1 -- Set uncalculated values to -1
 
-export type ClockFunction = () -> number
-
 export type SlaveClock = typeof(setmetatable(
 	{} :: {
 		_remoteEvent: RemoteEvent,
 		_remoteFunction: RemoteFunction,
-		_clockFunction: ClockFunction,
+		_clockFunction: BaseClock.ClockFunction,
 		_ping: ValueObject.ValueObject<number>,
 		_offset: number,
 		_pneWayDelay: number,
@@ -30,7 +29,7 @@ export type SlaveClock = typeof(setmetatable(
 		SyncedEvent: RBXScriptSignal,
 	},
 	{} :: typeof({ __index = SlaveClock })
-)) & BaseObject.BaseObject
+)) & BaseObject.BaseObject & BaseClock.BaseClock
 
 --[=[
 	Constructs a new SlaveClock
@@ -67,11 +66,11 @@ end
 
 	@return function
 ]=]
-function SlaveClock.GetClockFunction(self: SlaveClock): ClockFunction
+function SlaveClock.GetClockFunction(self: SlaveClock): BaseClock.ClockFunction
 	return self._clockFunction
 end
 
-function SlaveClock.ObservePing(self: SlaveClock): _Observable.Observable<number>
+function SlaveClock.ObservePing(self: SlaveClock): Observable.Observable<number>
 	return self._ping:Observe()
 end
 

package/src/Shared/TimeSyncService.lua

@@ -10,10 +10,12 @@ local require = require(script.Parent.loader).load(script)
 
 local RunService = game:GetService("RunService")
 
+local BaseClock = require("BaseClock")
 local GetRemoteEvent = require("GetRemoteEvent")
 local GetRemoteFunction = require("GetRemoteFunction")
 local Maid = require("Maid")
 local MasterClock = require("MasterClock")
+local Observable = require("Observable")
 local Promise = require("Promise")
 local PromiseGetRemoteEvent = require("PromiseGetRemoteEvent")
 local PromiseGetRemoteFunction = require("PromiseGetRemoteFunction")
@@ -22,12 +24,11 @@ local Rx = require("Rx")
 local SlaveClock = require("SlaveClock")
 local TimeSyncConstants = require("TimeSyncConstants")
 local TimeSyncUtils = require("TimeSyncUtils")
-local _Observable = require("Observable")
 
 local TimeSyncService = {}
 TimeSyncService.ServiceName = "TimeSyncService"
 
-export type SyncedClock = MasterClock.MasterClock | SlaveClock.SlaveClock
+export type SyncedClock = BaseClock.BaseClock
 
 export type TimeSyncService = typeof(setmetatable(
 	{} :: {
@@ -75,6 +76,32 @@ function TimeSyncService.IsSynced(self: TimeSyncService): boolean
 	return self._clockPromise:IsFulfilled()
 end
 
+local function buildMockClock(): SyncedClock
+	local mock = {}
+
+	function mock.IsSynced(_this: SyncedClock): boolean
+		return true
+	end
+
+	function mock.GetTime(_this: SyncedClock): number
+		return tick()
+	end
+
+	function mock.GetPing(_this: SyncedClock): number
+		return 0
+	end
+
+	function mock.GetClockFunction(_this: SyncedClock): BaseClock.ClockFunction
+		return tick
+	end
+
+	function mock.ObservePing(_this: SyncedClock): Observable.Observable<number>
+		return Rx.of(0) :: any
+	end
+
+	return mock
+end
+
 --[=[
 	Waits for the synced clock, or throws an error.
 
@@ -83,7 +110,7 @@ end
 ]=]
 function TimeSyncService.WaitForSyncedClock(self: TimeSyncService): SyncedClock
 	if not RunService:IsRunning() then
-		return self:_buildMockClock()
+		return buildMockClock()
 	end
 
 	assert(self._clockPromise, "TimeSyncService is not initialized")
@@ -97,7 +124,7 @@ end
 ]=]
 function TimeSyncService.GetSyncedClock(self: TimeSyncService): SyncedClock?
 	if not RunService:IsRunning() then
-		return self:_buildMockClock()
+		return buildMockClock()
 	end
 
 	assert(self._clockPromise, "TimeSyncService is not initialized")
@@ -115,35 +142,17 @@ end
 ]=]
 function TimeSyncService.PromiseSyncedClock(self: TimeSyncService): Promise.Promise<SyncedClock>
 	if not RunService:IsRunning() then
-		return Promise.resolved(self:_buildMockClock())
+		return Promise.resolved(buildMockClock())
 	end
 
 	assert(self._clockPromise, "TimeSyncService is not initialized")
 	return Promise.resolved(self._clockPromise)
 end
 
-function TimeSyncService.ObserveSyncedClock(self: TimeSyncService): _Observable.Observable<SyncedClock>
+function TimeSyncService.ObserveSyncedClock(self: TimeSyncService): Observable.Observable<SyncedClock>
 	return Rx.fromPromise(self:PromiseSyncedClock()) :: any
 end
 
-function TimeSyncService._buildMockClock(_self: TimeSyncService): any
-	local mock = {}
-
-	function mock.IsSynced(_self)
-		return true
-	end
-
-	function mock.GetTime(_self)
-		return tick()
-	end
-
-	function mock.GetPing(_self)
-		return 0
-	end
-
-	return mock
-end
-
 function TimeSyncService._buildMasterClock(self: TimeSyncService): MasterClock.MasterClock
 	local remoteEvent = GetRemoteEvent(TimeSyncConstants.REMOTE_EVENT_NAME)
 	local remoteFunction = GetRemoteFunction(TimeSyncConstants.REMOTE_FUNCTION_NAME)
@@ -173,4 +182,4 @@ function TimeSyncService.Destroy(self: TimeSyncService)
 	self._maid:DoCleaning()
 end
 
-return TimeSyncService
+return TimeSyncService

package/src/Shared/TimeSyncUtils.lua

@@ -6,8 +6,8 @@
 
 local require = require(script.Parent.loader).load(script)
 
-local Promise = require("Promise")
 local Maid = require("Maid")
+local Promise = require("Promise")
 
 local TimeSyncUtils = {}
 
@@ -40,4 +40,4 @@ function TimeSyncUtils.promiseClockSynced(clock: any): Promise.Promise<any>
 	return promise
 end
 
-return TimeSyncUtils
+return TimeSyncUtils