@quenty/tie 5.0.0-canary.367.e9fdcbc.0 → 5.0.0

package/CHANGELOG.md

@@ -3,7 +3,106 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-# [5.0.0-canary.367.e9fdcbc.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/tie@4.19.0...@quenty/tie@5.0.0-canary.367.e9fdcbc.0) (2023-06-05)
+# [5.0.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/tie@4.29.0...@quenty/tie@5.0.0) (2023-10-11)
+
+
+* fix!: Make RxSignal not automatically skip first input ([6fe7586](https://github.com/Quenty/NevermoreEngine/commit/6fe7586029ea4753b1de7a8633c7d5af15bab420))
+
+
+### Features
+
+* Tie has better errors ([9e66f62](https://github.com/Quenty/NevermoreEngine/commit/9e66f621ff5b8e7c24800eca819612e9033c35c5))
+
+
+### BREAKING CHANGES
+
+* RxSignal used to export a different value
+
+
+
+
+
+# [4.29.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/tie@4.28.0...@quenty/tie@4.29.0) (2023-09-21)
+
+**Note:** Version bump only for package @quenty/tie
+
+
+
+
+
+# [4.28.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/tie@4.27.0...@quenty/tie@4.28.0) (2023-09-04)
+
+**Note:** Version bump only for package @quenty/tie
+
+
+
+
+
+# [4.27.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/tie@4.26.0...@quenty/tie@4.27.0) (2023-08-23)
+
+**Note:** Version bump only for package @quenty/tie
+
+
+
+
+
+# [4.26.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/tie@4.25.0...@quenty/tie@4.26.0) (2023-08-01)
+
+**Note:** Version bump only for package @quenty/tie
+
+
+
+
+
+# [4.25.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/tie@4.24.0...@quenty/tie@4.25.0) (2023-07-28)
+
+**Note:** Version bump only for package @quenty/tie
+
+
+
+
+
+# [4.24.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/tie@4.23.0...@quenty/tie@4.24.0) (2023-07-23)
+
+**Note:** Version bump only for package @quenty/tie
+
+
+
+
+
+# [4.23.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/tie@4.22.0...@quenty/tie@4.23.0) (2023-07-15)
+
+
+### Bug Fixes
+
+* Fix valueBase assignment and retrieval ([50453dd](https://github.com/Quenty/NevermoreEngine/commit/50453dd1562e00e1a619eb09870097f3deebed46))
+
+
+### Features
+
+* Add :Observe() API calls to a variety of systems and allow Blend to :Observe() stuff ([ca29c68](https://github.com/Quenty/NevermoreEngine/commit/ca29c68164dfdaf136e9168faf48f487bed26088))
+
+
+
+
+
+# [4.22.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/tie@4.21.0...@quenty/tie@4.22.0) (2023-07-10)
+
+**Note:** Version bump only for package @quenty/tie
+
+
+
+
+
+# [4.21.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/tie@4.20.0...@quenty/tie@4.21.0) (2023-06-17)
+
+**Note:** Version bump only for package @quenty/tie
+
+
+
+
+
+# [4.20.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/tie@4.19.0...@quenty/tie@4.20.0) (2023-06-05)
 
 
 ### Features

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/tie",
-  "version": "5.0.0-canary.367.e9fdcbc.0",
+  "version": "5.0.0",
   "description": "Tie allows interfaces to be defined between Lua OOP and Roblox objects.",
   "keywords": [
     "Roblox",
@@ -28,26 +28,27 @@
     "Quenty"
   ],
   "dependencies": {
-    "@quenty/attributeutils": "8.15.0",
-    "@quenty/baseobject": "6.2.1",
-    "@quenty/brio": "8.13.0",
-    "@quenty/instanceutils": "7.14.0",
-    "@quenty/loader": "6.2.1",
-    "@quenty/maid": "2.5.0",
-    "@quenty/rx": "7.11.0",
-    "@quenty/statestack": "9.0.0-canary.367.e9fdcbc.0",
-    "@quenty/string": "3.1.0",
-    "@quenty/symbol": "2.2.0",
-    "@quenty/table": "3.2.0",
-    "@quenty/valuebaseutils": "7.14.0",
-    "@quenty/valueobject": "8.0.0-canary.367.e9fdcbc.0"
+    "@quenty/attributeutils": "^9.0.0",
+    "@quenty/baseobject": "^7.0.0",
+    "@quenty/brio": "^9.0.0",
+    "@quenty/collectionserviceutils": "^3.0.0",
+    "@quenty/instanceutils": "^8.0.0",
+    "@quenty/loader": "^7.0.0",
+    "@quenty/maid": "^2.6.0",
+    "@quenty/rx": "^8.0.0",
+    "@quenty/statestack": "^9.0.0",
+    "@quenty/string": "^3.1.0",
+    "@quenty/symbol": "^2.2.0",
+    "@quenty/table": "^3.3.0",
+    "@quenty/valuebaseutils": "^8.0.0",
+    "@quenty/valueobject": "^8.0.0"
   },
   "devDependencies": {
-    "@quenty/promise": "6.5.0",
-    "@quenty/signal": "2.4.0"
+    "@quenty/promise": "^7.0.0",
+    "@quenty/signal": "^3.0.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "e9fdcbc6ea1d46e068bf42a08b833099e9005259"
+  "gitHead": "fdeae46099587019ec5fc15317dc673aed379400"
 }

package/src/Shared/Definition/TieDefinition.lua

@@ -11,6 +11,7 @@ local Maid = require("Maid")
 local Observable = require("Observable")
 local Rx = require("Rx")
 local RxBrioUtils = require("RxBrioUtils")
+local RxCollectionServiceUtils = require("RxCollectionServiceUtils")
 local RxInstanceUtils = require("RxInstanceUtils")
 local RxStateStackUtils = require("RxStateStackUtils")
 local String = require("String")
@@ -82,6 +83,85 @@ function TieDefinition:GetImplementations(adornee: Instance)
 	return implementations
 end
 
+--[=[
+	Observes all the children implementations for this adornee
+
+	@param adornee Instance
+	@return Observable<Brio<TieInterface>>
+]=]
+function TieDefinition:ObserveChildrenBrio(adornee: Instance)
+	return RxInstanceUtils.observeChildrenBrio(adornee):Pipe({
+		RxBrioUtils.flatMapBrio(function(child)
+			return self:ObserveBrio(child)
+		end)
+	})
+end
+
+--[=[
+	Promises the implementation
+
+	@param adornee Adornee
+	@return Promise<TieInterface>
+]=]
+function TieDefinition:Promise(adornee)
+	assert(typeof(adornee) == "Instance", "Bad adornee")
+
+	-- TODO: Support cancellation cleanup here.
+
+	return Rx.toPromise(self:Observe(adornee):Pipe({
+		Rx.where(function(value)
+			return value ~= nil
+		end)
+	}))
+end
+
+--[=[
+	Gets all valid interfaces for this adornee's children
+
+	@param adornee Instance
+	@return { TieInterface }
+]=]
+function TieDefinition:GetChildren(adornee: Instance)
+	assert(typeof(adornee) == "Instance", "Bad adornee")
+
+	local implementations = {}
+
+	-- TODO: Make this faster
+	for _, item in pairs(adornee:GetChildren()) do
+		for _, option in pairs(self:GetImplementations(item)) do
+			table.insert(implementations, option)
+		end
+	end
+
+	return implementations
+end
+
+--[=[
+	Finds the implementation on the adornee. Alais for [FindFirstImplementation]
+
+	@param adornee Adornee
+	@return TieInterface | nil
+]=]
+function TieDefinition:Find(adornee: Instance)
+	return self:FindFirstImplementation(adornee)
+end
+
+--[=[
+	Observes all implementations that are tagged with the given tag name
+
+	@param tagName string
+	@return TieInterface | nil
+]=]
+function TieDefinition:ObserveAllTaggedBrio(tagName)
+	assert(type(tagName) == "string", "Bad tagName")
+
+	return RxCollectionServiceUtils.observeTaggedBrio(tagName):Pipe({
+		RxBrioUtils.flatMapBrio(function(instance)
+			return self:ObserveBrio(instance)
+		end)
+	})
+end
+
 --[=[
 	Finds the first valid interfaces for this adornee
 	@param adornee Instance
@@ -196,6 +276,10 @@ function TieDefinition:ObserveLastImplementationBrio(adornee: Instance)
 		})
 end
 
+function TieDefinition:ObserveBrio(adornee: Instance)
+	return self:ObserveLastImplementationBrio(adornee)
+end
+
 --[=[
 	Observes a valid implementation if it exists, or nil
 
@@ -210,6 +294,9 @@ function TieDefinition:ObserveLastImplementation(adornee: Instance)
 	})
 end
 
+function TieDefinition:Observe(adornee: Instance)
+	return self:ObserveLastImplementation(adornee)
+end
 
 --[=[
 	Observes valid implementations wrapped in a brio if it exists.

package/src/Shared/Implementation/TieImplementation.lua

@@ -59,7 +59,7 @@ function TieImplementation:__index(index)
 	if memberMap[index] then
 		return memberMap[index]:GetInterface(self._folder, self)
 	else
-		error(("Bad index %q for TieImplementation"):format(tostring(index)))
+		error(string.format("Bad index %q for TieImplementation", tostring(index)))
 	end
 end
 

package/src/Shared/Implementation/TiePropertyImplementation.lua

@@ -100,7 +100,7 @@ function TiePropertyImplementation:_updateImplementation(maid, implementation)
 
 	local className = ValueBaseUtils.getClassNameFromType(typeof(implementation))
 	if not className then
-		error(("[TiePropertyImplementation] - Bad implementation value type %q, cannot set"):format(typeof(implementation)))
+		error(string.format("[TiePropertyImplementation] - Bad implementation value type %q, cannot set %s", typeof(implementation), self._memberDefinition:GetMemberName()))
 	end
 
 	local copy = self:_changeToClassIfNeeded(className, implementation)

package/src/Shared/Interface/TiePropertyInterface.lua

@@ -75,7 +75,7 @@ function TiePropertyInterface:_getFolder()
 	return TieInterfaceUtils.getFolder(self._tieDefinition, self._folder, self._adornee)
 end
 
-function TiePropertyInterface:_getValueBase()
+function TiePropertyInterface:_findValueBase()
 	local folder = self:_getFolder()
 	if not folder then
 		return nil
@@ -97,7 +97,7 @@ function TiePropertyInterface:_getValueBase()
 end
 
 function TiePropertyInterface:_getValueBaseOrError()
-	local valueBase = self:_getValueBase()
+	local valueBase = self:_findValueBase()
 	if not valueBase then
 		error(("%s.%s is not implemented for %s"):format(
 			self._tieDefinition:GetContainerName(),
@@ -151,6 +151,10 @@ function TiePropertyInterface:_observeFromFolder(folder)
 		local lastImplementationType = UNSET_VALUE
 
 		local function update()
+			if not sub:IsPending() then
+				return
+			end
+
 			-- Prioritize attributes first
 			local currentAttribute = folder:GetAttribute(memberName)
 			if currentAttribute ~= nil then
@@ -263,7 +267,15 @@ function TiePropertyInterface:__newindex(index, value)
 	if index == "_adornee" or index == "_folder" or index == "_memberDefinition" or index == "_tieDefinition" then
 		rawset(self, index, value)
 	elseif index == "Value" then
-		if AttributeUtils.isValidAttributeType(typeof(value)) and value ~= nil then
+		local className = ValueBaseUtils.getClassNameFromType(typeof(value))
+		if not className then
+			error(("[TiePropertyImplementation] - Bad implementation value type %q, cannot set"):format(typeof(value)))
+		end
+
+		local valueBase = self:_findValueBase()
+		if type(valueBase) == "table" or (typeof(valueBase) == "Instance" and valueBase.ClassName == className) then
+			valueBase.Value = value
+		elseif AttributeUtils.isValidAttributeType(typeof(value)) and value ~= nil then
 			local folder = self:_getFolder()
 			if folder then
 				folder:SetAttribute(self._memberDefinition:GetMemberName(), value)
@@ -275,16 +287,6 @@ function TiePropertyInterface:__newindex(index, value)
 				end
 				return
 			end
-		end
-
-		local className = ValueBaseUtils.getClassNameFromType(typeof(value))
-		if not className then
-			error(("[TiePropertyImplementation] - Bad implementation value type %q, cannot set"):format(typeof(value)))
-		end
-
-		local valueBase = self:_getValueBase()
-		if valueBase and valueBase.ClassName == className then
-			valueBase.Value = value
 		else
 			local folder = self:_getFolder()
 			if folder then