@quenty/tie 4.29.0 → 4.29.1-canary.417.052e8ba.0

package/CHANGELOG.md

@@ -3,6 +3,25 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [4.29.1-canary.417.052e8ba.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/tie@4.29.0...@quenty/tie@4.29.1-canary.417.052e8ba.0) (2023-10-11)
+
+
+* fix!: Make RxSignal not automatically skip first input ([6fe7586](https://github.com/Quenty/NevermoreEngine/commit/6fe7586029ea4753b1de7a8633c7d5af15bab420))
+
+
+### Features
+
+* Tie has better errors ([9e66f62](https://github.com/Quenty/NevermoreEngine/commit/9e66f621ff5b8e7c24800eca819612e9033c35c5))
+
+
+### BREAKING CHANGES
+
+* RxSignal used to export a different value
+
+
+
+
+
 # [4.29.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/tie@4.28.0...@quenty/tie@4.29.0) (2023-09-21)
 
 **Note:** Version bump only for package @quenty/tie

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/tie",
-  "version": "4.29.0",
+  "version": "4.29.1-canary.417.052e8ba.0",
   "description": "Tie allows interfaces to be defined between Lua OOP and Roblox objects.",
   "keywords": [
     "Roblox",
@@ -28,26 +28,27 @@
     "Quenty"
   ],
   "dependencies": {
-    "@quenty/attributeutils": "^8.22.0",
-    "@quenty/baseobject": "^6.3.0",
-    "@quenty/brio": "^8.19.0",
-    "@quenty/instanceutils": "^7.21.0",
-    "@quenty/loader": "^6.3.0",
-    "@quenty/maid": "^2.6.0",
-    "@quenty/rx": "^7.16.0",
-    "@quenty/statestack": "^8.24.0",
-    "@quenty/string": "^3.1.0",
-    "@quenty/symbol": "^2.2.0",
-    "@quenty/table": "^3.3.0",
-    "@quenty/valuebaseutils": "^7.22.0",
-    "@quenty/valueobject": "^7.24.0"
+    "@quenty/attributeutils": "8.22.1-canary.417.052e8ba.0",
+    "@quenty/baseobject": "6.3.1-canary.417.052e8ba.0",
+    "@quenty/brio": "8.19.1-canary.417.052e8ba.0",
+    "@quenty/collectionserviceutils": "2.21.1-canary.417.052e8ba.0",
+    "@quenty/instanceutils": "7.21.1-canary.417.052e8ba.0",
+    "@quenty/loader": "6.3.1-canary.417.052e8ba.0",
+    "@quenty/maid": "2.6.0",
+    "@quenty/rx": "7.16.1-canary.417.052e8ba.0",
+    "@quenty/statestack": "8.24.1-canary.417.052e8ba.0",
+    "@quenty/string": "3.1.0",
+    "@quenty/symbol": "2.2.0",
+    "@quenty/table": "3.3.0",
+    "@quenty/valuebaseutils": "7.22.1-canary.417.052e8ba.0",
+    "@quenty/valueobject": "7.24.1-canary.417.052e8ba.0"
   },
   "devDependencies": {
-    "@quenty/promise": "^6.8.0",
-    "@quenty/signal": "^2.4.0"
+    "@quenty/promise": "6.8.1-canary.417.052e8ba.0",
+    "@quenty/signal": "2.4.1-canary.417.052e8ba.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "fd634d0ed1918fc14bae8501aff1cc099d0537e7"
+  "gitHead": "052e8ba33437f71398c4c08c8dbcbf076022d388"
 }

package/src/Shared/Definition/TieDefinition.lua

@@ -11,6 +11,7 @@ local Maid = require("Maid")
 local Observable = require("Observable")
 local Rx = require("Rx")
 local RxBrioUtils = require("RxBrioUtils")
+local RxCollectionServiceUtils = require("RxCollectionServiceUtils")
 local RxInstanceUtils = require("RxInstanceUtils")
 local RxStateStackUtils = require("RxStateStackUtils")
 local String = require("String")
@@ -82,6 +83,85 @@ function TieDefinition:GetImplementations(adornee: Instance)
 	return implementations
 end
 
+--[=[
+	Observes all the children implementations for this adornee
+
+	@param adornee Instance
+	@return Observable<Brio<TieInterface>>
+]=]
+function TieDefinition:ObserveChildrenBrio(adornee: Instance)
+	return RxInstanceUtils.observeChildrenBrio(adornee):Pipe({
+		RxBrioUtils.flatMapBrio(function(child)
+			return self:ObserveBrio(child)
+		end)
+	})
+end
+
+--[=[
+	Promises the implementation
+
+	@param adornee Adornee
+	@return Promise<TieInterface>
+]=]
+function TieDefinition:Promise(adornee)
+	assert(typeof(adornee) == "Instance", "Bad adornee")
+
+	-- TODO: Support cancellation cleanup here.
+
+	return Rx.toPromise(self:Observe(adornee):Pipe({
+		Rx.where(function(value)
+			return value ~= nil
+		end)
+	}))
+end
+
+--[=[
+	Gets all valid interfaces for this adornee's children
+
+	@param adornee Instance
+	@return { TieInterface }
+]=]
+function TieDefinition:GetChildren(adornee: Instance)
+	assert(typeof(adornee) == "Instance", "Bad adornee")
+
+	local implementations = {}
+
+	-- TODO: Make this faster
+	for _, item in pairs(adornee:GetChildren()) do
+		for _, option in pairs(self:GetImplementations(item)) do
+			table.insert(implementations, option)
+		end
+	end
+
+	return implementations
+end
+
+--[=[
+	Finds the implementation on the adornee. Alais for [FindFirstImplementation]
+
+	@param adornee Adornee
+	@return TieInterface | nil
+]=]
+function TieDefinition:Find(adornee: Instance)
+	return self:FindFirstImplementation(adornee)
+end
+
+--[=[
+	Observes all implementations that are tagged with the given tag name
+
+	@param tagName string
+	@return TieInterface | nil
+]=]
+function TieDefinition:ObserveAllTaggedBrio(tagName)
+	assert(type(tagName) == "string", "Bad tagName")
+
+	return RxCollectionServiceUtils.observeTaggedBrio(tagName):Pipe({
+		RxBrioUtils.flatMapBrio(function(instance)
+			return self:ObserveBrio(instance)
+		end)
+	})
+end
+
 --[=[
 	Finds the first valid interfaces for this adornee
 	@param adornee Instance

package/src/Shared/Implementation/TieImplementation.lua

@@ -59,7 +59,7 @@ function TieImplementation:__index(index)
 	if memberMap[index] then
 		return memberMap[index]:GetInterface(self._folder, self)
 	else
-		error(("Bad index %q for TieImplementation"):format(tostring(index)))
+		error(string.format("Bad index %q for TieImplementation", tostring(index)))
 	end
 end
 

package/src/Shared/Implementation/TiePropertyImplementation.lua

@@ -100,7 +100,7 @@ function TiePropertyImplementation:_updateImplementation(maid, implementation)
 
 	local className = ValueBaseUtils.getClassNameFromType(typeof(implementation))
 	if not className then
-		error(("[TiePropertyImplementation] - Bad implementation value type %q, cannot set"):format(typeof(implementation)))
+		error(string.format("[TiePropertyImplementation] - Bad implementation value type %q, cannot set %s", typeof(implementation), self._memberDefinition:GetMemberName()))
 	end
 
 	local copy = self:_changeToClassIfNeeded(className, implementation)

package/src/Shared/Interface/TiePropertyInterface.lua

@@ -151,6 +151,10 @@ function TiePropertyInterface:_observeFromFolder(folder)
 		local lastImplementationType = UNSET_VALUE
 
 		local function update()
+			if not sub:IsPending() then
+				return
+			end
+
 			-- Prioritize attributes first
 			local currentAttribute = folder:GetAttribute(memberName)
 			if currentAttribute ~= nil then