@quenty/tie 4.22.0 → 4.23.0-canary.5a3bf28.0

package/CHANGELOG.md

@@ -3,6 +3,22 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [4.23.0-canary.5a3bf28.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/tie@4.22.0...@quenty/tie@4.23.0-canary.5a3bf28.0) (2023-07-17)
+
+
+### Bug Fixes
+
+* Fix valueBase assignment and retrieval ([50453dd](https://github.com/Quenty/NevermoreEngine/commit/50453dd1562e00e1a619eb09870097f3deebed46))
+
+
+### Features
+
+* Add :Observe() API calls to a variety of systems and allow Blend to :Observe() stuff ([ca29c68](https://github.com/Quenty/NevermoreEngine/commit/ca29c68164dfdaf136e9168faf48f487bed26088))
+
+
+
+
+
 # [4.22.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/tie@4.21.0...@quenty/tie@4.22.0) (2023-07-10)
 
 **Note:** Version bump only for package @quenty/tie

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/tie",
-  "version": "4.22.0",
+  "version": "4.23.0-canary.5a3bf28.0",
   "description": "Tie allows interfaces to be defined between Lua OOP and Roblox objects.",
   "keywords": [
     "Roblox",
@@ -28,26 +28,26 @@
     "Quenty"
   ],
   "dependencies": {
-    "@quenty/attributeutils": "^8.16.0",
-    "@quenty/baseobject": "^6.2.1",
-    "@quenty/brio": "^8.14.0",
-    "@quenty/instanceutils": "^7.16.0",
-    "@quenty/loader": "^6.2.1",
-    "@quenty/maid": "^2.5.0",
-    "@quenty/rx": "^7.12.0",
-    "@quenty/statestack": "^8.17.0",
-    "@quenty/string": "^3.1.0",
-    "@quenty/symbol": "^2.2.0",
-    "@quenty/table": "^3.2.0",
-    "@quenty/valuebaseutils": "^7.16.0",
-    "@quenty/valueobject": "^7.17.0"
+    "@quenty/attributeutils": "8.17.0-canary.5a3bf28.0",
+    "@quenty/baseobject": "6.2.1",
+    "@quenty/brio": "8.15.0-canary.5a3bf28.0",
+    "@quenty/instanceutils": "7.17.0-canary.5a3bf28.0",
+    "@quenty/loader": "6.2.1",
+    "@quenty/maid": "2.5.0",
+    "@quenty/rx": "7.13.0-canary.5a3bf28.0",
+    "@quenty/statestack": "8.18.0-canary.5a3bf28.0",
+    "@quenty/string": "3.1.0",
+    "@quenty/symbol": "2.2.0",
+    "@quenty/table": "3.2.0",
+    "@quenty/valuebaseutils": "7.17.0-canary.5a3bf28.0",
+    "@quenty/valueobject": "7.18.0-canary.5a3bf28.0"
   },
   "devDependencies": {
-    "@quenty/promise": "^6.6.0",
-    "@quenty/signal": "^2.4.0"
+    "@quenty/promise": "6.6.0",
+    "@quenty/signal": "2.4.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "6c9093879c4547ca55a7b42842e35ad277cc0f08"
+  "gitHead": "5a3bf28211375884c176eeed34ff3de2e319653e"
 }

package/src/Shared/Definition/TieDefinition.lua

@@ -196,6 +196,10 @@ function TieDefinition:ObserveLastImplementationBrio(adornee: Instance)
 		})
 end
 
+function TieDefinition:ObserveBrio(adornee: Instance)
+	return self:ObserveLastImplementationBrio(adornee)
+end
+
 --[=[
 	Observes a valid implementation if it exists, or nil
 
@@ -210,6 +214,9 @@ function TieDefinition:ObserveLastImplementation(adornee: Instance)
 	})
 end
 
+function TieDefinition:Observe(adornee: Instance)
+	return self:ObserveLastImplementation(adornee)
+end
 
 --[=[
 	Observes valid implementations wrapped in a brio if it exists.

package/src/Shared/Interface/TiePropertyInterface.lua

@@ -75,7 +75,7 @@ function TiePropertyInterface:_getFolder()
 	return TieInterfaceUtils.getFolder(self._tieDefinition, self._folder, self._adornee)
 end
 
-function TiePropertyInterface:_getValueBase()
+function TiePropertyInterface:_findValueBase()
 	local folder = self:_getFolder()
 	if not folder then
 		return nil
@@ -97,7 +97,7 @@ function TiePropertyInterface:_getValueBase()
 end
 
 function TiePropertyInterface:_getValueBaseOrError()
-	local valueBase = self:_getValueBase()
+	local valueBase = self:_findValueBase()
 	if not valueBase then
 		error(("%s.%s is not implemented for %s"):format(
 			self._tieDefinition:GetContainerName(),
@@ -263,7 +263,15 @@ function TiePropertyInterface:__newindex(index, value)
 	if index == "_adornee" or index == "_folder" or index == "_memberDefinition" or index == "_tieDefinition" then
 		rawset(self, index, value)
 	elseif index == "Value" then
-		if AttributeUtils.isValidAttributeType(typeof(value)) and value ~= nil then
+		local className = ValueBaseUtils.getClassNameFromType(typeof(value))
+		if not className then
+			error(("[TiePropertyImplementation] - Bad implementation value type %q, cannot set"):format(typeof(value)))
+		end
+
+		local valueBase = self:_findValueBase()
+		if type(valueBase) == "table" or (typeof(valueBase) == "Instance" and valueBase.ClassName == className) then
+			valueBase.Value = value
+		elseif AttributeUtils.isValidAttributeType(typeof(value)) and value ~= nil then
 			local folder = self:_getFolder()
 			if folder then
 				folder:SetAttribute(self._memberDefinition:GetMemberName(), value)
@@ -275,16 +283,6 @@ function TiePropertyInterface:__newindex(index, value)
 				end
 				return
 			end
-		end
-
-		local className = ValueBaseUtils.getClassNameFromType(typeof(value))
-		if not className then
-			error(("[TiePropertyImplementation] - Bad implementation value type %q, cannot set"):format(typeof(value)))
-		end
-
-		local valueBase = self:_getValueBase()
-		if valueBase and valueBase.ClassName == className then
-			valueBase.Value = value
 		else
 			local folder = self:_getFolder()
 			if folder then