@quenty/tie 10.5.1-canary.478.34e8ede.0 → 10.5.1-canary.478.88914d9.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (4) hide show
  1. package/CHANGELOG.md +2 -1
  2. package/package.json +16 -16
  3. package/src/Shared/Members/Signals/TieSignalImplementation.lua +8 -8
  4. package/src/Shared/Utils/TieUtils.lua +4 -1
package/CHANGELOG.md CHANGED
@@ -3,11 +3,12 @@
3
3
  All notable changes to this project will be documented in this file.
4
4
  See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
5
5
 
6
- ## [10.5.1-canary.478.34e8ede.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/tie@10.5.0...@quenty/tie@10.5.1-canary.478.34e8ede.0) (2024-08-27)
6
+ ## [10.5.1-canary.478.88914d9.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/tie@10.5.0...@quenty/tie@10.5.1-canary.478.88914d9.0) (2024-09-12)
7
7
 
8
8
 
9
9
  ### Bug Fixes
10
10
 
11
+ * Tie signal implementation fix ([8dc23bb](https://github.com/Quenty/NevermoreEngine/commit/8dc23bb8300598431a58b273ee2382ee90e76243))
11
12
  * TODO FIX THIS ([3731acd](https://github.com/Quenty/NevermoreEngine/commit/3731acdf4cf888bdac55157670fc61d6a6ba7c3d))
12
13
 
13
14
 
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@quenty/tie",
3
- "version": "10.5.1-canary.478.34e8ede.0",
3
+ "version": "10.5.1-canary.478.88914d9.0",
4
4
  "description": "Tie allows interfaces to be defined between Lua OOP and Roblox objects.",
5
5
  "keywords": [
6
6
  "Roblox",
@@ -28,28 +28,28 @@
28
28
  "Quenty"
29
29
  ],
30
30
  "dependencies": {
31
- "@quenty/attributeutils": "14.3.1-canary.478.34e8ede.0",
32
- "@quenty/baseobject": "10.3.1-canary.478.34e8ede.0",
33
- "@quenty/brio": "14.3.1-canary.478.34e8ede.0",
34
- "@quenty/collectionserviceutils": "8.3.1-canary.478.34e8ede.0",
35
- "@quenty/instanceutils": "13.3.1-canary.478.34e8ede.0",
36
- "@quenty/loader": "10.3.1-canary.478.34e8ede.0",
37
- "@quenty/maid": "3.2.0",
38
- "@quenty/rx": "13.3.1-canary.478.34e8ede.0",
39
- "@quenty/statestack": "14.4.1-canary.478.34e8ede.0",
31
+ "@quenty/attributeutils": "14.3.1-canary.478.88914d9.0",
32
+ "@quenty/baseobject": "10.3.1-canary.478.88914d9.0",
33
+ "@quenty/brio": "14.3.1-canary.478.88914d9.0",
34
+ "@quenty/collectionserviceutils": "8.3.1-canary.478.88914d9.0",
35
+ "@quenty/instanceutils": "13.3.1-canary.478.88914d9.0",
36
+ "@quenty/loader": "10.3.1-canary.478.88914d9.0",
37
+ "@quenty/maid": "3.2.1-canary.478.88914d9.0",
38
+ "@quenty/rx": "13.3.1-canary.478.88914d9.0",
39
+ "@quenty/statestack": "14.4.1-canary.478.88914d9.0",
40
40
  "@quenty/string": "3.2.0",
41
41
  "@quenty/symbol": "3.1.0",
42
42
  "@quenty/table": "3.5.0",
43
- "@quenty/tuple": "1.0.1-canary.478.34e8ede.0",
44
- "@quenty/valuebaseutils": "13.3.1-canary.478.34e8ede.0",
45
- "@quenty/valueobject": "13.3.1-canary.478.34e8ede.0"
43
+ "@quenty/tuple": "1.0.1-canary.478.88914d9.0",
44
+ "@quenty/valuebaseutils": "13.3.1-canary.478.88914d9.0",
45
+ "@quenty/valueobject": "13.3.1-canary.478.88914d9.0"
46
46
  },
47
47
  "devDependencies": {
48
- "@quenty/promise": "10.3.1-canary.478.34e8ede.0",
49
- "@quenty/signal": "7.3.1-canary.478.34e8ede.0"
48
+ "@quenty/promise": "10.3.1-canary.478.88914d9.0",
49
+ "@quenty/signal": "7.3.1-canary.478.88914d9.0"
50
50
  },
51
51
  "publishConfig": {
52
52
  "access": "public"
53
53
  },
54
- "gitHead": "34e8edee97fa93a0a5bd84442b85826082444f2a"
54
+ "gitHead": "88914d9021cfc9d91111f4d825341271dc292ec4"
55
55
  }
package/src/Shared/Members/Signals/TieSignalImplementation.lua CHANGED
@@ -38,30 +38,30 @@ function TieSignalImplementation:SetImplementation(signal)
38
38
  local bindableEventFiredArgs = {}
39
39
 
40
40
  maid:GiveTask(signal:Connect(function(...)
41
- local args = Tuple.new(TieUtils.encode(...))
42
- for pendingArgs, _ in pairs(bindableEventFiredArgs) do
41
+ local args = Tuple.new(...)
42
+ for pendingArgs, _ in pairs(signalFiredArgs) do
43
43
  if pendingArgs == args then
44
44
  -- Remove from queue
45
- bindableEventFiredArgs[pendingArgs] = nil
45
+ signalFiredArgs[pendingArgs] = nil
46
46
  return
47
47
  end
48
48
  end
49
49
 
50
- signalFiredArgs[args] = true
51
- self._bindableEvent:Fire(args:Unpack())
50
+ bindableEventFiredArgs[args] = true
51
+ self._bindableEvent:Fire(TieUtils.encode(...))
52
52
  end))
53
53
 
54
54
  maid:GiveTask(self._bindableEvent.Event:Connect(function(...)
55
55
  local args = Tuple.new(TieUtils.decode(...))
56
- for pendingArgs, _ in pairs(signalFiredArgs) do
56
+ for pendingArgs, _ in pairs(bindableEventFiredArgs) do
57
57
  if pendingArgs == args then
58
58
  -- Remove from queue
59
- signalFiredArgs[pendingArgs] = nil
59
+ bindableEventFiredArgs[pendingArgs] = nil
60
60
  return
61
61
  end
62
62
  end
63
63
 
64
- bindableEventFiredArgs[args] = true
64
+ signalFiredArgs[args] = true
65
65
  signal:Fire(args:Unpack())
66
66
  end))
67
67
  end
package/src/Shared/Utils/TieUtils.lua CHANGED
@@ -14,7 +14,10 @@ function TieUtils.encode(...)
14
14
  local results = table.pack(...)
15
15
 
16
16
  for i=1, results.n do
17
- if type(results[i]) == "table" or type(results[i]) == "function" then
17
+ if type(results[i]) == "table"
18
+ or type(results[i]) == "function"
19
+ or typeof(results[i]) == "userdata" then -- newproxy() symbols
20
+
18
21
  local saved = results[i]
19
22
  results[i] = function()
20
23
  return saved -- Pack into a callback so we can transfer data.