@quenty/sunpositionutils 2.3.0 → 2.3.1-canary.545.2374fb2.0

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [2.3.1-canary.545.2374fb2.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/sunpositionutils@2.3.0...@quenty/sunpositionutils@2.3.1-canary.545.2374fb2.0) (2025-04-05)
+
+
+### Bug Fixes
+
+* Add types to packages ([2374fb2](https://github.com/Quenty/NevermoreEngine/commit/2374fb2b043cfbe0e9b507b3316eec46a4e353a0))
+
+
+
+
+
 # [2.3.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/sunpositionutils@2.2.1...@quenty/sunpositionutils@2.3.0) (2024-05-09)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/sunpositionutils",
-  "version": "2.3.0",
+  "version": "2.3.1-canary.545.2374fb2.0",
   "description": "Utility to position the sun and to retrieve sun information specific to Roblox.",
   "keywords": [
     "Roblox",
@@ -27,5 +27,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "3fd5cdca3128bf34c8d9dfae1e92d62533b6e6f5"
+  "gitHead": "2374fb2b043cfbe0e9b507b3316eec46a4e353a0"
 }

package/src/Shared/SunPositionUtils.lua

@@ -1,3 +1,4 @@
+--!strict
 --[=[
 	Utility to position the sun and to retrieve sun information specific to Roblox.
 
@@ -19,9 +20,11 @@ local ZAXIS = Vector3.new(0, 0, 1)
 	@param direction Vector3
 	@return number
 ]=]
-function SunPositionUtils.getGeographicalLatitudeFromDirection(direction: Vector3)
-	local angle = math.atan2(direction.z, math.sqrt(direction.x^2 + direction.y^2))
-	return angle/(math.pi*2)*360+EARTH_TILT
+function SunPositionUtils.getGeographicalLatitudeFromDirection(direction: Vector3): number
+	local x = direction.X
+	local y = direction.Y
+	local angle = math.atan2(direction.Z, math.sqrt(x * x + y * y))
+	return angle / (math.pi * 2) * 360 + EARTH_TILT
 end
 
 SunPositionUtils.getGeographicalLatitudeFromMoonDirection = SunPositionUtils.getGeographicalLatitudeFromDirection
@@ -32,10 +35,10 @@ SunPositionUtils.getGeographicalLatitudeFromMoonDirection = SunPositionUtils.get
 	@param direction Vector3
 	@return number
 ]=]
-function SunPositionUtils.getClockTimeFromDirection(direction: Vector3)
-	local altitude = math.atan2(-direction.y, -direction.x)
+function SunPositionUtils.getClockTimeFromDirection(direction: Vector3): number
+	local altitude = math.atan2(-direction.Y, -direction.X)
 
-	return (altitude/(math.pi*2)*24-6) % 24
+	return (altitude / (math.pi * 2) * 24 - 6) % 24
 end
 
 --[=[
@@ -44,10 +47,10 @@ end
 	@param direction Vector3
 	@return number
 ]=]
-function SunPositionUtils.getClockTimeFromMoonDirection(direction: Vector3)
-	local altitude = math.atan2(direction.y, direction.x)
+function SunPositionUtils.getClockTimeFromMoonDirection(direction: Vector3): number
+	local altitude = math.atan2(direction.Y, direction.X)
 
-	return (altitude/(math.pi*2)*24-6) % 24
+	return (altitude / (math.pi * 2) * 24 - 6) % 24
 end
 
 --[=[
@@ -58,9 +61,9 @@ end
 	@param north Vector3?
 	@return number
 ]=]
-function SunPositionUtils.getDirection(azimuthRad: number, altitudeRad: number, north: Vector3)
-	local cframe = (CFrame.Angles(0, azimuthRad, 0) * CFrame.Angles(altitudeRad, 0, 0))
-	return cframe:vectorToWorldSpace(north or NORTH)
+function SunPositionUtils.getDirection(azimuthRad: number, altitudeRad: number, north: Vector3): Vector3
+	local cframe: CFrame = (CFrame.Angles(0, azimuthRad, 0) * CFrame.Angles(altitudeRad, 0, 0))
+	return cframe:VectorToWorldSpace(north or NORTH)
 end
 
 --[=[
@@ -71,7 +74,7 @@ end
 	@return Vector3 -- Sun position
 	@return Vector3 -- Moon position
 ]=]
-function SunPositionUtils.getSunPosition(clockTime: number, geoLatitude: number)
+function SunPositionUtils.getSunPosition(clockTime: number, geoLatitude: number): (Vector3, Vector3)
 	local seconds = clockTime*60*60
 	local DAY = 24 * 60 * 60
 	local YEAR = 365.2564 * DAY