@quenty/soundgroup 1.20.3 → 1.20.4-canary.11a5dcf.0

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [1.20.4-canary.11a5dcf.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/soundgroup@1.20.3...@quenty/soundgroup@1.20.4-canary.11a5dcf.0) (2025-05-10)
+
+
+### Bug Fixes
+
+* Additional type checking updates ([05ba29a](https://github.com/Quenty/NevermoreEngine/commit/05ba29a03efc9f3feed74b34f1d9dfb237496214))
+
+
+
+
+
 ## [1.20.3](https://github.com/Quenty/NevermoreEngine/compare/@quenty/soundgroup@1.20.2...@quenty/soundgroup@1.20.3) (2025-04-10)
 
 **Note:** Version bump only for package @quenty/soundgroup

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/soundgroup",
-  "version": "1.20.3",
+  "version": "1.20.4-canary.11a5dcf.0",
   "description": "Service and utility methods to working with sound groups and sounds in Roblox",
   "keywords": [
     "Roblox",
@@ -25,18 +25,18 @@
     "Quenty"
   ],
   "dependencies": {
-    "@quenty/baseobject": "^10.8.3",
-    "@quenty/counter": "^7.17.3",
-    "@quenty/instanceutils": "^13.17.3",
-    "@quenty/loader": "^10.8.3",
-    "@quenty/maid": "^3.4.3",
-    "@quenty/observablecollection": "^12.20.3",
-    "@quenty/rx": "^13.17.3",
-    "@quenty/table": "^3.7.4",
-    "@quenty/valueobject": "^13.17.3"
+    "@quenty/baseobject": "10.8.4-canary.11a5dcf.0",
+    "@quenty/counter": "7.17.4-canary.11a5dcf.0",
+    "@quenty/instanceutils": "13.17.4-canary.11a5dcf.0",
+    "@quenty/loader": "10.8.4-canary.11a5dcf.0",
+    "@quenty/maid": "3.4.4-canary.11a5dcf.0",
+    "@quenty/observablecollection": "12.20.4-canary.11a5dcf.0",
+    "@quenty/rx": "13.17.4-canary.11a5dcf.0",
+    "@quenty/table": "3.7.5-canary.11a5dcf.0",
+    "@quenty/valueobject": "13.17.4-canary.11a5dcf.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "b06c070ae91d5dab7bd8de6e290ad2caabb15d8f"
+  "gitHead": "11a5dcf7d4c7a0bfbf3337e97d30e8346ea09d3f"
 }

package/src/Client/SoundGroupServiceClient.lua

@@ -5,12 +5,12 @@
 local require = require(script.Parent.loader).load(script)
 
 local Maid = require("Maid")
-local _ServiceBag = require("ServiceBag")
+local ServiceBag = require("ServiceBag")
 
 local SoundGroupServiceClient = {}
 SoundGroupServiceClient.ServiceName = "SoundGroupServiceClient"
 
-function SoundGroupServiceClient:Init(serviceBag: _ServiceBag.ServiceBag)
+function SoundGroupServiceClient:Init(serviceBag: ServiceBag.ServiceBag)
 	assert(not self._serviceBag, "Already initialized")
 	self._serviceBag = assert(serviceBag, "No serviceBag")
 	self._maid = Maid.new()
@@ -23,4 +23,4 @@ function SoundGroupServiceClient:Destroy()
 	self._maid:DoCleaning()
 end
 
-return SoundGroupServiceClient
+return SoundGroupServiceClient

package/src/Server/SoundGroupService.lua

@@ -5,13 +5,13 @@
 local require = require(script.Parent.loader).load(script)
 
 local Maid = require("Maid")
+local ServiceBag = require("ServiceBag")
 local WellKnownSoundGroups = require("WellKnownSoundGroups")
-local _ServiceBag = require("ServiceBag")
 
 local SoundGroupService = {}
 SoundGroupService.ServiceName = "SoundGroupService"
 
-function SoundGroupService:Init(serviceBag: _ServiceBag.ServiceBag)
+function SoundGroupService:Init(serviceBag: ServiceBag.ServiceBag)
 	assert(not self._serviceBag, "Already initialized")
 	self._serviceBag = assert(serviceBag, "No serviceBag")
 	self._maid = Maid.new()
@@ -32,4 +32,4 @@ function SoundGroupService:Destroy()
 	self._maid:DoCleaning()
 end
 
-return SoundGroupService
+return SoundGroupService

package/src/Shared/Effects/SoundEffectsList.lua

@@ -8,14 +8,14 @@
 local require = require(script.Parent.loader).load(script)
 
 local BaseObject = require("BaseObject")
-local ObservableList = require("ObservableList")
+local Counter = require("Counter")
 local Maid = require("Maid")
 local MaidTaskUtils = require("MaidTaskUtils")
-local ValueObject = require("ValueObject")
-local Counter = require("Counter")
+local Observable = require("Observable")
+local ObservableList = require("ObservableList")
 local Rx = require("Rx")
-local _Signal = require("Signal")
-local _Observable = require("Observable")
+local Signal = require("Signal")
+local ValueObject = require("ValueObject")
 
 local SoundEffectsList = setmetatable({}, BaseObject)
 SoundEffectsList.ClassName = "SoundEffectsList"
@@ -29,7 +29,7 @@ export type SoundEffectsList = typeof(setmetatable(
 		_appliedCount: Counter.Counter,
 		_isActive: ValueObject.ValueObject<boolean>,
 		_hasEffects: ValueObject.ValueObject<boolean>,
-		IsActiveChanged: _Signal.Signal<boolean>,
+		IsActiveChanged: Signal.Signal<boolean>,
 		HasEffects: () -> boolean,
 	},
 	{} :: typeof({ __index = SoundEffectsList })
@@ -72,7 +72,7 @@ end
 
 	@return Observable<boolean>
 ]=]
-function SoundEffectsList.ObserveHasEffects(self: SoundEffectsList): _Observable.Observable<boolean>
+function SoundEffectsList.ObserveHasEffects(self: SoundEffectsList): Observable.Observable<boolean>
 	return self._hasEffects:Observe()
 end
 
@@ -140,4 +140,4 @@ function SoundEffectsList.ApplyEffects(self: SoundEffectsList, instance: SoundGr
 	end
 end
 
-return SoundEffectsList
+return SoundEffectsList

package/src/Shared/Effects/SoundEffectsRegistry.lua

@@ -9,13 +9,13 @@
 local require = require(script.Parent.loader).load(script)
 
 local BaseObject = require("BaseObject")
+local Brio = require("Brio")
 local Maid = require("Maid")
+local Observable = require("Observable")
 local ObservableMap = require("ObservableMap")
+local ObservableSet = require("ObservableSet")
 local SoundEffectsList = require("SoundEffectsList")
 local SoundGroupPathUtils = require("SoundGroupPathUtils")
-local ObservableSet = require("ObservableSet")
-local _Observable = require("Observable")
-local _Brio = require("Brio")
 
 local SoundEffectsRegistry = setmetatable({}, BaseObject)
 SoundEffectsRegistry.ClassName = "SoundEffectsRegistry"
@@ -64,11 +64,14 @@ end
 
 function SoundEffectsRegistry.ObserveActiveEffectsPathBrios(
 	self: SoundEffectsRegistry
-): _Observable.Observable<_Brio.Brio<string>>
+): Observable.Observable<Brio.Brio<string>>
 	return self._activeEffectsPathSet:ObserveItemsBrio() :: any
 end
 
-function SoundEffectsRegistry._getOrCreateEffectList(self: SoundEffectsRegistry, soundGroupPath: string): SoundEffectsList.SoundEffectsList
+function SoundEffectsRegistry._getOrCreateEffectList(
+	self: SoundEffectsRegistry,
+	soundGroupPath: string
+): SoundEffectsList.SoundEffectsList
 	assert(SoundGroupPathUtils.isSoundGroupPath(soundGroupPath), "Bad soundGroupPath")
 
 	local found = self._pathToEffectList:Get(soundGroupPath)
@@ -100,4 +103,4 @@ function SoundEffectsRegistry._getOrCreateEffectList(self: SoundEffectsRegistry,
 	return soundEffectsList
 end
 
-return SoundEffectsRegistry
+return SoundEffectsRegistry

package/src/Shared/SoundEffectService.lua

@@ -6,20 +6,20 @@
 
 local require = require(script.Parent.loader).load(script)
 
-local SoundService = game:GetService("SoundService")
 local RunService = game:GetService("RunService")
+local SoundService = game:GetService("SoundService")
 
 local Maid = require("Maid")
+local ServiceBag = require("ServiceBag")
 local SoundEffectsRegistry = require("SoundEffectsRegistry")
 local SoundGroupPathUtils = require("SoundGroupPathUtils")
 local SoundGroupTracker = require("SoundGroupTracker")
 local WellKnownSoundGroups = require("WellKnownSoundGroups")
-local _ServiceBag = require("ServiceBag")
 
 local SoundEffectService = {}
 SoundEffectService.ServiceName = "SoundEffectService"
 
-function SoundEffectService:Init(serviceBag: _ServiceBag.ServiceBag)
+function SoundEffectService:Init(serviceBag: ServiceBag.ServiceBag)
 	assert(not self._serviceBag, "Already initialized")
 	self._serviceBag = assert(serviceBag, "No serviceBag")
 	self._maid = Maid.new()
@@ -97,14 +97,13 @@ function SoundEffectService:_setupEffectApplication()
 		end
 
 		local maid, soundGroup = brio:ToMaidAndValue()
-		maid:GiveTask(self._tracker:ObserveSoundGroupPath(soundGroup)
-			:Subscribe(function(soundGroupPath)
-				if soundGroupPath then
-					maid._currentEffects = self._soundEffectsRegister:ApplyEffects(soundGroupPath, soundGroup)
-				else
-					maid._currentEffects = nil
-				end
-			end))
+		maid:GiveTask(self._tracker:ObserveSoundGroupPath(soundGroup):Subscribe(function(soundGroupPath)
+			if soundGroupPath then
+				maid._currentEffects = self._soundEffectsRegister:ApplyEffects(soundGroupPath, soundGroup)
+			else
+				maid._currentEffects = nil
+			end
+		end))
 	end))
 
 	-- Render sound groups
@@ -122,9 +121,8 @@ function SoundEffectService:_setupEffectApplication()
 	end))
 end
 
-
 function SoundEffectService:Destroy()
 	self._maid:DoCleaning()
 end
 
-return SoundEffectService
+return SoundEffectService

package/src/Shared/SoundGroupTracker.lua

@@ -6,13 +6,13 @@
 local require = require(script.Parent.loader).load(script)
 
 local BaseObject = require("BaseObject")
-local RxInstanceUtils = require("RxInstanceUtils")
-local ObservableMapList = require("ObservableMapList")
 local Maid = require("Maid")
+local Observable = require("Observable")
 local ObservableMap = require("ObservableMap")
-local SoundGroupPathUtils = require("SoundGroupPathUtils")
+local ObservableMapList = require("ObservableMapList")
 local Rx = require("Rx")
-local Observable = require("Observable")
+local RxInstanceUtils = require("RxInstanceUtils")
+local SoundGroupPathUtils = require("SoundGroupPathUtils")
 
 local SoundGroupTracker = setmetatable({}, BaseObject)
 SoundGroupTracker.ClassName = "SoundGroupTracker"
@@ -123,4 +123,4 @@ function SoundGroupTracker._track(self: SoundGroupTracker, observeRootPath, pare
 	end
 end
 
-return SoundGroupTracker
+return SoundGroupTracker

package/src/Shared/Utils/SoundGroupPathUtils.lua

@@ -97,4 +97,4 @@ function SoundGroupPathUtils._findSoundGroup(parent: Instance, soundGroupName: s
 	return nil
 end
 
-return SoundGroupPathUtils
+return SoundGroupPathUtils

package/test/scripts/Client/ClientMain.client.lua

@@ -7,4 +7,4 @@ local require = require(loader).bootstrapGame(loader.Parent)
 local serviceBag = require("ServiceBag").new()
 serviceBag:GetService(require("SoundGroupServiceClient"))
 serviceBag:Init()
-serviceBag:Start()
+serviceBag:Start()

package/test/scripts/Server/ServerMain.server.lua

@@ -9,4 +9,4 @@ local require = require(loader).bootstrapGame(ServerScriptService.soundgroup)
 local serviceBag = require("ServiceBag").new()
 serviceBag:GetService(require("SoundGroupService"))
 serviceBag:Init()
-serviceBag:Start()
+serviceBag:Start()