@quenty/signal 7.5.0 → 7.6.0

package/CHANGELOG.md

@@ -3,6 +3,22 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [7.6.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/signal@7.5.0...@quenty/signal@7.6.0) (2024-09-25)
+
+
+### Bug Fixes
+
+* Selene doesn't know debug.getmemorycategory() ([0c613a3](https://github.com/Quenty/NevermoreEngine/commit/0c613a3ae0b6ba6a4cda511f572220bfa951c70d))
+
+
+### Features
+
+* MemoryCategory is tracked properly in signal (Not sure what the perf implications of this are) ([4d43b0c](https://github.com/Quenty/NevermoreEngine/commit/4d43b0c0c07fd5d24335b1801ca96c58d37ba149))
+
+
+
+
+
 # [7.5.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/signal@7.4.0...@quenty/signal@7.5.0) (2024-09-25)
 
 **Note:** Version bump only for package @quenty/signal

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/signal",
-  "version": "7.5.0",
+  "version": "7.6.0",
   "description": "A simple signal implementation for Roblox",
   "keywords": [
     "Roblox",
@@ -32,5 +32,5 @@
   "dependencies": {
     "@quenty/loader": "^10.5.0"
   },
-  "gitHead": "41715b15e2b48b2d22ff4f5277a8d4b7a0d32ef3"
+  "gitHead": "9b17fe79cddd071f0f06a9d35184e76b44bd6fe6"
 }

package/src/Shared/GoodSignal.lua

@@ -44,25 +44,33 @@
 ]=]
 
 -- The currently idle thread to run the next handler on
-local freeRunnerThread = nil
+local freeRunnerThreadLookup = {}
 
 -- Function which acquires the currently idle handler runner thread, runs the
 -- function fn on it, and then releases the thread, returning it to being the
 -- currently idle one.
 -- If there was a currently idle runner thread already, that's okay, that old
 -- one will just get thrown and eventually GCed.
-local function acquireRunnerThreadAndCallEventHandler(fn, ...)
-	local acquiredRunnerThread = freeRunnerThread
-	freeRunnerThread = nil
+local function acquireRunnerThreadAndCallEventHandler(memoryCategory, fn, ...)
+	debug.setmemorycategory(memoryCategory)
+
+	local acquiredRunnerThread = freeRunnerThreadLookup[memoryCategory]
+	freeRunnerThreadLookup[memoryCategory] = nil
 	fn(...)
 	-- The handler finished running, this runner thread is free again.
-	freeRunnerThread = acquiredRunnerThread
+	freeRunnerThreadLookup[memoryCategory] = acquiredRunnerThread
 end
 
 -- Coroutine runner that we create coroutines of. The coroutine can be
 -- repeatedly resumed with functions to run followed by the argument to run
 -- them with.
-local function runEventHandlerInFreeThread()
+local function runEventHandlerInFreeThread(memoryCategory)
+	if #memoryCategory == 0 then
+		debug.setmemorycategory("signal_unknown")
+	else
+		debug.setmemorycategory(memoryCategory)
+	end
+
 	-- Note: We cannot use the initial set of arguments passed to
 	-- runEventHandlerInFreeThread for a call to the handler, because those
 	-- arguments would stay on the stack for the duration of the thread's
@@ -186,15 +194,18 @@ end
 	@param ... T -- Variable arguments to pass to handler
 ]=]
 function Signal:Fire(...)
+	-- selene: allow(incorrect_standard_library_use)
+	local memoryCategory = debug.getmemorycategory()
+
 	local item = self._handlerListHead
 	while item do
 		if item._connected then
-			if not freeRunnerThread then
-				freeRunnerThread = coroutine.create(runEventHandlerInFreeThread)
+			if not freeRunnerThreadLookup[memoryCategory] then
+				freeRunnerThreadLookup[memoryCategory] = coroutine.create(runEventHandlerInFreeThread)
 				-- Get the freeRunnerThread to the first yield
-				coroutine.resume(freeRunnerThread)
+				coroutine.resume(freeRunnerThreadLookup[memoryCategory], memoryCategory)
 			end
-			task.spawn(freeRunnerThread, item._fn, ...)
+			task.spawn(freeRunnerThreadLookup[memoryCategory], memoryCategory, item._fn, ...)
 		end
 		item = item._next
 	end