@quenty/settings 11.23.4-canary.559.9f38947.0 → 11.24.0-canary.0a5db80.0

package/CHANGELOG.md

@@ -3,20 +3,12 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-## [11.23.4-canary.559.9f38947.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/settings@11.23.3...@quenty/settings@11.23.4-canary.559.9f38947.0) (2025-05-10)
+# [11.24.0-canary.0a5db80.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/settings@11.23.2...@quenty/settings@11.24.0-canary.0a5db80.0) (2025-05-10)
 
 
 ### Bug Fixes
 
-* Additional type checking updates ([05ba29a](https://github.com/Quenty/NevermoreEngine/commit/05ba29a03efc9f3feed74b34f1d9dfb237496214))
-
-
-
-
-
-## [11.23.3](https://github.com/Quenty/NevermoreEngine/compare/@quenty/settings@11.23.2...@quenty/settings@11.23.3) (2025-04-10)
-
-**Note:** Version bump only for package @quenty/settings
+* Additional type checking updates ([7e008c5](https://github.com/Quenty/NevermoreEngine/commit/7e008c58547bd00b5904e56541454a38c8d72ccc))
 
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/settings",
-  "version": "11.23.4-canary.559.9f38947.0",
+  "version": "11.24.0-canary.0a5db80.0",
   "description": "Centralized player settings service",
   "keywords": [
     "Roblox",
@@ -25,38 +25,38 @@
     "Quenty"
   ],
   "dependencies": {
-    "@quenty/attributeutils": "14.17.4-canary.559.9f38947.0",
-    "@quenty/baseobject": "10.8.4-canary.559.9f38947.0",
-    "@quenty/binder": "14.19.4-canary.559.9f38947.0",
-    "@quenty/brio": "14.17.4-canary.559.9f38947.0",
-    "@quenty/cmdrservice": "13.22.4-canary.559.9f38947.0",
-    "@quenty/datastore": "13.20.4-canary.559.9f38947.0",
-    "@quenty/ducktype": "5.8.5-canary.559.9f38947.0",
+    "@quenty/attributeutils": "14.18.0-canary.0a5db80.0",
+    "@quenty/baseobject": "10.9.0-canary.0a5db80.0",
+    "@quenty/binder": "14.20.0-canary.0a5db80.0",
+    "@quenty/brio": "14.18.0-canary.0a5db80.0",
+    "@quenty/cmdrservice": "13.23.0-canary.0a5db80.0",
+    "@quenty/datastore": "13.21.0-canary.0a5db80.0",
+    "@quenty/ducktype": "5.9.0-canary.0a5db80.0",
     "@quenty/enumutils": "3.4.2",
-    "@quenty/instanceutils": "13.17.4-canary.559.9f38947.0",
-    "@quenty/jsonutils": "10.10.5-canary.559.9f38947.0",
-    "@quenty/loader": "10.8.4-canary.559.9f38947.0",
-    "@quenty/maid": "3.4.4-canary.559.9f38947.0",
-    "@quenty/observablecollection": "12.20.4-canary.559.9f38947.0",
-    "@quenty/playerbinder": "14.19.4-canary.559.9f38947.0",
-    "@quenty/playerutils": "8.17.4-canary.559.9f38947.0",
-    "@quenty/remotefunctionutils": "10.10.5-canary.559.9f38947.0",
-    "@quenty/remoting": "12.18.4-canary.559.9f38947.0",
-    "@quenty/rx": "13.17.4-canary.559.9f38947.0",
-    "@quenty/rxbinderutils": "14.19.4-canary.559.9f38947.0",
-    "@quenty/rxsignal": "7.17.4-canary.559.9f38947.0",
-    "@quenty/servicebag": "11.11.5-canary.559.9f38947.0",
-    "@quenty/signal": "7.10.4-canary.559.9f38947.0",
-    "@quenty/statestack": "14.18.4-canary.559.9f38947.0",
+    "@quenty/instanceutils": "13.18.0-canary.0a5db80.0",
+    "@quenty/jsonutils": "10.11.0-canary.0a5db80.0",
+    "@quenty/loader": "10.9.0-canary.0a5db80.0",
+    "@quenty/maid": "3.5.0-canary.0a5db80.0",
+    "@quenty/observablecollection": "12.21.0-canary.0a5db80.0",
+    "@quenty/playerbinder": "14.20.0-canary.0a5db80.0",
+    "@quenty/playerutils": "8.18.0-canary.0a5db80.0",
+    "@quenty/remotefunctionutils": "10.11.0-canary.0a5db80.0",
+    "@quenty/remoting": "12.19.0-canary.0a5db80.0",
+    "@quenty/rx": "13.18.0-canary.0a5db80.0",
+    "@quenty/rxbinderutils": "14.20.0-canary.0a5db80.0",
+    "@quenty/rxsignal": "7.18.0-canary.0a5db80.0",
+    "@quenty/servicebag": "11.12.0-canary.0a5db80.0",
+    "@quenty/signal": "7.11.0-canary.0a5db80.0",
+    "@quenty/statestack": "14.19.0-canary.0a5db80.0",
     "@quenty/string": "3.3.3",
-    "@quenty/symbol": "3.4.3-canary.559.9f38947.0",
-    "@quenty/table": "3.7.5-canary.559.9f38947.0",
-    "@quenty/throttle": "10.9.4-canary.559.9f38947.0",
-    "@quenty/tie": "10.20.4-canary.559.9f38947.0",
-    "@quenty/valueobject": "13.17.4-canary.559.9f38947.0"
+    "@quenty/symbol": "3.4.2",
+    "@quenty/table": "3.8.0-canary.0a5db80.0",
+    "@quenty/throttle": "10.10.0-canary.0a5db80.0",
+    "@quenty/tie": "10.21.0-canary.0a5db80.0",
+    "@quenty/valueobject": "13.18.0-canary.0a5db80.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "9f38947767d202411936a5c98898033df5865da0"
+  "gitHead": "0a5db8004684dc3e76fd5944599a22602d48cfa9"
 }

package/src/Client/Player/PlayerSettingsClient.lua

@@ -19,12 +19,12 @@ local PlayerSettingsBase = require("PlayerSettingsBase")
 local PlayerSettingsConstants = require("PlayerSettingsConstants")
 local PlayerSettingsInterface = require("PlayerSettingsInterface")
 local PlayerSettingsUtils = require("PlayerSettingsUtils")
-local Promise = require("Promise")
 local Remoting = require("Remoting")
-local ServiceBag = require("ServiceBag")
 local Symbol = require("Symbol")
 local ThrottledFunction = require("ThrottledFunction")
 local ValueObject = require("ValueObject")
+local ServiceBag = require("ServiceBag")
+local Promise = require("Promise")
 
 local UNSET_VALUE = Symbol.named("unsetValue")
 

package/src/Server/Cmdr/SettingsCmdrService.lua

@@ -6,10 +6,10 @@
 
 local require = require(script.Parent.loader).load(script)
 
-local Maid = require("Maid")
 local PlayerUtils = require("PlayerUtils")
-local ServiceBag = require("ServiceBag")
 local SettingsCmdrUtils = require("SettingsCmdrUtils")
+local Maid = require("Maid")
+local ServiceBag = require("ServiceBag")
 
 local SettingsCmdrService = {}
 SettingsCmdrService.ServiceName = "SettingsCmdrService"

package/src/Server/Player/PlayerHasSettings.lua

@@ -5,12 +5,12 @@
 local require = require(script.Parent.loader).load(script)
 
 local BaseObject = require("BaseObject")
-local DataStoreStringUtils = require("DataStoreStringUtils")
-local PlayerBinder = require("PlayerBinder")
-local PlayerDataStoreService = require("PlayerDataStoreService")
+local PlayerSettingsUtils = require("PlayerSettingsUtils")
 local PlayerSettings = require("PlayerSettings")
+local PlayerDataStoreService = require("PlayerDataStoreService")
+local DataStoreStringUtils = require("DataStoreStringUtils")
 local PlayerSettingsConstants = require("PlayerSettingsConstants")
-local PlayerSettingsUtils = require("PlayerSettingsUtils")
+local PlayerBinder = require("PlayerBinder")
 local ServiceBag = require("ServiceBag")
 
 local PlayerHasSettings = setmetatable({}, BaseObject)
@@ -41,24 +41,24 @@ end
 function PlayerHasSettings:_promiseLoadSettings()
 	self._settings = self._maid:Add(PlayerSettingsUtils.create())
 
-	self._maid
-		:GivePromise(self._playerDataStoreService:PromiseDataStore(self._obj))
+	self._maid:GivePromise(self._playerDataStoreService:PromiseDataStore(self._obj))
 		:Then(function(dataStore)
 			-- Ensure we've fully loaded before we parent.
 			-- This should ensure the cache is mostly instant.
 
 			local subStore = dataStore:GetSubStore("settings")
 
-			return dataStore:Load("settings", {}):Then(function(settings)
-				for settingName, value in settings do
-					local attributeName = PlayerSettingsUtils.getAttributeName(settingName)
-					self._settings:SetAttribute(attributeName, PlayerSettingsUtils.encodeForAttribute(value))
-				end
-
-				self._maid:GiveTask(self._settings.AttributeChanged:Connect(function(attributeName)
-					self:_handleAttributeChanged(subStore, attributeName)
-				end))
-			end)
+			return dataStore:Load("settings", {})
+				:Then(function(settings)
+					for settingName, value in settings do
+						local attributeName = PlayerSettingsUtils.getAttributeName(settingName)
+						self._settings:SetAttribute(attributeName, PlayerSettingsUtils.encodeForAttribute(value))
+					end
+
+					self._maid:GiveTask(self._settings.AttributeChanged:Connect(function(attributeName)
+						self:_handleAttributeChanged(subStore, attributeName)
+					end))
+				end)
 		end)
 		:Catch(function(err)
 			warn(string.format("[PlayerHasSettings] - Failed to load settings for player. %s", tostring(err)))
@@ -85,9 +85,7 @@ function PlayerHasSettings:_handleAttributeChanged(subStore, attributeName)
 
 	if type(newValue) == "string" then
 		if (#settingName + #newValue) > PlayerSettingsConstants.MAX_SETTINGS_LENGTH then
-			warn(
-				string.format("[PlayerSettingsClient.SetValue] - Setting is too long for %q. Cannot save.", settingName)
-			)
+			warn(string.format("[PlayerSettingsClient.SetValue] - Setting is too long for %q. Cannot save.", settingName))
 			return
 		end
 		-- TODO: JSON encode and check length for ther scenarios
@@ -96,4 +94,4 @@ function PlayerHasSettings:_handleAttributeChanged(subStore, attributeName)
 	subStore:Store(settingName, newValue)
 end
 
-return PlayerBinder.new("PlayerHasSettings", PlayerHasSettings)
+return PlayerBinder.new("PlayerHasSettings", PlayerHasSettings)

package/src/Shared/Cmdr/SettingsCmdrUtils.lua

@@ -18,23 +18,23 @@ function SettingsCmdrUtils.registerSettingDefinition(cmdr, serviceBag)
 		Transform = function(text)
 			local definitions = settingsDataService:GetSettingDefinitions()
 			local settingNames = {}
-			for _, settingDefinition in definitions do
-				table.insert(settingNames, settingDefinition:GetSettingName())
-			end
+		for _, settingDefinition in definitions do
+			table.insert(settingNames, settingDefinition:GetSettingName())
+		end
 
-			local find = cmdr.Util.MakeFuzzyFinder(settingNames)
-			return find(text)
-		end,
+		local find = cmdr.Util.MakeFuzzyFinder(settingNames)
+		return find(text)
+		end;
 		Validate = function(keys)
-			return #keys > 0, "No item model with that name could be found."
+		return #keys > 0, "No item model with that name could be found."
 		end,
 		Autocomplete = function(keys)
-			return keys
+		return keys
 		end,
 		Parse = function(keys)
-			local name = keys[1]
+		local name = keys[1]
 
-			local definitions = settingsDataService:GetSettingDefinitions()
+		local definitions = settingsDataService:GetSettingDefinitions()
 			for _, settingDefinition in definitions do
 				if settingDefinition:GetSettingName() == name then
 					return settingDefinition
@@ -42,11 +42,12 @@ function SettingsCmdrUtils.registerSettingDefinition(cmdr, serviceBag)
 			end
 
 			return nil
-		end,
+		end;
 	}
 
 	cmdr.Registry:RegisterType("settingDefinition", settingDefinitionType)
 	cmdr.Registry:RegisterType("settingDefinitions", cmdr.Util.MakeListableType(settingDefinitionType))
 end
 
-return SettingsCmdrUtils
+
+return SettingsCmdrUtils

package/src/Shared/Interface/PlayerSettingsInterface.lua

@@ -7,11 +7,11 @@ local require = require(script.Parent.loader).load(script)
 local TieDefinition = require("TieDefinition")
 
 return TieDefinition.new("PlayerSettings", {
-	GetSettingProperty = TieDefinition.Types.METHOD,
-	GetValue = TieDefinition.Types.METHOD,
-	SetValue = TieDefinition.Types.METHOD,
-	ObserveValue = TieDefinition.Types.METHOD,
-	RestoreDefault = TieDefinition.Types.METHOD,
-	EnsureInitialized = TieDefinition.Types.METHOD,
-	GetPlayer = TieDefinition.Types.METHOD,
-})
+	GetSettingProperty = TieDefinition.Types.METHOD;
+	GetValue = TieDefinition.Types.METHOD;
+	SetValue = TieDefinition.Types.METHOD;
+	ObserveValue = TieDefinition.Types.METHOD;
+	RestoreDefault = TieDefinition.Types.METHOD;
+	EnsureInitialized = TieDefinition.Types.METHOD;
+	GetPlayer = TieDefinition.Types.METHOD;
+})

package/src/Shared/Player/PlayerSettingsBase.lua

@@ -8,12 +8,12 @@
 local require = require(script.Parent.loader).load(script)
 
 local BaseObject = require("BaseObject")
-local DataStoreStringUtils = require("DataStoreStringUtils")
 local PlayerSettingsUtils = require("PlayerSettingsUtils")
-local Rx = require("Rx")
 local RxAttributeUtils = require("RxAttributeUtils")
-local ServiceBag = require("ServiceBag")
 local SettingDefinition = require("SettingDefinition")
+local Rx = require("Rx")
+local DataStoreStringUtils = require("DataStoreStringUtils")
+local ServiceBag = require("ServiceBag")
 
 local PlayerSettingsBase = setmetatable({}, BaseObject)
 PlayerSettingsBase.ClassName = "PlayerSettingsBase"
@@ -164,4 +164,4 @@ function PlayerSettingsBase.EnsureInitialized(_self: PlayerSettingsBase, setting
 	-- noop
 end
 
-return PlayerSettingsBase
+return PlayerSettingsBase

package/src/Shared/Player/PlayerSettingsConstants.lua

@@ -8,12 +8,12 @@ local require = require(script.Parent.loader).load(script)
 local Table = require("Table")
 
 return Table.readonly({
-	SETTING_ATTRIBUTE_PREFIX = "Setting_",
-	SETTING_DEFAULT_VALUE_SUFFIX = "_Default",
-	SETTING_LOCAL_USER_VALUE_SUFFIX = "_Client",
+	SETTING_ATTRIBUTE_PREFIX = "Setting_";
+	SETTING_DEFAULT_VALUE_SUFFIX = "_Default";
+	SETTING_LOCAL_USER_VALUE_SUFFIX = "_Client";
 
-	PLAYER_SETTINGS_NAME = "PlayerSettings",
-	REMOTE_FUNCTION_NAME = "PlayerSettingsRemoteFunction",
-	REQUEST_UPDATE_SETTINGS = "requestUpdateSettings",
-	MAX_SETTINGS_LENGTH = 2048,
-})
+	PLAYER_SETTINGS_NAME = "PlayerSettings";
+	REMOTE_FUNCTION_NAME = "PlayerSettingsRemoteFunction";
+	REQUEST_UPDATE_SETTINGS = "requestUpdateSettings";
+	MAX_SETTINGS_LENGTH = 2048;
+})

package/src/Shared/Player/PlayerSettingsUtils.lua

@@ -7,10 +7,10 @@
 
 local require = require(script.Parent.loader).load(script)
 
-local DataStoreStringUtils = require("DataStoreStringUtils")
-local EnumUtils = require("EnumUtils")
 local PlayerSettingsConstants = require("PlayerSettingsConstants")
 local String = require("String")
+local EnumUtils = require("EnumUtils")
+local DataStoreStringUtils = require("DataStoreStringUtils")
 
 local PlayerSettingsUtils = {}
 

package/src/Shared/Setting/SettingDefinition.lua

@@ -194,4 +194,4 @@ function SettingDefinition:Destroy()
 	self._maid:DoCleaning()
 end
 
-return SettingDefinition
+return SettingDefinition

package/src/Shared/Setting/SettingDefinitionProvider.lua

@@ -27,8 +27,8 @@
 local require = require(script.Parent.loader).load(script)
 
 local Maid = require("Maid")
-local ServiceBag = require("ServiceBag")
 local SettingDefinition = require("SettingDefinition")
+local ServiceBag = require("ServiceBag")
 
 local SettingDefinitionProvider = {}
 SettingDefinitionProvider.ClassName = "SettingDefinitionProvider"
@@ -176,13 +176,12 @@ function SettingDefinitionProvider:__index(index)
 		error("[SettingDefinitionProvider] - Cannot index provider with nil value")
 	elseif SettingDefinitionProvider[index] then
 		return SettingDefinitionProvider[index]
-	elseif
-		index == "_lookup"
+	elseif index == "_lookup"
 		or index == "_settingDefinitionList"
 		or index == "_maid"
 		or index == "_initializedDefinitionLookup"
-		or index == "_serviceBag"
-	then
+		or index == "_serviceBag" then
+
 		return rawget(self, index)
 	elseif type(index) == "string" then
 		local lookup = rawget(self, "_lookup")
@@ -229,4 +228,4 @@ function SettingDefinitionProvider:Destroy()
 	self._maid:DoCleaning()
 end
 
-return SettingDefinitionProvider
+return SettingDefinitionProvider

package/src/Shared/Setting/SettingProperty.lua

@@ -203,4 +203,4 @@ function SettingProperty._promisePlayerSettings<T>(self: SettingProperty<T>)
 	return self._bridge:PromisePlayerSettings(self._player)
 end
 
-return SettingProperty
+return SettingProperty

package/test/scripts/Client/ClientMain.client.lua

@@ -22,4 +22,4 @@ game:GetService("UserInputService").InputBegan:Connect(function(input)
 	if input.UserInputType == Enum.UserInputType.MouseButton1 then
 		volume.Value = math.random()
 	end
-end)
+end)

package/test/scripts/Server/ServerMain.server.lua

@@ -17,6 +17,7 @@ serviceBag:GetService(screenShakeDefinition)
 serviceBag:Init()
 serviceBag:Start()
 
+
 local volumeDefinition = SettingDefinition.new("Volume", 1)
 bridge:RegisterSettingDefinition(volumeDefinition)
 
@@ -40,3 +41,4 @@ game.Players.PlayerAdded:Connect(handlePlayer)
 for _, player in game.Players:GetPlayers() do
 	handlePlayer(player)
 end
+