@quenty/secrets 7.50.1 → 7.51.0

package/CHANGELOG.md

@@ -3,6 +3,20 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [7.51.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/secrets@7.50.2...@quenty/secrets@7.51.0) (2026-07-14)
+
+### Bug Fixes
+
+- **lint:** resolve selene unused-self and Rx shadowing from --!strict conversions ([3f4a085](https://github.com/Quenty/NevermoreEngine/commit/3f4a085911808146f10a2435efbe9e89dff8edff))
+
+### Features
+
+- **secrets:** convert package to --!strict ([d0771a1](https://github.com/Quenty/NevermoreEngine/commit/d0771a1e22b964bb9b06a072e3d43ff5e1443923))
+
+## [7.50.2](https://github.com/Quenty/NevermoreEngine/compare/@quenty/secrets@7.50.1...@quenty/secrets@7.50.2) (2026-06-03)
+
+**Note:** Version bump only for package @quenty/secrets
+
 ## [7.50.1](https://github.com/Quenty/NevermoreEngine/compare/@quenty/secrets@7.50.0...@quenty/secrets@7.50.1) (2026-05-30)
 
 **Note:** Version bump only for package @quenty/secrets

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/secrets",
-  "version": "7.50.1",
+  "version": "7.51.0",
   "description": "Secrets storage system and API surface",
   "keywords": [
     "Roblox",
@@ -28,13 +28,13 @@
     "Quenty"
   ],
   "dependencies": {
-    "@quenty/cmdrservice": "13.45.1",
-    "@quenty/datastore": "13.39.1",
-    "@quenty/ellipticcurvecryptography": "1.12.0",
+    "@quenty/cmdrservice": "13.46.0",
+    "@quenty/datastore": "13.40.0",
+    "@quenty/ellipticcurvecryptography": "1.13.0",
     "@quenty/loader": "10.11.0",
     "@quenty/maid": "3.9.0",
     "@quenty/nevermore-test-runner": "1.4.0",
-    "@quenty/permissionprovider": "14.38.1",
+    "@quenty/permissionprovider": "14.39.0",
     "@quenty/promise": "10.18.1",
     "@quenty/remotefunctionutils": "10.18.1",
     "@quenty/remoting": "12.32.1",
@@ -46,5 +46,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "598b2b62b36bdcbdbbd56f7db10c399831cc6eba"
+  "gitHead": "13f0162f4971a77378e55e9b7236aea94f0dd3a8"
 }

package/src/Client/SecretsServiceClient.lua

@@ -1,4 +1,4 @@
---!nonstrict
+--!strict
 --[=[
 	@class SecretsServiceClient
 ]=]
@@ -16,8 +16,19 @@ local ServiceBag = require("ServiceBag")
 local SecretsServiceClient = {}
 SecretsServiceClient.ServiceName = "SecretsServiceClient"
 
-function SecretsServiceClient:Init(serviceBag: ServiceBag.ServiceBag)
-	assert(not self._serviceBag, "Already initialized")
+export type SecretsServiceClient = typeof(setmetatable(
+	{} :: {
+		_serviceBag: ServiceBag.ServiceBag,
+		_maid: Maid.Maid,
+		_cmdrService: any,
+		_permissionsService: any,
+		_remoteFunctionPromise: Promise.Promise<any>?,
+	},
+	{} :: typeof({ __index = SecretsServiceClient })
+))
+
+function SecretsServiceClient.Init(self: SecretsServiceClient, serviceBag: ServiceBag.ServiceBag): ()
+	assert(not (self :: any)._serviceBag, "Already initialized")
 	self._serviceBag = assert(serviceBag, "No serviceBag")
 	self._maid = Maid.new()
 
@@ -26,46 +37,49 @@ function SecretsServiceClient:Init(serviceBag: ServiceBag.ServiceBag)
 	self._permissionsService = self._serviceBag:GetService(require("PermissionServiceClient"))
 end
 
-function SecretsServiceClient:Start()
+function SecretsServiceClient.Start(self: SecretsServiceClient): ()
 	self:_registerCmdrTypes()
 end
 
-function SecretsServiceClient:PromiseSecretKeyNamesList(): Promise.Promise<{ string }>
-	return self:_promiseRemoteFunction()
-		:Then(function(remoteFunction)
-			return self._maid:GivePromise(
-				RemoteFunctionUtils.promiseInvokeServer(
-					remoteFunction,
-					SecretsServiceConstants.REQUEST_SECRET_KEY_NAMES_LIST
+function SecretsServiceClient.PromiseSecretKeyNamesList(self: SecretsServiceClient): Promise.Promise<{ string }>
+	return (
+		self:_promiseRemoteFunction()
+			:Then(function(remoteFunction)
+				return self._maid:GivePromise(
+					RemoteFunctionUtils.promiseInvokeServer(
+						remoteFunction,
+						SecretsServiceConstants.REQUEST_SECRET_KEY_NAMES_LIST
+					)
 				)
-			)
-		end)
-		:Then(function(ok, list)
-			if not ok then
-				return Promise.rejected(list or "Failed to get list")
-			else
-				return Promise.resolved(list)
-			end
-		end)
+			end)
+			:Then(function(ok, list)
+				if not ok then
+					return Promise.rejected(list or "Failed to get list")
+				else
+					return Promise.resolved(list)
+				end
+			end) :: any
+	) :: Promise.Promise<{ string }>
 end
 
-function SecretsServiceClient:_registerCmdrTypes()
+function SecretsServiceClient._registerCmdrTypes(self: SecretsServiceClient): ()
 	self._maid:GivePromise(self._cmdrService:PromiseCmdr()):Then(function(cmdr)
 		SecretsCmdrTypeUtils.registerSecretKeyTypes(cmdr, self)
 	end)
 end
 
-function SecretsServiceClient:_promiseRemoteFunction()
+function SecretsServiceClient._promiseRemoteFunction(self: SecretsServiceClient): Promise.Promise<any>
 	if self._remoteFunctionPromise then
 		return self._remoteFunctionPromise
 	end
 
-	self._remoteFunctionPromise =
+	local remoteFunctionPromise =
 		self._maid:GivePromise(PromiseGetRemoteFunction(SecretsServiceConstants.REMOTE_FUNCTION_NAME))
-	return self._remoteFunctionPromise
+	self._remoteFunctionPromise = remoteFunctionPromise
+	return remoteFunctionPromise
 end
 
-function SecretsServiceClient:Destroy()
+function SecretsServiceClient.Destroy(self: SecretsServiceClient): ()
 	self._maid:DoCleaning()
 end
 

package/src/Server/Cmdr/SecretsCommandService.lua

@@ -1,4 +1,4 @@
---!nonstrict
+--!strict
 --[=[
 	@class SecretsCommandService
 ]=]
@@ -12,8 +12,18 @@ local ServiceBag = require("ServiceBag")
 local SecretsCommandService = {}
 SecretsCommandService.ServiceName = "SecretsCommandService"
 
-function SecretsCommandService:Init(serviceBag: ServiceBag.ServiceBag)
-	assert(not self._serviceBag, "Already initialized")
+export type SecretsCommandService = typeof(setmetatable(
+	{} :: {
+		_serviceBag: ServiceBag.ServiceBag,
+		_maid: Maid.Maid,
+		_cmdrService: any,
+		_secretsService: any,
+	},
+	{} :: typeof({ __index = SecretsCommandService })
+))
+
+function SecretsCommandService.Init(self: SecretsCommandService, serviceBag: ServiceBag.ServiceBag): ()
+	assert(not (self :: any)._serviceBag, "Already initialized")
 	self._serviceBag = assert(serviceBag, "No serviceBag")
 	self._maid = Maid.new()
 
@@ -21,11 +31,11 @@ function SecretsCommandService:Init(serviceBag: ServiceBag.ServiceBag)
 	self._secretsService = self._serviceBag:GetService((require :: any)("SecretsService"))
 end
 
-function SecretsCommandService:Start()
+function SecretsCommandService.Start(self: SecretsCommandService): ()
 	self:_registerCommands()
 end
 
-function SecretsCommandService:_registerCommands()
+function SecretsCommandService._registerCommands(self: SecretsCommandService): ()
 	self._maid:GivePromise(self._cmdrService:PromiseCmdr()):Then(function(cmdr)
 		SecretsCmdrTypeUtils.registerSecretKeyTypes(cmdr, self._secretsService)
 	end)
@@ -153,7 +163,7 @@ function SecretsCommandService:_registerCommands()
 	end)
 end
 
-function SecretsCommandService:Destroy()
+function SecretsCommandService.Destroy(self: SecretsCommandService): ()
 	self._maid:DoCleaning()
 end
 

package/src/Server/SecretsService.lua

@@ -1,4 +1,4 @@
---!nonstrict
+--!strict
 --[=[
 	@class SecretsService
 ]=]
@@ -18,8 +18,28 @@ local ServiceBag = require("ServiceBag")
 local SecretsService = {}
 SecretsService.ServiceName = "SecretsService"
 
-function SecretsService:Init(serviceBag: ServiceBag.ServiceBag)
-	assert(not self._serviceBag, "Already initialized")
+export type SecretsData = {
+	encrypted: { number },
+	signature: { number },
+}
+
+export type SecretsService = typeof(setmetatable(
+	{} :: {
+		_serviceBag: ServiceBag.ServiceBag,
+		_maid: Maid.Maid,
+		_gameDataStoreService: any,
+		_permissionsService: any,
+		_publicKey: any,
+		_privateKey: any,
+		_warningRequired: boolean,
+		_remoteFunction: RemoteFunction,
+		_substorePromise: any,
+	},
+	{} :: typeof({ __index = SecretsService })
+))
+
+function SecretsService.Init(self: SecretsService, serviceBag: ServiceBag.ServiceBag): ()
+	assert(not (self :: any)._serviceBag, "Already initialized")
 	self._serviceBag = assert(serviceBag, "No serviceBag")
 	self._maid = Maid.new()
 
@@ -43,7 +63,7 @@ end
 
 	@param seed number
 ]=]
-function SecretsService:SetPublicKeySeed(seed: number): ()
+function SecretsService.SetPublicKeySeed(self: SecretsService, seed: number): ()
 	assert(type(seed) == "number", "Bad seed")
 
 	local private, public = EllipticCurveCryptography.keypair(seed or EllipticCurveCryptography.random.random())
@@ -55,7 +75,7 @@ end
 --[=[
 	Starts the secret service. Should be done via [ServiceBag].
 ]=]
-function SecretsService:Start()
+function SecretsService.Start(self: SecretsService): ()
 	self._remoteFunction = GetRemoteFunction(SecretsServiceConstants.REMOTE_FUNCTION_NAME)
 	self._remoteFunction.OnServerInvoke = function(...)
 		return self:_handleServerInvoke(...)
@@ -68,7 +88,7 @@ end
 	@param secretKey string
 	@return Promise<string>
 ]=]
-function SecretsService:PromiseSecret(secretKey: string): Promise.Promise<string | Secret>
+function SecretsService.PromiseSecret(self: SecretsService, secretKey: string): Promise.Promise<string | Secret>
 	assert(type(secretKey) == "string", "Bad secretKey")
 
 	local found
@@ -79,14 +99,14 @@ function SecretsService:PromiseSecret(secretKey: string): Promise.Promise<string
 		return Promise.resolved(found)
 	end
 
-	return self:_promiseSubstore():Then(function(substore)
-		return self._maid:GivePromise(substore:Load(secretKey)):Then(function(data)
+	return (self :: any):_promiseSubstore():Then(function(substore)
+		return (self._maid :: any):GivePromise(substore:Load(secretKey)):Then(function(data)
 			if type(data) ~= "table" then
 				return Promise.resolved(nil)
 			else
 				local ok, value = self:_decrypt(data)
 				if ok then
-					return value
+					return value :: any
 				else
 					return Promise.rejected(value or "Failed to decrypt result")
 				end
@@ -100,9 +120,9 @@ end
 
 	@return @return Promise<{string}>
 ]=]
-function SecretsService:PromiseAllSecrets(): Promise.Promise<{ string }>
-	return self:_promiseSubstore():Then(function(substore)
-		return self._maid:GivePromise(substore:LoadAll()):Then(function(secretsList)
+function SecretsService.PromiseAllSecrets(self: SecretsService): Promise.Promise<{ string }>
+	return (self :: any):_promiseSubstore():Then(function(substore)
+		return (self._maid :: any):GivePromise(substore:LoadAll()):Then(function(secretsList)
 			local secretMap = {}
 
 			for key, secretData in secretsList do
@@ -125,13 +145,13 @@ end
 	@param secretKey string
 	@return Observable<string>
 ]=]
-function SecretsService:ObserveSecret(secretKey: string): Observable.Observable<string>
+function SecretsService.ObserveSecret(self: SecretsService, secretKey: string): Observable.Observable<string>
 	assert(type(secretKey) == "string", "Bad secretKey")
 
-	return Observable.new(function(sub)
-		local maid = Maid.new()
+	return Observable.new(function(sub: any)
+		local maid: any = Maid.new()
 
-		maid:GivePromise(self:_promiseSubstore():Then(function(substore)
+		maid:GivePromise((self :: any):_promiseSubstore():Then(function(substore)
 			maid:GivePromise(
 				substore:Observe(secretKey):Subscribe(function(data)
 					if type(data) ~= "table" then
@@ -153,7 +173,7 @@ function SecretsService:ObserveSecret(secretKey: string): Observable.Observable<
 		end))
 
 		return maid
-	end)
+	end) :: any
 end
 
 --[=[
@@ -161,10 +181,10 @@ end
 
 	@param secretKey string
 ]=]
-function SecretsService:DeleteSecret(secretKey: string): Promise.Promise<()>
+function SecretsService.DeleteSecret(self: SecretsService, secretKey: string): Promise.Promise<()>
 	assert(type(secretKey) == "string", "Bad secretKey")
 
-	return self:_promiseSubstore():Then(function(substore)
+	return (self :: any):_promiseSubstore():Then(function(substore)
 		substore:Delete(secretKey)
 	end)
 end
@@ -175,20 +195,19 @@ end
 	@param secretKey string
 	@param value string
 ]=]
-function SecretsService:StoreSecret(secretKey: string, value: string): ()
+function SecretsService.StoreSecret(self: SecretsService, secretKey: string, value: string): ()
 	assert(type(secretKey) == "string", "Bad secretKey")
 	assert(type(value) == "string", "Bad value")
 
-	self:_warnAboutNoPublicKeyStoredInSourceCode()
-
-	self:_promiseSubstore():Then(function(substore)
+	self:_warnAboutNoPublicKeyStoredInSourceCode();
+	(self :: any):_promiseSubstore():Then(function(substore)
 		local encrypted = EllipticCurveCryptography.encrypt(value, self._privateKey)
 		local signature = EllipticCurveCryptography.sign(self._privateKey, value)
 
 		-- TODO: Encode byte array in more efficient structure for JSON
 		local toStore = {
-			encrypted = setmetatable(table.clone(encrypted), nil), -- remove metatable
-			signature = setmetatable(table.clone(signature), nil), -- remove metatable
+			encrypted = setmetatable(table.clone(encrypted) :: any, nil), -- remove metatable
+			signature = setmetatable(table.clone(signature) :: any, nil), -- remove metatable
 		}
 
 		substore:Store(secretKey, toStore)
@@ -200,8 +219,8 @@ end
 
 	@return Promise<()>
 ]=]
-function SecretsService:ClearAllSecrets(): Promise.Promise<()>
-	return self:_promiseSubstore():Then(function(substore)
+function SecretsService.ClearAllSecrets(self: SecretsService): Promise.Promise<()>
+	return (self :: any):_promiseSubstore():Then(function(substore)
 		return substore:Wipe()
 	end)
 end
@@ -211,20 +230,20 @@ end
 
 	@return Promise<{ string }>
 ]=]
-function SecretsService:PromiseSecretKeyNamesList(): Promise.Promise<{ string }>
-	return self:_promiseSubstore():Then(function(substore)
+function SecretsService.PromiseSecretKeyNamesList(self: SecretsService): Promise.Promise<{ string }>
+	return (self :: any):_promiseSubstore():Then(function(substore)
 		return substore:PromiseKeyList()
 	end)
 end
 
-function SecretsService:_warnAboutNoPublicKeyStoredInSourceCode(): ()
+function SecretsService._warnAboutNoPublicKeyStoredInSourceCode(self: SecretsService): ()
 	if self._warningRequired then
 		self._warningRequired = false
 		warn(self:_getInstructions())
 	end
 end
 
-function SecretsService:_getInstructions(): string
+function SecretsService._getInstructions(_self: SecretsService): string
 	local instructions =
 		"[SecretsService.StoreSecret] - Security - Current private key seed is GameId, which is guessable."
 	instructions = instructions .. "\n\tTIP: This is only applicable if we're storing API keys for use in here."
@@ -236,12 +255,7 @@ function SecretsService:_getInstructions(): string
 	return instructions
 end
 
-export type SecretsData = {
-	encrypted: { number },
-	signature: { number },
-}
-
-function SecretsService:_decrypt(data: SecretsData): (boolean?, string)
+function SecretsService._decrypt(self: SecretsService, data: SecretsData): (boolean?, string)
 	assert(type(data) == "table", "Bad data")
 	assert(data.encrypted ~= nil, "Bad data.encrypted")
 	assert(data.signature ~= nil, "Bad data.signature")
@@ -259,15 +273,15 @@ function SecretsService:_decrypt(data: SecretsData): (boolean?, string)
 	return true, tostring(decrypted)
 end
 
-function SecretsService:_handleServerInvoke(player: Player, request)
+function SecretsService._handleServerInvoke(self: SecretsService, player: Player, request: any): any
 	if request == SecretsServiceConstants.REQUEST_SECRET_KEY_NAMES_LIST then
-		return self:_promiseHandleList(player):Yield()
+		return (self :: any):_promiseHandleList(player):Yield()
 	else
 		error(string.format("Bad request %q", tostring(request)))
 	end
 end
 
-function SecretsService:_promiseHandleList(player: Player)
+function SecretsService._promiseHandleList(self: SecretsService, player: Player): any
 	return self._permissionsService
 		:PromisePermissionProvider()
 		:Then(function(provider)
@@ -282,7 +296,7 @@ function SecretsService:_promiseHandleList(player: Player)
 		end)
 end
 
-function SecretsService:_promiseSubstore()
+function SecretsService._promiseSubstore(self: SecretsService): any
 	if self._substorePromise then
 		return self._substorePromise
 	end
@@ -296,7 +310,7 @@ function SecretsService:_promiseSubstore()
 	return self._substorePromise
 end
 
-function SecretsService:Destroy()
+function SecretsService.Destroy(self: SecretsService): ()
 	self._maid:DoCleaning()
 end