@quenty/secrets 7.23.3 → 7.23.4-canary.559.339cfa7.0

package/CHANGELOG.md

@@ -3,6 +3,22 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [7.23.4-canary.559.339cfa7.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/secrets@7.23.3...@quenty/secrets@7.23.4-canary.559.339cfa7.0) (2025-05-10)
+
+
+### Bug Fixes
+
+* Additional type checking updates ([05ba29a](https://github.com/Quenty/NevermoreEngine/commit/05ba29a03efc9f3feed74b34f1d9dfb237496214))
+
+
+### Features
+
+* Add even more types ([b31717d](https://github.com/Quenty/NevermoreEngine/commit/b31717d8c9f7620c457f5018a2affa760a65334a))
+
+
+
+
+
 ## [7.23.3](https://github.com/Quenty/NevermoreEngine/compare/@quenty/secrets@7.23.2...@quenty/secrets@7.23.3) (2025-04-10)
 
 **Note:** Version bump only for package @quenty/secrets

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/secrets",
-  "version": "7.23.3",
+  "version": "7.23.4-canary.559.339cfa7.0",
   "description": "Secrets storage system and API surface",
   "keywords": [
     "Roblox",
@@ -25,21 +25,21 @@
     "Quenty"
   ],
   "dependencies": {
-    "@quenty/cmdrservice": "^13.22.3",
-    "@quenty/datastore": "^13.20.3",
-    "@quenty/ellipticcurvecryptography": "^1.6.2",
-    "@quenty/loader": "^10.8.3",
-    "@quenty/maid": "^3.4.3",
-    "@quenty/permissionprovider": "^14.19.3",
-    "@quenty/promise": "^10.10.4",
-    "@quenty/remotefunctionutils": "^10.10.4",
-    "@quenty/remoting": "^12.18.3",
-    "@quenty/rx": "^13.17.3",
-    "@quenty/servicebag": "^11.11.4",
-    "@quenty/table": "^3.7.4"
+    "@quenty/cmdrservice": "13.22.4-canary.559.339cfa7.0",
+    "@quenty/datastore": "13.20.4-canary.559.339cfa7.0",
+    "@quenty/ellipticcurvecryptography": "1.6.3-canary.559.339cfa7.0",
+    "@quenty/loader": "10.8.4-canary.559.339cfa7.0",
+    "@quenty/maid": "3.4.4-canary.559.339cfa7.0",
+    "@quenty/permissionprovider": "14.19.4-canary.559.339cfa7.0",
+    "@quenty/promise": "10.10.5-canary.559.339cfa7.0",
+    "@quenty/remotefunctionutils": "10.10.5-canary.559.339cfa7.0",
+    "@quenty/remoting": "12.18.4-canary.559.339cfa7.0",
+    "@quenty/rx": "13.17.4-canary.559.339cfa7.0",
+    "@quenty/servicebag": "11.11.5-canary.559.339cfa7.0",
+    "@quenty/table": "3.7.5-canary.559.339cfa7.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "b06c070ae91d5dab7bd8de6e290ad2caabb15d8f"
+  "gitHead": "339cfa778736f08768ed7305041f6221faa35bfc"
 }

package/src/Client/SecretsServiceClient.lua

@@ -5,17 +5,17 @@
 local require = require(script.Parent.loader).load(script)
 
 local Maid = require("Maid")
+local Promise = require("Promise")
 local PromiseGetRemoteFunction = require("PromiseGetRemoteFunction")
+local RemoteFunctionUtils = require("RemoteFunctionUtils")
 local SecretsCmdrTypeUtils = require("SecretsCmdrTypeUtils")
 local SecretsServiceConstants = require("SecretsServiceConstants")
-local RemoteFunctionUtils = require("RemoteFunctionUtils")
-local Promise = require("Promise")
-local _ServiceBag = require("ServiceBag")
+local ServiceBag = require("ServiceBag")
 
 local SecretsServiceClient = {}
 SecretsServiceClient.ServiceName = "SecretsServiceClient"
 
-function SecretsServiceClient:Init(serviceBag: _ServiceBag.ServiceBag)
+function SecretsServiceClient:Init(serviceBag: ServiceBag.ServiceBag)
 	assert(not self._serviceBag, "Already initialized")
 	self._serviceBag = assert(serviceBag, "No serviceBag")
 	self._maid = Maid.new()
@@ -29,12 +29,15 @@ function SecretsServiceClient:Start()
 	self:_registerCmdrTypes()
 end
 
-function SecretsServiceClient:PromiseSecretKeyNamesList()
+function SecretsServiceClient:PromiseSecretKeyNamesList(): Promise.Promise<{ string }>
 	return self:_promiseRemoteFunction()
 		:Then(function(remoteFunction)
-			return self._maid:GivePromise(RemoteFunctionUtils.promiseInvokeServer(
-				remoteFunction,
-				SecretsServiceConstants.REQUEST_SECRET_KEY_NAMES_LIST))
+			return self._maid:GivePromise(
+				RemoteFunctionUtils.promiseInvokeServer(
+					remoteFunction,
+					SecretsServiceConstants.REQUEST_SECRET_KEY_NAMES_LIST
+				)
+			)
 		end)
 		:Then(function(ok, list)
 			if not ok then
@@ -56,7 +59,8 @@ function SecretsServiceClient:_promiseRemoteFunction()
 		return self._remoteFunctionPromise
 	end
 
-	self._remoteFunctionPromise = self._maid:GivePromise(PromiseGetRemoteFunction(SecretsServiceConstants.REMOTE_FUNCTION_NAME))
+	self._remoteFunctionPromise =
+		self._maid:GivePromise(PromiseGetRemoteFunction(SecretsServiceConstants.REMOTE_FUNCTION_NAME))
 	return self._remoteFunctionPromise
 end
 
@@ -64,4 +68,4 @@ function SecretsServiceClient:Destroy()
 	self._maid:DoCleaning()
 end
 
-return SecretsServiceClient
+return SecretsServiceClient

package/src/Server/Cmdr/SecretsCommandService.lua

@@ -4,14 +4,14 @@
 
 local require = require(script.Parent.loader).load(script)
 
-local SecretsCmdrTypeUtils = require("SecretsCmdrTypeUtils")
 local Maid = require("Maid")
-local _ServiceBag = require("ServiceBag")
+local SecretsCmdrTypeUtils = require("SecretsCmdrTypeUtils")
+local ServiceBag = require("ServiceBag")
 
 local SecretsCommandService = {}
 SecretsCommandService.ServiceName = "SecretsCommandService"
 
-function SecretsCommandService:Init(serviceBag: _ServiceBag.ServiceBag)
+function SecretsCommandService:Init(serviceBag: ServiceBag.ServiceBag)
 	assert(not self._serviceBag, "Already initialized")
 	self._serviceBag = assert(serviceBag, "No serviceBag")
 	self._maid = Maid.new()
@@ -30,11 +30,11 @@ function SecretsCommandService:_registerCommands()
 	end)
 
 	self._cmdrService:RegisterCommand({
-		Name = "list-all-secret-keys";
-		Aliases = { };
-		Description = "Lists all secret keys available.";
-		Group = "Secrets";
-		Args = {};
+		Name = "list-all-secret-keys",
+		Aliases = {},
+		Description = "Lists all secret keys available.",
+		Group = "Secrets",
+		Args = {},
 	}, function(_context)
 		local secrets = self._secretsService:PromiseSecretKeyNamesList():Wait()
 
@@ -47,22 +47,22 @@ function SecretsCommandService:_registerCommands()
 	end)
 
 	self._cmdrService:RegisterCommand({
-		Name = "store-secret";
-		Aliases = { };
-		Description = "Stores a secret key.";
-		Group = "Secrets";
+		Name = "store-secret",
+		Aliases = {},
+		Description = "Stores a secret key.",
+		Group = "Secrets",
 		Args = {
 			{
-				Name = "SecretKey";
-				Type = "secretKey";
-				Description = "The key of the secret to store.";
+				Name = "SecretKey",
+				Type = "secretKey",
+				Description = "The key of the secret to store.",
 			},
 			{
-				Name = "SecretValue";
-				Type = "string";
-				Description = "The value of the secret to store";
-			}
-		};
+				Name = "SecretValue",
+				Type = "string",
+				Description = "The value of the secret to store",
+			},
+		},
 	}, function(_context, secretKey, secretValue)
 		self._secretsService:StoreSecret(secretKey, secretValue)
 
@@ -70,17 +70,17 @@ function SecretsCommandService:_registerCommands()
 	end)
 
 	self._cmdrService:RegisterCommand({
-		Name = "delete-secret";
-		Aliases = { };
-		Description = "Stores a secret by key.";
-		Group = "Secrets";
+		Name = "delete-secret",
+		Aliases = {},
+		Description = "Stores a secret by key.",
+		Group = "Secrets",
 		Args = {
 			{
-				Name = "SecretKey";
-				Type = "requiredSecretKey";
-				Description = "The key of the secret to store.";
-			}
-		};
+				Name = "SecretKey",
+				Type = "requiredSecretKey",
+				Description = "The key of the secret to store.",
+			},
+		},
 	}, function(_context, secretKey)
 		self._secretsService:DeleteSecret(secretKey)
 
@@ -88,17 +88,17 @@ function SecretsCommandService:_registerCommands()
 	end)
 
 	self._cmdrService:RegisterCommand({
-		Name = "read-secret";
-		Aliases = { };
-		Description = "Reads a secret by key.";
-		Group = "Secrets";
+		Name = "read-secret",
+		Aliases = {},
+		Description = "Reads a secret by key.",
+		Group = "Secrets",
 		Args = {
 			{
-				Name = "SecretKey";
-				Type = "requiredSecretKey";
-				Description = "The key of the secret to read.";
-			}
-		};
+				Name = "SecretKey",
+				Type = "requiredSecretKey",
+				Description = "The key of the secret to read.",
+			},
+		},
 	}, function(_context, secretKey)
 		local secret = self._secretsService:PromiseSecret(secretKey):Wait()
 
@@ -110,11 +110,11 @@ function SecretsCommandService:_registerCommands()
 	end)
 
 	self._cmdrService:RegisterCommand({
-		Name = "list-all-secrets";
-		Aliases = { };
-		Description = "Reads all secrets.";
-		Group = "Secrets";
-		Args = {};
+		Name = "list-all-secrets",
+		Aliases = {},
+		Description = "Reads all secrets.",
+		Group = "Secrets",
+		Args = {},
 	}, function(_context)
 		local secrets = self._secretsService:PromiseAllSecrets():Wait()
 
@@ -140,11 +140,11 @@ function SecretsCommandService:_registerCommands()
 	end)
 
 	self._cmdrService:RegisterCommand({
-		Name = "clear-all-secrets";
-		Aliases = { };
-		Description = "Clears all secrets in the store.";
-		Group = "Secrets";
-		Args = {};
+		Name = "clear-all-secrets",
+		Aliases = {},
+		Description = "Clears all secrets in the store.",
+		Group = "Secrets",
+		Args = {},
 	}, function(_context)
 		self._secretsService:ClearAllSecrets()
 
@@ -156,4 +156,4 @@ function SecretsCommandService:Destroy()
 	self._maid:DoCleaning()
 end
 
-return SecretsCommandService
+return SecretsCommandService

package/src/Server/SecretsService.lua

@@ -4,18 +4,18 @@
 
 local require = require(script.Parent.loader).load(script)
 
-local Maid = require("Maid")
-local SecretsServiceConstants = require("SecretsServiceConstants")
+local EllipticCurveCryptography = require("EllipticCurveCryptography")
 local GetRemoteFunction = require("GetRemoteFunction")
-local Promise = require("Promise")
+local Maid = require("Maid")
 local Observable = require("Observable")
-local EllipticCurveCryptography = require("EllipticCurveCryptography")
-local _ServiceBag = require("ServiceBag")
+local Promise = require("Promise")
+local SecretsServiceConstants = require("SecretsServiceConstants")
+local ServiceBag = require("ServiceBag")
 
 local SecretsService = {}
 SecretsService.ServiceName = "SecretsService"
 
-function SecretsService:Init(serviceBag: _ServiceBag.ServiceBag)
+function SecretsService:Init(serviceBag: ServiceBag.ServiceBag)
 	assert(not self._serviceBag, "Already initialized")
 	self._serviceBag = assert(serviceBag, "No serviceBag")
 	self._maid = Maid.new()
@@ -40,7 +40,7 @@ end
 
 	@param seed number
 ]=]
-function SecretsService:SetPublicKeySeed(seed: number)
+function SecretsService:SetPublicKeySeed(seed: number): ()
 	assert(type(seed) == "number", "Bad seed")
 
 	local private, public = EllipticCurveCryptography.keypair(seed or EllipticCurveCryptography.random.random())
@@ -65,7 +65,7 @@ end
 	@param secretKey string
 	@return Promise<string>
 ]=]
-function SecretsService:PromiseSecret(secretKey: string)
+function SecretsService:PromiseSecret(secretKey: string): Promise.Promise<string>
 	assert(type(secretKey) == "string", "Bad secretKey")
 
 	return self:_promiseSubstore():Then(function(substore)
@@ -164,7 +164,7 @@ end
 	@param secretKey string
 	@param value string
 ]=]
-function SecretsService:StoreSecret(secretKey: string, value: string)
+function SecretsService:StoreSecret(secretKey: string, value: string): ()
 	assert(type(secretKey) == "string", "Bad secretKey")
 	assert(type(value) == "string", "Bad value")
 
@@ -206,7 +206,7 @@ function SecretsService:PromiseSecretKeyNamesList(): Promise.Promise<{ string }>
 	end)
 end
 
-function SecretsService:_warnAboutNoPublicKeyStoredInSourceCode()
+function SecretsService:_warnAboutNoPublicKeyStoredInSourceCode(): ()
 	if self._warningRequired then
 		self._warningRequired = false
 		warn(self:_getInstructions())
@@ -257,7 +257,8 @@ function SecretsService:_handleServerInvoke(player, request)
 end
 
 function SecretsService:_promiseHandleList(player)
-	return self._permissionsService:PromisePermissionProvider()
+	return self._permissionsService
+		:PromisePermissionProvider()
 		:Then(function(provider)
 			return provider:PromiseIsAdmin(player)
 		end)
@@ -275,7 +276,8 @@ function SecretsService:_promiseSubstore()
 		return self._substorePromise
 	end
 
-	self._substorePromise = self._maid:GivePromise(self._gameDataStoreService:PromiseDataStore())
+	self._substorePromise = self._maid
+		:GivePromise(self._gameDataStoreService:PromiseDataStore())
 		:Then(function(dataStore)
 			return dataStore:GetSubStore("secrets")
 		end)
@@ -287,4 +289,4 @@ function SecretsService:Destroy()
 	self._maid:DoCleaning()
 end
 
-return SecretsService
+return SecretsService

package/src/Shared/Cmdr/SecretsCmdrTypeUtils.lua

@@ -1,3 +1,4 @@
+--!strict
 --[=[
 	@class SecretsCmdrTypeUtils
 ]=]
@@ -17,7 +18,7 @@ end
 function SecretsCmdrTypeUtils.makeSecretKeyType(cmdr, secretsService, isRequired)
 	return {
 		Transform = function(text)
-		local secretNames = secretsService:PromiseSecretKeyNamesList():Wait()
+			local secretNames = secretsService:PromiseSecretKeyNamesList():Wait()
 			local list
 			if not isRequired then
 				list = table.clone(secretNames)
@@ -28,7 +29,7 @@ function SecretsCmdrTypeUtils.makeSecretKeyType(cmdr, secretsService, isRequired
 
 			local find = cmdr.Util.MakeFuzzyFinder(list)
 			return find(text)
-		end;
+		end,
 		Validate = function(keys)
 			return #keys > 0, "No secret exists with key."
 		end,
@@ -37,8 +38,8 @@ function SecretsCmdrTypeUtils.makeSecretKeyType(cmdr, secretsService, isRequired
 		end,
 		Parse = function(keys)
 			return keys[1]
-		end;
+		end,
 	}
 end
 
-return SecretsCmdrTypeUtils
+return SecretsCmdrTypeUtils

package/src/Shared/SecretsServiceConstants.lua

@@ -1,3 +1,4 @@
+--!strict
 --[=[
 	@class SecretsServiceConstants
 ]=]
@@ -7,6 +8,6 @@ local require = require(script.Parent.loader).load(script)
 local Table = require("Table")
 
 return Table.readonly({
-	REMOTE_FUNCTION_NAME = "SecretsServiceRemoteFunction";
-	REQUEST_SECRET_KEY_NAMES_LIST = "requestSecretKeyNamesList"
-})
+	REMOTE_FUNCTION_NAME = "SecretsServiceRemoteFunction",
+	REQUEST_SECRET_KEY_NAMES_LIST = "requestSecretKeyNamesList",
+})

package/test/scripts/Client/ClientMain.client.lua

@@ -8,4 +8,3 @@ local serviceBag = require("ServiceBag").new()
 serviceBag:GetService(require("SecretsServiceClient"))
 serviceBag:Init()
 serviceBag:Start()
-

package/test/scripts/Server/ServerMain.server.lua

@@ -15,7 +15,6 @@ serviceBag:Start()
 serviceBag:GetService(require("SecretsService")):SetPublicKeySeed(1523523523)
 serviceBag:GetService(require("SecretsService")):StoreSecret("test", "36dfda27-1ba4-42f3-92ff-79262fc7a6e6")
 
-serviceBag:GetService(require("SecretsService")):PromiseSecret("test")
-	:Then(function(value)
-		print("Got secret", value)
-	end)
+serviceBag:GetService(require("SecretsService")):PromiseSecret("test"):Then(function(value)
+	print("Got secret", value)
+end)