@quenty/screenshothudservice 1.8.0 → 1.9.0

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [1.9.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/screenshothudservice@1.8.0...@quenty/screenshothudservice@1.9.0) (2023-05-26)
+
+
+### Features
+
+* Initial refactor of guis to use ValueObject instead of ValueObject ([723aba0](https://github.com/Quenty/NevermoreEngine/commit/723aba0208cae7e06c9d8bf2d8f0092d042d70ea))
+
+
+
+
+
 # [1.8.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/screenshothudservice@1.7.0...@quenty/screenshothudservice@1.8.0) (2023-05-08)
 
 **Note:** Version bump only for package @quenty/screenshothudservice

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/screenshothudservice",
-  "version": "1.8.0",
+  "version": "1.9.0",
   "description": "Provides centralized API surface for screenshot hud API",
   "keywords": [
     "Roblox",
@@ -26,19 +26,19 @@
   ],
   "dependencies": {
     "@quenty/baseobject": "^6.2.1",
-    "@quenty/brio": "^8.12.0",
-    "@quenty/instanceutils": "^7.13.0",
+    "@quenty/brio": "^8.13.0",
+    "@quenty/instanceutils": "^7.14.0",
     "@quenty/loader": "^6.2.1",
     "@quenty/maid": "^2.5.0",
     "@quenty/promise": "^6.5.0",
-    "@quenty/rx": "^7.10.0",
-    "@quenty/servicebag": "^6.6.1",
-    "@quenty/signal": "^2.3.0",
-    "@quenty/statestack": "^8.13.0",
-    "@quenty/valueobject": "^7.13.0"
+    "@quenty/rx": "^7.11.0",
+    "@quenty/servicebag": "^6.7.0",
+    "@quenty/signal": "^2.4.0",
+    "@quenty/statestack": "^8.14.0",
+    "@quenty/valueobject": "^7.14.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "2ad8cea7dd3ad79a39afd7d7b785b489b90553fd"
+  "gitHead": "11058e90e51ea83d3dad6ae9abe59cc19c36b94b"
 }

package/src/Client/ScreenshotHudModel.lua

@@ -6,7 +6,6 @@ local require = require(script.Parent.loader).load(script)
 
 local BaseObject = require("BaseObject")
 local ValueObject = require("ValueObject")
-local RxInstanceUtils = require("RxInstanceUtils")
 local Signal = require("Signal")
 
 local ScreenshotHudModel = setmetatable({}, BaseObject)
@@ -16,8 +15,7 @@ ScreenshotHudModel.__index = ScreenshotHudModel
 function ScreenshotHudModel.new()
 	local self = setmetatable(BaseObject.new(), ScreenshotHudModel)
 
-	self._cameraButtonIcon = Instance.new("StringValue")
-	self._cameraButtonIcon.Value = ""
+	self._cameraButtonIcon = ValueObject.new("", "string")
 	self._maid:GiveTask(self._cameraButtonIcon)
 
 	self._cameraButtonPosition = ValueObject.new(UDim2.new(0, 0, 0, 0))
@@ -26,35 +24,28 @@ function ScreenshotHudModel.new()
 	self._closeButtonPosition = ValueObject.new(UDim2.new(0, 0, 0, 0))
 	self._maid:GiveTask(self._closeButtonPosition)
 
-	self._closeWhenScreenshotTaken = Instance.new("BoolValue")
-	self._closeWhenScreenshotTaken.Value = false
+	self._closeWhenScreenshotTaken = ValueObject.new(false, "boolean")
 	self._maid:GiveTask(self._closeWhenScreenshotTaken)
 
-	self._experienceNameOverlayEnabled = Instance.new("BoolValue")
-	self._experienceNameOverlayEnabled.Value = false
+	self._experienceNameOverlayEnabled = ValueObject.new(false, "boolean")
 	self._maid:GiveTask(self._experienceNameOverlayEnabled)
 
 	self._overlayFont = ValueObject.new(Enum.Font.SourceSans)
 	self._maid:GiveTask(self._overlayFont)
 
-	self._usernameOverlayEnabled = Instance.new("BoolValue")
-	self._usernameOverlayEnabled.Value = false
+	self._usernameOverlayEnabled = ValueObject.new(false, "boolean")
 	self._maid:GiveTask(self._usernameOverlayEnabled)
 
-	self._visible = Instance.new("BoolValue")
-	self._visible.Value = false
+	self._visible = ValueObject.new(false, "boolean")
 	self._maid:GiveTask(self._visible)
 
-	self._cameraButtonVisible = Instance.new("BoolValue")
-	self._cameraButtonVisible.Value = true
+	self._cameraButtonVisible = ValueObject.new(true, "boolean")
 	self._maid:GiveTask(self._cameraButtonVisible)
 
-	self._closeButtonVisible = Instance.new("BoolValue")
-	self._closeButtonVisible.Value = false
+	self._closeButtonVisible = ValueObject.new(false, "boolean")
 	self._maid:GiveTask(self._closeButtonVisible)
 
-	self._keepOpen = Instance.new("BoolValue")
-	self._keepOpen.Value = true
+	self._keepOpen = ValueObject.new(true, "boolean")
 	self._maid:GiveTask(self._keepOpen)
 
 	self.CloseRequested = Signal.new()
@@ -78,7 +69,7 @@ end
 	@return Observable<boolean>
 ]=]
 function ScreenshotHudModel:ObserveCloseButtonVisible()
-	return RxInstanceUtils.observeProperty(self._closeButtonVisible, "Value")
+	return self._closeButtonVisible:Observe()
 end
 
 --[=[
@@ -96,7 +87,7 @@ end
 	@return Observable<boolean>
 ]=]
 function ScreenshotHudModel:ObserveCameraButtonVisible()
-	return RxInstanceUtils.observeProperty(self._cameraButtonVisible, "Value")
+	return self._cameraButtonVisible:Observe()
 end
 
 --[=[
@@ -199,7 +190,7 @@ end
 	@return Observable<string>
 ]=]
 function ScreenshotHudModel:ObserveCameraButtonIcon()
-	return RxInstanceUtils.observeProperty(self._cameraButtonIcon, "Value")
+	return self._cameraButtonIcon:Observe()
 end
 
 --[=[
@@ -226,7 +217,7 @@ end
 	@return Observable<boolean>
 ]=]
 function ScreenshotHudModel:ObserveCloseWhenScreenshotTaken()
-	return RxInstanceUtils.observeProperty(self._closeWhenScreenshotTaken, "Value")
+	return self._closeWhenScreenshotTaken:Observe()
 end
 
 --[=[
@@ -244,7 +235,7 @@ end
 	@return Observable<boolean>
 ]=]
 function ScreenshotHudModel:ObserveExperienceNameOverlayEnabled()
-	return RxInstanceUtils.observeProperty(self._experienceNameOverlayEnabled, "Value")
+	return self._experienceNameOverlayEnabled:Observe()
 end
 
 --[=[
@@ -262,7 +253,7 @@ end
 	@return Observable<boolean>
 ]=]
 function ScreenshotHudModel:ObserveUsernameOverlayEnabled()
-	return RxInstanceUtils.observeProperty(self._usernameOverlayEnabled, "Value")
+	return self._usernameOverlayEnabled:Observe()
 end
 
 --[=[
@@ -270,7 +261,7 @@ end
 	@return Observable<boolean>
 ]=]
 function ScreenshotHudModel:ObserveVisible()
-	return RxInstanceUtils.observeProperty(self._visible, "Value")
+	return self._visible:Observe()
 end
 
 function ScreenshotHudModel:InternalNotifyVisible(isVisible)