@quenty/rxsignal 1.5.0 → 2.0.0

package/CHANGELOG.md

@@ -3,6 +3,20 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [2.0.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/rxsignal@1.5.0...@quenty/rxsignal@2.0.0) (2023-10-11)
+
+
+* fix!: Make RxSignal not automatically skip first input ([6fe7586](https://github.com/Quenty/NevermoreEngine/commit/6fe7586029ea4753b1de7a8633c7d5af15bab420))
+
+
+### BREAKING CHANGES
+
+* RxSignal used to export a different value
+
+
+
+
+
 # [1.5.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/rxsignal@1.4.0...@quenty/rxsignal@1.5.0) (2023-09-21)
 
 **Note:** Version bump only for package @quenty/rxsignal

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/rxsignal",
-  "version": "1.5.0",
+  "version": "2.0.0",
   "description": "Signal API for RxObservables",
   "keywords": [
     "Roblox",
@@ -25,11 +25,11 @@
     "Quenty"
   ],
   "dependencies": {
-    "@quenty/loader": "^6.3.0",
-    "@quenty/rx": "^7.16.0"
+    "@quenty/loader": "^7.0.0",
+    "@quenty/rx": "^8.0.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "fd634d0ed1918fc14bae8501aff1cc099d0537e7"
+  "gitHead": "fdeae46099587019ec5fc15317dc673aed379400"
 }

package/src/Shared/RxSignal.lua

@@ -5,6 +5,7 @@
 local require = require(script.Parent.loader).load(script)
 
 local Rx = require("Rx")
+local Observable = require("Observable")
 
 local RxSignal = {}
 RxSignal.ClassName = "RxSignal"
@@ -13,7 +14,7 @@ RxSignal.__index = RxSignal
 --[=[
 	Converts an observable to the Signal interface
 
-	@param observable Observable<T>
+	@param observable Observable<T> | () -> Observable<T>
 	@return RxSignal<T>
 ]=]
 function RxSignal.new(observable)
@@ -21,19 +22,33 @@ function RxSignal.new(observable)
 
 	local self = setmetatable({}, RxSignal)
 
-	self._observable = observable:Pipe({
-		Rx.skip(1);
-	})
+	self._observable = observable
 
 	return self
 end
 
 function RxSignal:Connect(callback)
-	return self._observable:Subscribe(callback)
+	return self:_getObservable():Subscribe(callback)
+end
+
+function RxSignal:_getObservable()
+	if Observable.isObservable(self._observable) then
+		return self._observable
+	end
+
+	if type(self._observable) == "function" then
+		local result = self._observable()
+
+		assert(Observable.isObservable(result), "Result should be observable")
+
+		return result
+	else
+		error("Could not convert self._observable to observable")
+	end
 end
 
 function RxSignal:Once(callback)
-	return self._observable:Pipe({
+	return self:_getObservable():Pipe({
 		Rx.take(1);
 	}):Subscribe(callback)
 end