@quenty/rx 8.0.0 → 8.1.0

package/CHANGELOG.md

@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [8.1.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/rx@8.0.0...@quenty/rx@8.1.0) (2023-10-18)
+
+**Note:** Version bump only for package @quenty/rx
+
+
+
+
+
 # [8.0.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/rx@7.16.0...@quenty/rx@8.0.0) (2023-10-11)
 
 **Note:** Version bump only for package @quenty/rx

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/rx",
-  "version": "8.0.0",
+  "version": "8.1.0",
   "description": "Quenty's reactive library for Roblox",
   "keywords": [
     "Roblox",
@@ -40,5 +40,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "fdeae46099587019ec5fc15317dc673aed379400"
+  "gitHead": "ad451bee2ee34d9cad70ff72d0af360db1f91a34"
 }

package/src/Shared/ObservablePerformance.story.lua

@@ -0,0 +1,30 @@
+--[[
+	@class ObservablePerformance.story
+]]
+
+local require = require(game:GetService("ServerScriptService"):FindFirstChild("LoaderUtils", true).Parent).load(script)
+
+local Observable = require("Observable")
+
+return function(_target)
+
+	local startTime = tick()
+
+	for _=1, 1000000 do
+		local observable = Observable.new(function(sub)
+			sub:Fire()
+		end)
+
+		local sub = observable:Subscribe(function()
+			-- nooopt
+		end)
+
+		sub:Destroy()
+	end
+
+	print((tick() - startTime) * 1000 .. " ms for 1,000,000")
+
+	return function()
+
+	end
+end

package/src/Shared/Rx.lua

@@ -1392,18 +1392,20 @@ end
 function Rx.combineLatest(observables)
 	assert(type(observables) == "table", "Bad observables")
 
-	return Observable.new(function(sub)
-		local pending = 0
-
-		local latest = {}
-		for key, value in pairs(observables) do
-			if Observable.isObservable(value) then
-				pending = pending + 1
-				latest[key] = UNSET_VALUE
-			else
-				latest[key] = value
-			end
+	local initialPending = 0
+	local defaultLatest = {}
+	for key, value in pairs(observables) do
+		if Observable.isObservable(value) then
+			initialPending = initialPending + 1
+			defaultLatest[key] = UNSET_VALUE
+		else
+			defaultLatest[key] = value
 		end
+	end
+
+	return Observable.new(function(sub)
+		local pending = initialPending
+		local latest = table.clone(defaultLatest)
 
 		if pending == 0 then
 			sub:Fire(latest)

package/src/Shared/Subscription.lua

@@ -37,10 +37,9 @@ local stateTypes = {
 	@param fireCallback function?
 	@param failCallback function?
 	@param completeCallback function?
-	@param onSubscribe () -> MaidTask
 	@return Subscription
 ]=]
-function Subscription.new(fireCallback, failCallback, completeCallback, onSubscribe)
+function Subscription.new(fireCallback, failCallback, completeCallback)
 	assert(type(fireCallback) == "function" or fireCallback == nil, "Bad fireCallback")
 	assert(type(failCallback) == "function" or failCallback == nil, "Bad failCallback")
 	assert(type(completeCallback) == "function" or completeCallback == nil, "Bad completeCallback")
@@ -51,7 +50,6 @@ function Subscription.new(fireCallback, failCallback, completeCallback, onSubscr
 		_fireCallback = fireCallback;
 		_failCallback = failCallback;
 		_completeCallback = completeCallback;
-		_onSubscribe = onSubscribe;
 	}, Subscription)
 end