@quenty/rogue-properties 4.23.0 → 4.24.0

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [4.24.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/rogue-properties@4.23.0...@quenty/rogue-properties@4.24.0) (2023-07-15)
+
+
+### Features
+
+* Add support for setting values in RoguePropertyValue ([df5cdc4](https://github.com/Quenty/NevermoreEngine/commit/df5cdc42d57756cf269fb887113a28e9feb50095))
+
+
+
+
+
 # [4.23.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/rogue-properties@4.22.2...@quenty/rogue-properties@4.23.0) (2023-07-10)
 
 **Note:** Version bump only for package @quenty/rogue-properties

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/rogue-properties",
-  "version": "4.23.0",
+  "version": "4.24.0",
   "description": "Roguelike properties which can be modified by external provides",
   "keywords": [
     "Roblox",
@@ -25,24 +25,24 @@
   ],
   "dependencies": {
     "@quenty/baseobject": "^6.2.1",
-    "@quenty/binder": "^8.20.0",
-    "@quenty/brio": "^8.14.0",
-    "@quenty/instanceutils": "^7.16.0",
+    "@quenty/binder": "^8.21.0",
+    "@quenty/brio": "^8.15.0",
+    "@quenty/instanceutils": "^7.17.0",
     "@quenty/jsonutils": "^6.6.0",
-    "@quenty/linkutils": "^7.16.0",
+    "@quenty/linkutils": "^7.17.0",
     "@quenty/loader": "^6.2.1",
     "@quenty/maid": "^2.5.0",
-    "@quenty/rx": "^7.12.0",
-    "@quenty/rxbinderutils": "^8.21.0",
+    "@quenty/rx": "^7.13.0",
+    "@quenty/rxbinderutils": "^8.22.0",
     "@quenty/servicebag": "^6.8.0",
     "@quenty/signal": "^2.4.0",
     "@quenty/table": "^3.2.0",
-    "@quenty/valuebaseutils": "^7.16.0",
-    "@quenty/valueobject": "^7.17.0",
+    "@quenty/valuebaseutils": "^7.17.0",
+    "@quenty/valueobject": "^7.18.0",
     "@quentystudios/t": "^3.0.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "6c9093879c4547ca55a7b42842e35ad277cc0f08"
+  "gitHead": "af7a623f58fe7ec96b47c80e385b71f820fd4cb8"
 }

package/src/Shared/Modifiers/Additive/RogueAdditiveProvider.lua

@@ -53,6 +53,20 @@ function RogueAdditiveProvider:Create(additive, source)
 	return obj
 end
 
+function RogueAdditiveProvider:GetInvertedVersion(propObj, rogueProperty, baseValue)
+	if rogueProperty:GetDefinition():GetValueType() == "number" then
+		local value = baseValue
+
+		for _, item in pairs(self:_getAdditives(propObj)) do
+			value = value - item:GetAdditive()
+		end
+
+		return value
+	else
+		return baseValue
+	end
+end
+
 function RogueAdditiveProvider:GetModifiedVersion(propObj, rogueProperty, baseValue)
 	if rogueProperty:GetDefinition():GetValueType() == "number" then
 		local value = baseValue

package/src/Shared/Modifiers/Multiplier/RogueMultiplierProvider.lua

@@ -53,6 +53,20 @@ function RogueMultiplierProvider:Create(multiplier, source)
 	return obj
 end
 
+function RogueMultiplierProvider:GetInvertedVersion(propObj, rogueProperty, baseValue)
+	if rogueProperty:GetDefinition():GetValueType() == "number" then
+		local multiplier = 1
+
+		for _, item in pairs(self:_getMultipliers(propObj)) do
+			multiplier = multiplier*item:GetMultiplier()
+		end
+
+		return baseValue/multiplier
+	else
+		return baseValue
+	end
+end
+
 function RogueMultiplierProvider:GetModifiedVersion(propObj, rogueProperty, baseValue)
 	if rogueProperty:GetDefinition():GetValueType() == "number" then
 		local multiplier = 1

package/src/Shared/Modifiers/Setter/RogueSetterProvider.lua

@@ -47,6 +47,11 @@ function RogueSetterProvider:Create(value, source)
 	return obj
 end
 
+function RogueSetterProvider:GetInvertedVersion(_propObj, _rogueProperty, baseValue)
+	-- TODO: discard previous value chain
+	return baseValue
+end
+
 function RogueSetterProvider:GetModifiedVersion(propObj, rogueProperty, baseValue)
 	-- TODO: Support more than just the base value type
 	if rogueProperty:GetDefinition():GetValueType() == "number" then

package/src/Shared/Property/RogueProperty.lua

@@ -25,7 +25,7 @@ RogueProperty.ClassName = "RogueProperty"
 RogueProperty.__index = RogueProperty
 
 function RogueProperty.new(adornee, serviceBag, definition)
-	local self = setmetatable({}, RogueProperty)
+	local self = {}
 
 	self._serviceBag = assert(serviceBag, "No serviceBag")
 	self._roguePropertyBinderGroups = self._serviceBag:GetService(RoguePropertyBinderGroups)
@@ -34,6 +34,8 @@ function RogueProperty.new(adornee, serviceBag, definition)
 	self._adornee = assert(adornee, "Bad adornee")
 	self._definition = assert(definition, "Bad definition")
 
+	self = setmetatable(self, RogueProperty)
+
 	if self._roguePropertyService:CanInitializeProperties() then
 		self:GetBaseValueObject()
 	end
@@ -91,6 +93,22 @@ function RogueProperty:SetBaseValue(value)
 	end
 end
 
+function RogueProperty:SetValue(value)
+	local baseValue = self:GetBaseValueObject()
+	if not baseValue then
+		warn("Failed to get the baseValue to parent")
+		return
+	end
+
+	local current = value
+	-- TODO: Consider applying inverted chain here
+	for _, item in pairs(self._roguePropertyService:GetProviders()) do
+		current = item:GetInvertedVersion(baseValue, self, current)
+	end
+
+	baseValue.Value = self:_encodeValue(current)
+end
+
 function RogueProperty:GetBaseValue()
 	local baseValue = self:GetBaseValueObject()
 	if baseValue then
@@ -100,7 +118,6 @@ function RogueProperty:GetBaseValue()
 	end
 end
 
-
 function RogueProperty:GetValue()
 	local propObj = self:GetBaseValueObject()
 	if not propObj then
@@ -239,6 +256,19 @@ function RogueProperty:__index(index)
 	end
 end
 
+function RogueProperty:__newindex(index, value)
+	if index == "Value" then
+		self:SetValue(value)
+	elseif index == "Changed" then
+		error("Cannot set .Changed event")
+	elseif RogueProperty[index] then
+		return RogueProperty[index]
+	else
+		error(("Bad index %q"):format(tostring(index)))
+	end
+end
+
+
 function RogueProperty:_decodeValue(current)
 	return RoguePropertyUtils.decodeProperty(self._definition, current)
 end