@quenty/rogue-properties 2.2.0 → 2.3.0

package/CHANGELOG.md

@@ -3,6 +3,22 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [2.3.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/rogue-properties@2.2.0...@quenty/rogue-properties@2.3.0) (2022-07-31)
+
+
+### Bug Fixes
+
+* RogueProperties work in test mode ([e68b0e8](https://github.com/Quenty/NevermoreEngine/commit/e68b0e8fd883a2bdbd638d94656e35ecea6870e9))
+
+
+### Features
+
+* RogueProperty has GetBaseValueObject API ([424d3d6](https://github.com/Quenty/NevermoreEngine/commit/424d3d6fb032ae7f50199e9da0536266d2a56bb4))
+
+
+
+
+
 # [2.2.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/rogue-properties@2.1.0...@quenty/rogue-properties@2.2.0) (2022-07-02)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/rogue-properties",
-  "version": "2.2.0",
+  "version": "2.3.0",
   "description": "Roguelike properties which can be modified by external provides",
   "keywords": [
     "Roblox",
@@ -24,24 +24,24 @@
     "Quenty"
   ],
   "dependencies": {
-    "@quenty/baseobject": "^5.0.0",
-    "@quenty/binder": "^6.2.0",
-    "@quenty/brio": "^6.1.0",
-    "@quenty/instanceutils": "^5.1.0",
-    "@quenty/jsonutils": "^5.0.0",
-    "@quenty/linkutils": "^5.1.0",
+    "@quenty/baseobject": "^5.1.0",
+    "@quenty/binder": "^6.3.0",
+    "@quenty/brio": "^6.2.0",
+    "@quenty/instanceutils": "^5.2.0",
+    "@quenty/jsonutils": "^5.1.0",
+    "@quenty/linkutils": "^5.2.0",
     "@quenty/loader": "^5.0.0",
-    "@quenty/maid": "^2.3.0",
-    "@quenty/rx": "^5.1.0",
-    "@quenty/rxbinderutils": "^6.2.0",
-    "@quenty/servicebag": "^5.0.0",
+    "@quenty/maid": "^2.4.0",
+    "@quenty/rx": "^5.2.0",
+    "@quenty/rxbinderutils": "^6.3.0",
+    "@quenty/servicebag": "^5.1.0",
     "@quenty/signal": "^2.2.0",
     "@quenty/table": "^3.1.0",
-    "@quenty/valuebaseutils": "^5.1.0",
+    "@quenty/valuebaseutils": "^5.2.0",
     "@quentystudios/t": "^1.2.5"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "de33c83e7f897e2b0887c77aeb1fc7963756f234"
+  "gitHead": "e31b3a35aa475bb5699a24898a8639e107165b36"
 }

package/src/Shared/Modifiers/RoguePropertyModifierUtils.lua

@@ -18,4 +18,8 @@ function RoguePropertyModifierUtils.observeSourceLinksBrio(modifier)
 	return RxLinkUtils.observeValidLinksBrio(RoguePropertyModifierConstants.PROPERTY_SOURCE_LINK_NAME, modifier)
 end
 
+function RoguePropertyModifierUtils.getSourceFromModifier(modifier)
+	return LinkUtils.getLinkValue(RoguePropertyModifierConstants.PROPERTY_SOURCE_LINK_NAME, modifier)
+end
+
 return RoguePropertyModifierUtils

package/src/Shared/Property/RogueProperty.lua

@@ -33,13 +33,13 @@ function RogueProperty.new(adornee, serviceBag, definition)
 	self._definition = assert(definition, "Bad definition")
 
 	if self._roguePropertyService:CanInitializeProperties() then
-		self:_getBaseValueObject()
+		self:GetBaseValueObject()
 	end
 
 	return self
 end
 
-function RogueProperty:_getBaseValueObject()
+function RogueProperty:GetBaseValueObject()
 	local parent
 	local tableDefinition = self._definition:GetPropertyTableDefinition()
 	if tableDefinition then
@@ -81,7 +81,7 @@ function RogueProperty:_observeBaseValueBrio()
 end
 
 function RogueProperty:SetBaseValue(value)
-	local baseValue = self:_getBaseValueObject()
+	local baseValue = self:GetBaseValueObject()
 	if baseValue then
 		baseValue.Value = self:_encodeValue(value)
 	else
@@ -90,7 +90,7 @@ function RogueProperty:SetBaseValue(value)
 end
 
 function RogueProperty:GetBaseValue()
-	local baseValue = self:_getBaseValueObject()
+	local baseValue = self:GetBaseValueObject()
 	if baseValue then
 		return self:_decodeValue(baseValue.Value)
 	else
@@ -100,7 +100,7 @@ end
 
 
 function RogueProperty:GetValue()
-	local propObj = self:_getBaseValueObject()
+	local propObj = self:GetBaseValueObject()
 	if not propObj then
 		return self._definition:GetDefaultValue()
 	end
@@ -169,6 +169,7 @@ function RogueProperty:Observe()
 			return current
 		end);
 		RxBrioUtils.emitOnDeath(self._definition:GetDefaultValue());
+		Rx.defaultsTo(self._definition:GetDefaultValue());
 	})
 end
 
@@ -176,7 +177,7 @@ function RogueProperty:CreateMultiplier(amount, source)
 	assert(type(amount) == "number", "Bad amount")
 
 	local provider = self._serviceBag:GetService(RogueMultiplierProvider)
-	local baseValue = self:_getBaseValueObject()
+	local baseValue = self:GetBaseValueObject()
 
 	if not baseValue then
 		warn("Failed to get the baseValue to parent")
@@ -192,7 +193,7 @@ function RogueProperty:CreateAdditive(amount, source)
 	assert(type(amount) == "number", "Bad amount")
 
 	local provider = self._serviceBag:GetService(RogueAdditiveProvider)
-	local baseValue = self:_getBaseValueObject()
+	local baseValue = self:GetBaseValueObject()
 
 	if not baseValue then
 		warn("Failed to get the baseValue to parent")
@@ -208,7 +209,7 @@ function RogueProperty:CreateSetter(amount, source)
 	assert(type(amount) == "number", "Bad amount")
 
 	local provider = self._serviceBag:GetService(RogueSetterProvider)
-	local baseValue = self:_getBaseValueObject()
+	local baseValue = self:GetBaseValueObject()
 
 	if not baseValue then
 		warn("Failed to get the baseValue to parent")

package/src/Shared/RoguePropertyService.lua

@@ -42,10 +42,20 @@ function RoguePropertyService:AddProvider(provider)
 end
 
 function RoguePropertyService:GetProviders()
+	if not RunService:IsRunning() then
+		return {}
+	end
+
 	return self._providers
 end
 
 function RoguePropertyService:ObserveProviderList()
+	if not RunService:IsRunning() then
+		return Observable.new(function(sub)
+			sub:Fire({})
+		end)
+	end
+
 	return Observable.new(function(sub)
 		local maid = Maid.new()
 

package/src/Shared/Table/RoguePropertyTable.lua

@@ -2,8 +2,6 @@
 	@class RoguePropertyTable
 ]=]
 
-local require = require(script.Parent.loader).load(script)
-
 local RunService = game:GetService("RunService")
 
 local RoguePropertyTable = {}