@quenty/rogue-properties 11.22.3 → 11.22.4-canary.559.339cfa7.0

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [11.22.4-canary.559.339cfa7.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/rogue-properties@11.22.3...@quenty/rogue-properties@11.22.4-canary.559.339cfa7.0) (2025-05-10)
+
+
+### Bug Fixes
+
+* Additional type checking updates ([05ba29a](https://github.com/Quenty/NevermoreEngine/commit/05ba29a03efc9f3feed74b34f1d9dfb237496214))
+
+
+
+
+
 ## [11.22.3](https://github.com/Quenty/NevermoreEngine/compare/@quenty/rogue-properties@11.22.2...@quenty/rogue-properties@11.22.3) (2025-04-10)
 
 **Note:** Version bump only for package @quenty/rogue-properties

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/rogue-properties",
-  "version": "11.22.3",
+  "version": "11.22.4-canary.559.339cfa7.0",
   "description": "Roguelike properties which can be modified by external provides",
   "keywords": [
     "Roblox",
@@ -24,33 +24,33 @@
     "Quenty"
   ],
   "dependencies": {
-    "@quenty/adorneedata": "^7.18.3",
-    "@quenty/baseobject": "^10.8.3",
-    "@quenty/binder": "^14.19.3",
-    "@quenty/brio": "^14.17.3",
-    "@quenty/defaultvalueutils": "^1.2.2",
-    "@quenty/ducktype": "^5.8.4",
-    "@quenty/instanceutils": "^13.17.3",
-    "@quenty/jsonutils": "^10.10.4",
-    "@quenty/linkutils": "^13.17.3",
-    "@quenty/loader": "^10.8.3",
-    "@quenty/maid": "^3.4.3",
-    "@quenty/observablecollection": "^12.20.3",
-    "@quenty/rx": "^13.17.3",
-    "@quenty/rxbinderutils": "^14.19.3",
-    "@quenty/rxsignal": "^7.17.3",
-    "@quenty/servicebag": "^11.11.4",
-    "@quenty/signal": "^7.10.3",
-    "@quenty/spring": "^10.8.4",
-    "@quenty/string": "^3.3.3",
-    "@quenty/table": "^3.7.4",
-    "@quenty/tie": "^10.20.3",
-    "@quenty/valuebaseutils": "^13.17.3",
-    "@quenty/valueobject": "^13.17.3",
+    "@quenty/adorneedata": "7.18.4-canary.559.339cfa7.0",
+    "@quenty/baseobject": "10.8.4-canary.559.339cfa7.0",
+    "@quenty/binder": "14.19.4-canary.559.339cfa7.0",
+    "@quenty/brio": "14.17.4-canary.559.339cfa7.0",
+    "@quenty/defaultvalueutils": "1.2.2",
+    "@quenty/ducktype": "5.8.5-canary.559.339cfa7.0",
+    "@quenty/instanceutils": "13.17.4-canary.559.339cfa7.0",
+    "@quenty/jsonutils": "10.10.5-canary.559.339cfa7.0",
+    "@quenty/linkutils": "13.17.4-canary.559.339cfa7.0",
+    "@quenty/loader": "10.8.4-canary.559.339cfa7.0",
+    "@quenty/maid": "3.4.4-canary.559.339cfa7.0",
+    "@quenty/observablecollection": "12.20.4-canary.559.339cfa7.0",
+    "@quenty/rx": "13.17.4-canary.559.339cfa7.0",
+    "@quenty/rxbinderutils": "14.19.4-canary.559.339cfa7.0",
+    "@quenty/rxsignal": "7.17.4-canary.559.339cfa7.0",
+    "@quenty/servicebag": "11.11.5-canary.559.339cfa7.0",
+    "@quenty/signal": "7.10.4-canary.559.339cfa7.0",
+    "@quenty/spring": "10.8.5-canary.559.339cfa7.0",
+    "@quenty/string": "3.3.3",
+    "@quenty/table": "3.7.5-canary.559.339cfa7.0",
+    "@quenty/tie": "10.20.4-canary.559.339cfa7.0",
+    "@quenty/valuebaseutils": "13.17.4-canary.559.339cfa7.0",
+    "@quenty/valueobject": "13.17.4-canary.559.339cfa7.0",
     "@quentystudios/t": "^3.0.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "b06c070ae91d5dab7bd8de6e290ad2caabb15d8f"
+  "gitHead": "339cfa778736f08768ed7305041f6221faa35bfc"
 }

package/src/Shared/Array/RoguePropertyArrayConstants.lua

@@ -7,5 +7,5 @@ local require = require(script.Parent.loader).load(script)
 local Table = require("Table")
 
 return Table.readonly({
-	ARRAY_ENTRY_PERFIX = "ArrayEntry_";
-})
+	ARRAY_ENTRY_PERFIX = "ArrayEntry_",
+})

package/src/Shared/Array/RoguePropertyArrayUtils.lua

@@ -4,9 +4,9 @@
 
 local require = require(script.Parent.loader).load(script)
 
+local DefaultValueUtils = require("DefaultValueUtils")
 local RoguePropertyArrayConstants = require("RoguePropertyArrayConstants")
 local String = require("String")
-local DefaultValueUtils = require("DefaultValueUtils")
 
 local RoguePropertyArrayUtils = {}
 
@@ -160,4 +160,4 @@ function RoguePropertyArrayUtils.createDefinitionsFromArrayData(arrayData, prope
 	return definitions
 end
 
-return RoguePropertyArrayUtils
+return RoguePropertyArrayUtils

package/src/Shared/Cache/RoguePropertyCache.lua

@@ -4,7 +4,6 @@
 	@class RoguePropertyCache
 ]=]
 
-
 local RoguePropertyCache = {}
 RoguePropertyCache.ClassName = "RoguePropertyCache"
 RoguePropertyCache.__index = RoguePropertyCache

package/src/Shared/Cache/RoguePropertyCacheService.lua

@@ -9,16 +9,16 @@ local require = require(script.Parent.loader).load(script)
 local RunService = game:GetService("RunService")
 
 local RoguePropertyCache = require("RoguePropertyCache")
-local _ServiceBag = require("ServiceBag")
+local ServiceBag = require("ServiceBag")
 
 local RoguePropertyCacheService = {}
 RoguePropertyCacheService.ServiceName = "RoguePropertyCacheService"
 
-function RoguePropertyCacheService:Init(serviceBag: _ServiceBag.ServiceBag)
+function RoguePropertyCacheService:Init(serviceBag: ServiceBag.ServiceBag)
 	assert(not self._serviceBag, "Already initialized")
 	self._serviceBag = assert(serviceBag, "No serviceBag")
 
-	self._cache = setmetatable({}, {__mode = "k"})
+	self._cache = setmetatable({}, { __mode = "k" })
 end
 
 function RoguePropertyCacheService:GetCache(roguePropertyDefinition)
@@ -37,4 +37,4 @@ function RoguePropertyCacheService:GetCache(roguePropertyDefinition)
 	return cache
 end
 
-return RoguePropertyCacheService
+return RoguePropertyCacheService

package/src/Shared/Definition/RoguePropertyDefinition.lua

@@ -4,12 +4,12 @@
 
 local require = require(script.Parent.loader).load(script)
 
+local DuckTypeUtils = require("DuckTypeUtils")
 local RogueProperty = require("RogueProperty")
-local ServiceBag = require("ServiceBag")
+local RoguePropertyCacheService = require("RoguePropertyCacheService")
 local RoguePropertyUtils = require("RoguePropertyUtils")
-local DuckTypeUtils = require("DuckTypeUtils")
+local ServiceBag = require("ServiceBag")
 local ValueBaseUtils = require("ValueBaseUtils")
-local RoguePropertyCacheService = require("RoguePropertyCacheService")
 
 local RoguePropertyDefinition = {}
 RoguePropertyDefinition.ClassName = "RoguePropertyDefinition"
@@ -41,7 +41,7 @@ end
 	@param adornee Instance
 	@return RogueProperty
 ]=]
-function RoguePropertyDefinition:Get(serviceBag, adornee)
+function RoguePropertyDefinition:Get(serviceBag: ServiceBag.ServiceBag, adornee: Instance)
 	assert(ServiceBag.isServiceBag(serviceBag), "Bad serviceBag")
 	assert(typeof(adornee) == "Instance", "Bad adornee")
 
@@ -58,14 +58,15 @@ function RoguePropertyDefinition:Get(serviceBag, adornee)
 	return rogueProperty
 end
 
-function RoguePropertyDefinition:GetOrCreateInstance(parent)
+function RoguePropertyDefinition:GetOrCreateInstance(parent: Instance)
 	assert(typeof(parent) == "Instance", "Bad parent")
 
 	return ValueBaseUtils.getOrCreateValue(
 		parent,
 		self:GetStorageInstanceType(),
 		self:GetName(),
-		self:GetEncodedDefaultValue())
+		self:GetEncodedDefaultValue()
+	)
 end
 
 function RoguePropertyDefinition:SetParentPropertyTableDefinition(parentPropertyTableDefinition)
@@ -76,15 +77,21 @@ function RoguePropertyDefinition:GetParentPropertyDefinition()
 	return self._parentPropertyTableDefinition
 end
 
-function RoguePropertyDefinition:CanAssign(value, _strict)
+function RoguePropertyDefinition:CanAssign(value, _strict): (boolean, string?)
 	if self._valueType == typeof(value) then
 		return true
 	else
-		return false, string.format("got %q, expected %q when assigning to %q", self._valueType, typeof(value), self:GetFullName())
+		return false,
+			string.format(
+				"got %q, expected %q when assigning to %q",
+				self._valueType,
+				typeof(value),
+				self:GetFullName()
+			)
 	end
 end
 
-function RoguePropertyDefinition:SetName(name: string)
+function RoguePropertyDefinition:SetName(name: string): ()
 	assert(type(name) == "string", "Bad name")
 
 	self._name = name
@@ -122,7 +129,7 @@ function RoguePropertyDefinition:GetValueType()
 	return self._valueType
 end
 
-function RoguePropertyDefinition:GetStorageInstanceType()
+function RoguePropertyDefinition:GetStorageInstanceType(): string
 	return self._storageType
 end
 
@@ -152,5 +159,4 @@ function RoguePropertyDefinition:_computeStorageInstanceType()
 	end
 end
 
-
-return RoguePropertyDefinition
+return RoguePropertyDefinition

package/src/Shared/Definition/RoguePropertyDefinitionArrayHelper.lua

@@ -75,4 +75,4 @@ function RoguePropertyDefinitionArrayHelper:CanAssignAsArrayMember(value, strict
 	return self._requiredPropertyDefinition:CanAssign(value, strict)
 end
 
-return RoguePropertyDefinitionArrayHelper
+return RoguePropertyDefinitionArrayHelper

package/src/Shared/Definition/RoguePropertyTableDefinition.lua

@@ -16,13 +16,13 @@ local RxBrioUtils = require("RxBrioUtils")
 local RxInstanceUtils = require("RxInstanceUtils")
 local ServiceBag = require("ServiceBag")
 local Set = require("Set")
-local _Table = require("Table")
+local Table = require("Table")
 
 local RoguePropertyTableDefinition = {} -- Inherits from RoguePropertyDefinition
 RoguePropertyTableDefinition.ClassName = "RoguePropertyTableDefinition"
 RoguePropertyTableDefinition.__index = RoguePropertyTableDefinition
 
-function RoguePropertyTableDefinition.new(tableName: string?, defaultValueTable: _Table.Map<string, any>?)
+function RoguePropertyTableDefinition.new(tableName: string?, defaultValueTable: Table.Map<string, any>?)
 	local self = setmetatable(RoguePropertyDefinition.new(), RoguePropertyTableDefinition)
 
 	if tableName then
@@ -40,7 +40,7 @@ function RoguePropertyTableDefinition.isRoguePropertyTableDefinition(value): boo
 	return DuckTypeUtils.isImplementation(RoguePropertyTableDefinition, value)
 end
 
-function RoguePropertyTableDefinition:SetDefaultValue(defaultValueTable: _Table.Map<string, any>?)
+function RoguePropertyTableDefinition:SetDefaultValue(defaultValueTable: Table.Map<string, any>?)
 	assert(type(defaultValueTable) == "table", "Bad defaultValueTable")
 
 	RoguePropertyDefinition.SetDefaultValue(self, defaultValueTable)
@@ -196,7 +196,7 @@ end
 	@param adornee Instance
 	@return RoguePropertyTable
 ]=]
-function RoguePropertyTableDefinition:Get(serviceBag, adornee: Instance)
+function RoguePropertyTableDefinition:Get(serviceBag: ServiceBag.ServiceBag, adornee: Instance)
 	assert(ServiceBag.isServiceBag(serviceBag), "Bad serviceBag")
 	assert(typeof(adornee) == "Instance", "Bad adornee")
 

package/src/Shared/Implementation/RogueProperty.lua

@@ -4,6 +4,9 @@
 
 local require = require(script.Parent.loader).load(script)
 
+local Maid = require("Maid")
+local Observable = require("Observable")
+local ObservableSortedList = require("ObservableSortedList")
 local RogueAdditive = require("RogueAdditive")
 local RogueModifierInterface = require("RogueModifierInterface")
 local RogueMultiplier = require("RogueMultiplier")
@@ -14,16 +17,14 @@ local Rx = require("Rx")
 local RxBrioUtils = require("RxBrioUtils")
 local RxInstanceUtils = require("RxInstanceUtils")
 local RxSignal = require("RxSignal")
+local ServiceBag = require("ServiceBag")
 local ValueBaseUtils = require("ValueBaseUtils")
-local Maid = require("Maid")
-local Observable = require("Observable")
-local ObservableSortedList = require("ObservableSortedList")
 
 local RogueProperty = {}
 RogueProperty.ClassName = "RogueProperty"
 RogueProperty.__index = RogueProperty
 
-function RogueProperty.new(adornee, serviceBag, definition)
+function RogueProperty.new(adornee: Instance, serviceBag: ServiceBag.ServiceBag, definition)
 	local self = {}
 
 	self._serviceBag = assert(serviceBag, "No serviceBag")
@@ -93,17 +94,21 @@ end
 function RogueProperty:_observeBaseValueBrio()
 	local parentDefinition = self._definition:GetParentPropertyDefinition()
 	if parentDefinition then
-		return parentDefinition:ObserveContainerBrio(self._adornee, self:CanInitialize())
-			:Pipe({
-				RxBrioUtils.switchMapBrio(function(container)
-					return RxInstanceUtils.observeLastNamedChildBrio(
-						container,
-						self._definition:GetStorageInstanceType(),
-						self._definition:GetName())
-				end);
-			})
+		return parentDefinition:ObserveContainerBrio(self._adornee, self:CanInitialize()):Pipe({
+			RxBrioUtils.switchMapBrio(function(container)
+				return RxInstanceUtils.observeLastNamedChildBrio(
+					container,
+					self._definition:GetStorageInstanceType(),
+					self._definition:GetName()
+				)
+			end),
+		})
 	else
-		return RxInstanceUtils.observeLastNamedChildBrio(self._adornee, self._definition:GetStorageInstanceType(), self._definition:GetName())
+		return RxInstanceUtils.observeLastNamedChildBrio(
+			self._adornee,
+			self._definition:GetStorageInstanceType(),
+			self._definition:GetName()
+		)
 	end
 end
 
@@ -114,7 +119,13 @@ function RogueProperty:SetBaseValue(value)
 	if baseValue then
 		baseValue.Value = self:_encodeValue(value)
 	else
-		warn(string.format("[RogueProperty.SetBaseValue] - Failed to get the baseValue for %q on %q", self._definition:GetFullName(), self._adornee:GetFullName()))
+		warn(
+			string.format(
+				"[RogueProperty.SetBaseValue] - Failed to get the baseValue for %q on %q",
+				self._definition:GetFullName(),
+				self._adornee:GetFullName()
+			)
+		)
 	end
 end
 
@@ -123,14 +134,20 @@ function RogueProperty:SetValue(value)
 
 	local baseValue = self:GetBaseValueObject()
 	if not baseValue then
-		warn(string.format("[RogueProperty.SetValue] - Failed to get the baseValue for %q on %q", self._definition:GetFullName(), self._adornee:GetFullName()))
+		warn(
+			string.format(
+				"[RogueProperty.SetValue] - Failed to get the baseValue for %q on %q",
+				self._definition:GetFullName(),
+				self._adornee:GetFullName()
+			)
+		)
 		return
 	end
 
 	local current = value
 
 	local modifiers = self:GetRogueModifiers()
-	for i=#modifiers, 1, -1 do
+	for i = #modifiers, 1, -1 do
 		current = modifiers[i]:GetInvertedVersion(current, value)
 	end
 
@@ -224,21 +241,21 @@ function RogueProperty:Observe()
 
 	return self:_observeModifierSortedList():Pipe({
 		Rx.switchMap(function(sortedList)
-		return sortedList:Observe()
-		end);
+			return sortedList:Observe()
+		end),
 		Rx.switchMap(function(rogueModifierList)
-		local current = observeInitialValue
+			local current = observeInitialValue
 			for _, rogueModifier in rogueModifierList do
 				current = rogueModifier:ObserveModifiedVersion(current)
 			end
 			return current
-		end);
+		end),
 	})
 end
 
 function RogueProperty:ObserveBrio(predicate)
 	return self:Observe():Pipe({
-		RxBrioUtils.switchToBrio(predicate)
+		RxBrioUtils.switchToBrio(predicate),
 	})
 end
 
@@ -247,7 +264,13 @@ function RogueProperty:CreateMultiplier(amount, source)
 
 	local baseValue = self:GetBaseValueObject()
 	if not baseValue then
-		warn(string.format("[RogueProperty.CreateMultiplier] - Failed to get the baseValue for %q on %q", self._definition:GetFullName(), self._adornee:GetFullName()))
+		warn(
+			string.format(
+				"[RogueProperty.CreateMultiplier] - Failed to get the baseValue for %q on %q",
+				self._definition:GetFullName(),
+				self._adornee:GetFullName()
+			)
+		)
 	end
 
 	local className = ValueBaseUtils.getClassNameFromType(typeof(amount))
@@ -276,7 +299,13 @@ function RogueProperty:CreateAdditive(amount: number, source)
 
 	local baseValue = self:GetBaseValueObject()
 	if not baseValue then
-		warn(string.format("[RogueProperty.CreateAdditive] - Failed to get the baseValue for %q on %q", self._definition:GetFullName(), self._adornee:GetFullName()))
+		warn(
+			string.format(
+				"[RogueProperty.CreateAdditive] - Failed to get the baseValue for %q on %q",
+				self._definition:GetFullName(),
+				self._adornee:GetFullName()
+			)
+		)
 		return nil
 	end
 
@@ -304,7 +333,13 @@ end
 function RogueProperty:GetNamedAdditive(name, source)
 	local baseValue = self:GetBaseValueObject()
 	if not baseValue then
-		warn(string.format("[RogueProperty.GetNamedAdditive] - Failed to get the baseValue for %q on %q", self._definition:GetFullName(), self._adornee:GetFullName()))
+		warn(
+			string.format(
+				"[RogueProperty.GetNamedAdditive] - Failed to get the baseValue for %q on %q",
+				self._definition:GetFullName(),
+				self._adornee:GetFullName()
+			)
+		)
 		return nil
 	end
 
@@ -323,7 +358,13 @@ end
 function RogueProperty:CreateSetter(value, source)
 	local baseValue = self:GetBaseValueObject()
 	if not baseValue then
-		warn(string.format("[RogueProperty.CreateSetter] - Failed to get the baseValue for %q on %q", self._definition:GetFullName(), self._adornee:GetFullName()))
+		warn(
+			string.format(
+				"[RogueProperty.CreateSetter] - Failed to get the baseValue for %q on %q",
+				self._definition:GetFullName(),
+				self._adornee:GetFullName()
+			)
+		)
 		return nil
 	end
 
@@ -382,8 +423,8 @@ end
 
 function RogueProperty:GetChangedEvent()
 	return RxSignal.new(self:Observe():Pipe({
-		Rx.skip(1)
+		Rx.skip(1),
 	}))
 end
 
-return RogueProperty
+return RogueProperty

package/src/Shared/Implementation/RoguePropertyArrayHelper.lua

@@ -61,8 +61,10 @@ function RoguePropertyArrayHelper:GetArrayRogueProperties()
 
 	local adornee = self._roguePropertyTable:GetAdornee()
 
-
-	local definitions = RoguePropertyArrayUtils.createDefinitionsFromContainer(container, self._arrayDefinitionHelper:GetPropertyTableDefinition())
+	local definitions = RoguePropertyArrayUtils.createDefinitionsFromContainer(
+		container,
+		self._arrayDefinitionHelper:GetPropertyTableDefinition()
+	)
 	local rogueProperties = {}
 
 	for index, definition in definitions do
@@ -198,4 +200,4 @@ function RoguePropertyArrayHelper:ObserveArrayValues()
 	return Rx.combineLatest(observables)
 end
 
-return RoguePropertyArrayHelper
+return RoguePropertyArrayHelper

package/src/Shared/Implementation/RoguePropertyTable.lua

@@ -5,14 +5,15 @@
 local require = require(script.Parent.loader).load(script)
 
 local RogueProperty = require("RogueProperty")
-local Rx = require("Rx")
 local RoguePropertyArrayHelper = require("RoguePropertyArrayHelper")
+local Rx = require("Rx")
+local ServiceBag = require("ServiceBag")
 
 local RoguePropertyTable = {} -- inherits from RogueProperty
 RoguePropertyTable.ClassName = "RoguePropertyTable"
 RoguePropertyTable.__index = RoguePropertyTable
 
-function RoguePropertyTable.new(adornee: Instance, serviceBag, roguePropertyTableDefinition)
+function RoguePropertyTable.new(adornee: Instance, serviceBag: ServiceBag.ServiceBag, roguePropertyTableDefinition)
 	local self = setmetatable(RogueProperty.new(adornee, serviceBag, roguePropertyTableDefinition), RoguePropertyTable)
 
 	rawset(self, "_properties", {})

package/src/Shared/Implementation/RoguePropertyUtils.lua

@@ -36,4 +36,4 @@ function RoguePropertyUtils.encodeProperty(definition, value)
 	end
 end
 
-return RoguePropertyUtils
+return RoguePropertyUtils

package/src/Shared/Modifiers/Implementations/RogueAdditive.lua

@@ -4,12 +4,12 @@
 
 local require = require(script.Parent.loader).load(script)
 
-local RogueModifierBase = require("RogueModifierBase")
-local RxInstanceUtils = require("RxInstanceUtils")
 local Binder = require("Binder")
-local Rx = require("Rx")
 local LinearValue = require("LinearValue")
+local RogueModifierBase = require("RogueModifierBase")
 local RogueModifierInterface = require("RogueModifierInterface")
+local Rx = require("Rx")
+local RxInstanceUtils = require("RxInstanceUtils")
 
 local RogueAdditive = setmetatable({}, RogueModifierBase)
 RogueAdditive.ClassName = "RogueAdditive"
@@ -39,8 +39,8 @@ end
 
 function RogueAdditive:ObserveModifiedVersion(inputValue)
 	return Rx.combineLatest({
-		inputValue = inputValue;
-		additive = RxInstanceUtils.observeProperty(self._obj, "Value");
+		inputValue = inputValue,
+		additive = RxInstanceUtils.observeProperty(self._obj, "Value"),
 	}):Pipe({
 		Rx.map(function(state)
 			if state.inputValue and type(state.inputValue) == type(state.additive) then
@@ -51,9 +51,9 @@ function RogueAdditive:ObserveModifiedVersion(inputValue)
 			else
 				return state.inputValue
 			end
-		end);
-		Rx.distinct();
+		end),
+		Rx.distinct(),
 	})
 end
 
-return Binder.new("RogueAdditive", RogueAdditive)
+return Binder.new("RogueAdditive", RogueAdditive)

package/src/Shared/Modifiers/Implementations/RogueModifierBase.lua

@@ -5,8 +5,8 @@
 local require = require(script.Parent.loader).load(script)
 
 local BaseObject = require("BaseObject")
-local TieRealmService = require("TieRealmService")
 local RoguePropertyModifierData = require("RoguePropertyModifierData")
+local TieRealmService = require("TieRealmService")
 
 local RogueModifierBase = setmetatable({}, BaseObject)
 RogueModifierBase.ClassName = "RogueModifierBase"
@@ -34,4 +34,4 @@ function RogueModifierBase:ObserveModifiedVersion(_value)
 	error("Not implemented")
 end
 
-return RogueModifierBase
+return RogueModifierBase

package/src/Shared/Modifiers/Implementations/RogueMultiplier.lua

@@ -4,12 +4,12 @@
 
 local require = require(script.Parent.loader).load(script)
 
-local RogueModifierBase = require("RogueModifierBase")
 local Binder = require("Binder")
-local Rx = require("Rx")
-local RxInstanceUtils = require("RxInstanceUtils")
 local LinearValue = require("LinearValue")
+local RogueModifierBase = require("RogueModifierBase")
 local RogueModifierInterface = require("RogueModifierInterface")
+local Rx = require("Rx")
+local RxInstanceUtils = require("RxInstanceUtils")
 
 local RogueMultiplier = setmetatable({}, RogueModifierBase)
 RogueMultiplier.ClassName = "RogueMultiplier"
@@ -39,8 +39,8 @@ end
 
 function RogueMultiplier:ObserveModifiedVersion(inputValue)
 	return Rx.combineLatest({
-		inputValue = inputValue;
-		multiplier = RxInstanceUtils.observeProperty(self._obj, "Value");
+		inputValue = inputValue,
+		multiplier = RxInstanceUtils.observeProperty(self._obj, "Value"),
 	}):Pipe({
 		Rx.map(function(state)
 			if state.inputValue and type(state.inputValue) == type(state.multiplier) then
@@ -51,9 +51,9 @@ function RogueMultiplier:ObserveModifiedVersion(inputValue)
 			else
 				return state.inputValue
 			end
-		end);
-		Rx.distinct();
+		end),
+		Rx.distinct(),
 	})
 end
 
-return Binder.new("RogueMultiplier", RogueMultiplier)
+return Binder.new("RogueMultiplier", RogueMultiplier)

package/src/Shared/Modifiers/Implementations/RogueSetter.lua

@@ -4,12 +4,12 @@
 
 local require = require(script.Parent.loader).load(script)
 
-local RogueModifierBase = require("RogueModifierBase")
 local Binder = require("Binder")
-local RxValueBaseUtils = require("RxValueBaseUtils")
+local RogueModifierBase = require("RogueModifierBase")
 local RogueModifierInterface = require("RogueModifierInterface")
+local RxValueBaseUtils = require("RxValueBaseUtils")
 
-local RogueSetter = setmetatable( {}, RogueModifierBase)
+local RogueSetter = setmetatable({}, RogueModifierBase)
 RogueSetter.ClassName = "RogueSetter"
 RogueSetter.__index = RogueSetter
 
@@ -33,4 +33,4 @@ function RogueSetter:GetInvertedVersion(_, initialValue)
 	return initialValue
 end
 
-return Binder.new("RogueSetter", RogueSetter)
+return Binder.new("RogueSetter", RogueSetter)

package/src/Shared/Modifiers/RogueModifierInterface.lua

@@ -7,11 +7,11 @@ local require = require(script.Parent.loader).load(script)
 local TieDefinition = require("TieDefinition")
 
 return TieDefinition.new("RogueModifier", {
-	Order = TieDefinition.Types.PROPERTY;
-	Source = TieDefinition.Types.PROPERTY;
+	Order = TieDefinition.Types.PROPERTY,
+	Source = TieDefinition.Types.PROPERTY,
 
 	--
-	GetModifiedVersion = TieDefinition.Types.METHOD;
-	ObserveModifiedVersion = TieDefinition.Types.METHOD;
-	GetInvertedVersion = TieDefinition.Types.METHOD;
-})
+	GetModifiedVersion = TieDefinition.Types.METHOD,
+	ObserveModifiedVersion = TieDefinition.Types.METHOD,
+	GetInvertedVersion = TieDefinition.Types.METHOD,
+})

package/src/Shared/Modifiers/RoguePropertyModifierData.lua

@@ -10,8 +10,8 @@ local ValueBaseValue = require("ValueBaseValue")
 local t = require("t")
 
 return AdorneeData.new({
-	Order = 0;
+	Order = 0,
 	RoguePropertySourceLink = AdorneeDataEntry.new(t.optional(t.Instance), function(adornee)
 		return ValueBaseValue.new(adornee, "ObjectValue", "RoguePropertySourceLink", nil)
-	end);
-})
+	end),
+})

package/src/Shared/RoguePropertyService.lua

@@ -10,12 +10,12 @@ local require = require(script.Parent.loader).load(script)
 local RunService = game:GetService("RunService")
 
 local Maid = require("Maid")
-local _ServiceBag = require("ServiceBag")
+local ServiceBag = require("ServiceBag")
 
 local RoguePropertyService = {}
 RoguePropertyService.ServiceName = "RoguePropertyService"
 
-function RoguePropertyService:Init(serviceBag: _ServiceBag.ServiceBag)
+function RoguePropertyService:Init(serviceBag: ServiceBag.ServiceBag)
 	assert(not self._serviceBag, "Already initialized")
 	self._serviceBag = assert(serviceBag, "No serviceBag")
 
@@ -39,4 +39,4 @@ function RoguePropertyService:Destroy()
 	self._maid:DoCleaning()
 end
 
-return RoguePropertyService
+return RoguePropertyService

package/test/scripts/Client/ClientMain.client.lua

@@ -7,4 +7,4 @@ local require = require(loader).bootstrapGame(loader.Parent)
 local serviceBag = require("ServiceBag").new()
 serviceBag:GetService(require("RoguePropertyService"))
 serviceBag:Init()
-serviceBag:Start()
+serviceBag:Start()

package/test/scripts/Server/ServerMain.server.lua

@@ -14,41 +14,41 @@ serviceBag:Start()
 local RoguePropertyTableDefinition = require("RoguePropertyTableDefinition")
 
 local propertyDefinition = RoguePropertyTableDefinition.new("CombatStats", {
-	Health = 100;
+	Health = 100,
 
 	Ultimate = {
-		AttackDamage = 30;
-		AbilityPower = 30;
+		AttackDamage = 30,
+		AbilityPower = 30,
 
 		Sequence = {
 			{
-				Name = "Ultimate 1";
-				AnimationId = "rbxassetid://1";
-			};
+				Name = "Ultimate 1",
+				AnimationId = "rbxassetid://1",
+			},
 			{
-				Name = "Ultimate 2";
-				AnimationId = "rbxassetid://2";
-			};
-		};
-	};
+				Name = "Ultimate 2",
+				AnimationId = "rbxassetid://2",
+			},
+		},
+	},
 
 	HeavyPunch = {
-		AttackDamage = 45;
-		AbilityPower = 100;
+		AttackDamage = 45,
+		AbilityPower = 100,
 
 		Sequence = {
 			{
-				Name = "HeavyPunch 1";
-				AnimationId = "rbxassetid://1";
-			};
+				Name = "HeavyPunch 1",
+				AnimationId = "rbxassetid://1",
+			},
 			{
-				Name = "HeavyPunch 2";
-				AnimationId = "rbxassetid://2";
-			};
-		};
-	};
+				Name = "HeavyPunch 2",
+				AnimationId = "rbxassetid://2",
+			},
+		},
+	},
 
-	ReticleHairRotationsDegree = { 0, 120, 240 };
+	ReticleHairRotationsDegree = { 0, 120, 240 },
 })
 
 local properties = propertyDefinition:GetPropertyTable(serviceBag, workspace)
@@ -70,24 +70,24 @@ properties.Changed:Connect(function()
 end)
 
 properties:SetBaseValue({
-	Health = 5;
+	Health = 5,
 
 	Ultimate = {
-		AttackDamage = 2;
-		AbilityPower = 2;
-	};
+		AttackDamage = 2,
+		AbilityPower = 2,
+	},
 
 	HeavyPunch = {
-		AttackDamage = 5;
-		AbilityPower = 9;
-	};
+		AttackDamage = 5,
+		AbilityPower = 9,
+	},
 
-	ReticleHairRotationsDegree = { 1, 25, 135, 325, 500 };
+	ReticleHairRotationsDegree = { 1, 25, 135, 325, 500 },
 })
 
 -- print("ReticleHairRotationsDegree", properties.ReticleHairRotationsDegree.Value)
 
-properties.ReticleHairRotationsDegree.Value = { 2, 5}
+properties.ReticleHairRotationsDegree.Value = { 2, 5 }
 
 -- print("ReticleHairRotationsDegree", properties.ReticleHairRotationsDegree.Value)
 
@@ -97,17 +97,16 @@ properties.Health.Value = 25
 
 properties.Ultimate.Sequence.Value = {
 	{
-		Name = "Another value 3";
-		AnimationId = "rbxassetid://3";
-	};
+		Name = "Another value 3",
+		AnimationId = "rbxassetid://3",
+	},
 }
 
 -- print("properties.Ultimate.Sequence", properties.Ultimate.Sequence.Value)
 
 properties.Value = {
-	Health = 25000;
-};
-
+	Health = 25000,
+}
 
 local multiplier = ultAttackDamage:CreateMultiplier(2, workspace)
 -- ultAttackDamage:CreateAdditive(100, workspace)
@@ -118,4 +117,4 @@ local multiplier = ultAttackDamage:CreateMultiplier(2, workspace)
 -- 	print(value:GetValue())
 -- end)
 
-multiplier:Destroy()
+multiplier:Destroy()