@quenty/rogue-properties 11.22.0-canary.544.de8fcee.0 → 11.22.1-canary.545.2374fb2.0

package/CHANGELOG.md

@@ -3,7 +3,26 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-# [11.22.0-canary.544.de8fcee.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/rogue-properties@11.21.4...@quenty/rogue-properties@11.22.0-canary.544.de8fcee.0) (2025-04-01)
+## [11.22.1-canary.545.2374fb2.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/rogue-properties@11.22.0...@quenty/rogue-properties@11.22.1-canary.545.2374fb2.0) (2025-04-05)
+
+
+### Bug Fixes
+
+* Add types to packages ([2374fb2](https://github.com/Quenty/NevermoreEngine/commit/2374fb2b043cfbe0e9b507b3316eec46a4e353a0))
+
+
+
+
+
+# [11.22.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/rogue-properties@11.21.5...@quenty/rogue-properties@11.22.0) (2025-04-02)
+
+**Note:** Version bump only for package @quenty/rogue-properties
+
+
+
+
+
+## [11.21.5](https://github.com/Quenty/NevermoreEngine/compare/@quenty/rogue-properties@11.21.4...@quenty/rogue-properties@11.21.5) (2025-03-31)
 
 **Note:** Version bump only for package @quenty/rogue-properties
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/rogue-properties",
-  "version": "11.22.0-canary.544.de8fcee.0",
+  "version": "11.22.1-canary.545.2374fb2.0",
   "description": "Roguelike properties which can be modified by external provides",
   "keywords": [
     "Roblox",
@@ -24,33 +24,33 @@
     "Quenty"
   ],
   "dependencies": {
-    "@quenty/adorneedata": "7.18.0-canary.544.de8fcee.0",
-    "@quenty/baseobject": "10.8.0",
-    "@quenty/binder": "14.19.0-canary.544.de8fcee.0",
-    "@quenty/brio": "14.17.0-canary.544.de8fcee.0",
-    "@quenty/defaultvalueutils": "1.2.0",
-    "@quenty/ducktype": "5.8.1",
-    "@quenty/instanceutils": "13.17.0-canary.544.de8fcee.0",
-    "@quenty/jsonutils": "10.10.1",
-    "@quenty/linkutils": "13.17.0-canary.544.de8fcee.0",
-    "@quenty/loader": "10.8.0",
-    "@quenty/maid": "3.4.0",
-    "@quenty/observablecollection": "12.20.0-canary.544.de8fcee.0",
-    "@quenty/rx": "13.17.0-canary.544.de8fcee.0",
-    "@quenty/rxbinderutils": "14.19.0-canary.544.de8fcee.0",
-    "@quenty/rxsignal": "7.17.0-canary.544.de8fcee.0",
-    "@quenty/servicebag": "11.11.1",
-    "@quenty/signal": "7.10.0",
-    "@quenty/spring": "10.8.1",
-    "@quenty/string": "3.3.1",
-    "@quenty/table": "3.7.1",
-    "@quenty/tie": "10.20.0-canary.544.de8fcee.0",
-    "@quenty/valuebaseutils": "13.17.0-canary.544.de8fcee.0",
-    "@quenty/valueobject": "13.17.0-canary.544.de8fcee.0",
+    "@quenty/adorneedata": "7.18.1-canary.545.2374fb2.0",
+    "@quenty/baseobject": "10.8.1-canary.545.2374fb2.0",
+    "@quenty/binder": "14.19.1-canary.545.2374fb2.0",
+    "@quenty/brio": "14.17.1-canary.545.2374fb2.0",
+    "@quenty/defaultvalueutils": "1.2.1-canary.545.2374fb2.0",
+    "@quenty/ducktype": "5.8.2-canary.545.2374fb2.0",
+    "@quenty/instanceutils": "13.17.1-canary.545.2374fb2.0",
+    "@quenty/jsonutils": "10.10.2-canary.545.2374fb2.0",
+    "@quenty/linkutils": "13.17.1-canary.545.2374fb2.0",
+    "@quenty/loader": "10.8.1-canary.545.2374fb2.0",
+    "@quenty/maid": "3.4.1-canary.545.2374fb2.0",
+    "@quenty/observablecollection": "12.20.1-canary.545.2374fb2.0",
+    "@quenty/rx": "13.17.1-canary.545.2374fb2.0",
+    "@quenty/rxbinderutils": "14.19.1-canary.545.2374fb2.0",
+    "@quenty/rxsignal": "7.17.1-canary.545.2374fb2.0",
+    "@quenty/servicebag": "11.11.2-canary.545.2374fb2.0",
+    "@quenty/signal": "7.10.1-canary.545.2374fb2.0",
+    "@quenty/spring": "10.8.2-canary.545.2374fb2.0",
+    "@quenty/string": "3.3.2-canary.545.2374fb2.0",
+    "@quenty/table": "3.7.2-canary.545.2374fb2.0",
+    "@quenty/tie": "10.20.1-canary.545.2374fb2.0",
+    "@quenty/valuebaseutils": "13.17.1-canary.545.2374fb2.0",
+    "@quenty/valueobject": "13.17.1-canary.545.2374fb2.0",
     "@quentystudios/t": "^3.0.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "de8fcee995fcdae464964357b4c770c03f4c7e03"
+  "gitHead": "2374fb2b043cfbe0e9b507b3316eec46a4e353a0"
 }

package/src/Shared/Array/RoguePropertyArrayUtils.lua

@@ -10,11 +10,11 @@ local DefaultValueUtils = require("DefaultValueUtils")
 
 local RoguePropertyArrayUtils = {}
 
-function RoguePropertyArrayUtils.getNameFromIndex(index)
+function RoguePropertyArrayUtils.getNameFromIndex(index: number): string
 	return RoguePropertyArrayConstants.ARRAY_ENTRY_PERFIX .. tostring(index)
 end
 
-function RoguePropertyArrayUtils.getIndexFromName(name)
+function RoguePropertyArrayUtils.getIndexFromName(name: string): number?
 	return tonumber(String.removePrefix(name, RoguePropertyArrayConstants.ARRAY_ENTRY_PERFIX))
 end
 
@@ -26,7 +26,7 @@ function RoguePropertyArrayUtils.createRequiredPropertyDefinitionFromArray(array
 		return nil, "Missing array data"
 	end
 
-	for index, item in pairs(arrayData) do
+	for index, item in arrayData do
 		if typeof(item) ~= expectedType then
 			expectedType = nil
 			-- TODO: Maybe union?
@@ -38,7 +38,7 @@ function RoguePropertyArrayUtils.createRequiredPropertyDefinitionFromArray(array
 end
 
 function RoguePropertyArrayUtils.createRequiredTableDefinition(arrayData, parentPropertyTableDefinition)
-	local RoguePropertyTableDefinition = require("RoguePropertyTableDefinition")
+	local RoguePropertyTableDefinition = (require :: any)("RoguePropertyTableDefinition")
 
 	local entry = arrayData[1]
 	if type(entry) ~= "table" then
@@ -51,7 +51,7 @@ function RoguePropertyArrayUtils.createRequiredTableDefinition(arrayData, parent
 	propertyDefinition:SetParentPropertyTableDefinition(parentPropertyTableDefinition)
 	propertyDefinition:SetDefaultValue(DefaultValueUtils.toDefaultValue(entry))
 
-	for _, item in pairs(arrayData) do
+	for _, item in arrayData do
 		local canAssign, message = propertyDefinition:CanAssign(item, true)
 		if not canAssign then
 			return nil, string.format("Cannot assign due to %q", message)
@@ -61,8 +61,11 @@ function RoguePropertyArrayUtils.createRequiredTableDefinition(arrayData, parent
 	return propertyDefinition
 end
 
-function RoguePropertyArrayUtils.createRequiredPropertyDefinitionFromType(expectedType, parentPropertyTableDefinition)
-	local RoguePropertyDefinition = require("RoguePropertyDefinition")
+function RoguePropertyArrayUtils.createRequiredPropertyDefinitionFromType(
+	expectedType: string,
+	parentPropertyTableDefinition
+)
+	local RoguePropertyDefinition = (require :: any)("RoguePropertyDefinition")
 
 	local default = DefaultValueUtils.getDefaultValueForType(expectedType)
 	if default == nil then
@@ -77,13 +80,13 @@ function RoguePropertyArrayUtils.createRequiredPropertyDefinitionFromType(expect
 	return propertyDefinition
 end
 
-function RoguePropertyArrayUtils.createDefinitionsFromContainer(container, parentPropertyTableDefinition)
-	local RoguePropertyTableDefinition = require("RoguePropertyTableDefinition")
-	local RoguePropertyDefinition = require("RoguePropertyDefinition")
+function RoguePropertyArrayUtils.createDefinitionsFromContainer(container: Instance, parentPropertyTableDefinition)
+	local RoguePropertyTableDefinition = (require :: any)("RoguePropertyTableDefinition")
+	local RoguePropertyDefinition = (require :: any)("RoguePropertyDefinition")
 
 	local value = {}
 
-	for _, item in pairs(container:GetChildren()) do
+	for _, item in container:GetChildren() do
 		local index = RoguePropertyArrayUtils.getIndexFromName(item.Name)
 		if not index then
 			continue
@@ -108,10 +111,10 @@ function RoguePropertyArrayUtils.createDefinitionsFromContainer(container, paren
 	return value
 end
 
-function RoguePropertyArrayUtils.getDefaultValueMapFromContainer(container)
+function RoguePropertyArrayUtils.getDefaultValueMapFromContainer(container: Instance)
 	local value = {}
 
-	for _, item in pairs(container:GetChildren()) do
+	for _, item in container:GetChildren() do
 		local index = RoguePropertyArrayUtils.getIndexFromName(item.Name)
 		if index then
 			if item:IsA("Folder") then
@@ -132,11 +135,11 @@ function RoguePropertyArrayUtils.getDefaultValueMapFromContainer(container)
 end
 
 function RoguePropertyArrayUtils.createDefinitionsFromArrayData(arrayData, propertyTableDefinition)
-	local RoguePropertyTableDefinition = require("RoguePropertyTableDefinition")
-	local RoguePropertyDefinition = require("RoguePropertyDefinition")
+	local RoguePropertyTableDefinition = (require :: any)("RoguePropertyTableDefinition")
+	local RoguePropertyDefinition = (require :: any)("RoguePropertyDefinition")
 
 	local definitions = {}
-	for index, defaultValue in pairs(arrayData) do
+	for index, defaultValue in arrayData do
 		local name = RoguePropertyArrayUtils.getNameFromIndex(index)
 
 		if type(defaultValue) == "table" then

package/src/Shared/Cache/RoguePropertyCache.lua

@@ -4,7 +4,6 @@
 	@class RoguePropertyCache
 ]=]
 
-local require = require(script.Parent.loader).load(script)
 
 local RoguePropertyCache = {}
 RoguePropertyCache.ClassName = "RoguePropertyCache"

package/src/Shared/Cache/RoguePropertyCacheService.lua

@@ -5,16 +5,16 @@
 	@class RoguePropertyCacheService
 ]=]
 
-local RunService = game:GetService("RunService")
-
 local require = require(script.Parent.loader).load(script)
+local RunService = game:GetService("RunService")
 
 local RoguePropertyCache = require("RoguePropertyCache")
+local _ServiceBag = require("ServiceBag")
 
 local RoguePropertyCacheService = {}
 RoguePropertyCacheService.ServiceName = "RoguePropertyCacheService"
 
-function RoguePropertyCacheService:Init(serviceBag)
+function RoguePropertyCacheService:Init(serviceBag: _ServiceBag.ServiceBag)
 	assert(not self._serviceBag, "Already initialized")
 	self._serviceBag = assert(serviceBag, "No serviceBag")
 

package/src/Shared/Definition/RoguePropertyDefinition.lua

@@ -32,7 +32,7 @@ function RoguePropertyDefinition:SetDefaultValue(defaultValue)
 	self._encodedDefaultValue = RoguePropertyUtils.encodeProperty(self, self._defaultValue)
 end
 
-function RoguePropertyDefinition.isRoguePropertyDefinition(value)
+function RoguePropertyDefinition.isRoguePropertyDefinition(value: any): boolean
 	return DuckTypeUtils.isImplementation(RoguePropertyDefinition, value)
 end
 
@@ -84,7 +84,7 @@ function RoguePropertyDefinition:CanAssign(value, _strict)
 	end
 end
 
-function RoguePropertyDefinition:SetName(name)
+function RoguePropertyDefinition:SetName(name: string)
 	assert(type(name) == "string", "Bad name")
 
 	self._name = name

package/src/Shared/Definition/RoguePropertyDefinitionArrayHelper.lua

@@ -20,7 +20,7 @@ function RoguePropertyDefinitionArrayHelper.new(propertyTableDefinition, default
 	return self
 end
 
-function RoguePropertyDefinitionArrayHelper:IsArray()
+function RoguePropertyDefinitionArrayHelper:IsArray(): boolean
 	return self._defaultArrayData ~= nil
 end
 
@@ -37,7 +37,8 @@ function RoguePropertyDefinitionArrayHelper:GetDefaultDefinitions()
 		return self._defaultDefinitions
 	end
 
-	self._defaultDefinitions = RoguePropertyArrayUtils.createDefinitionsFromArrayData(self._defaultArrayData, self._propertyTableDefinition)
+	self._defaultDefinitions =
+		RoguePropertyArrayUtils.createDefinitionsFromArrayData(self._defaultArrayData, self._propertyTableDefinition)
 	return self._defaultDefinitions
 end
 
@@ -45,16 +46,22 @@ function RoguePropertyDefinitionArrayHelper:GetRequiredPropertyDefinition()
 	return self._requiredPropertyDefinition
 end
 
-function RoguePropertyDefinitionArrayHelper:CanAssign(arrayValue, strict)
+function RoguePropertyDefinitionArrayHelper:CanAssign(arrayValue, strict): boolean
 	if type(arrayValue) ~= "table" then
 		return false, string.format("got %q, expected %q", self._valueType, typeof(arrayValue))
 	end
 
-	for key, value in pairs(arrayValue) do
+	for key, value in arrayValue do
 		if type(key) == "number" then
 			local canAssign, message = self._requiredPropertyDefinition:CanAssign(value, strict)
 			if not canAssign then
-				return false,  string.format("Array at %s was %q, cannot assign due to %q", tostring(key), typeof(value), tostring(message))
+				return false,
+					string.format(
+						"Array at %s was %q, cannot assign due to %q",
+						tostring(key),
+						typeof(value),
+						tostring(message)
+					)
 			end
 		end
 	end
@@ -62,7 +69,7 @@ function RoguePropertyDefinitionArrayHelper:CanAssign(arrayValue, strict)
 	return true
 end
 
-function RoguePropertyDefinitionArrayHelper:CanAssignAsArrayMember(value, strict)
+function RoguePropertyDefinitionArrayHelper:CanAssignAsArrayMember(value, strict): boolean
 	assert(type(strict) == "boolean", "Bad strict")
 
 	return self._requiredPropertyDefinition:CanAssign(value, strict)

package/src/Shared/Definition/RoguePropertyTableDefinition.lua

@@ -6,22 +6,23 @@
 local require = require(script.Parent.loader).load(script)
 
 local DuckTypeUtils = require("DuckTypeUtils")
+local RoguePropertyArrayUtils = (require :: any)("RoguePropertyArrayUtils")
+local RoguePropertyCacheService = require("RoguePropertyCacheService")
 local RoguePropertyDefinition = require("RoguePropertyDefinition")
 local RoguePropertyDefinitionArrayHelper = require("RoguePropertyDefinitionArrayHelper")
+local RoguePropertyService = require("RoguePropertyService")
 local RoguePropertyTable = require("RoguePropertyTable")
 local RxBrioUtils = require("RxBrioUtils")
 local RxInstanceUtils = require("RxInstanceUtils")
 local ServiceBag = require("ServiceBag")
-local RoguePropertyService = require("RoguePropertyService")
-local RoguePropertyArrayUtils = require("RoguePropertyArrayUtils")
 local Set = require("Set")
-local RoguePropertyCacheService = require("RoguePropertyCacheService")
+local _Table = require("Table")
 
 local RoguePropertyTableDefinition = {} -- Inherits from RoguePropertyDefinition
 RoguePropertyTableDefinition.ClassName = "RoguePropertyTableDefinition"
 RoguePropertyTableDefinition.__index = RoguePropertyTableDefinition
 
-function RoguePropertyTableDefinition.new(tableName, defaultValueTable)
+function RoguePropertyTableDefinition.new(tableName: string?, defaultValueTable: _Table.Map<string, any>?)
 	local self = setmetatable(RoguePropertyDefinition.new(), RoguePropertyTableDefinition)
 
 	if tableName then
@@ -39,7 +40,7 @@ function RoguePropertyTableDefinition.isRoguePropertyTableDefinition(value): boo
 	return DuckTypeUtils.isImplementation(RoguePropertyTableDefinition, value)
 end
 
-function RoguePropertyTableDefinition:SetDefaultValue(defaultValueTable)
+function RoguePropertyTableDefinition:SetDefaultValue(defaultValueTable: _Table.Map<string, any>?)
 	assert(type(defaultValueTable) == "table", "Bad defaultValueTable")
 
 	RoguePropertyDefinition.SetDefaultValue(self, defaultValueTable)
@@ -48,7 +49,7 @@ function RoguePropertyTableDefinition:SetDefaultValue(defaultValueTable)
 
 	local defaultArrayData = {}
 
-	for key, defaultValue in pairs(defaultValueTable) do
+	for key, defaultValue in defaultValueTable do
 		if type(key) == "number" then
 			table.insert(defaultArrayData, defaultValue)
 		else
@@ -89,7 +90,7 @@ function RoguePropertyTableDefinition:SetDefaultValue(defaultValueTable)
 	end
 end
 
-function RoguePropertyTableDefinition:CanAssign(mainValue, strict: boolean): boolean
+function RoguePropertyTableDefinition:CanAssign(mainValue, strict: boolean): (boolean, string?)
 	assert(type(strict) == "boolean", "Bad strict")
 
 	if type(mainValue) ~= "table" then
@@ -102,14 +103,14 @@ function RoguePropertyTableDefinition:CanAssign(mainValue, strict: boolean): boo
 			)
 	end
 
-	local remainingKeys
+	local remainingKeys: Set.Set<string>
 	if strict then
 		remainingKeys = Set.fromKeys(self._definitionMap)
 	else
 		remainingKeys = {}
 	end
 
-	for key, value in pairs(mainValue) do
+	for key, value in mainValue do
 		remainingKeys[key] = nil
 
 		if type(key) == "number" then
@@ -158,13 +159,13 @@ function RoguePropertyTableDefinition:CanAssign(mainValue, strict: boolean): boo
 		return false,
 			string.format(
 				"Had %d unassigned keys %q while assigning to %q",
-				#remainingKeys,
-				table.concat(remainingKeys, ", "),
+				Set.count(remainingKeys),
+				table.concat(Set.toList(remainingKeys), ", "),
 				self:GetFullName()
 			)
 	end
 
-	return true
+	return true, nil
 end
 
 function RoguePropertyTableDefinition:GetDefinitionArrayHelper()
@@ -195,7 +196,7 @@ end
 	@param adornee Instance
 	@return RoguePropertyTable
 ]=]
-function RoguePropertyTableDefinition:Get(serviceBag, adornee)
+function RoguePropertyTableDefinition:Get(serviceBag, adornee: Instance)
 	assert(ServiceBag.isServiceBag(serviceBag), "Bad serviceBag")
 	assert(typeof(adornee) == "Instance", "Bad adornee")
 
@@ -288,7 +289,7 @@ function RoguePropertyTableDefinition:GetOrCreateInstance(parent)
 	return folder
 end
 
-function RoguePropertyTableDefinition:__index(index)
+function RoguePropertyTableDefinition:__index(index: string)
 	assert(type(index) == "string", "Bad index")
 
 	if index == "_definitionMap" or index == "_arrayDefinitionHelper" or index == "_parentPropertyTableDefinition" then
@@ -318,6 +319,8 @@ function RoguePropertyTableDefinition:__index(index)
 		else
 			error(string.format("Bad definition %q - Not an array", tostring(index)))
 		end
+	else
+		error(string.format("Bad index %q", tostring(index)))
 	end
 end
 

package/src/Shared/Implementation/RogueProperty.lua

@@ -35,7 +35,7 @@ function RogueProperty.new(adornee, serviceBag, definition)
 	return setmetatable(self, RogueProperty)
 end
 
-function RogueProperty:SetCanInitialize(canInitialize)
+function RogueProperty:SetCanInitialize(canInitialize: boolean)
 	assert(type(canInitialize) == "boolean", "Bad canInitialize")
 
 	if rawget(self, "_canInitialize") ~= canInitialize then
@@ -154,7 +154,7 @@ function RogueProperty:GetValue()
 
 	local current = self:_decodeValue(propObj.Value)
 
-	for _, rogueModifier in pairs(self:GetRogueModifiers()) do
+	for _, rogueModifier in self:GetRogueModifiers() do
 		current = rogueModifier:GetModifiedVersion(current)
 	end
 
@@ -174,7 +174,7 @@ function RogueProperty:GetRogueModifiers()
 	local found = RogueModifierInterface:GetChildren(propObj)
 
 	local orders = {}
-	for _, item in pairs(found) do
+	for _, item in found do
 		orders[item] = item.Order.Value
 	end
 	table.sort(found, function(a, b)
@@ -190,23 +190,25 @@ function RogueProperty:_observeModifierSortedList()
 
 		local sortedList = topMaid:Add(ObservableSortedList.new())
 
-		topMaid:GiveTask(self:_observeBaseValueBrio():Pipe({
-			RxBrioUtils.flatMapBrio(function(baseValue)
-				return RogueModifierInterface:ObserveChildrenBrio(baseValue)
-			end);
-		}):Subscribe(function(brio)
-			if brio:IsDead() then
-				return
-			end
-			local maid, rogueModifier = brio:ToMaidAndValue()
-			maid:GiveTask(sortedList:Add(rogueModifier, rogueModifier.Order:Observe()))
-		end))
+		topMaid:GiveTask(self:_observeBaseValueBrio()
+			:Pipe({
+				RxBrioUtils.flatMapBrio(function(baseValue)
+					return RogueModifierInterface:ObserveChildrenBrio(baseValue)
+				end),
+			})
+			:Subscribe(function(brio)
+				if brio:IsDead() then
+					return
+				end
+				local maid, rogueModifier = brio:ToMaidAndValue()
+				maid:GiveTask(sortedList:Add(rogueModifier, rogueModifier.Order:Observe()))
+			end))
 
 		sub:Fire(sortedList)
 
 		return topMaid
 	end):Pipe({
-		Rx.cache();
+		Rx.cache(),
 	})
 end
 
@@ -214,19 +216,19 @@ function RogueProperty:Observe()
 	local observeInitialValue = self:_observeBaseValueBrio():Pipe({
 		RxBrioUtils.switchMapBrio(function(baseValue)
 			return RxInstanceUtils.observeProperty(baseValue, "Value")
-		end);
-		RxBrioUtils.emitOnDeath(self._definition:GetDefaultValue());
-		Rx.defaultsTo(self._definition:GetDefaultValue());
-		Rx.distinct();
+		end),
+		RxBrioUtils.emitOnDeath(self._definition:GetDefaultValue()),
+		Rx.defaultsTo(self._definition:GetDefaultValue()),
+		Rx.distinct(),
 	})
 
 	return self:_observeModifierSortedList():Pipe({
 		Rx.switchMap(function(sortedList)
-			return sortedList:Observe()
+		return sortedList:Observe()
 		end);
 		Rx.switchMap(function(rogueModifierList)
-			local current = observeInitialValue
-			for _, rogueModifier in pairs(rogueModifierList) do
+		local current = observeInitialValue
+			for _, rogueModifier in rogueModifierList do
 				current = rogueModifier:ObserveModifiedVersion(current)
 			end
 			return current
@@ -269,7 +271,7 @@ function RogueProperty:CreateMultiplier(amount, source)
 	return multiplier
 end
 
-function RogueProperty:CreateAdditive(amount, source)
+function RogueProperty:CreateAdditive(amount: number, source)
 	assert(type(amount) == "number", "Bad amount")
 
 	local baseValue = self:GetBaseValueObject()

package/src/Shared/Implementation/RoguePropertyArrayHelper.lua

@@ -22,13 +22,13 @@ function RoguePropertyArrayHelper.new(serviceBag, arrayDefinitionHelper, roguePr
 	return self
 end
 
-function RoguePropertyArrayHelper:SetCanInitialize(canInitialize)
+function RoguePropertyArrayHelper:SetCanInitialize(canInitialize: boolean)
 	if canInitialize then
 		self:GetArrayRogueProperties()
 	end
 end
 
-function RoguePropertyArrayHelper:GetArrayRogueProperty(index)
+function RoguePropertyArrayHelper:GetArrayRogueProperty(index: number)
 	assert(type(index) == "number", "Bad index")
 
 	-- TODO: Maybe return something general for that index
@@ -47,7 +47,7 @@ function RoguePropertyArrayHelper:GetArrayRogueProperties()
 		if not (container and container:GetAttribute("HasInitializedArrayComponent")) then
 			container:SetAttribute("HasInitializedArrayComponent", true)
 			local properties = self:_getDefaultRogueProperties()
-			for _, rogueProperty in pairs(properties) do
+			for _, rogueProperty in properties do
 				-- Force initialization once and only once...
 				rogueProperty:SetCanInitialize(true)
 				rogueProperty:SetCanInitialize(false)
@@ -65,7 +65,7 @@ function RoguePropertyArrayHelper:GetArrayRogueProperties()
 	local definitions = RoguePropertyArrayUtils.createDefinitionsFromContainer(container, self._arrayDefinitionHelper:GetPropertyTableDefinition())
 	local rogueProperties = {}
 
-	for index, definition in pairs(definitions) do
+	for index, definition in definitions do
 		local property = definition:Get(self._serviceBag, adornee)
 		property:SetCanInitialize(false) -- Explicitly not going to reinitialize
 		rogueProperties[index] = property
@@ -81,7 +81,7 @@ function RoguePropertyArrayHelper:_getDefaultRogueProperties()
 
 	local defaultRogueProperties = {}
 	local adornee = self._roguePropertyTable:GetAdornee()
-	for _, definition in pairs(self._arrayDefinitionHelper:GetDefaultDefinitions()) do
+	for _, definition in self._arrayDefinitionHelper:GetDefaultDefinitions() do
 		local property = definition:Get(self._serviceBag, adornee)
 		table.insert(defaultRogueProperties, property)
 	end
@@ -105,7 +105,7 @@ function RoguePropertyArrayHelper:SetArrayBaseData(arrayData)
 	local adornee = self._roguePropertyTable:GetAdornee()
 	local definitions = RoguePropertyArrayUtils.createDefinitionsFromArrayData(arrayData, parentPropertyTableDefinition)
 
-	for index, definition in pairs(definitions) do
+	for index, definition in definitions do
 		if available[index] and available[index]:GetDefinition():GetValueType() == definition:GetValueType() then
 			available[index]:SetBaseValue(definition:GetDefaultValue())
 		else
@@ -140,7 +140,7 @@ function RoguePropertyArrayHelper:SetArrayData(arrayData)
 	local adornee = self._roguePropertyTable:GetAdornee()
 	local definitions = RoguePropertyArrayUtils.createDefinitionsFromArrayData(arrayData, parentPropertyTableDefinition)
 
-	for index, definition in pairs(definitions) do
+	for index, definition in definitions do
 		if available[index] and available[index]:GetDefinition():GetValueType() == definition:GetValueType() then
 			available[index]:SetValue(definition:GetDefaultValue())
 		else
@@ -159,7 +159,7 @@ function RoguePropertyArrayHelper:SetArrayData(arrayData)
 end
 
 function RoguePropertyArrayHelper:_removeUnspecified(container, definitions)
-	for _, item in pairs(container:GetChildren()) do
+	for _, item in container:GetChildren() do
 		local index = RoguePropertyArrayUtils.getIndexFromName(item.Name)
 		if index then
 			if not definitions[index] then
@@ -169,7 +169,6 @@ function RoguePropertyArrayHelper:_removeUnspecified(container, definitions)
 	end
 end
 
-
 function RoguePropertyArrayHelper:GetArrayBaseValues()
 	local result = {}
 	for index, rogueProperty in pairs(self:GetArrayRogueProperties()) do
@@ -192,7 +191,7 @@ function RoguePropertyArrayHelper:ObserveArrayValues()
 	-- TODO: Allow for observing
 	local observables = {}
 
-	for _, rogueProperty in pairs(self:GetArrayRogueProperties()) do
+	for _, rogueProperty in self:GetArrayRogueProperties() do
 		table.insert(observables, rogueProperty:Observe())
 	end
 

package/src/Shared/Implementation/RoguePropertyTable.lua

@@ -12,7 +12,7 @@ local RoguePropertyTable = {} -- inherits from RogueProperty
 RoguePropertyTable.ClassName = "RoguePropertyTable"
 RoguePropertyTable.__index = RoguePropertyTable
 
-function RoguePropertyTable.new(adornee, serviceBag, roguePropertyTableDefinition)
+function RoguePropertyTable.new(adornee: Instance, serviceBag, roguePropertyTableDefinition)
 	local self = setmetatable(RogueProperty.new(adornee, serviceBag, roguePropertyTableDefinition), RoguePropertyTable)
 
 	rawset(self, "_properties", {})
@@ -25,12 +25,12 @@ function RoguePropertyTable.new(adornee, serviceBag, roguePropertyTableDefinitio
 	return self
 end
 
-function RoguePropertyTable:SetCanInitialize(canInitialize)
+function RoguePropertyTable:SetCanInitialize(canInitialize: boolean)
 	assert(type(canInitialize) == "boolean", "Bad canInitialize")
 
 	RogueProperty.SetCanInitialize(self, canInitialize)
 
-	for _, property in pairs(self:GetRogueProperties()) do
+	for _, property in self:GetRogueProperties() do
 		property:SetCanInitialize(canInitialize)
 	end
 
@@ -44,7 +44,7 @@ function RoguePropertyTable:ObserveContainerBrio()
 	return self._definition:ObserveContainerBrio(self._adornee, self:CanInitialize())
 end
 
-function RoguePropertyTable:GetContainer()
+function RoguePropertyTable:GetContainer(): Instance
 	local cached = rawget(self, "_containerCache")
 	if cached and cached:IsDescendantOf(self._adornee) then
 		return cached
@@ -60,7 +60,7 @@ function RoguePropertyTable:SetBaseValue(newBaseValue)
 
 	local arrayData = {}
 
-	for propertyName, value in pairs(newBaseValue) do
+	for propertyName, value in newBaseValue do
 		if type(propertyName) == "string" then
 			local rogueProperty = self:GetRogueProperty(propertyName)
 			if not rogueProperty then
@@ -88,7 +88,7 @@ function RoguePropertyTable:SetValue(newValue)
 
 	local arrayData = {}
 
-	for propertyName, value in pairs(newValue) do
+	for propertyName, value in newValue do
 		if type(propertyName) == "string" then
 			local rogueProperty = self:GetRogueProperty(propertyName)
 			if not rogueProperty then
@@ -185,7 +185,7 @@ function RoguePropertyTable:_observeDictionary()
 	return Rx.combineLatest(toObserve)
 end
 
-function RoguePropertyTable:GetRogueProperty(name)
+function RoguePropertyTable:GetRogueProperty(name: string)
 	assert(type(name) == "string", "Bad name")
 
 	-- Caching these things doesn't do a whole lot, but saves on table allocation.

package/src/Shared/RoguePropertyService.lua

@@ -10,11 +10,12 @@ local require = require(script.Parent.loader).load(script)
 local RunService = game:GetService("RunService")
 
 local Maid = require("Maid")
+local _ServiceBag = require("ServiceBag")
 
 local RoguePropertyService = {}
 RoguePropertyService.ServiceName = "RoguePropertyService"
 
-function RoguePropertyService:Init(serviceBag)
+function RoguePropertyService:Init(serviceBag: _ServiceBag.ServiceBag)
 	assert(not self._serviceBag, "Already initialized")
 	self._serviceBag = assert(serviceBag, "No serviceBag")
 
@@ -30,7 +31,7 @@ function RoguePropertyService:Init(serviceBag)
 	self._serviceBag:GetService(require("RogueSetter"))
 end
 
-function RoguePropertyService:CanInitializeProperties()
+function RoguePropertyService:CanInitializeProperties(): boolean
 	return RunService:IsServer()
 end