@quenty/rogue-properties 10.0.0 → 11.0.0

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [11.0.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/rogue-properties@10.0.0...@quenty/rogue-properties@11.0.0) (2024-02-27)
+
+
+### Bug Fixes
+
+* Fix rogue property speeds ([0275254](https://github.com/Quenty/NevermoreEngine/commit/027525423896ecc110c2e12e2af5a9b5b6da75ae))
+
+
+
+
+
 # [10.0.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/rogue-properties@9.0.0...@quenty/rogue-properties@10.0.0) (2024-02-14)
 
 **Note:** Version bump only for package @quenty/rogue-properties

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/rogue-properties",
-  "version": "10.0.0",
+  "version": "11.0.0",
   "description": "Roguelike properties which can be modified by external provides",
   "keywords": [
     "Roblox",
@@ -48,5 +48,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "63f949a67b77d3edc98b358cace163da8c789e9f"
+  "gitHead": "76dd93ee8ce79e7e156f1c39978bf72224f6dd05"
 }

package/src/Shared/Implementation/RogueProperty.lua

@@ -211,8 +211,8 @@ function RogueProperty:Observe()
 				current = Rx.of(self._definition:GetDefaultValue())
 			end
 
-			for _, item in pairs(self._roguePropertyService:GetProviders()) do
-				current = item:ObserveModifiedVersion(baseValue, self, current)
+			for _, provider in pairs(self._roguePropertyService:GetProviders()) do
+				current = provider:ObserveModifiedVersion(baseValue, self, current)
 			end
 
 			return current

package/src/Shared/Modifiers/Additive/RogueAdditiveProvider.lua

@@ -13,6 +13,7 @@ local RoguePropertyModifierUtils = require("RoguePropertyModifierUtils")
 local RoguePropertyService = require("RoguePropertyService")
 local Observable = require("Observable")
 local Maid = require("Maid")
+local ValueObject = require("ValueObject")
 
 local RogueAdditiveProvider = {}
 RogueAdditiveProvider.ServiceName = "RogueAdditiveProvider"
@@ -86,6 +87,12 @@ function RogueAdditiveProvider:ObserveModifiedVersion(propObj, rogueProperty, ob
 		return Observable.new(function(sub)
 			local topMaid = Maid.new()
 
+			local lastValue = topMaid:Add(ValueObject.fromObservable(observeBaseValue))
+
+			local function update()
+				sub:Fire(lastValue.Value)
+			end
+
 			topMaid:GiveTask(self:_observeAddersBrio(propObj):Subscribe(function(brio)
 				if brio:IsDead() then
 					return
@@ -95,25 +102,25 @@ function RogueAdditiveProvider:ObserveModifiedVersion(propObj, rogueProperty, ob
 				local value = brio:GetValue()
 
 				maid:GiveTask(value:ObserveAdditive():Subscribe(function()
-					sub:Fire()
+					update()
 				end))
 
-				sub:Fire()
+				update()
 
 				maid:GiveTask(function()
-					sub:Fire()
+					update()
 				end)
 			end))
 
 			topMaid:GiveTask(observeBaseValue:Subscribe(function()
-				sub:Fire()
+				update()
 			end))
 
 			return topMaid
 		end):Pipe({
 			Rx.throttleDefer();
-			Rx.map(function()
-				return self:GetModifiedVersion(propObj, rogueProperty, propObj.Value)
+			Rx.map(function(baseValue)
+				return self:GetModifiedVersion(propObj, rogueProperty, baseValue)
 			end);
 		})
 	else

package/src/Shared/Modifiers/Multiplier/RogueMultiplierProvider.lua

@@ -13,6 +13,7 @@ local RoguePropertyModifierUtils = require("RoguePropertyModifierUtils")
 local RoguePropertyService = require("RoguePropertyService")
 local Observable = require("Observable")
 local Maid = require("Maid")
+local ValueObject = require("ValueObject")
 
 local RogueMultiplierProvider = {}
 RogueMultiplierProvider.ServiceName = "RogueMultiplierProvider"
@@ -86,6 +87,12 @@ function RogueMultiplierProvider:ObserveModifiedVersion(propObj, rogueProperty,
 		return Observable.new(function(sub)
 			local topMaid = Maid.new()
 
+			local lastValue = topMaid:Add(ValueObject.fromObservable(observeBaseValue))
+
+			local function update()
+				sub:Fire(lastValue.Value)
+			end
+
 			topMaid:GiveTask(self:_observeMultipliersBrio(propObj):Subscribe(function(brio)
 				if brio:IsDead() then
 					return
@@ -95,25 +102,25 @@ function RogueMultiplierProvider:ObserveModifiedVersion(propObj, rogueProperty,
 				local value = brio:GetValue()
 
 				maid:GiveTask(value:ObserveMultiplier():Subscribe(function()
-					sub:Fire()
+					update()
 				end))
 
-				sub:Fire()
+				update()
 
 				maid:GiveTask(function()
-					sub:Fire()
+					update()
 				end)
 			end))
 
-			topMaid:GiveTask(observeBaseValue:Subscribe(function()
-				sub:Fire()
+			topMaid:GiveTask(lastValue:Observe():Subscribe(function()
+				update()
 			end))
 
 			return topMaid
 		end):Pipe({
 			Rx.throttleDefer();
-			Rx.map(function()
-				return self:GetModifiedVersion(propObj, rogueProperty, propObj.Value)
+			Rx.map(function(baseValue)
+				return self:GetModifiedVersion(propObj, rogueProperty, baseValue)
 			end);
 		})
 	else