@quenty/promise 10.22.0 → 10.23.1

package/CHANGELOG.md

@@ -3,6 +3,16 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [10.23.1](https://github.com/Quenty/NevermoreEngine/compare/@quenty/promise@10.23.0...@quenty/promise@10.23.1) (2026-08-14)
+
+**Note:** Version bump only for package @quenty/promise
+
+# [10.23.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/promise@10.22.0...@quenty/promise@10.23.0) (2026-07-25)
+
+### Features
+
+- Promises don't reject on Promise.rejected(nil) ([be63400](https://github.com/Quenty/NevermoreEngine/commit/be63400f89c863624b75b1903f7e8357ddca7bf9))
+
 # [10.22.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/promise@10.21.0...@quenty/promise@10.22.0) (2026-07-23)
 
 ### Features

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/promise",
-  "version": "10.22.0",
+  "version": "10.23.1",
   "description": "Promise implementation for Roblox",
   "keywords": [
     "Roblox",
@@ -29,15 +29,15 @@
   ],
   "dependencies": {
     "@quenty/deferred": "2.3.2",
-    "@quenty/loader": "10.11.0",
-    "@quenty/maid": "3.11.0",
+    "@quenty/loader": "10.11.1",
+    "@quenty/maid": "3.11.1",
     "@quenty/math": "2.7.5",
-    "@quenty/nevermore-test-runner": "1.5.0",
-    "@quenty/signal": "7.13.1",
+    "@quenty/nevermore-test-runner": "1.5.1",
+    "@quenty/signal": "7.13.2",
     "@quentystudios/jest-lua": "3.10.0-quenty.2"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "88b03743718172ff79cd62ade64a86565fcac17d"
+  "gitHead": "f084360c3729ea424d49d9bc42f8f0d1c128fa82"
 }

package/src/Shared/Promise.lua

@@ -363,11 +363,8 @@ function Promise._reject<T...>(self: Promise<T...>, values: { n: number, [number
 		self:_executeThen(unpack(data))
 	end
 
-	-- Check for uncaught exceptions. A single empty table carries no more information than an
-	-- empty rejection (aggregators may reject with an empty results table), so it is not
-	-- reported either.
-	local isEmptyTableRejection = values.n == 1 and type(values[1]) == "table" and next(values[1]) == nil
-	if self._unconsumedException and values.n > 0 and not isEmptyTableRejection then
+	-- Check for uncaught exceptions
+	if self._unconsumedException and self:_isReportableRejection(values) then
 		task.defer(function()
 			-- Yield to end of frame, giving control back to Roblox.
 			-- This is the equivalent of giving something back to a task manager.
@@ -386,6 +383,23 @@ function Promise._reject<T...>(self: Promise<T...>, values: { n: number, [number
 	end
 end
 
+-- A rejection is only worth reporting if it carries information. Rejecting with no values at all
+-- (what Destroy() and cancellation produce), with values that are all nil, or with a single empty
+-- table (aggregators may reject with an empty results table) says nothing a warning could relay.
+function Promise._isReportableRejection<T...>(_self: Promise<T...>, values: { n: number, [number]: any }): boolean
+	if values.n == 1 and type(values[1]) == "table" and next(values[1]) == nil then
+		return false
+	end
+
+	for index = 1, values.n do
+		if values[index] ~= nil then
+			return true
+		end
+	end
+
+	return false
+end
+
 function Promise._toHumanReadable<T...>(_self: Promise<T...>, data: any): string
 	if type(data) == "table" then
 		-- A custom __tostring is the best human-readable form; only address-form tables

package/src/Shared/Promise.spec.lua

@@ -133,6 +133,25 @@ describe("Promise.rejected", function()
 	it("reuses a single shared promise when rejecting with no values", function()
 		expect(Promise.rejected()).toBe(Promise.rejected())
 	end)
+
+	it("rejects with nil without reporting an uncaught exception", function()
+		local promise = Promise.rejected(nil)
+
+		expect(promise:IsRejected()).toEqual(true)
+		expect(promise:_isReportableRejection(promise._rejected)).toEqual(false)
+
+		local ok, err = promise:GetResults()
+		expect(ok).toEqual(false)
+		expect(err).toEqual(nil)
+	end)
+
+	it("rejects with several nils without reporting an uncaught exception", function()
+		local promise = Promise.rejected(nil, nil, nil)
+
+		expect(promise:IsRejected()).toEqual(true)
+		expect(promise._rejected.n).toEqual(3)
+		expect(promise:_isReportableRejection(promise._rejected)).toEqual(false)
+	end)
 end)
 
 describe("Promise:Resolve", function()
@@ -531,6 +550,34 @@ describe("Promise:GetResults", function()
 	end)
 end)
 
+describe("Promise._isReportableRejection", function()
+	local promise = Promise.new()
+
+	it("reports a rejection that carries a value", function()
+		expect(promise:_isReportableRejection(table.pack("boom"))).toEqual(true)
+		expect(promise:_isReportableRejection(table.pack(false))).toEqual(true)
+		expect(promise:_isReportableRejection(table.pack(0))).toEqual(true)
+		expect(promise:_isReportableRejection(table.pack({ code = 500 }))).toEqual(true)
+	end)
+
+	it("reports a rejection whose value is not the first one", function()
+		expect(promise:_isReportableRejection(table.pack(nil, "boom"))).toEqual(true)
+	end)
+
+	it("does not report a rejection with no values", function()
+		expect(promise:_isReportableRejection({ n = 0 })).toEqual(false)
+	end)
+
+	it("does not report a rejection whose values are all nil", function()
+		expect(promise:_isReportableRejection(table.pack(nil))).toEqual(false)
+		expect(promise:_isReportableRejection(table.pack(nil, nil, nil))).toEqual(false)
+	end)
+
+	it("does not report a rejection carrying a single empty table", function()
+		expect(promise:_isReportableRejection(table.pack({}))).toEqual(false)
+	end)
+end)
+
 describe("Promise._toHumanReadable", function()
 	local promise = Promise.new()