@quenty/observablecollection 12.47.1 → 12.48.1

package/CHANGELOG.md

@@ -3,6 +3,16 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [12.48.1](https://github.com/Quenty/NevermoreEngine/compare/@quenty/observablecollection@12.48.0...@quenty/observablecollection@12.48.1) (2026-08-24)
+
+### Bug Fixes
+
+- ObservableSortedList handles removal immediately. ([9f115e8](https://github.com/Quenty/NevermoreEngine/commit/9f115e8b32c5450f63904a1a39845e98f423712e))
+
+# [12.48.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/observablecollection@12.47.1...@quenty/observablecollection@12.48.0) (2026-08-24)
+
+**Note:** Version bump only for package @quenty/observablecollection
+
 ## [12.47.1](https://github.com/Quenty/NevermoreEngine/compare/@quenty/observablecollection@12.47.0...@quenty/observablecollection@12.47.1) (2026-08-14)
 
 **Note:** Version bump only for package @quenty/observablecollection

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/observablecollection",
-  "version": "12.47.1",
+  "version": "12.48.1",
   "description": "A set of observable collections, such as sets, maps, sorted lists, and more.",
   "keywords": [
     "Roblox",
@@ -48,10 +48,10 @@
     "@quentystudios/jest-lua": "3.10.0-quenty.2"
   },
   "devDependencies": {
-    "@quenty/blend": "12.45.1"
+    "@quenty/blend": "12.46.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "f084360c3729ea424d49d9bc42f8f0d1c128fa82"
+  "gitHead": "1a2c0cc735d06b4adcd324f60302b950e12d68b0"
 }

package/src/Shared/SortedList/ObservableSortedList.lua

@@ -50,6 +50,7 @@ export type ObservableSortedList<T> = typeof(setmetatable(
 
 		_unifiedTracker: UnifiedChangedSpanTracker.UnifiedChangedSpanTracker,
 
+		_nodeRemovedImmediate: Signal.Signal<SortedNode.SortedNode<T>>,
 		_indexObservers: any,
 		_nodeIndexObservables: any,
 		_mainObservables: any,
@@ -116,6 +117,10 @@ function ObservableSortedList.new<T>(isReversed: boolean?, compare: CompareFunct
 ]=]
 	self.OrderChanged = self._maid:Add(Signal.new())
 
+	-- Internal: fires the moment a node leaves the tree, ahead of the batched ItemRemoved, for
+	-- observers holding the node itself.
+	self._nodeRemovedImmediate = self._maid:Add(Signal.new()) :: any
+
 	--[=[
 	Fires when the count changes
 
@@ -286,6 +291,13 @@ function ObservableSortedList.ObserveItemsBrio<T>(
 		-- to so many events
 
 		local function handleItem(data: T, _index, node)
+			-- Nodes added before this subscription are announced from the tree below, and their
+			-- ItemAdded still fires on the next flush. Announcing twice would replace the brio the
+			-- subscriber is already holding.
+			if maid[node] then
+				return
+			end
+
 			local brio = Brio.new(data, node)
 			maid[node] = brio
 			sub:Fire(brio)
@@ -297,7 +309,7 @@ function ObservableSortedList.ObserveItemsBrio<T>(
 		end
 
 		maid:GiveTask(self.ItemAdded:Connect(handleItem))
-		maid:GiveTask(self.ItemRemoved:Connect(function(_item, node)
+		maid:GiveTask(self._nodeRemovedImmediate:Connect(function(node)
 			maid[node] = nil
 		end))
 
@@ -494,6 +506,11 @@ function ObservableSortedList._assignSortValue<T>(
 			self:_removeNode(node)
 			node.value = nil
 			self:_queueFireEvents()
+
+			-- Holders of the node itself have to let go now, not on the next flush. A node added and
+			-- removed before that flush cancels both batched events, so ItemRemoved alone would
+			-- leave them holding a node that is no longer in the list.
+			self._nodeRemovedImmediate:Fire(node)
 		else
 			node.value = nil
 		end

package/src/Shared/SortedList/ObservableSortedList.spec.lua

@@ -1013,6 +1013,111 @@ describe("ObservableSortedList", function()
 			maid:Destroy()
 		end)
 
+		it("should kill the brio of an item added and removed in the same frame", function()
+			local maid = Maid.new()
+			local list = maid:Add(ObservableSortedList.new())
+
+			local remove = list:Add("a", 1)
+
+			local brios: { any } = {}
+			maid:GiveTask(list:ObserveItemsBrio():Subscribe(function(brio)
+				table.insert(brios, brio)
+			end))
+
+			expect(#brios).toEqual(1)
+			expect(brios[1]:IsDead()).toEqual(false)
+
+			remove()
+
+			expect(brios[1]:IsDead()).toEqual(true)
+			expect(list:GetList()).toEqual({})
+
+			list:_testForceFireEvents()
+
+			expect(brios[1]:IsDead()).toEqual(true)
+
+			maid:Destroy()
+		end)
+
+		it("should kill the brio of an item removed after its add has fired", function()
+			local maid = Maid.new()
+			local list = maid:Add(ObservableSortedList.new())
+
+			local remove = list:Add("a", 1)
+			list:_testForceFireEvents()
+
+			local brios: { any } = {}
+			maid:GiveTask(list:ObserveItemsBrio():Subscribe(function(brio)
+				table.insert(brios, brio)
+			end))
+
+			expect(#brios).toEqual(1)
+
+			remove()
+
+			expect(brios[1]:IsDead()).toEqual(true)
+
+			maid:Destroy()
+		end)
+
+		it("should not announce an item added and removed before anyone subscribed", function()
+			local maid = Maid.new()
+			local list = maid:Add(ObservableSortedList.new())
+
+			local remove = list:Add("a", 1)
+			remove()
+
+			local brios: { any } = {}
+			maid:GiveTask(list:ObserveItemsBrio():Subscribe(function(brio)
+				table.insert(brios, brio)
+			end))
+
+			list:_testForceFireEvents()
+
+			expect(#brios).toEqual(0)
+
+			maid:Destroy()
+		end)
+
+		it("should announce an item once when subscribing before its add fires", function()
+			local maid = Maid.new()
+			local list = maid:Add(ObservableSortedList.new())
+
+			list:Add("a", 1)
+
+			local brios: { any } = {}
+			maid:GiveTask(list:ObserveItemsBrio():Subscribe(function(brio)
+				table.insert(brios, brio)
+			end))
+
+			expect(#brios).toEqual(1)
+
+			list:_testForceFireEvents()
+
+			expect(#brios).toEqual(1)
+			expect(brios[1]:IsDead()).toEqual(false)
+
+			maid:Destroy()
+		end)
+
+		it("should keep announcing items added after the subscription", function()
+			local maid = Maid.new()
+			local list = maid:Add(ObservableSortedList.new())
+
+			local brios: { any } = {}
+			maid:GiveTask(list:ObserveItemsBrio():Subscribe(function(brio)
+				table.insert(brios, brio)
+			end))
+
+			list:Add("a", 1)
+			list:_testForceFireEvents()
+
+			expect(#brios).toEqual(1)
+			expect((brios[1]:GetValue())).toEqual("a")
+
+			maid:Destroy()
+		end)
+
 		it("should handle removing during a sort value change", function()
 			local maid = Maid.new()
 			local list = maid:Add(ObservableSortedList.new())