@quenty/observablecollection 12.38.1 → 12.40.0

package/CHANGELOG.md

@@ -3,6 +3,16 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [12.40.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/observablecollection@12.39.0...@quenty/observablecollection@12.40.0) (2026-07-18)
+
+**Note:** Version bump only for package @quenty/observablecollection
+
+# [12.39.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/observablecollection@12.38.1...@quenty/observablecollection@12.39.0) (2026-07-14)
+
+### Features
+
+- **observablecollection:** convert package to --!strict ([c9e45ee](https://github.com/Quenty/NevermoreEngine/commit/c9e45eeac15ddd736d8848cfbbdca6f525d4cadf))
+
 ## [12.38.1](https://github.com/Quenty/NevermoreEngine/compare/@quenty/observablecollection@12.38.0...@quenty/observablecollection@12.38.1) (2026-05-30)
 
 **Note:** Version bump only for package @quenty/observablecollection

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/observablecollection",
-  "version": "12.38.1",
+  "version": "12.40.0",
   "description": "A set of observable collections, such as sets, maps, sorted lists, and more.",
   "keywords": [
     "Roblox",
@@ -32,26 +32,26 @@
   "dependencies": {
     "@quenty/baseobject": "10.13.0",
     "@quenty/binarysearch": "2.4.0",
-    "@quenty/brio": "14.30.1",
+    "@quenty/brio": "14.31.0",
     "@quenty/ducktype": "5.11.0",
-    "@quenty/instanceutils": "13.30.1",
+    "@quenty/instanceutils": "13.31.0",
     "@quenty/loader": "10.11.0",
     "@quenty/maid": "3.9.0",
     "@quenty/nevermore-test-runner": "1.4.0",
-    "@quenty/promise": "10.18.1",
-    "@quenty/rx": "13.28.3",
+    "@quenty/promise": "10.19.0",
+    "@quenty/rx": "13.29.0",
     "@quenty/signal": "7.13.1",
     "@quenty/steputils": "3.6.3",
     "@quenty/symbol": "3.5.2",
     "@quenty/table": "3.9.2",
-    "@quenty/valueobject": "13.31.1",
+    "@quenty/valueobject": "13.32.0",
     "@quentystudios/jest-lua": "3.10.0-quenty.2"
   },
   "devDependencies": {
-    "@quenty/blend": "12.36.1"
+    "@quenty/blend": "12.38.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "598b2b62b36bdcbdbbd56f7db10c399831cc6eba"
+  "gitHead": "cbbb89635bfdcbf32f26a40422ac736292917cca"
 }

package/src/Shared/FilteredObservableListView.lua

@@ -1,4 +1,4 @@
---!nonstrict
+--!strict
 --[=[
 	@class FilteredObservableListView
 ]=]
@@ -6,16 +6,36 @@
 local require = require(script.Parent.loader).load(script)
 
 local BaseObject = require("BaseObject")
+local Brio = require("Brio")
 local Observable = require("Observable")
 local ObservableSortedList = require("ObservableSortedList")
 local Rx = require("Rx")
+local SortedNode = require("SortedNode")
+local Symbol = require("Symbol")
 
 local FilteredObservableListView = setmetatable({}, BaseObject)
 FilteredObservableListView.ClassName = "FilteredObservableListView"
 FilteredObservableListView.__index = FilteredObservableListView
 
+export type ObservableListLike<T> = {
+	ObserveItemsBrio: (self: any) -> Observable.Observable<Brio.Brio<T>>,
+	ObserveIndexByKey: (self: any, key: Symbol.Symbol) -> Observable.Observable<number?>,
+}
+
+export type FilteredObservableListView<T> =
+	typeof(setmetatable(
+		{} :: {
+			_compare: (any, any) -> number,
+			_baseList: ObservableListLike<T>,
+			_observeScoreCallback: (T) -> Observable.Observable<any>,
+			_scoredList: ObservableSortedList.ObservableSortedList<T>,
+		},
+		{} :: typeof({ __index = FilteredObservableListView })
+	))
+	& BaseObject.BaseObject
+
 -- Higher numbers last
-local function defaultCompare(a, b)
+local function defaultCompare(a: any, b: any): number
 	-- equivalent of `return a - b` except it supports comparison of strings and stuff
 	if b > a then
 		return -1
@@ -26,25 +46,29 @@ local function defaultCompare(a, b)
 	end
 end
 
-function FilteredObservableListView.new(observableList, observeScoreCallback, compare)
-	local self = setmetatable(BaseObject.new(), FilteredObservableListView)
+function FilteredObservableListView.new<T>(
+	observableList: ObservableListLike<T>,
+	observeScoreCallback: (T) -> Observable.Observable<any>,
+	compare: ((any, any) -> number)?
+): FilteredObservableListView<T>
+	local self: FilteredObservableListView<T> = setmetatable(BaseObject.new() :: any, FilteredObservableListView)
 
 	self._compare = compare or defaultCompare
 	self._baseList = assert(observableList, "No observableList")
 	self._observeScoreCallback = assert(observeScoreCallback, "No observeScoreCallback")
 
-	self._scoredList = self._maid:Add(ObservableSortedList.new(false, function(a, b)
+	self._scoredList = self._maid:Add(ObservableSortedList.new(false, function(a: any, b: any): number
 		-- Preserve index when scoring does not
 		if a.score == b.score then
 			return a.index - b.index
 		else
 			return self._compare(a.score, b.score)
 		end
-	end))
+	end) :: ObservableSortedList.ObservableSortedList<T>)
 
 	-- Shockingly this is somewhat performant because the sorted list defers all events
 	-- to process the list reordering.
-	self._maid:GiveTask(self._baseList:ObserveItemsBrio():Subscribe(function(brio)
+	self._maid:GiveTask((self._baseList:ObserveItemsBrio() :: any):Subscribe(function(brio: any)
 		if brio:IsDead() then
 			return
 		end
@@ -56,11 +80,11 @@ function FilteredObservableListView.new(observableList, observeScoreCallback, co
 
 		maid._add = self._scoredList:Add(
 			entry,
-			Rx.combineLatest({
+			(Rx.combineLatest({
 				score = observeScore,
 				index = self._baseList:ObserveIndexByKey(key),
-			}):Pipe({
-				Rx.map(function(state)
+			}) :: any):Pipe({
+				Rx.map(function(state): any
 					if state.score == nil then
 						return nil
 					end
@@ -77,8 +101,10 @@ end
 	Observes all items in the list
 	@return Observable<Brio<T>>
 ]=]
-function FilteredObservableListView:ObserveItemsBrio()
-	return self._scoredList:ObserveItemsBrio()
+function FilteredObservableListView.ObserveItemsBrio<T>(
+	self: FilteredObservableListView<T>
+): Observable.Observable<Brio.Brio<T>>
+	return (self._scoredList:ObserveItemsBrio() :: any) :: Observable.Observable<Brio.Brio<T>>
 end
 
 --[=[
@@ -88,7 +114,10 @@ end
 	@param key Symbol
 	@return Observable<number>
 ]=]
-function FilteredObservableListView:ObserveIndexByKey(key)
+function FilteredObservableListView.ObserveIndexByKey<T>(
+	self: FilteredObservableListView<T>,
+	key: SortedNode.SortedNode<T>
+): Observable.Observable<number>
 	return self._scoredList:ObserveIndexByKey(key)
 end
 
@@ -96,7 +125,7 @@ end
 	Gets the count of items in the list
 	@return number
 ]=]
-function FilteredObservableListView:GetCount()
+function FilteredObservableListView.GetCount<T>(self: FilteredObservableListView<T>): number
 	return self._scoredList:GetCount()
 end
 
@@ -106,7 +135,7 @@ FilteredObservableListView.__len = FilteredObservableListView.GetCount
 	Observes the count of the list
 	@return Observable<number>
 ]=]
-function FilteredObservableListView:ObserveCount()
+function FilteredObservableListView.ObserveCount<T>(self: FilteredObservableListView<T>): Observable.Observable<number>
 	return self._scoredList:ObserveCount()
 end
 

package/src/Shared/SortedList/ObservableSortedList.lua

@@ -1,5 +1,4 @@
---!nonstrict
---strict
+--!strict
 --[=[
 	A list that can be observed for blend and other components and maintains sorting order.
 
@@ -97,7 +96,7 @@ function ObservableSortedList.new<T>(isReversed: boolean?, compare: CompareFunct
 	@prop ItemAdded Signal<T, number, Symbol>
 	@within ObservableSortedList
 ]=]
-	self.ItemAdded = self._maid:Add(Signal.new())
+	self.ItemAdded = self._maid:Add(Signal.new()) :: any
 
 	--[=[
 	Fires when an item is removed.
@@ -106,7 +105,7 @@ function ObservableSortedList.new<T>(isReversed: boolean?, compare: CompareFunct
 	@prop ItemRemoved Signal<T, Symbol>
 	@within ObservableSortedList
 ]=]
-	self.ItemRemoved = self._maid:Add(Signal.new())
+	self.ItemRemoved = self._maid:Add(Signal.new()) :: any
 
 	--[=[
 	Fires when the order could have changed
@@ -160,7 +159,7 @@ function ObservableSortedList.__iter<T>(self: ObservableSortedList<T>): SortFunc
 	if self._root then
 		return self._root:IterateData()
 	else
-		return SortFunctionUtils.emptyIterator
+		return SortFunctionUtils.emptyIterator :: any
 	end
 end
 
@@ -189,7 +188,7 @@ function ObservableSortedList._iterateNodes<T>(
 	if self._root then
 		return self._root:IterateNodes()
 	else
-		return SortFunctionUtils.emptyIterator
+		return SortFunctionUtils.emptyIterator :: any
 	end
 end
 
@@ -201,7 +200,7 @@ function ObservableSortedList._iterateNodesRange<T>(
 	if self._root then
 		return self._root:IterateNodesRange(start, finish)
 	else
-		return SortFunctionUtils.emptyIterator
+		return SortFunctionUtils.emptyIterator :: any
 	end
 end
 
@@ -358,7 +357,7 @@ function ObservableSortedList.ObserveAtIndex<T>(
 		if node then
 			sub:Fire(node.data, node)
 		else
-			sub:Fire(nil, nil)
+			sub:Fire(nil :: any, nil :: any)
 		end
 	end) :: any
 end
@@ -503,7 +502,7 @@ function ObservableSortedList._assignSortValue<T>(
 	end
 
 	if self._compare ~= nil then
-		value = SortedNodeValue.new(value, self._compare) :: any
+		value = SortedNodeValue.new(value, self._compare :: any) :: any
 	end
 
 	-- our value changing didn't change anything
@@ -583,9 +582,10 @@ function ObservableSortedList._fireEvents<T>(self: ObservableSortedList<T>)
 
 	-- TODO: Prevent Rx.of(itemAdded) stuff in our UI
 	for node in nodesAdded do
+		local anyNode = node :: any
 		-- TODO: Prevent query slow here...?
-		local index = node:GetIndex()
-		self.ItemAdded:Fire(node.data, index, node)
+		local index = anyNode:GetIndex()
+		self.ItemAdded:Fire(anyNode.data, index, anyNode)
 	end
 
 	if not self.Destroy then
@@ -593,7 +593,8 @@ function ObservableSortedList._fireEvents<T>(self: ObservableSortedList<T>)
 	end
 
 	for node in nodesRemoved do
-		self.ItemRemoved:Fire(node.data, node)
+		local anyNode = node :: any
+		self.ItemRemoved:Fire(anyNode.data, anyNode)
 	end
 
 	if not self.Destroy then