@quenty/nevermore-cli 4.43.4 → 4.44.0

package/dist/utils/testing/structured-test-results.js

@@ -0,0 +1,140 @@
+/**
+ * Tag NevermoreTestRunnerUtils stamps on the results table a test script
+ * returns. A test place also runs probe scripts (`--script-text`) that return
+ * whatever they like, so results are recognized by this rather than by shape.
+ */
+export const TEST_RESULTS_FORMAT = 'nevermore-test-results@1';
+function readNumber(source, key) {
+    const value = source[key];
+    return typeof value === 'number' && Number.isFinite(value) ? value : 0;
+}
+function readFailures(value) {
+    if (!Array.isArray(value)) {
+        return [];
+    }
+    const failures = [];
+    for (const entry of value) {
+        if (typeof entry !== 'object' || entry === null) {
+            continue;
+        }
+        const record = entry;
+        if (typeof record.name !== 'string') {
+            continue;
+        }
+        failures.push({
+            name: record.name,
+            message: typeof record.message === 'string' ? record.message : undefined,
+        });
+    }
+    return failures;
+}
+/**
+ * Decode a single returned value into results, or undefined if it is not one.
+ *
+ * Fields are read defensively rather than trusted: the value crossed a
+ * transport, and the two transports spell exotic Luau types differently, so a
+ * malformed field must not become a verdict.
+ */
+export function decodeStructuredTestResults(value) {
+    if (typeof value !== 'object' || value === null || Array.isArray(value)) {
+        return undefined;
+    }
+    const record = value;
+    if (record.format !== TEST_RESULTS_FORMAT) {
+        return undefined;
+    }
+    return {
+        // Only an explicit `true` is a pass. A results table that lost its verdict
+        // in transit must not read as one.
+        success: record.success === true,
+        ranJest: record.ranJest === true,
+        passed: readNumber(record, 'passed'),
+        failed: readNumber(record, 'failed'),
+        skipped: readNumber(record, 'skipped'),
+        total: readNumber(record, 'total'),
+        suitesPassed: readNumber(record, 'suitesPassed'),
+        suitesFailed: readNumber(record, 'suitesFailed'),
+        suitesTotal: readNumber(record, 'suitesTotal'),
+        failures: readFailures(record.failures),
+        omittedFailures: readNumber(record, 'omittedFailures'),
+        error: typeof record.error === 'string' ? record.error : undefined,
+    };
+}
+/**
+ * Find the results a run returned, if it returned any.
+ *
+ * `undefined` covers both "the transport delivered no return channel" and "the
+ * script returned nothing recognizable" — a caller falls back to the logs
+ * either way, which is what a test script written before this convention gets.
+ */
+export function findStructuredTestResults(returnValues) {
+    if (!returnValues) {
+        return undefined;
+    }
+    for (const value of returnValues) {
+        const results = decodeStructuredTestResults(value);
+        if (results) {
+            return results;
+        }
+    }
+    return undefined;
+}
+/**
+ * Describe a verdict the run's own counts do not support, for a warning.
+ *
+ * A run reporting failure while nothing in it failed is self-contradicting, and
+ * it is precisely what a runner reading the wrong field produces: the counts
+ * stay plausible, so nothing looks wrong except that every package fails at
+ * once. That shipped once — a runner consulted jest-lua's inverted
+ * `AggregatedResult.success` and failed every passing suite.
+ *
+ * Reported, never corrected. A runner that says it failed may know something its
+ * counts cannot express (an interrupted run, a snapshot check, a reporter
+ * error), so the verdict stands and the contradiction is made loud instead.
+ */
+export function describeUnexplainedVerdict(results) {
+    if (results.success || results.failed > 0 || results.suitesFailed > 0) {
+        return undefined;
+    }
+    return (`the run reports failure but its own counts show nothing failed ` +
+        `(${results.passed} passed, 0 failed, ${results.total} total, ` +
+        `0 of ${results.suitesTotal} suite(s) failed)` +
+        (results.error
+            ? `. It says: ${results.error}`
+            : ' and gives no reason at all'));
+}
+/** Counts in the shape the reporters already render. */
+export function toParsedTestCounts(results) {
+    return {
+        passed: results.passed,
+        failed: results.failed,
+        total: results.total,
+    };
+}
+/**
+ * Why the runner says the run failed. Empty when it says it passed.
+ *
+ * Phrased to match the log parser's wording so that merging the two sources
+ * collapses the overlap instead of reporting every failure twice.
+ */
+export function structuredFailureReasons(results) {
+    if (results.success) {
+        return [];
+    }
+    const reasons = [];
+    if (results.suitesFailed > 0) {
+        reasons.push(`${results.suitesFailed} test suite(s) failed`);
+    }
+    if (results.failed > 0) {
+        reasons.push(`${results.failed} test(s) failed`);
+    }
+    // The runner's own message restates those two lines when a count explains the
+    // failure, so it is only worth repeating when nothing else can say why —
+    // an interrupted run, a failed snapshot check, a result shape it could not
+    // read. That case is also the one where a reason is most needed.
+    if (reasons.length === 0) {
+        reasons.push(results.error ?? 'the test runner reported the run as failed');
+    }
+    return reasons;
+}
+//# sourceMappingURL=structured-test-results.js.map

package/dist/utils/testing/structured-test-results.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"structured-test-results.js","sourceRoot":"","sources":["../../../src/utils/testing/structured-test-results.ts"],"names":[],"mappings":"AAEA;;;;GAIG;AACH,MAAM,CAAC,MAAM,mBAAmB,GAAG,0BAA0B,CAAC;AAkC9D,SAAS,UAAU,CAAC,MAA+B,EAAE,GAAW;IAC9D,MAAM,KAAK,GAAG,MAAM,CAAC,GAAG,CAAC,CAAC;IAC1B,OAAO,OAAO,KAAK,KAAK,QAAQ,IAAI,MAAM,CAAC,QAAQ,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC;AACzE,CAAC;AAED,SAAS,YAAY,CAAC,KAAc;IAClC,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC;QAC1B,OAAO,EAAE,CAAC;IACZ,CAAC;IAED,MAAM,QAAQ,GAA4B,EAAE,CAAC;IAC7C,KAAK,MAAM,KAAK,IAAI,KAAK,EAAE,CAAC;QAC1B,IAAI,OAAO,KAAK,KAAK,QAAQ,IAAI,KAAK,KAAK,IAAI,EAAE,CAAC;YAChD,SAAS;QACX,CAAC;QACD,MAAM,MAAM,GAAG,KAAgC,CAAC;QAChD,IAAI,OAAO,MAAM,CAAC,IAAI,KAAK,QAAQ,EAAE,CAAC;YACpC,SAAS;QACX,CAAC;QACD,QAAQ,CAAC,IAAI,CAAC;YACZ,IAAI,EAAE,MAAM,CAAC,IAAI;YACjB,OAAO,EAAE,OAAO,MAAM,CAAC,OAAO,KAAK,QAAQ,CAAC,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,CAAC,SAAS;SACzE,CAAC,CAAC;IACL,CAAC;IACD,OAAO,QAAQ,CAAC;AAClB,CAAC;AAED;;;;;;GAMG;AACH,MAAM,UAAU,2BAA2B,CACzC,KAAc;IAEd,IAAI,OAAO,KAAK,KAAK,QAAQ,IAAI,KAAK,KAAK,IAAI,IAAI,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC;QACxE,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,MAAM,MAAM,GAAG,KAAgC,CAAC;IAChD,IAAI,MAAM,CAAC,MAAM,KAAK,mBAAmB,EAAE,CAAC;QAC1C,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,OAAO;QACL,2EAA2E;QAC3E,mCAAmC;QACnC,OAAO,EAAE,MAAM,CAAC,OAAO,KAAK,IAAI;QAChC,OAAO,EAAE,MAAM,CAAC,OAAO,KAAK,IAAI;QAChC,MAAM,EAAE,UAAU,CAAC,MAAM,EAAE,QAAQ,CAAC;QACpC,MAAM,EAAE,UAAU,CAAC,MAAM,EAAE,QAAQ,CAAC;QACpC,OAAO,EAAE,UAAU,CAAC,MAAM,EAAE,SAAS,CAAC;QACtC,KAAK,EAAE,UAAU,CAAC,MAAM,EAAE,OAAO,CAAC;QAClC,YAAY,EAAE,UAAU,CAAC,MAAM,EAAE,cAAc,CAAC;QAChD,YAAY,EAAE,UAAU,CAAC,MAAM,EAAE,cAAc,CAAC;QAChD,WAAW,EAAE,UAAU,CAAC,MAAM,EAAE,aAAa,CAAC;QAC9C,QAAQ,EAAE,YAAY,CAAC,MAAM,CAAC,QAAQ,CAAC;QACvC,eAAe,EAAE,UAAU,CAAC,MAAM,EAAE,iBAAiB,CAAC;QACtD,KAAK,EAAE,OAAO,MAAM,CAAC,KAAK,KAAK,QAAQ,CAAC,CAAC,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,SAAS;KACnE,CAAC;AACJ,CAAC;AAED;;;;;;GAMG;AACH,MAAM,UAAU,yBAAyB,CACvC,YAAmC;IAEnC,IAAI,CAAC,YAAY,EAAE,CAAC;QAClB,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,KAAK,MAAM,KAAK,IAAI,YAAY,EAAE,CAAC;QACjC,MAAM,OAAO,GAAG,2BAA2B,CAAC,KAAK,CAAC,CAAC;QACnD,IAAI,OAAO,EAAE,CAAC;YACZ,OAAO,OAAO,CAAC;QACjB,CAAC;IACH,CAAC;IACD,OAAO,SAAS,CAAC;AACnB,CAAC;AAED;;;;;;;;;;;;GAYG;AACH,MAAM,UAAU,0BAA0B,CACxC,OAA8B;IAE9B,IAAI,OAAO,CAAC,OAAO,IAAI,OAAO,CAAC,MAAM,GAAG,CAAC,IAAI,OAAO,CAAC,YAAY,GAAG,CAAC,EAAE,CAAC;QACtE,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,OAAO,CACL,iEAAiE;QACjE,IAAI,OAAO,CAAC,MAAM,sBAAsB,OAAO,CAAC,KAAK,UAAU;QAC/D,QAAQ,OAAO,CAAC,WAAW,mBAAmB;QAC9C,CAAC,OAAO,CAAC,KAAK;YACZ,CAAC,CAAC,cAAc,OAAO,CAAC,KAAK,EAAE;YAC/B,CAAC,CAAC,6BAA6B,CAAC,CACnC,CAAC;AACJ,CAAC;AAED,wDAAwD;AACxD,MAAM,UAAU,kBAAkB,CAChC,OAA8B;IAE9B,OAAO;QACL,MAAM,EAAE,OAAO,CAAC,MAAM;QACtB,MAAM,EAAE,OAAO,CAAC,MAAM;QACtB,KAAK,EAAE,OAAO,CAAC,KAAK;KACrB,CAAC;AACJ,CAAC;AAED;;;;;GAKG;AACH,MAAM,UAAU,wBAAwB,CACtC,OAA8B;IAE9B,IAAI,OAAO,CAAC,OAAO,EAAE,CAAC;QACpB,OAAO,EAAE,CAAC;IACZ,CAAC;IAED,MAAM,OAAO,GAAa,EAAE,CAAC;IAC7B,IAAI,OAAO,CAAC,YAAY,GAAG,CAAC,EAAE,CAAC;QAC7B,OAAO,CAAC,IAAI,CAAC,GAAG,OAAO,CAAC,YAAY,uBAAuB,CAAC,CAAC;IAC/D,CAAC;IACD,IAAI,OAAO,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QACvB,OAAO,CAAC,IAAI,CAAC,GAAG,OAAO,CAAC,MAAM,iBAAiB,CAAC,CAAC;IACnD,CAAC;IAED,8EAA8E;IAC9E,yEAAyE;IACzE,2EAA2E;IAC3E,iEAAiE;IACjE,IAAI,OAAO,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QACzB,OAAO,CAAC,IAAI,CAAC,OAAO,CAAC,KAAK,IAAI,4CAA4C,CAAC,CAAC;IAC9E,CAAC;IACD,OAAO,OAAO,CAAC;AACjB,CAAC"}

package/dist/utils/testing/structured-test-results.test.d.ts

@@ -0,0 +1,7 @@
+/**
+ * Unit tests for decoding the results a test run returns. The decoder stands
+ * between a transport and a pass/fail verdict, so the cases that matter are the
+ * ones where a value is not what it claims to be.
+ */
+export {};
+//# sourceMappingURL=structured-test-results.test.d.ts.map

package/dist/utils/testing/structured-test-results.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"structured-test-results.test.d.ts","sourceRoot":"","sources":["../../../src/utils/testing/structured-test-results.test.ts"],"names":[],"mappings":"AAAA;;;;GAIG"}

package/dist/utils/testing/structured-test-results.test.js

@@ -0,0 +1,179 @@
+/**
+ * Unit tests for decoding the results a test run returns. The decoder stands
+ * between a transport and a pass/fail verdict, so the cases that matter are the
+ * ones where a value is not what it claims to be.
+ */
+import { describe, expect, it } from 'vitest';
+import { TEST_RESULTS_FORMAT, decodeStructuredTestResults, describeUnexplainedVerdict, findStructuredTestResults, structuredFailureReasons, toParsedTestCounts, } from './structured-test-results.js';
+function results(overrides = {}) {
+    return {
+        format: TEST_RESULTS_FORMAT,
+        success: true,
+        ranJest: true,
+        passed: 25,
+        failed: 0,
+        skipped: 1,
+        total: 26,
+        suitesPassed: 3,
+        suitesFailed: 0,
+        suitesTotal: 3,
+        failures: [],
+        omittedFailures: 0,
+        ...overrides,
+    };
+}
+describe('decodeStructuredTestResults', () => {
+    it('decodes a results table', () => {
+        const decoded = decodeStructuredTestResults(results());
+        expect(decoded).toEqual({
+            success: true,
+            ranJest: true,
+            passed: 25,
+            failed: 0,
+            skipped: 1,
+            total: 26,
+            suitesPassed: 3,
+            suitesFailed: 0,
+            suitesTotal: 3,
+            failures: [],
+            omittedFailures: 0,
+            error: undefined,
+        });
+    });
+    it('ignores a value that is not tagged as results', () => {
+        // A probe run (--script-text) returns whatever it likes, and none of it is
+        // a verdict on anything.
+        expect(decodeStructuredTestResults({ success: true })).toBeUndefined();
+        expect(decodeStructuredTestResults({ format: 'something-else', success: true })).toBeUndefined();
+        expect(decodeStructuredTestResults('nevermore-test-results@1')).toBeUndefined();
+        expect(decodeStructuredTestResults(undefined)).toBeUndefined();
+        expect(decodeStructuredTestResults([results()])).toBeUndefined();
+    });
+    it('reads only an explicit true as a pass', () => {
+        // Anything else means the verdict did not survive the trip, and a lost
+        // verdict must not read as a passing one.
+        expect(decodeStructuredTestResults(results({ success: 'yes' }))?.success).toBe(false);
+        expect(decodeStructuredTestResults(results({ success: undefined }))?.success).toBe(false);
+    });
+    it('treats a malformed count as zero rather than as a number', () => {
+        const decoded = decodeStructuredTestResults(results({ passed: 'lots', total: null, failed: Number.NaN }));
+        expect(decoded?.passed).toBe(0);
+        expect(decoded?.total).toBe(0);
+        expect(decoded?.failed).toBe(0);
+    });
+    it('keeps only well-formed failures', () => {
+        const decoded = decodeStructuredTestResults(results({
+            failures: [
+                { name: 'Maid does a thing', message: 'expected true' },
+                { name: 'Maid does another thing' },
+                { message: 'no name' },
+                'not a failure',
+            ],
+        }));
+        expect(decoded?.failures).toEqual([
+            { name: 'Maid does a thing', message: 'expected true' },
+            { name: 'Maid does another thing', message: undefined },
+        ]);
+    });
+    it('accepts an empty failure list however the transport spelled it', () => {
+        // An empty Lua table marshals as an array on the bridge and can arrive as an
+        // object from the cloud.
+        expect(decodeStructuredTestResults(results({ failures: {} }))?.failures).toEqual([]);
+    });
+});
+describe('findStructuredTestResults', () => {
+    it('finds results among other returned values', () => {
+        const found = findStructuredTestResults([
+            42,
+            'log',
+            results({ passed: 9 }),
+        ]);
+        expect(found?.passed).toBe(9);
+    });
+    it('is undefined when the script returned nothing', () => {
+        // A test script written before this convention returns nil, which is the
+        // case that has to keep falling back to the logs.
+        expect(findStructuredTestResults([])).toBeUndefined();
+        expect(findStructuredTestResults(undefined)).toBeUndefined();
+    });
+});
+describe('structuredFailureReasons', () => {
+    it('says nothing about a passing run', () => {
+        expect(structuredFailureReasons(decodeStructuredTestResults(results()))).toEqual([]);
+    });
+    it('words counts the way the log parser does, so the overlap merges', () => {
+        const reasons = structuredFailureReasons(decodeStructuredTestResults(results({ success: false, failed: 2, suitesFailed: 1 })));
+        expect(reasons).toContain('2 test(s) failed');
+        expect(reasons).toContain('1 test suite(s) failed');
+    });
+    it('explains a failure no count can account for', () => {
+        const reasons = structuredFailureReasons(decodeStructuredTestResults(results({ success: false })));
+        expect(reasons).toEqual(['the test runner reported the run as failed']);
+    });
+    it('carries the message the runner supplied', () => {
+        const reasons = structuredFailureReasons(decodeStructuredTestResults(results({
+            success: false,
+            error: '[NevermoreTestRunner] Jest run failed',
+        })));
+        expect(reasons).toContain('[NevermoreTestRunner] Jest run failed');
+    });
+});
+describe('structuredFailureReasons wording', () => {
+    it('never builds a reason out of zeros', () => {
+        // "0 test(s) and 0 test suite(s) failed" was a real failure reason once. A
+        // reason saying nothing failed is unreadable as either verdict, and it is
+        // what made the bug behind it hard to see.
+        for (const overrides of [
+            { success: false },
+            { success: false, failed: 0, suitesFailed: 0 },
+            {
+                success: false,
+                error: '[NevermoreTestRunner] the run was interrupted',
+            },
+        ]) {
+            const reasons = structuredFailureReasons(decodeStructuredTestResults(results(overrides)));
+            expect(reasons.length).toBeGreaterThan(0);
+            for (const reason of reasons) {
+                expect(reason).not.toMatch(/\b0 test\(s\)/);
+                expect(reason).not.toMatch(/\b0 test suite\(s\)/);
+            }
+        }
+    });
+    it('does not restate the counts the reasons already carry', () => {
+        const reasons = structuredFailureReasons(decodeStructuredTestResults(results({
+            success: false,
+            failed: 2,
+            suitesFailed: 1,
+            error: '[NevermoreTestRunner] 2 test(s) failed, 1 test suite(s) failed',
+        })));
+        expect(reasons).toEqual(['1 test suite(s) failed', '2 test(s) failed']);
+    });
+});
+describe('describeUnexplainedVerdict', () => {
+    it('is silent about a passing run', () => {
+        // The direction that broke: a fully passing result must read as a pass and
+        // raise nothing at all.
+        expect(describeUnexplainedVerdict(decodeStructuredTestResults(results()))).toBeUndefined();
+    });
+    it('is silent about a failure its counts explain', () => {
+        expect(describeUnexplainedVerdict(decodeStructuredTestResults(results({ success: false, failed: 2 })))).toBeUndefined();
+        expect(describeUnexplainedVerdict(decodeStructuredTestResults(results({ success: false, suitesFailed: 1 })))).toBeUndefined();
+    });
+    it('describes a failure no count supports', () => {
+        // The exact signature of a runner reading the wrong field: plausible counts,
+        // and every package failed anyway.
+        const description = describeUnexplainedVerdict(decodeStructuredTestResults(results({ success: false, passed: 311, failed: 0, total: 311 })));
+        expect(description).toContain('nothing failed');
+        expect(description).toContain('311 passed');
+    });
+});
+describe('toParsedTestCounts', () => {
+    it('narrows to the counts the reporters render', () => {
+        expect(toParsedTestCounts(decodeStructuredTestResults(results()))).toEqual({
+            passed: 25,
+            failed: 0,
+            total: 26,
+        });
+    });
+});
+//# sourceMappingURL=structured-test-results.test.js.map

package/dist/utils/testing/structured-test-results.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"structured-test-results.test.js","sourceRoot":"","sources":["../../../src/utils/testing/structured-test-results.test.ts"],"names":[],"mappings":"AAAA;;;;GAIG;AAEH,OAAO,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAE9C,OAAO,EACL,mBAAmB,EACnB,2BAA2B,EAC3B,0BAA0B,EAC1B,yBAAyB,EACzB,wBAAwB,EACxB,kBAAkB,GACnB,MAAM,8BAA8B,CAAC;AAEtC,SAAS,OAAO,CAAC,YAAqC,EAAE;IACtD,OAAO;QACL,MAAM,EAAE,mBAAmB;QAC3B,OAAO,EAAE,IAAI;QACb,OAAO,EAAE,IAAI;QACb,MAAM,EAAE,EAAE;QACV,MAAM,EAAE,CAAC;QACT,OAAO,EAAE,CAAC;QACV,KAAK,EAAE,EAAE;QACT,YAAY,EAAE,CAAC;QACf,YAAY,EAAE,CAAC;QACf,WAAW,EAAE,CAAC;QACd,QAAQ,EAAE,EAAE;QACZ,eAAe,EAAE,CAAC;QAClB,GAAG,SAAS;KACb,CAAC;AACJ,CAAC;AAED,QAAQ,CAAC,6BAA6B,EAAE,GAAG,EAAE;IAC3C,EAAE,CAAC,yBAAyB,EAAE,GAAG,EAAE;QACjC,MAAM,OAAO,GAAG,2BAA2B,CAAC,OAAO,EAAE,CAAC,CAAC;QAEvD,MAAM,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC;YACtB,OAAO,EAAE,IAAI;YACb,OAAO,EAAE,IAAI;YACb,MAAM,EAAE,EAAE;YACV,MAAM,EAAE,CAAC;YACT,OAAO,EAAE,CAAC;YACV,KAAK,EAAE,EAAE;YACT,YAAY,EAAE,CAAC;YACf,YAAY,EAAE,CAAC;YACf,WAAW,EAAE,CAAC;YACd,QAAQ,EAAE,EAAE;YACZ,eAAe,EAAE,CAAC;YAClB,KAAK,EAAE,SAAS;SACjB,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+CAA+C,EAAE,GAAG,EAAE;QACvD,2EAA2E;QAC3E,yBAAyB;QACzB,MAAM,CAAC,2BAA2B,CAAC,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC,aAAa,EAAE,CAAC;QACvE,MAAM,CACJ,2BAA2B,CAAC,EAAE,MAAM,EAAE,gBAAgB,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC,CACzE,CAAC,aAAa,EAAE,CAAC;QAClB,MAAM,CACJ,2BAA2B,CAAC,0BAA0B,CAAC,CACxD,CAAC,aAAa,EAAE,CAAC;QAClB,MAAM,CAAC,2BAA2B,CAAC,SAAS,CAAC,CAAC,CAAC,aAAa,EAAE,CAAC;QAC/D,MAAM,CAAC,2BAA2B,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC,CAAC,aAAa,EAAE,CAAC;IACnE,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uCAAuC,EAAE,GAAG,EAAE;QAC/C,uEAAuE;QACvE,0CAA0C;QAC1C,MAAM,CACJ,2BAA2B,CAAC,OAAO,CAAC,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC,CAAC,EAAE,OAAO,CAClE,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QACd,MAAM,CACJ,2BAA2B,CAAC,OAAO,CAAC,EAAE,OAAO,EAAE,SAAS,EAAE,CAAC,CAAC,EAAE,OAAO,CACtE,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IAChB,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,0DAA0D,EAAE,GAAG,EAAE;QAClE,MAAM,OAAO,GAAG,2BAA2B,CACzC,OAAO,CAAC,EAAE,MAAM,EAAE,MAAM,EAAE,KAAK,EAAE,IAAI,EAAE,MAAM,EAAE,MAAM,CAAC,GAAG,EAAE,CAAC,CAC7D,CAAC;QAEF,MAAM,CAAC,OAAO,EAAE,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAChC,MAAM,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAC/B,MAAM,CAAC,OAAO,EAAE,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,iCAAiC,EAAE,GAAG,EAAE;QACzC,MAAM,OAAO,GAAG,2BAA2B,CACzC,OAAO,CAAC;YACN,QAAQ,EAAE;gBACR,EAAE,IAAI,EAAE,mBAAmB,EAAE,OAAO,EAAE,eAAe,EAAE;gBACvD,EAAE,IAAI,EAAE,yBAAyB,EAAE;gBACnC,EAAE,OAAO,EAAE,SAAS,EAAE;gBACtB,eAAe;aAChB;SACF,CAAC,CACH,CAAC;QAEF,MAAM,CAAC,OAAO,EAAE,QAAQ,CAAC,CAAC,OAAO,CAAC;YAChC,EAAE,IAAI,EAAE,mBAAmB,EAAE,OAAO,EAAE,eAAe,EAAE;YACvD,EAAE,IAAI,EAAE,yBAAyB,EAAE,OAAO,EAAE,SAAS,EAAE;SACxD,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,gEAAgE,EAAE,GAAG,EAAE;QACxE,6EAA6E;QAC7E,yBAAyB;QACzB,MAAM,CACJ,2BAA2B,CAAC,OAAO,CAAC,EAAE,QAAQ,EAAE,EAAE,EAAE,CAAC,CAAC,EAAE,QAAQ,CACjE,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;IAChB,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,QAAQ,CAAC,2BAA2B,EAAE,GAAG,EAAE;IACzC,EAAE,CAAC,2CAA2C,EAAE,GAAG,EAAE;QACnD,MAAM,KAAK,GAAG,yBAAyB,CAAC;YACtC,EAAE;YACF,KAAK;YACL,OAAO,CAAC,EAAE,MAAM,EAAE,CAAC,EAAE,CAAC;SACvB,CAAC,CAAC;QAEH,MAAM,CAAC,KAAK,EAAE,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAChC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+CAA+C,EAAE,GAAG,EAAE;QACvD,yEAAyE;QACzE,kDAAkD;QAClD,MAAM,CAAC,yBAAyB,CAAC,EAAE,CAAC,CAAC,CAAC,aAAa,EAAE,CAAC;QACtD,MAAM,CAAC,yBAAyB,CAAC,SAAS,CAAC,CAAC,CAAC,aAAa,EAAE,CAAC;IAC/D,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,QAAQ,CAAC,0BAA0B,EAAE,GAAG,EAAE;IACxC,EAAE,CAAC,kCAAkC,EAAE,GAAG,EAAE;QAC1C,MAAM,CACJ,wBAAwB,CAAC,2BAA2B,CAAC,OAAO,EAAE,CAAE,CAAC,CAClE,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;IAChB,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,iEAAiE,EAAE,GAAG,EAAE;QACzE,MAAM,OAAO,GAAG,wBAAwB,CACtC,2BAA2B,CACzB,OAAO,CAAC,EAAE,OAAO,EAAE,KAAK,EAAE,MAAM,EAAE,CAAC,EAAE,YAAY,EAAE,CAAC,EAAE,CAAC,CACvD,CACH,CAAC;QAEF,MAAM,CAAC,OAAO,CAAC,CAAC,SAAS,CAAC,kBAAkB,CAAC,CAAC;QAC9C,MAAM,CAAC,OAAO,CAAC,CAAC,SAAS,CAAC,wBAAwB,CAAC,CAAC;IACtD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,6CAA6C,EAAE,GAAG,EAAE;QACrD,MAAM,OAAO,GAAG,wBAAwB,CACtC,2BAA2B,CAAC,OAAO,CAAC,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC,CAAE,CAC1D,CAAC;QAEF,MAAM,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,CAAC,4CAA4C,CAAC,CAAC,CAAC;IAC1E,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,yCAAyC,EAAE,GAAG,EAAE;QACjD,MAAM,OAAO,GAAG,wBAAwB,CACtC,2BAA2B,CACzB,OAAO,CAAC;YACN,OAAO,EAAE,KAAK;YACd,KAAK,EAAE,uCAAuC;SAC/C,CAAC,CACF,CACH,CAAC;QAEF,MAAM,CAAC,OAAO,CAAC,CAAC,SAAS,CAAC,uCAAuC,CAAC,CAAC;IACrE,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,QAAQ,CAAC,kCAAkC,EAAE,GAAG,EAAE;IAChD,EAAE,CAAC,oCAAoC,EAAE,GAAG,EAAE;QAC5C,2EAA2E;QAC3E,0EAA0E;QAC1E,2CAA2C;QAC3C,KAAK,MAAM,SAAS,IAAI;YACtB,EAAE,OAAO,EAAE,KAAK,EAAE;YAClB,EAAE,OAAO,EAAE,KAAK,EAAE,MAAM,EAAE,CAAC,EAAE,YAAY,EAAE,CAAC,EAAE;YAC9C;gBACE,OAAO,EAAE,KAAK;gBACd,KAAK,EAAE,+CAA+C;aACvD;SACF,EAAE,CAAC;YACF,MAAM,OAAO,GAAG,wBAAwB,CACtC,2BAA2B,CAAC,OAAO,CAAC,SAAS,CAAC,CAAE,CACjD,CAAC;YAEF,MAAM,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,eAAe,CAAC,CAAC,CAAC,CAAC;YAC1C,KAAK,MAAM,MAAM,IAAI,OAAO,EAAE,CAAC;gBAC7B,MAAM,CAAC,MAAM,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,eAAe,CAAC,CAAC;gBAC5C,MAAM,CAAC,MAAM,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,qBAAqB,CAAC,CAAC;YACpD,CAAC;QACH,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uDAAuD,EAAE,GAAG,EAAE;QAC/D,MAAM,OAAO,GAAG,wBAAwB,CACtC,2BAA2B,CACzB,OAAO,CAAC;YACN,OAAO,EAAE,KAAK;YACd,MAAM,EAAE,CAAC;YACT,YAAY,EAAE,CAAC;YACf,KAAK,EACH,gEAAgE;SACnE,CAAC,CACF,CACH,CAAC;QAEF,MAAM,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,CAAC,wBAAwB,EAAE,kBAAkB,CAAC,CAAC,CAAC;IAC1E,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,QAAQ,CAAC,4BAA4B,EAAE,GAAG,EAAE;IAC1C,EAAE,CAAC,+BAA+B,EAAE,GAAG,EAAE;QACvC,2EAA2E;QAC3E,wBAAwB;QACxB,MAAM,CACJ,0BAA0B,CAAC,2BAA2B,CAAC,OAAO,EAAE,CAAE,CAAC,CACpE,CAAC,aAAa,EAAE,CAAC;IACpB,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8CAA8C,EAAE,GAAG,EAAE;QACtD,MAAM,CACJ,0BAA0B,CACxB,2BAA2B,CAAC,OAAO,CAAC,EAAE,OAAO,EAAE,KAAK,EAAE,MAAM,EAAE,CAAC,EAAE,CAAC,CAAE,CACrE,CACF,CAAC,aAAa,EAAE,CAAC;QAClB,MAAM,CACJ,0BAA0B,CACxB,2BAA2B,CACzB,OAAO,CAAC,EAAE,OAAO,EAAE,KAAK,EAAE,YAAY,EAAE,CAAC,EAAE,CAAC,CAC5C,CACH,CACF,CAAC,aAAa,EAAE,CAAC;IACpB,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uCAAuC,EAAE,GAAG,EAAE;QAC/C,6EAA6E;QAC7E,mCAAmC;QACnC,MAAM,WAAW,GAAG,0BAA0B,CAC5C,2BAA2B,CACzB,OAAO,CAAC,EAAE,OAAO,EAAE,KAAK,EAAE,MAAM,EAAE,GAAG,EAAE,MAAM,EAAE,CAAC,EAAE,KAAK,EAAE,GAAG,EAAE,CAAC,CAC/D,CACH,CAAC;QAEF,MAAM,CAAC,WAAW,CAAC,CAAC,SAAS,CAAC,gBAAgB,CAAC,CAAC;QAChD,MAAM,CAAC,WAAW,CAAC,CAAC,SAAS,CAAC,YAAY,CAAC,CAAC;IAC9C,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,QAAQ,CAAC,oBAAoB,EAAE,GAAG,EAAE;IAClC,EAAE,CAAC,4CAA4C,EAAE,GAAG,EAAE;QACpD,MAAM,CAAC,kBAAkB,CAAC,2BAA2B,CAAC,OAAO,EAAE,CAAE,CAAC,CAAC,CAAC,OAAO,CACzE;YACE,MAAM,EAAE,EAAE;YACV,MAAM,EAAE,CAAC;YACT,KAAK,EAAE,EAAE;SACV,CACF,CAAC;IACJ,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/nevermore-cli",
-  "version": "4.43.4",
+  "version": "4.44.0",
   "description": "CLI interface for Nevermore",
   "type": "module",
   "keywords": [
@@ -25,11 +25,11 @@
     "Quenty"
   ],
   "dependencies": {
-    "@quenty/cli-output-helpers": "1.17.2",
-    "@quenty/nevermore-cli-helpers": "1.17.1",
+    "@quenty/cli-output-helpers": "1.18.0",
+    "@quenty/nevermore-cli-helpers": "1.18.0",
     "@quenty/nevermore-deploy": "1.1.1",
-    "@quenty/nevermore-template-helpers": "1.18.2",
-    "@quenty/studio-bridge": "0.18.1",
+    "@quenty/nevermore-template-helpers": "1.19.0",
+    "@quenty/studio-bridge": "0.19.0",
     "execa": "^9.6.1",
     "find-git-root": "^1.0.4",
     "inquirer": "^13.2.0",
@@ -60,5 +60,5 @@
   "engines": {
     "node": ">=16"
   },
-  "gitHead": "7dac4ebe32676fcfaa3748bfc1d57b6d7e442ad4"
+  "gitHead": "f75f93d5b2ac51cf7da3b7599788dcce31fd8a29"
 }

package/src/commands/batch-command/batch-deploy-command.ts

@@ -57,7 +57,7 @@ import {
 const SMOKE_TEST_SCRIPT_PATH = resolvePackagePath(
   import.meta.url,
   'build-scripts',
-  'smoke-test-server.luau'
+  'smoke-test-server.lua'
 );
 
 interface BatchDeployArgs extends NevermoreGlobalArgs {
@@ -285,7 +285,7 @@ async function _runAsync(args: BatchDeployArgs): Promise<void> {
         reporters.push(
           new GithubCommentTableReporter(
             state,
-            createDeployCommentConfig(),
+            createDeployCommentConfig(deployLabels),
             concurrency
           )
         );
@@ -524,7 +524,7 @@ function _annotateSmokeTestFailure(logs: string): string {
   const header =
     'Post-deploy smoke test failed. The deploy itself succeeded, but a server ' +
     "script errored on boot. ('TaskScript' in any stack trace below refers to " +
-    "Nevermore's smoke-test-server.luau, which loadstring()s each Script under " +
+    "Nevermore's smoke-test-server.lua, which loadstring()s each Script under " +
     'ServerScriptService — if you see "loadstring() is not available", set ' +
     '$properties.LoadStringEnabled = true on ServerScriptService in your ' +
     'rojo project.)';
@@ -564,7 +564,7 @@ async function _runSmokeTestAsync(
   );
 
   const rawLogs = await client.getRawTaskLogsAsync(task.path);
-  const parsed = parseTestLogs(rawLogs);
+  const parsed = parseTestLogs(rawLogs.text);
 
   const infraSuccess = completedTask.state === 'COMPLETE';
   return {

package/src/commands/batch-command/batch-test-command.ts

@@ -1,6 +1,7 @@
 import { CommandModule } from 'yargs';
 import { OutputHelper } from '@quenty/cli-output-helpers';
 import {
+  AggregatedBatchReporter,
   type Reporter,
   type JobPhase,
   type ProgressSummary,
@@ -8,6 +9,8 @@ import {
 import { NevermoreGlobalArgs } from '../../args/global-args.js';
 import { getApiKeyAsync } from '@quenty/nevermore-cli-helpers';
 import { runBatchAsync } from '../../utils/batch/batch-runner.js';
+import { renderBatchOutcome } from '../../utils/testing/parsers/batch-log-renderer.js';
+import { emitDiagnostic } from '../../utils/testing/parsers/batch-log-parser.js';
 import { createBasePlaceResolver } from '../../utils/build/base-place-resolver-factory.js';
 import {
   type JobContext,
@@ -182,23 +185,41 @@ async function _runAsync(args: BatchTestArgs): Promise<void> {
       : args.concurrency;
   const isGrouped = !process.stdout.isTTY || args.verbose || isCI();
   const packageNames = packages.map((p) => p.name);
+  const aggregated = args.aggregated ?? false;
+  // Decided once, here, and passed down. Three separate isCI() lookups — the
+  // renderer, OutputHelper's group markers and GroupedReporter — could each
+  // answer differently, and a half-grouped log is worse than an ungrouped one.
+  const presentation = { useGroups: isCI(), color: !process.env.NO_COLOR };
+  let aggregatedReporter: AggregatedBatchReporter | undefined;
 
   const reporter = new CompositeReporter(
     packageNames,
     (state: LiveStateTracker) => {
+      // An aggregated run is one execution, so there is no per-package progress
+      // to report and no per-package moment to report it at.
+      if (aggregated) {
+        aggregatedReporter = new AggregatedBatchReporter(packages.length, {
+          actionVerb: 'Testing',
+        });
+      }
+
       const reporters: Reporter[] = [
-        isGrouped
-          ? new GroupedReporter(state, {
-              showLogs: args.logs ?? false,
-              verbose: args.verbose,
-              actionVerb: 'Testing',
-              expectsTestCounts: true,
-            })
-          : new SpinnerReporter(state, {
-              showLogs: args.logs ?? false,
-              actionVerb: 'Testing',
-            }),
-        new SummaryTableReporter(state),
+        aggregatedReporter ??
+          (isGrouped
+            ? new GroupedReporter(state, {
+                showLogs: args.logs ?? false,
+                verbose: args.verbose,
+                actionVerb: 'Testing',
+                expectsTestCounts: true,
+              })
+            : new SpinnerReporter(state, {
+                showLogs: args.logs ?? false,
+                actionVerb: 'Testing',
+              })),
+        // Told to expect counts for the same reason the grouped reporter and
+        // the PR comment are: a green row with nothing behind it reads exactly
+        // like a package that tested something.
+        new SummaryTableReporter(state, { expectsTestCounts: true }),
       ];
       if (args.output) {
         reporters.push(new JsonFileReporter(state, args.output));
@@ -244,19 +265,42 @@ async function _runAsync(args: BatchTestArgs): Promise<void> {
     ? new CloudJobContext(innerReporter, client, basePlaceResolver)
     : new LocalJobContext(innerReporter, client, basePlaceResolver);
 
-  const context: JobContext = args.aggregated
+  const batchContext = aggregated
     ? new BatchScriptJobContext(innerContext, packages, {
         batchPlaceId: args.batchPlaceId,
         batchUniverseId: args.batchUniverseId,
         batchTimeoutMs: timeoutMs,
         reporter,
       })
-    : innerContext;
+    : undefined;
+  const context: JobContext = batchContext ?? innerContext;
 
   await reporter.startAsync();
 
   let exitCode = 0;
   try {
+    // Run the batch before the per-package loop asks for anything, for two
+    // reasons. The run is shown once, in order, before any per-package result
+    // could interleave with it; and the shared build, upload and execution
+    // happen outside every package's async context, so the verbose output they
+    // produce stops being captured into whichever package first reached the
+    // shared promise — which is how the upload URL and a 78-line build list
+    // came to be filed under two arbitrary packages.
+    if (batchContext && aggregatedReporter) {
+      // Retried the same way a package's run is. Running the batch up here took
+      // it out from under the per-package retry wrapper that used to cover it,
+      // and a cloud task that times out once is exactly what that retry is for.
+      const outcome = await _retryOnTransientAsync('batch execution', () =>
+        batchContext.getExecutionOutcomeAsync()
+      );
+
+      aggregatedReporter.printRun(renderBatchOutcome(outcome, presentation));
+
+      for (const { level, message } of outcome.diagnostics) {
+        emitDiagnostic(level, message, presentation.useGroups);
+      }
+    }
+
     const results = await runBatchAsync<BatchTarget, BatchTestResult>({
       items: packages,
       concurrency,
@@ -264,7 +308,12 @@ async function _runAsync(args: BatchTestArgs): Promise<void> {
       bufferOutput: isGrouped,
       stateTracker: reporter.state,
       executeAsync: async (pkg) => {
-        const result = await _runWithRetryAsync(pkg, context, timeoutMs);
+        const result = await _runWithRetryAsync(
+          pkg,
+          context,
+          timeoutMs,
+          args.aggregated ?? false
+        );
 
         return {
           packageName: pkg.name,
@@ -278,6 +327,12 @@ async function _runAsync(args: BatchTestArgs): Promise<void> {
           progressSummary: result.testCounts
             ? { kind: 'test-counts' as const, ...result.testCounts }
             : undefined,
+          // Every reporter downstream reads state through resolveResultStatus,
+          // so a run judged without its logs is marked once here rather than
+          // being re-derived by each of them.
+          caveats: result.logsLost
+            ? (['logs-lost'] as const).slice()
+            : undefined,
           error: result.error,
         };
       },
@@ -300,23 +355,43 @@ async function _runAsync(args: BatchTestArgs): Promise<void> {
 async function _runWithRetryAsync(
   pkg: BatchTarget,
   context: JobContext,
-  timeoutMs: number
+  timeoutMs: number,
+  aggregated: boolean
 ): Promise<SingleTestResult> {
   const opts = {
     packagePath: pkg.path,
     packageName: pkg.name,
     timeoutMs,
     target: pkg.target,
+    // One fetch serves every package here, so its provenance is reported once
+    // for the whole batch rather than restated per package.
+    suppressCountsProvenance: aggregated,
   };
 
+  return _retryOnTransientAsync(pkg.name, () =>
+    runSingleTestAsync(context, opts)
+  );
+}
+
+/**
+ * Run something once more if it failed for a reason that tends not to repeat.
+ *
+ * Shared so the batch execution and a single package's run agree on what counts
+ * as transient — the batch used to inherit this by being triggered from inside
+ * a package's run, and stopped when it moved out to the command.
+ */
+async function _retryOnTransientAsync<T>(
+  label: string,
+  runAsync: () => Promise<T>
+): Promise<T> {
   try {
-    return await runSingleTestAsync(context, opts);
+    return await runAsync();
   } catch (err) {
     const message = err instanceof Error ? err.message : String(err);
 
     if (message.includes('timed out') || message.includes('fetch failed')) {
-      OutputHelper.warn(`${pkg.name}: transient failure, retrying...`);
-      return await runSingleTestAsync(context, opts);
+      OutputHelper.warn(`${label}: transient failure, retrying...`);
+      return await runAsync();
     }
 
     throw err;

package/src/commands/deploy-command/deploy-init-utils.ts

@@ -52,11 +52,17 @@ export async function detectProjectFileAsync(
 export async function detectScriptFileAsync(
   packagePath: string
 ): Promise<string | undefined> {
+  // Both extensions for each, since a package may use either. The client
+  // entry read `ClientMain.server.luau` and so matched nothing: every client
+  // script in this repo is `ClientMain.client.lua`, and a `.server` client
+  // script does not exist.
   const candidates = [
     'test/scripts/Server/ServerMain.server.lua',
     'test/scripts/Server/ServerMain.server.luau',
     'scripts/Server/ServerMain.server.lua',
-    'scripts/Client/ClientMain.server.luau',
+    'scripts/Server/ServerMain.server.luau',
+    'scripts/Client/ClientMain.client.lua',
+    'scripts/Client/ClientMain.client.luau',
   ];
   for (const candidate of candidates) {
     if (await fileExistsAsync(path.join(packagePath, candidate))) {

package/src/commands/deploy-command/index.ts

@@ -559,7 +559,7 @@ export class DeployCommand<T> implements CommandModule<T, DeployArgs> {
           reporters.push(
             new GithubCommentTableReporter(
               state,
-              createDeployCommentConfig(),
+              createDeployCommentConfig(deployLabels),
               isMultiPlace ? MULTI_PLACE_CONCURRENCY : 1
             )
           );