@quenty/loader 10.6.0 → 10.7.0

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [10.7.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/loader@10.6.0...@quenty/loader@10.7.0) (2024-10-06)
+
+
+### Bug Fixes
+
+* Replicator replicates attributes and tags properly ([3c7f020](https://github.com/Quenty/NevermoreEngine/commit/3c7f020c61a0c378ef84f8a49dcd7f070ec2c6c5))
+
+
+
+
+
 # [10.6.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/loader@10.5.0...@quenty/loader@10.6.0) (2024-10-04)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/loader",
-  "version": "10.6.0",
+  "version": "10.7.0",
   "description": "A simple module loader for Roblox",
   "keywords": [
     "Roblox",
@@ -26,5 +26,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "035abfa088c854a73e1c65b350267eaa17669646"
+  "gitHead": "67c5dbf46f6f45213812f3f117419a5534936a0b"
 }

package/src/Maid.lua

@@ -18,6 +18,7 @@
 	maid:DoCleaning()
 	```
 
+	@ignore
 	@class Maid
 ]]
 -- luacheck: pop
@@ -32,6 +33,7 @@ Maid.ClassName = "Maid"
 	local maid = Maid.new()
 	```
 
+	@ignore
 	@return Maid
 ]=]
 function Maid.new()
@@ -48,6 +50,7 @@ end
 	print(Maid.isMaid(nil)) --> false
 	```
 
+	@ignore
 	@param value any
 	@return boolean
 ]=]
@@ -67,6 +70,7 @@ end
 	print(maid._current) --> nil
 	```
 
+	@ignore
 	@param index any
 	@return MaidTask
 ]=]
@@ -94,6 +98,7 @@ end
 	Maid[key] = nil                Removes a named task.
 	```
 
+	@ignore
 	@param index any
 	@param newTask MaidTask
 ]=]
@@ -143,6 +148,7 @@ end
 --[=[
 	Gives a task to the maid for cleanup and returns the resulting value
 
+	@ignore
 	@param task MaidTask -- An item to clean
 	@return MaidTask
 ]=]
@@ -163,6 +169,7 @@ end
 --[=[
 	Gives a task to the maid for cleanup, but uses an incremented number as a key.
 
+	@ignore
 	@param task MaidTask -- An item to clean
 	@return number -- taskId
 ]=]
@@ -184,6 +191,7 @@ end
 --[=[
 	Gives a promise to the maid for clean.
 
+	@ignore
 	@param promise Promise<T>
 	@return Promise<T>
 ]=]
@@ -218,6 +226,8 @@ end
 	However, adding tasks while cleaning is not generally a good idea, as if you add a
 	function that adds itself, this will loop indefinitely.
 	:::
+
+	@ignore
 ]=]
 function Maid:DoCleaning()
 	local tasks = self._tasks
@@ -265,6 +275,7 @@ end
 --[=[
 	Alias for [Maid.DoCleaning()](/api/Maid#DoCleaning)
 
+	@ignore
 	@function Destroy
 	@within Maid
 ]=]

package/src/Replication/Replicator.lua

@@ -307,6 +307,7 @@ function Replicator:_doStandardReplication(maid, replicator, child, copy)
 	assert(typeof(child) == "Instance", "Bad child")
 
 	self:_setupAttributeReplication(maid, child, copy)
+	self:_setupTagReplication(maid, child, copy)
 	self:_setupNameReplication(maid, child, copy)
 	self:_setupParentReplication(maid, copy)
 	self:_setupReference(maid, child, copy)
@@ -467,6 +468,44 @@ function Replicator:_setupParentReplication(maid, copy)
 	copy.Parent = self._target.Value
 end
 
+--[[
+	Sets up tag replication explicitly.
+
+	@param maid Maid
+	@param child Instance
+	@param copy Instance
+]]
+function Replicator:_setupTagReplication(maid, child, copy)
+	assert(Maid.isMaid(maid), "Bad maid")
+	assert(typeof(child) == "Instance", "Bad child")
+	assert(typeof(copy) == "Instance", "Bad copy")
+
+	for _, tag in pairs(child:GetTags()) do
+		copy:AddTag(tag)
+	end
+
+	maid:GiveTask(child.Changed:Connect(function(property)
+		if property == "Tags" then
+			local ourTagSet = {}
+			for _, tag in pairs(copy:GetTags()) do
+				ourTagSet[tag] = true
+			end
+
+			for _, tag in pairs(child:GetTags()) do
+				if not ourTagSet[tag] then
+					copy:AddTag(tag)
+				end
+
+				ourTagSet[tag] = nil
+			end
+
+			for tag, _ in pairs(ourTagSet) do
+				copy:RemoveTag(tag)
+			end
+		end
+	end))
+end
+
 --[[
 	Sets up the object value replication to point towards new values.
 
@@ -528,7 +567,7 @@ end
 
 function Replicator:_setupAttributeReplication(maid, child, copy)
 	for key, value in pairs(child:GetAttributes()) do
-		child:SetAttribute(key, value)
+		copy:SetAttribute(key, value)
 	end
 
 	maid:GiveTask(child.AttributeChanged:Connect(function(attribute)

package/src/init.lua

@@ -148,7 +148,11 @@ function Loader:_findDependency(request)
 	-- Just standard dependency search
 	local foundBackup = DependencyUtils.findDependency(self._packages, request, self._replicationType)
 	if foundBackup then
-		warn(string.format("[Loader] - Failed to find package %q in package tracker of root %s\n%s", request, self._packages:GetFullName(), debug.traceback()))
+		if packageTracker then
+			warn(string.format("[Loader] - No package tracker for root %s (while loading %s)\n%s", self._packages:GetFullName(), request, debug.traceback()))
+		else
+			warn(string.format("[Loader] - Failed to find package %q in package tracker of root %s\n%s", request, self._packages:GetFullName(), debug.traceback()))
+		end
 
 		-- Ensure hoarcekat story has a link to use
 		-- TODO: Maybe add to global package cache instead...