@quenty/gameconfig 6.3.1 → 6.4.0

package/CHANGELOG.md

@@ -3,6 +3,23 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [6.4.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/gameconfig@6.3.1...@quenty/gameconfig@6.4.0) (2023-12-14)
+
+
+### Bug Fixes
+
+* Fix dependencies ([11beb58](https://github.com/Quenty/NevermoreEngine/commit/11beb582b2d238abb077399fd1c59dea1c9ac90f))
+
+
+### Features
+
+* Can provide translated cloud description for badges ([5a899e7](https://github.com/Quenty/NevermoreEngine/commit/5a899e77a937bc5cf424af32e03b9240ed639f76))
+* Provider better formatted errors when prompting ([702e538](https://github.com/Quenty/NevermoreEngine/commit/702e5381c2981b6b57ba73882c7d9bc07740e99e))
+
+
+
+
+
 ## [6.3.1](https://github.com/Quenty/NevermoreEngine/compare/@quenty/gameconfig@6.3.0...@quenty/gameconfig@6.3.1) (2023-10-28)
 
 **Note:** Version bump only for package @quenty/gameconfig

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/gameconfig",
-  "version": "6.3.1",
+  "version": "6.4.0",
   "description": "Configuration service to specify Roblox badges, products, and other specific assets.",
   "keywords": [
     "Roblox",
@@ -27,30 +27,31 @@
     "access": "public"
   },
   "dependencies": {
-    "@quenty/attributeutils": "^9.1.1",
-    "@quenty/badgeutils": "^7.0.0",
-    "@quenty/baseobject": "^7.0.0",
-    "@quenty/binder": "^9.1.1",
-    "@quenty/brio": "^9.1.1",
-    "@quenty/clienttranslator": "^9.1.1",
-    "@quenty/cmdrservice": "^8.2.1",
-    "@quenty/instanceutils": "^8.1.1",
-    "@quenty/loader": "^7.0.0",
+    "@quenty/attributeutils": "^9.2.0",
+    "@quenty/badgeutils": "^7.1.0",
+    "@quenty/baseobject": "^7.1.0",
+    "@quenty/binder": "^9.2.0",
+    "@quenty/brio": "^9.2.0",
+    "@quenty/clienttranslator": "^9.2.0",
+    "@quenty/cmdrservice": "^8.3.0",
+    "@quenty/instanceutils": "^8.2.0",
+    "@quenty/loader": "^7.1.0",
     "@quenty/maid": "^2.6.0",
-    "@quenty/marketplaceutils": "^7.0.0",
-    "@quenty/observablecollection": "^6.2.1",
-    "@quenty/preferredparentutils": "^4.0.0",
-    "@quenty/promise": "^7.0.0",
+    "@quenty/marketplaceutils": "^7.1.0",
+    "@quenty/observablecollection": "^6.3.0",
+    "@quenty/playerutils": "^3.3.0",
+    "@quenty/preferredparentutils": "^4.1.0",
+    "@quenty/promise": "^7.1.0",
     "@quenty/pseudolocalize": "^3.2.0",
-    "@quenty/remotefunctionutils": "^7.0.0",
-    "@quenty/remoting": "^7.1.1",
-    "@quenty/rx": "^8.1.1",
-    "@quenty/rxbinderutils": "^9.1.1",
-    "@quenty/servicebag": "^7.0.0",
-    "@quenty/statestack": "^9.1.1",
+    "@quenty/remotefunctionutils": "^7.1.0",
+    "@quenty/remoting": "^7.2.0",
+    "@quenty/rx": "^8.2.0",
+    "@quenty/rxbinderutils": "^9.2.0",
+    "@quenty/servicebag": "^7.1.0",
+    "@quenty/statestack": "^9.2.0",
     "@quenty/string": "^3.1.0",
-    "@quenty/table": "^3.3.0",
-    "@quenty/valueobject": "^8.1.1"
+    "@quenty/table": "^3.4.0",
+    "@quenty/valueobject": "^8.2.0"
   },
-  "gitHead": "440aca7ce2b50b74317ee05fdc0b8d1e58001af3"
+  "gitHead": "2c2dbbc0cb2fbb46b4f3270c559c63890fe18b26"
 }

package/src/Server/Cmdr/GameConfigCommandService.lua

@@ -10,6 +10,7 @@ local TeleportService = game:GetService("TeleportService")
 
 local GameConfigCmdrUtils = require("GameConfigCmdrUtils")
 local BadgeUtils = require("BadgeUtils")
+local PlayerUtils = require("PlayerUtils")
 
 local GameConfigCommandService = {}
 GameConfigCommandService.ServiceName = "GameConfigCommandService"
@@ -57,11 +58,11 @@ function GameConfigCommandService:_registerCommands()
 		for _, player in pairs(players) do
 			for _, badgeId in pairs(badgeIds) do
 				BadgeUtils.promiseAwardBadge(player, badgeId)
-				table.insert(givenTo, ("%s badge %d"):format(player.DisplayName, badgeId))
+				table.insert(givenTo, string.format("%s badge %d", PlayerUtils.formatName(player), badgeId))
 			end
 		end
 
-		return ("Awards: %s"):format(table.concat(givenTo, ", "))
+		return string.format("Awards: %s", table.concat(givenTo, ", "))
 	end)
 
 	self._cmdrService:RegisterCommand({
@@ -85,10 +86,10 @@ function GameConfigCommandService:_registerCommands()
 
 		for _, player in pairs(players) do
 			MarketplaceService:PromptProductPurchase(player, productId)
-			table.insert(givenTo, ("%s prompted purchase of %d"):format(player.DisplayName, productId))
+			table.insert(givenTo, string.format("%s prompted purchase of %d", PlayerUtils.formatName(player), productId))
 		end
 
-		return ("Prompted: %s"):format(table.concat(givenTo, ", "))
+		return string.format("Prompted: %s", table.concat(givenTo, ", "))
 	end)
 
 	self._cmdrService:RegisterCommand({
@@ -112,10 +113,10 @@ function GameConfigCommandService:_registerCommands()
 
 		for _, player in pairs(players) do
 			MarketplaceService:PromptGamePassPurchase(player, gamePassId)
-			table.insert(givenTo, ("%s prompted purchase of %d"):format(player.DisplayName, gamePassId))
+			table.insert(givenTo, string.format("%s prompted purchase of %d", PlayerUtils.formatName(player), gamePassId))
 		end
 
-		return ("Prompted: %s"):format(table.concat(givenTo, ", "))
+		return string.format("Prompted: %s", table.concat(givenTo, ", "))
 	end)
 
 	self._cmdrService:RegisterCommand({
@@ -139,10 +140,10 @@ function GameConfigCommandService:_registerCommands()
 
 		for _, player in pairs(players) do
 			MarketplaceService:PromptPurchase(player, assetId)
-			table.insert(givenTo, ("%s prompted purchase of %d"):format(player.DisplayName, assetId))
+			table.insert(givenTo, string.format("%s prompted purchase of %d", PlayerUtils.formatName(player), assetId))
 		end
 
-		return ("Prompted: %s"):format(table.concat(givenTo, ", "))
+		return string.format("Prompted: %s", table.concat(givenTo, ", "))
 	end)
 
 	self._cmdrService:RegisterCommand({
@@ -166,10 +167,10 @@ function GameConfigCommandService:_registerCommands()
 
 		for _, player in pairs(players) do
 			MarketplaceService:PromptBundlePurchase(player, bundleId)
-			table.insert(givenTo, ("%s prompted purchase of %d"):format(player.DisplayName, bundleId))
+			table.insert(givenTo, string.format("%s prompted purchase of %d", PlayerUtils.formatName(player), bundleId))
 		end
 
-		return ("Prompted: %s"):format(table.concat(givenTo, ", "))
+		return string.format("Prompted: %s", table.concat(givenTo, ", "))
 	end)
 
 	self._cmdrService:RegisterCommand({

package/src/Shared/Config/Asset/GameConfigAssetBase.lua

@@ -189,7 +189,7 @@ end
 	@return Observable<string?>
 ]=]
 function GameConfigAssetBase:ObserveCloudName()
-	return self:_observeCloudProperty("Name", "string")
+	return self:_observeCloudProperty({ "Name" }, "string")
 end
 
 --[=[
@@ -198,7 +198,7 @@ end
 	@return Observable<string?>
 ]=]
 function GameConfigAssetBase:ObserveCloudDescription()
-	return self:_observeCloudProperty("Description", "string")
+	return self:_observeCloudProperty({ "Description" }, "string")
 end
 
 --[=[
@@ -206,27 +206,31 @@ end
 	@return Observable<number?>
 ]=]
 function GameConfigAssetBase:ObserveCloudPriceInRobux()
-	return self:_observeCloudProperty("PriceInRobux", "number")
+	return self:_observeCloudProperty({ "PriceInRobux" }, "number")
 end
 
 --[=[
 	@return Observable<number?>
 ]=]
 function GameConfigAssetBase:ObserveCloudIconImageAssetId()
-	return self:_observeCloudProperty("IconImageAssetId", "number")
+	return self:_observeCloudProperty({ "IconImageAssetId", "IconImageId" }, "number")
 end
 
-function GameConfigAssetBase:_observeCloudProperty(propertyName, expectedType)
-	assert(type(propertyName) == "string", "Bad propertyName")
+function GameConfigAssetBase:_observeCloudProperty(propertyNameList, expectedType)
+	assert(type(propertyNameList) == "table", "Bad propertyNameList")
 	assert(type(expectedType) == "string", "Bad expectedType")
 
 	return self:_observeCloudDataFromState():Pipe({
 		Rx.map(function(data)
 			if type(data) == "table" then
-				local result = data[propertyName]
-				if type(result) == expectedType then
-					return result
+				for _, propertyName in pairs(propertyNameList) do
+					local result = data[propertyName]
+					if type(result) == expectedType then
+						return result
+					end
 				end
+
+				return nil
 			else
 				return nil
 			end