@quenty/friendutils 12.41.0 → 12.42.1

package/CHANGELOG.md

@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [12.42.1](https://github.com/Quenty/NevermoreEngine/compare/@quenty/friendutils@12.42.0...@quenty/friendutils@12.42.1) (2026-09-03)
+
+**Note:** Version bump only for package @quenty/friendutils
+
+# [12.42.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/friendutils@12.41.0...@quenty/friendutils@12.42.0) (2026-09-02)
+
+**Note:** Version bump only for package @quenty/friendutils
+
 # [12.41.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/friendutils@12.40.0...@quenty/friendutils@12.41.0) (2026-08-28)
 
 **Note:** Version bump only for package @quenty/friendutils

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/friendutils",
-  "version": "12.41.0",
+  "version": "12.42.1",
   "description": "Utlity functions to help find friends of a user. Also contains utility to make testing in studio easier.",
   "keywords": [
     "Roblox",
@@ -29,12 +29,12 @@
   ],
   "dependencies": {
     "@quenty/brio": "14.37.0",
-    "@quenty/coreguiutils": "10.25.0",
+    "@quenty/coreguiutils": "10.26.1",
     "@quenty/loader": "10.11.1",
     "@quenty/maid": "3.12.0",
     "@quenty/nevermore-test-runner": "1.6.0",
     "@quenty/pagesutils": "5.25.0",
-    "@quenty/playermock": "1.8.0",
+    "@quenty/playermock": "1.9.1",
     "@quenty/promise": "10.24.0",
     "@quenty/rx": "13.34.0",
     "@quentystudios/jest-lua": "3.10.0-quenty.2"
@@ -42,5 +42,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "346201e192e467cb71160f43029863853be855b5"
+  "gitHead": "76bd184d0b68008d8fbc9e5d07b12f28eeab21f5"
 }

package/src/Shared/FriendUtils.lua

@@ -118,7 +118,7 @@ function FriendUtils.promiseFriendPages(userId: number): Promise.Promise<FriendP
 	return Promise.spawn(function(resolve, reject)
 		local mockPlayer = PlayerMock.getMockByUserId(userId)
 		if mockPlayer ~= nil then
-			local friends = PlayerMock.readLookup(mockPlayer, "Players.GetFriendsAsync", 0)
+			local friends = PlayerMock.callMethod(mockPlayer, "Players.GetFriendsAsync", 0)
 			return resolve(PagesProxy.new(PagesDatabase.fromPageData({ friends })) :: any)
 		end
 

package/src/Shared/FriendUtils.spec.lua

@@ -31,10 +31,10 @@ describe("FriendUtils.promiseAllFriends against a mock", function()
 	it("resolves the injected friends list", function()
 		local player = PlayerMock.new({ UserId = 90041001 })
 		player.Parent = Workspace
-		PlayerMock.writeLookup(player, "Players.GetFriendsAsync", 0, {
+		PlayerMock.writeLookup(player, "Players.GetFriendsAsync", {
 			makeFriendData(90041002, true),
 			makeFriendData(90041003, false),
-		})
+		}, 0)
 
 		local outcome, friends = PromiseTestUtils.awaitOutcome(FriendUtils.promiseAllFriends(90041001))
 
@@ -62,11 +62,11 @@ describe("FriendUtils.promiseAllFriends against a mock", function()
 	it("stops at limitMaxFriends", function()
 		local player = PlayerMock.new({ UserId = 90041005 })
 		player.Parent = Workspace
-		PlayerMock.writeLookup(player, "Players.GetFriendsAsync", 0, {
+		PlayerMock.writeLookup(player, "Players.GetFriendsAsync", {
 			makeFriendData(90041006, true),
 			makeFriendData(90041007, true),
 			makeFriendData(90041008, true),
-		})
+		}, 0)
 
 		local outcome, friends = PromiseTestUtils.awaitOutcome(FriendUtils.promiseAllFriends(90041005, 2))
 

package/src/Shared/RxFriendUtils.lua

@@ -26,15 +26,29 @@ local function getUserId(player: Player): number
 	return if PlayerMock.isMock(player) then PlayerMock.read(player, "UserId") else player.UserId
 end
 
+local function readFriendship(observedPlayer: Player, otherPlayer: Player): boolean
+	if PlayerMock.isMock(observedPlayer) then
+		return PlayerMock.callMethod(observedPlayer, "Player.IsFriendsWithAsync", getUserId(otherPlayer))
+	elseif PlayerMock.isMock(otherPlayer) then
+		return PlayerMock.callMethod(otherPlayer, "Player.IsFriendsWithAsync", getUserId(observedPlayer))
+	end
+
+	return observedPlayer:IsFriendsWithAsync(getUserId(otherPlayer))
+end
+
 --[=[
 	Observe friends in the current server (not including the LocalPlayer!), useful for social GUIs.
 	The lifetimes exist for the whole duration another player is a friend and in your server.
 	This means if a player is unfriended + friended multiple times per session, they will have emitted multiple friend lifetimes.
 
-	Works against [PlayerMock] players on either side: mocks in the DataModel are enumerated
-	alongside real players, friendship resolves from the mock's "Player.IsFriendsWithAsync" lookup
-	domain, and a mid-test [PlayerMock.writeLookup] to that domain stands in for the CoreGui
-	friended/unfriended events -- the observable re-reads and emits/kills lifetimes accordingly.
+	Works against [PlayerMock] players on either side: mocks in the DataModel are enumerated alongside
+	real players, and friendship resolves through the mock's `"Player.IsFriendsWithAsync"` domain. A
+	mock local player answers `StarterGui:GetCore` with its own stand-in for the CoreGui events below,
+	so a test fires a friending the way the CoreGui does:
+
+	```lua
+	PlayerMock.callMethod(player, "StarterGui.GetCore", "PlayerFriendedEvent"):Fire(otherPlayer)
+	```
 
 	@param player Player?
 	@return Observable<Brio<Player>>
@@ -54,11 +68,6 @@ function RxFriendUtils.observeFriendsInServerAsBrios(player: Player?): Observabl
 	return Observable.new(function(sub)
 		local maid = Maid.new()
 
-		-- Per-otherPlayer wiring (mock friendship-changed connections). Separate from the brio keyed
-		-- under maid[otherPlayer]: an unfriend kills the brio but the wiring must survive so a
-		-- re-friend emits a new lifetime. Both die together when the other player leaves.
-		local listenMaid = maid:Add(Maid.new())
-
 		local function handleFriendState(otherPlayer: Player, isFriendsWith: boolean)
 			if otherPlayer == Players.LocalPlayer then
 				return
@@ -82,37 +91,9 @@ function RxFriendUtils.observeFriendsInServerAsBrios(player: Player?): Observabl
 				return
 			end
 
-			-- Friendship is symmetric, so with only one side mocked the injected state lives on
-			-- whichever player is the mock; with both mocked, on the observed player.
-			local lookupMock: Player? = nil
-			local lookupKey: number? = nil
-			if PlayerMock.isMock(observedPlayer) then
-				lookupMock = observedPlayer
-				lookupKey = getUserId(otherPlayer)
-			elseif PlayerMock.isMock(otherPlayer) then
-				lookupMock = otherPlayer
-				lookupKey = getUserId(observedPlayer)
-			end
-
-			if lookupMock ~= nil and lookupKey ~= nil then
-				local mock: Player, key: number = lookupMock, lookupKey
-
-				local function readFriendState()
-					handleFriendState(otherPlayer, PlayerMock.readLookup(mock, "Player.IsFriendsWithAsync", key))
-				end
-
-				-- The lookup attribute's changed signal stands in for the CoreGui friended /
-				-- unfriended events below, which only the engine can fire.
-				listenMaid[otherPlayer] = PlayerMock.getLookupChangedSignal(mock, "Player.IsFriendsWithAsync", key)
-					:Connect(readFriendState)
-
-				readFriendState()
-				return
-			end
-
 			local isFriendsWith = false
 			local ok = pcall(function()
-				isFriendsWith = observedPlayer:IsFriendsWithAsync(getUserId(otherPlayer))
+				isFriendsWith = readFriendship(observedPlayer, otherPlayer)
 			end)
 			if not ok then
 				warn(
@@ -132,7 +113,6 @@ function RxFriendUtils.observeFriendsInServerAsBrios(player: Player?): Observabl
 		end
 
 		local function handlePlayerRemoving(otherPlayer: Player)
-			listenMaid[otherPlayer] = nil
 			maid[otherPlayer] = nil
 		end
 
@@ -162,7 +142,8 @@ function RxFriendUtils.observeFriendsInServerAsBrios(player: Player?): Observabl
 		-- https://devforum.roblox.com/t/playerfriendedevent-was-deleted-from-corescripts/696683
 		-- So just incase these connections throw, retrieve them off-thread so we don't error out the whole observable.
 		-- Only allow this while the game is running too
-		if observedPlayer == Players.LocalPlayer and RunService:IsRunning() then
+		local localPlayer = Players.LocalPlayer or PlayerMock.getMockedLocalPlayer()
+		if observedPlayer == localPlayer and (RunService:IsRunning() or PlayerMock.isMock(observedPlayer)) then
 			-- Getting the core yields, so the subscription may be cleaned up before it resolves.
 			local cancelled = false
 			maid:GiveTask(function()

package/src/Shared/RxFriendUtils.spec.lua

@@ -32,6 +32,17 @@ describe("RxFriendUtils.observeFriendsInServerAsBrios", function()
 		return player
 	end
 
+	local function makeLocalMock(userId: number): Player
+		local player = makeMock(userId)
+		maid:GiveTask(PlayerMock.setMockedLocalPlayer(player))
+		return player
+	end
+
+	local function fireCoreFriendship(observer: Player, otherPlayer: Player, isFriend: boolean): ()
+		local coreName = if isFriend then "PlayerFriendedEvent" else "PlayerUnfriendedEvent"
+		PlayerMock.callMethod(observer, "StarterGui.GetCore", coreName):Fire(otherPlayer)
+	end
+
 	local function trackBrios(observer: Player): { Brio.Brio<Player> }
 		local emissions: { Brio.Brio<Player> } = {}
 		maid:GiveTask(RxFriendUtils.observeFriendsInServerAsBrios(observer):Subscribe(function(brio)
@@ -43,7 +54,7 @@ describe("RxFriendUtils.observeFriendsInServerAsBrios", function()
 	it("emits an initial lifetime for a mock that is already a friend", function()
 		local observer = makeMock(90051001)
 		local friend = makeMock(90051002)
-		PlayerMock.writeLookup(observer, "Player.IsFriendsWithAsync", 90051002, true)
+		PlayerMock.writeLookup(observer, "Player.IsFriendsWithAsync", true, 90051002)
 
 		local emissions = trackBrios(observer)
 
@@ -61,30 +72,30 @@ describe("RxFriendUtils.observeFriendsInServerAsBrios", function()
 		expect(#emissions).toBe(0)
 	end)
 
-	it("emits when friendship is written mid-test and kills the lifetime on unfriend", function()
-		local observer = makeMock(90051005)
+	it("emits when the CoreGui reports a friending and kills the lifetime on unfriend", function()
+		local observer = makeLocalMock(90051005)
 		local friend = makeMock(90051006)
 
 		local emissions = trackBrios(observer)
 		expect(#emissions).toBe(0)
 
-		PlayerMock.writeLookup(observer, "Player.IsFriendsWithAsync", 90051006, true)
+		fireCoreFriendship(observer, friend, true)
 		expect(#emissions).toBe(1)
 		expect(emissions[1]:GetValue()).toBe(friend)
 
-		PlayerMock.writeLookup(observer, "Player.IsFriendsWithAsync", 90051006, false)
+		fireCoreFriendship(observer, friend, false)
 		expect(emissions[1]:IsDead()).toBe(true)
 	end)
 
 	it("emits a fresh lifetime per re-friend", function()
-		local observer = makeMock(90051007)
-		makeMock(90051008)
+		local observer = makeLocalMock(90051007)
+		local friend = makeMock(90051008)
 
 		local emissions = trackBrios(observer)
 
-		PlayerMock.writeLookup(observer, "Player.IsFriendsWithAsync", 90051008, true)
-		PlayerMock.writeLookup(observer, "Player.IsFriendsWithAsync", 90051008, false)
-		PlayerMock.writeLookup(observer, "Player.IsFriendsWithAsync", 90051008, true)
+		fireCoreFriendship(observer, friend, true)
+		fireCoreFriendship(observer, friend, false)
+		fireCoreFriendship(observer, friend, true)
 
 		expect(#emissions).toBe(2)
 		expect(emissions[1]:IsDead()).toBe(true)
@@ -92,22 +103,20 @@ describe("RxFriendUtils.observeFriendsInServerAsBrios", function()
 	end)
 
 	it("does not emit a duplicate lifetime for a repeated friended signal", function()
-		local observer = makeMock(90051009)
-		makeMock(90051010)
-		PlayerMock.writeLookup(observer, "Player.IsFriendsWithAsync", 90051010, true)
+		local observer = makeLocalMock(90051009)
+		local friend = makeMock(90051010)
+		PlayerMock.writeLookup(observer, "Player.IsFriendsWithAsync", true, 90051010)
 
 		local emissions = trackBrios(observer)
 
-		-- The CoreGui friended event this wiring stands in for can fire repeatedly; a re-write of
-		-- the same state must not open a second lifetime.
-		PlayerMock.writeLookup(observer, "Player.IsFriendsWithAsync", 90051010, true)
+		fireCoreFriendship(observer, friend, true)
 
 		expect(#emissions).toBe(1)
 	end)
 
 	it("emits for a friend mock that joins after subscription", function()
 		local observer = makeMock(90051011)
-		PlayerMock.writeLookup(observer, "Player.IsFriendsWithAsync", 90051012, true)
+		PlayerMock.writeLookup(observer, "Player.IsFriendsWithAsync", true, 90051012)
 
 		local emissions = trackBrios(observer)
 		expect(#emissions).toBe(0)
@@ -121,7 +130,7 @@ describe("RxFriendUtils.observeFriendsInServerAsBrios", function()
 	it("kills the lifetime when the friend mock leaves", function()
 		local observer = makeMock(90051013)
 		local friend = makeMock(90051014)
-		PlayerMock.writeLookup(observer, "Player.IsFriendsWithAsync", 90051014, true)
+		PlayerMock.writeLookup(observer, "Player.IsFriendsWithAsync", true, 90051014)
 
 		local emissions = trackBrios(observer)
 		expect(#emissions).toBe(1)