@quenty/friendutils 12.38.1 → 12.39.0

package/CHANGELOG.md

@@ -3,6 +3,12 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [12.39.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/friendutils@12.38.1...@quenty/friendutils@12.39.0) (2026-08-24)
+
+### Bug Fixes
+
+- Retry on GetCore failure ([c8a595a](https://github.com/Quenty/NevermoreEngine/commit/c8a595a01876ff9324f81a4790ea478086740d2a))
+
 ## [12.38.1](https://github.com/Quenty/NevermoreEngine/compare/@quenty/friendutils@12.38.0...@quenty/friendutils@12.38.1) (2026-08-14)
 
 **Note:** Version bump only for package @quenty/friendutils

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/friendutils",
-  "version": "12.38.1",
+  "version": "12.39.0",
   "description": "Utlity functions to help find friends of a user. Also contains utility to make testing in studio easier.",
   "keywords": [
     "Roblox",
@@ -29,6 +29,7 @@
   ],
   "dependencies": {
     "@quenty/brio": "14.35.2",
+    "@quenty/coreguiutils": "10.24.0",
     "@quenty/loader": "10.11.1",
     "@quenty/maid": "3.11.1",
     "@quenty/nevermore-test-runner": "1.5.1",
@@ -41,5 +42,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "f084360c3729ea424d49d9bc42f8f0d1c128fa82"
+  "gitHead": "eb9bb06284b3e3ec4140eedadc54cfe2296a52e1"
 }

package/src/Shared/RxFriendUtils.lua

@@ -10,13 +10,16 @@ local require = require(script.Parent.loader).load(script)
 local CollectionService = game:GetService("CollectionService")
 local Players = game:GetService("Players")
 local RunService = game:GetService("RunService")
-local StarterGui = game:GetService("StarterGui")
 
 local Brio = require("Brio")
+local CoreGuiUtils = require("CoreGuiUtils")
 local Maid = require("Maid")
 local Observable = require("Observable")
 local PlayerMock = require("PlayerMock")
 
+local MAX_GET_CORE_ATTEMPTS = 5
+local GET_CORE_INITIAL_WAIT_TIME = 0.5
+
 local RxFriendUtils = {}
 
 local function getUserId(player: Player): number
@@ -157,17 +160,39 @@ function RxFriendUtils.observeFriendsInServerAsBrios(player: Player?): Observabl
 		-- Handle changes for players already in this server.
 		-- There's a non-zero chance these get removed someday... :(
 		-- https://devforum.roblox.com/t/playerfriendedevent-was-deleted-from-corescripts/696683
-		-- So just incase these connections throw, use a new thread so we don't error out the whole observable.
+		-- So just incase these connections throw, retrieve them off-thread so we don't error out the whole observable.
 		-- Only allow this while the game is running too
 		if observedPlayer == Players.LocalPlayer and RunService:IsRunning() then
-			task.spawn(function()
-				maid:GiveTask(StarterGui:GetCore("PlayerFriendedEvent").Event:Connect(function(otherPlayer: Player)
-					handleFriendState(otherPlayer, true)
-				end))
-				maid:GiveTask(StarterGui:GetCore("PlayerUnfriendedEvent").Event:Connect(function(otherPlayer: Player)
-					handleFriendState(otherPlayer, false)
-				end))
+			-- Getting the core yields, so the subscription may be cleaned up before it resolves.
+			local cancelled = false
+			maid:GiveTask(function()
+				cancelled = true
 			end)
+
+			local function connectCoreEvent(coreName: string, isFriendsWith: boolean)
+				local promise = maid:GivePromise(
+					CoreGuiUtils.promiseRetryGetCore(MAX_GET_CORE_ATTEMPTS, GET_CORE_INITIAL_WAIT_TIME, coreName)
+				)
+
+				promise:Then(function(coreEvent)
+					if cancelled then
+						return
+					end
+
+					maid:GiveTask(coreEvent.Event:Connect(function(otherPlayer: Player)
+						handleFriendState(otherPlayer, isFriendsWith)
+					end))
+				end, function(err)
+					if cancelled then
+						return
+					end
+
+					warn(`[RxFriendUtils] Couldn't get core {coreName}: {tostring(err)}`)
+				end)
+			end
+
+			connectCoreEvent("PlayerFriendedEvent", true)
+			connectCoreEvent("PlayerUnfriendedEvent", false)
 		end
 
 		return maid