@quenty/ellipticcurvecryptography 1.1.0 → 1.2.0

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [1.2.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/ellipticcurvecryptography@1.1.0...@quenty/ellipticcurvecryptography@1.2.0) (2023-12-14)
+
+
+### Performance Improvements
+
+* Improve performance of elliptic curve crypto module, saving 100ms of startup compute time on server start ([b9b500e](https://github.com/Quenty/NevermoreEngine/commit/b9b500e33b0b297c0510b28ce272c553d19408e6))
+
+
+
+
+
 # 1.1.0 (2023-03-31)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/ellipticcurvecryptography",
-  "version": "1.1.0",
+  "version": "1.2.0",
   "description": "Elliptic curve cryptography forked from BoatBomber, forked from ComputerCraft",
   "keywords": [
     "Roblox",
@@ -28,5 +28,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "2a1c35a8d2e90b291a83a6e2def0ec69f3f24837"
+  "gitHead": "2c2dbbc0cb2fbb46b4f3270c559c63890fe18b26"
 }

package/src/Shared/EllipticCurveCryptography/arith.lua

@@ -1,3 +1,4 @@
+--!native
 -- Big integer arithmetic for 168-bit (and 336-bit) numbers
 -- Numbers are represented as little-endian tables of 24-bit integers
 local twoPower = require(script.Parent.twoPower)

package/src/Shared/EllipticCurveCryptography/benchmark.spec.lua

@@ -1,3 +1,4 @@
+--!native
 local ecc = require(script.Parent)
 
 warn("Running EllipticCurveCryptography benchmark...")

package/src/Shared/EllipticCurveCryptography/chacha20.lua

@@ -1,3 +1,5 @@
+--!native
+
 -- Chacha20 cipher in ComputerCraft
 -- By Anavrins
 -- For help and details, you can PM me on the CC forums

package/src/Shared/EllipticCurveCryptography/curve.lua

@@ -1,3 +1,5 @@
+--!native
+
 --[=[
 	Elliptic curve arithmetic
 

package/src/Shared/EllipticCurveCryptography/init.lua

@@ -1,3 +1,5 @@
+--!native
+
 --[=[
 	Elliptic Curve Cryptography
 
@@ -36,7 +38,6 @@ local chacha20 = require(script.chacha20)
 local random = require(script.random)
 local modq = require(script.modq)
 local curve = require(script.curve)
-
 local EllipticCurveCryptography = {}
 
 EllipticCurveCryptography.chacha20 = chacha20;

package/src/Shared/EllipticCurveCryptography/modp.lua

@@ -1,3 +1,5 @@
+--!native
+
 -- Arithmetic on the finite field of integers modulo p
 -- Where p is the finite field modulus
 local arith = require(script.Parent.arith)

package/src/Shared/EllipticCurveCryptography/modq.lua

@@ -1,3 +1,5 @@
+--!native
+
 -- Arithmetic on the Finite Field of Integers modulo q
 -- Where q is the generator's subgroup order.
 local util = require(script.Parent.util)

package/src/Shared/EllipticCurveCryptography/random.lua

@@ -1,9 +1,13 @@
+--!native
+
 -- random.lua - Random Byte Generator
 local sha256 = require(script.Parent.sha256)
 
 local entropy = ""
 local accumulator, accumulator_len = {}, 0
 
+local random = {}
+
 local function feed(data)
 	accumulator_len += 1
 	accumulator[accumulator_len] = tostring(data or "")
@@ -16,23 +20,44 @@ local function digest()
 	accumulator_len = 0
 end
 
-feed("init")
-feed(math.random(1, 2 ^ 31 - 1))
-feed("|")
-feed(math.random(1, 2 ^ 31 - 1))
-feed("|")
-feed(math.random(1, 2 ^ 4))
-feed("|")
-feed(DateTime.now().UnixTimestampMillis)
-feed("|")
-for _ = 1, 10000 do
-	feed(tostring({}):sub(-8))
+local entropyInitialized = false
+
+-- Defer this initialization until requested
+local function ensureEntropyInit()
+	if entropyInitialized then
+		return
+	end
+
+	local startTime = os.clock()
+	entropyInitialized = true
+
+	-- This takes about 100ms
+
+	feed("init")
+	feed(math.random(1, 2 ^ 31 - 1))
+	feed("|")
+	feed(math.random(1, 2 ^ 31 - 1))
+	feed("|")
+	feed(math.random(1, 2 ^ 4))
+	feed("|")
+	feed(DateTime.now().UnixTimestampMillis)
+	feed("|")
+	for _ = 1, 10000 do
+		feed(tostring({}):sub(-8))
+	end
+	digest()
+	feed(DateTime.now().UnixTimestampMillis)
+	digest()
+
+	random.save()
+
+	-- TODO: Suppress this warning
+	warn(string.format("[EllipticCurveCryptography.random] - Generating entropy took %s ms", 1000*(os.clock() - startTime)))
 end
-digest()
-feed(DateTime.now().UnixTimestampMillis)
-digest()
 
-local function save()
+function random.save()
+	ensureEntropyInit()
+
 	feed("save")
 	feed(DateTime.now().UnixTimestampMillis)
 	feed({})
@@ -40,23 +65,26 @@ local function save()
 
 	entropy = tostring(sha256.digest(entropy))
 end
-save()
 
-local function seed(data)
+function random.seed(data)
+	ensureEntropyInit()
+
 	feed("seed")
 	feed(DateTime.now().UnixTimestampMillis)
 	feed({})
 	feed(data)
 	digest()
-	save()
+	random.save()
 end
 
-local function random()
+function random.random()
+	ensureEntropyInit()
+
 	feed("random")
 	feed(DateTime.now().UnixTimestampMillis)
 	feed({})
 	digest()
-	save()
+	random.save()
 
 	local result = sha256.hmac("out", entropy)
 	entropy = tostring(sha256.digest(entropy))
@@ -64,8 +92,4 @@ local function random()
 	return result
 end
 
-return {
-	seed = seed,
-	save = save,
-	random = random,
-}
+return random

package/src/Shared/EllipticCurveCryptography/sha256.lua

@@ -1,3 +1,5 @@
+--!native
+
 -- SHA-256, HMAC and PBKDF2 functions in ComputerCraft
 -- By Anavrins
 -- For help and details, you can PM me on the CC forums
@@ -5,6 +7,8 @@
 -- http://www.computercraft.info/forums2/index.php?/user/12870-anavrins
 -- http://pastebin.com/6UV4qfNF
 -- Last update: October 10, 2017
+-- Updated by Quenty December 4th, 2023
+
 local twoPower = require(script.Parent.twoPower)
 local util = require(script.Parent.util)
 

package/src/Shared/EllipticCurveCryptography/twoPower.lua

@@ -6,9 +6,10 @@ local twoPower = setmetatable({}, {
 	end,
 })
 
+-- NOTE: This takes somewhere between 1.5 ms to 4 ms
 -- precache
-for index = -512, 512 do
-	local _ = twoPower[index]
-end
+-- for index = -512, 512 do
+-- 	twoPower[index] = 2 ^ index
+-- end
 
 return twoPower

package/src/Shared/EllipticCurveCryptography/util.lua

@@ -1,3 +1,5 @@
+--!native
+
 local util = {}
 
 util.byteTableMT = {