@quenty/ducktype 2.2.0 → 3.0.0-canary.439.eb597ee.0

package/CHANGELOG.md

@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [3.0.0-canary.439.eb597ee.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/ducktype@2.2.0...@quenty/ducktype@3.0.0-canary.439.eb597ee.0) (2024-01-17)
+
+**Note:** Version bump only for package @quenty/ducktype
+
+
+
+
+
 # [2.2.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/ducktype@2.1.0...@quenty/ducktype@2.2.0) (2024-01-08)
 
 **Note:** Version bump only for package @quenty/ducktype

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/ducktype",
-  "version": "2.2.0",
+  "version": "3.0.0-canary.439.eb597ee.0",
   "description": "Utility functions to duck type a value",
   "keywords": [
     "Roblox",
@@ -25,10 +25,10 @@
     "Quenty"
   ],
   "dependencies": {
-    "@quenty/loader": "^7.3.0"
+    "@quenty/loader": "8.0.0-canary.439.eb597ee.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "075fb03a03f12ade8758f667767ba738204e0c4b"
+  "gitHead": "eb597ee01e62e4dd91190bb7abd1d1404652d5ff"
 }

package/src/Shared/DuckTypeUtils.lua

@@ -1,4 +1,6 @@
 --[=[
+	Utility method to check interface is equivalent for two implementations
+
 	@class DuckTypeUtils
 ]=]
 
@@ -6,6 +8,13 @@ local require = require(script.Parent.loader).load(script)
 
 local DuckTypeUtils = {}
 
+--[=[
+	Returns true if a template is similar to a target
+
+	@param template table
+	@param target any
+	@return boolean
+]=]
 function DuckTypeUtils.isImplementation(template, target)
 	assert(type(template) == "table", "Bad template")
 
@@ -14,6 +23,17 @@ function DuckTypeUtils.isImplementation(template, target)
 end
 
 function DuckTypeUtils._checkInterface(template, target)
+	local targetMetatable = getmetatable(target)
+	local templateMetatable = getmetatable(template)
+	if targetMetatable and type(targetMetatable.__index) == "function" then
+		-- Indexing into this target could cause an error. Treat it differently and fast-fail
+		if templateMetatable then
+			return targetMetatable.__index == templateMetatable.__index
+		end
+
+		return false
+	end
+
 	for key, value in pairs(template) do
 		if type(value) == "function" and type(target[key]) ~= "function" then
 			return false
@@ -21,9 +41,8 @@ function DuckTypeUtils._checkInterface(template, target)
 	end
 
 	-- TODO: Prevent infinite recursion potential
-	local metatable = getmetatable(template)
-	if metatable and type(metatable.__index) == "table" then
-		return DuckTypeUtils._checkInterface(metatable.__index, target)
+	if templateMetatable and type(templateMetatable.__index) == "table" then
+		return DuckTypeUtils._checkInterface(templateMetatable.__index, target)
 	end
 
 	return true