@quenty/deathreport 10.21.3 → 10.21.4-canary.11a5dcf.0

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [10.21.4-canary.11a5dcf.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/deathreport@10.21.3...@quenty/deathreport@10.21.4-canary.11a5dcf.0) (2025-05-10)
+
+
+### Bug Fixes
+
+* Additional type checking updates ([05ba29a](https://github.com/Quenty/NevermoreEngine/commit/05ba29a03efc9f3feed74b34f1d9dfb237496214))
+
+
+
+
+
 ## [10.21.3](https://github.com/Quenty/NevermoreEngine/compare/@quenty/deathreport@10.21.2...@quenty/deathreport@10.21.3) (2025-04-10)
 
 **Note:** Version bump only for package @quenty/deathreport

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/deathreport",
-  "version": "10.21.3",
+  "version": "10.21.4-canary.11a5dcf.0",
   "description": "Death report service which will track the deaths of players",
   "keywords": [
     "Roblox",
@@ -29,19 +29,19 @@
     "access": "public"
   },
   "dependencies": {
-    "@quenty/baseobject": "^10.8.3",
-    "@quenty/binder": "^14.19.3",
-    "@quenty/characterutils": "^12.18.3",
-    "@quenty/humanoidkillerutils": "^2.3.3",
-    "@quenty/loader": "^10.8.3",
-    "@quenty/maid": "^3.4.3",
-    "@quenty/playerhumanoidbinder": "^14.19.3",
-    "@quenty/remoting": "^12.18.3",
-    "@quenty/rx": "^13.17.3",
-    "@quenty/rxbinderutils": "^14.19.3",
-    "@quenty/servicebag": "^11.11.4",
-    "@quenty/signal": "^7.10.3",
-    "@quenty/table": "^3.7.4"
+    "@quenty/baseobject": "10.8.4-canary.11a5dcf.0",
+    "@quenty/binder": "14.19.4-canary.11a5dcf.0",
+    "@quenty/characterutils": "12.18.4-canary.11a5dcf.0",
+    "@quenty/humanoidkillerutils": "2.3.3",
+    "@quenty/loader": "10.8.4-canary.11a5dcf.0",
+    "@quenty/maid": "3.4.4-canary.11a5dcf.0",
+    "@quenty/playerhumanoidbinder": "14.19.4-canary.11a5dcf.0",
+    "@quenty/remoting": "12.18.4-canary.11a5dcf.0",
+    "@quenty/rx": "13.17.4-canary.11a5dcf.0",
+    "@quenty/rxbinderutils": "14.19.4-canary.11a5dcf.0",
+    "@quenty/servicebag": "11.11.5-canary.11a5dcf.0",
+    "@quenty/signal": "7.10.4-canary.11a5dcf.0",
+    "@quenty/table": "3.7.5-canary.11a5dcf.0"
   },
-  "gitHead": "b06c070ae91d5dab7bd8de6e290ad2caabb15d8f"
+  "gitHead": "11a5dcf7d4c7a0bfbf3337e97d30e8346ea09d3f"
 }

package/src/Client/DeathReportBindersClient.lua

@@ -4,12 +4,12 @@
 
 local require = require(script.Parent.loader).load(script)
 
-local BinderProvider = require("BinderProvider")
 local Binder = require("Binder")
+local BinderProvider = require("BinderProvider")
 
 return BinderProvider.new(script.Name, function(self, serviceBag)
 	-- Stats
 	self:Add(Binder.new("TeamKillTracker", require("TeamKillTrackerClient"), serviceBag))
 	self:Add(Binder.new("PlayerKillTracker", require("PlayerKillTrackerClient"), serviceBag))
 	self:Add(Binder.new("PlayerDeathTracker", require("PlayerDeathTrackerClient"), serviceBag))
-end)
+end)

package/src/Client/DeathReportServiceClient.lua

@@ -8,13 +8,13 @@
 
 local require = require(script.Parent.loader).load(script)
 
-local Signal = require("Signal")
-local Maid = require("Maid")
-local DeathReportServiceConstants = require("DeathReportServiceConstants")
-local PromiseGetRemoteEvent = require("PromiseGetRemoteEvent")
 local DeathReportProcessor = require("DeathReportProcessor")
+local DeathReportServiceConstants = require("DeathReportServiceConstants")
 local DeathReportUtils = require("DeathReportUtils")
-local _ServiceBag = require("ServiceBag")
+local Maid = require("Maid")
+local PromiseGetRemoteEvent = require("PromiseGetRemoteEvent")
+local ServiceBag = require("ServiceBag")
+local Signal = require("Signal")
 
 -- Note: don't make this too big without upgrading the way we handle the queue
 local MAX_DEATH_REPORTS = 5
@@ -28,7 +28,7 @@ DeathReportServiceClient.ServiceName = "DeathReportServiceClient"
 
 	@param serviceBag ServiceBag
 ]=]
-function DeathReportServiceClient:Init(serviceBag: _ServiceBag.ServiceBag)
+function DeathReportServiceClient:Init(serviceBag: ServiceBag.ServiceBag)
 	assert(not self._serviceBag, "Already initialized")
 	self._serviceBag = assert(serviceBag, "No serviceBag")
 	self._maid = Maid.new()
@@ -43,12 +43,11 @@ function DeathReportServiceClient:Init(serviceBag: _ServiceBag.ServiceBag)
 	self._lastDeathReports = {}
 
 	-- Setup remote Event
-	self:_promiseRemoteEvent()
-		:Then(function(remoteEvent)
-			self._maid:GiveTask(remoteEvent.OnClientEvent:Connect(function(...)
-				self:_handleClientEvent(...)
-			end))
-		end)
+	self:_promiseRemoteEvent():Then(function(remoteEvent)
+		self._maid:GiveTask(remoteEvent.OnClientEvent:Connect(function(...)
+			self:_handleClientEvent(...)
+		end))
+	end)
 end
 
 --[=[
@@ -158,4 +157,4 @@ function DeathReportServiceClient:Destroy()
 	self._maid:DoCleaning()
 end
 
-return DeathReportServiceClient
+return DeathReportServiceClient

package/src/Client/Stats/PlayerDeathTrackerClient.lua

@@ -5,13 +5,13 @@
 local require = require(script.Parent.loader).load(script)
 
 local BaseObject = require("BaseObject")
-local _ServiceBag = require("ServiceBag")
+local ServiceBag = require("ServiceBag")
 
 local PlayerDeathTrackerClient = setmetatable({}, BaseObject)
 PlayerDeathTrackerClient.ClassName = "PlayerDeathTrackerClient"
 PlayerDeathTrackerClient.__index = PlayerDeathTrackerClient
 
-function PlayerDeathTrackerClient.new(tracker, serviceBag: _ServiceBag.ServiceBag)
+function PlayerDeathTrackerClient.new(tracker, serviceBag: ServiceBag.ServiceBag)
 	local self = setmetatable(BaseObject.new(tracker), PlayerDeathTrackerClient)
 
 	self._serviceBag = assert(serviceBag, "No serviceBag")
@@ -33,4 +33,4 @@ function PlayerDeathTrackerClient:GetKills()
 	return self._obj.Value
 end
 
-return PlayerDeathTrackerClient
+return PlayerDeathTrackerClient

package/src/Client/Stats/PlayerKillTrackerClient.lua

@@ -5,13 +5,13 @@
 local require = require(script.Parent.loader).load(script)
 
 local BaseObject = require("BaseObject")
-local _ServiceBag = require("ServiceBag")
+local ServiceBag = require("ServiceBag")
 
 local PlayerKillTrackerClient = setmetatable({}, BaseObject)
 PlayerKillTrackerClient.ClassName = "PlayerKillTrackerClient"
 PlayerKillTrackerClient.__index = PlayerKillTrackerClient
 
-function PlayerKillTrackerClient.new(tracker, serviceBag: _ServiceBag.ServiceBag)
+function PlayerKillTrackerClient.new(tracker, serviceBag: ServiceBag.ServiceBag)
 	local self = setmetatable(BaseObject.new(tracker), PlayerKillTrackerClient)
 
 	self._serviceBag = assert(serviceBag, "No serviceBag")
@@ -33,4 +33,4 @@ function PlayerKillTrackerClient:GetKills()
 	return self._obj.Value
 end
 
-return PlayerKillTrackerClient
+return PlayerKillTrackerClient

package/src/Client/Stats/TeamKillTrackerClient.lua

@@ -30,4 +30,4 @@ function TeamKillTrackerClient:GetKills()
 	return self._obj.Value
 end
 
-return TeamKillTrackerClient
+return TeamKillTrackerClient

package/src/Server/DeathReportBindersServer.lua

@@ -4,9 +4,9 @@
 
 local require = require(script.Parent.loader).load(script)
 
+local Binder = require("Binder")
 local BinderProvider = require("BinderProvider")
 local PlayerHumanoidBinder = require("PlayerHumanoidBinder")
-local Binder = require("Binder")
 
 return BinderProvider.new(script.Name, function(self, serviceBag)
 	-- Tracking
@@ -16,4 +16,4 @@ return BinderProvider.new(script.Name, function(self, serviceBag)
 	self:Add(Binder.new("TeamKillTracker", require("TeamKillTracker"), serviceBag))
 	self:Add(Binder.new("PlayerKillTracker", require("PlayerKillTracker"), serviceBag))
 	self:Add(Binder.new("PlayerDeathTracker", require("PlayerDeathTracker"), serviceBag))
-end)
+end)

package/src/Server/DeathReportService.lua

@@ -9,21 +9,21 @@
 
 local require = require(script.Parent.loader).load(script)
 
-local Signal = require("Signal")
-local GetRemoteEvent = require("GetRemoteEvent")
+local DeathReportProcessor = require("DeathReportProcessor")
 local DeathReportServiceConstants = require("DeathReportServiceConstants")
 local DeathReportUtils = require("DeathReportUtils")
+local GetRemoteEvent = require("GetRemoteEvent")
 local Maid = require("Maid")
-local DeathReportProcessor = require("DeathReportProcessor")
-local _ServiceBag = require("ServiceBag")
-local _Observable = require("Observable")
+local Observable = require("Observable")
+local ServiceBag = require("ServiceBag")
+local Signal = require("Signal")
 
 local DeathReportService = {}
 DeathReportService.ServiceName = "DeathReportService"
 
 export type DeathReportService = typeof(setmetatable(
 	{} :: {
-		_serviceBag: any,
+		_serviceBag: ServiceBag.ServiceBag,
 		_maid: Maid.Maid,
 		NewDeathReport: Signal.Signal<DeathReportUtils.DeathReport>,
 		_remoteEvent: RemoteEvent,
@@ -40,8 +40,8 @@ export type GetWeaponData = (humanoid: Humanoid) -> DeathReportUtils.WeaponData?
 
 	@param serviceBag ServiceBag
 ]=]
-function DeathReportService.Init(self: DeathReportService, serviceBag: _ServiceBag.ServiceBag)
-	assert(not self._serviceBag, "Already initialized")
+function DeathReportService.Init(self: DeathReportService, serviceBag: ServiceBag.ServiceBag)
+	assert(not (self :: any)._serviceBag, "Already initialized")
 	self._serviceBag = assert(serviceBag, "No serviceBag")
 	self._maid = Maid.new()
 
@@ -93,7 +93,7 @@ end
 function DeathReportService.ObservePlayerKillerReports(
 	self: DeathReportService,
 	player: Player
-): _Observable.Observable<DeathReportUtils.DeathReport>
+): Observable.Observable<DeathReportUtils.DeathReport>
 	assert(typeof(player) == "Instance" and player:IsA("Player"), "Bad player")
 
 	return self._reportProcessor:ObservePlayerKillerReports(player)
@@ -108,7 +108,7 @@ end
 function DeathReportService.ObservePlayerDeathReports(
 	self: DeathReportService,
 	player: Player
-): _Observable.Observable<DeathReportUtils.DeathReport>
+): Observable.Observable<DeathReportUtils.DeathReport>
 	assert(typeof(player) == "Instance" and player:IsA("Player"), "Bad player")
 
 	return self._reportProcessor:ObservePlayerDeathReports(player)
@@ -123,7 +123,7 @@ end
 function DeathReportService.ObserveHumanoidKillerReports(
 	self: DeathReportService,
 	humanoid: Humanoid
-): _Observable.Observable<DeathReportUtils.DeathReport>
+): Observable.Observable<DeathReportUtils.DeathReport>
 	assert(typeof(humanoid) == "Instance" and humanoid:IsA("Humanoid"), "Bad humanoid")
 
 	return self._reportProcessor:ObserveHumanoidKillerReports(humanoid)
@@ -138,7 +138,7 @@ end
 function DeathReportService.ObserveHumanoidDeathReports(
 	self: DeathReportService,
 	humanoid: Humanoid
-): _Observable.Observable<DeathReportUtils.DeathReport>
+): Observable.Observable<DeathReportUtils.DeathReport>
 	assert(typeof(humanoid) == "Instance" and humanoid:IsA("Humanoid"), "Bad humanoid")
 
 	return self._reportProcessor:ObserveHumanoidDeathReports(humanoid)
@@ -153,7 +153,7 @@ end
 function DeathReportService.ObserveCharacterKillerReports(
 	self: DeathReportService,
 	character: Model
-): _Observable.Observable<DeathReportUtils.DeathReport>
+): Observable.Observable<DeathReportUtils.DeathReport>
 	assert(typeof(character) == "Instance" and character:IsA("Model"), "Bad character")
 
 	return self._reportProcessor:ObserveCharacterKillerReports(character)
@@ -168,7 +168,7 @@ end
 function DeathReportService.ObserveCharacterDeathReports(
 	self: DeathReportService,
 	character: Model
-): _Observable.Observable<DeathReportUtils.DeathReport>
+): Observable.Observable<DeathReportUtils.DeathReport>
 	assert(typeof(character) == "Instance" and character:IsA("Model"), "Bad character")
 
 	return self._reportProcessor:ObserveCharacterDeathReports(character)
@@ -209,4 +209,4 @@ function DeathReportService.Destroy(self: DeathReportService)
 	self._maid:DoCleaning()
 end
 
-return DeathReportService
+return DeathReportService

package/src/Server/DeathTrackedHumanoid.lua

@@ -36,4 +36,4 @@ function DeathTrackedHumanoid:_handleDeath()
 	end
 end
 
-return DeathTrackedHumanoid
+return DeathTrackedHumanoid

package/src/Server/Stats/PlayerDeathTracker.lua

@@ -6,13 +6,13 @@ local require = require(script.Parent.loader).load(script)
 
 local BaseObject = require("BaseObject")
 local DeathReportService = require("DeathReportService")
-local _ServiceBag = require("ServiceBag")
+local ServiceBag = require("ServiceBag")
 
 local PlayerDeathTracker = setmetatable({}, BaseObject)
 PlayerDeathTracker.ClassName = "PlayerDeathTracker"
 PlayerDeathTracker.__index = PlayerDeathTracker
 
-function PlayerDeathTracker.new(scoreObject, serviceBag: _ServiceBag.ServiceBag)
+function PlayerDeathTracker.new(scoreObject, serviceBag: ServiceBag.ServiceBag)
 	local self = setmetatable(BaseObject.new(scoreObject), PlayerDeathTracker)
 
 	self._serviceBag = assert(serviceBag, "No serviceBag")
@@ -30,4 +30,4 @@ function PlayerDeathTracker.new(scoreObject, serviceBag: _ServiceBag.ServiceBag)
 	return self
 end
 
-return PlayerDeathTracker
+return PlayerDeathTracker

package/src/Server/Stats/PlayerKillTracker.lua

@@ -6,13 +6,13 @@ local require = require(script.Parent.loader).load(script)
 
 local BaseObject = require("BaseObject")
 local DeathReportService = require("DeathReportService")
-local _ServiceBag = require("ServiceBag")
+local ServiceBag = require("ServiceBag")
 
 local PlayerKillTracker = setmetatable({}, BaseObject)
 PlayerKillTracker.ClassName = "PlayerKillTracker"
 PlayerKillTracker.__index = PlayerKillTracker
 
-function PlayerKillTracker.new(scoreObject, serviceBag: _ServiceBag.ServiceBag)
+function PlayerKillTracker.new(scoreObject, serviceBag: ServiceBag.ServiceBag)
 	local self = setmetatable(BaseObject.new(scoreObject), PlayerKillTracker)
 
 	self._serviceBag = assert(serviceBag, "No serviceBag")
@@ -43,4 +43,4 @@ function PlayerKillTracker:GetKills(): number
 	return self._obj.Value
 end
 
-return PlayerKillTracker
+return PlayerKillTracker

package/src/Server/Stats/PlayerKillTrackerAssigner.lua

@@ -7,16 +7,16 @@ local require = require(script.Parent.loader).load(script)
 local Players = game:GetService("Players")
 
 local BaseObject = require("BaseObject")
+local DeathReportBindersServer = require("DeathReportBindersServer")
 local Maid = require("Maid")
 local PlayerKillTrackerUtils = require("PlayerKillTrackerUtils")
-local DeathReportBindersServer = require("DeathReportBindersServer")
-local _ServiceBag = require("ServiceBag")
+local ServiceBag = require("ServiceBag")
 
 local PlayerKillTrackerAssigner = setmetatable({}, BaseObject)
 PlayerKillTrackerAssigner.ClassName = "PlayerKillTrackerAssigner"
 PlayerKillTrackerAssigner.__index = PlayerKillTrackerAssigner
 
-function PlayerKillTrackerAssigner.new(serviceBag: _ServiceBag.ServiceBag)
+function PlayerKillTrackerAssigner.new(serviceBag: ServiceBag.ServiceBag)
 	local self = setmetatable(BaseObject.new(), PlayerKillTrackerAssigner)
 
 	self._serviceBag = assert(serviceBag, "No serviceBag")
@@ -78,5 +78,4 @@ function PlayerKillTrackerAssigner:_handlePlayerAdded(player)
 	self._maid[player] = maid
 end
 
-
-return PlayerKillTrackerAssigner
+return PlayerKillTrackerAssigner

package/src/Server/Stats/TeamKillTracker.lua

@@ -45,4 +45,4 @@ function TeamKillTracker:_handleDeathReport(deathReport)
 	end
 end
 
-return TeamKillTracker
+return TeamKillTracker

package/src/Shared/DeathReportProcessor.lua

@@ -10,9 +10,9 @@ local require = require(script.Parent.loader).load(script)
 local Players = game:GetService("Players")
 
 local BaseObject = require("BaseObject")
-local ObservableSubscriptionTable = require("ObservableSubscriptionTable")
 local DeathReportUtils = require("DeathReportUtils")
-local _Observable = require("Observable")
+local Observable = require("Observable")
+local ObservableSubscriptionTable = require("ObservableSubscriptionTable")
 
 local DeathReportProcessor = setmetatable({}, BaseObject)
 DeathReportProcessor.ClassName = "DeathReportProcessor"
@@ -57,7 +57,7 @@ end
 function DeathReportProcessor.ObservePlayerKillerReports(
 	self: DeathReportProcessor,
 	player: Player
-): _Observable.Observable<DeathReportUtils.DeathReport>
+): Observable.Observable<DeathReportUtils.DeathReport>
 	assert(typeof(player) == "Instance" and player:IsA("Player"), "Bad player")
 
 	return self._playerKillerSubTable:Observe(player)
@@ -72,7 +72,7 @@ end
 function DeathReportProcessor.ObservePlayerDeathReports(
 	self: DeathReportProcessor,
 	player: Player
-): _Observable.Observable<DeathReportUtils.DeathReport>
+): Observable.Observable<DeathReportUtils.DeathReport>
 	assert(typeof(player) == "Instance" and player:IsA("Player"), "Bad player")
 
 	return self._playerDeathSubTable:Observe(player)
@@ -87,7 +87,7 @@ end
 function DeathReportProcessor.ObserveHumanoidDeathReports(
 	self: DeathReportProcessor,
 	humanoid: Humanoid
-): _Observable.Observable<DeathReportUtils.DeathReport>
+): Observable.Observable<DeathReportUtils.DeathReport>
 	assert(typeof(humanoid) == "Instance" and humanoid:IsA("Humanoid"), "Bad humanoid")
 
 	return self._humanoidDeathSubTable:Observe(humanoid)
@@ -102,7 +102,7 @@ end
 function DeathReportProcessor.ObserveHumanoidKillerReports(
 	self: DeathReportProcessor,
 	humanoid: Humanoid
-): _Observable.Observable<DeathReportUtils.DeathReport>
+): Observable.Observable<DeathReportUtils.DeathReport>
 	assert(typeof(humanoid) == "Instance" and humanoid:IsA("Humanoid"), "Bad humanoid")
 
 	return self._humanoidKillerSubTable:Observe(humanoid)
@@ -117,7 +117,7 @@ end
 function DeathReportProcessor.ObserveCharacterKillerReports(
 	self: DeathReportProcessor,
 	character: Model
-): _Observable.Observable<DeathReportUtils.DeathReport>
+): Observable.Observable<DeathReportUtils.DeathReport>
 	assert(typeof(character) == "Instance" and character:IsA("Model"), "Bad character")
 
 	return self._characterKillerSubTable:Observe(character)
@@ -132,19 +132,18 @@ end
 function DeathReportProcessor.ObserveCharacterDeathReports(
 	self: DeathReportProcessor,
 	character: Model
-): _Observable.Observable<DeathReportUtils.DeathReport>
+): Observable.Observable<DeathReportUtils.DeathReport>
 	assert(typeof(character) == "Instance" and character:IsA("Model"), "Bad character")
 
 	return self._characterDeathSubTable:Observe(character)
 end
 
-
 --[=[
 	Handles the death report
 
 	@param deathReport DeathReport
 ]=]
-function DeathReportProcessor.HandleDeathReport(self: DeathReportProcessor,deathReport: DeathReportUtils.DeathReport)
+function DeathReportProcessor.HandleDeathReport(self: DeathReportProcessor, deathReport: DeathReportUtils.DeathReport)
 	assert(DeathReportUtils.isDeathReport(deathReport), "Bad deathreport")
 
 	if deathReport.killerPlayer then
@@ -174,4 +173,4 @@ function DeathReportProcessor.HandleDeathReport(self: DeathReportProcessor,death
 	end
 end
 
-return DeathReportProcessor
+return DeathReportProcessor

package/src/Shared/DeathReportServiceConstants.lua

@@ -7,5 +7,5 @@ local require = require(script.Parent.loader).load(script)
 local Table = require("Table")
 
 return Table.readonly({
-	REMOTE_EVENT_NAME = "DeathReportServiceRemoteEvent";
-})
+	REMOTE_EVENT_NAME = "DeathReportServiceRemoteEvent",
+})

package/src/Shared/Stats/PlayerKillTrackerUtils.lua

@@ -34,4 +34,4 @@ function PlayerKillTrackerUtils.getPlayerKillTracker(binder, team)
 	return BinderUtils.findFirstChild(binder, team)
 end
 
-return PlayerKillTrackerUtils
+return PlayerKillTrackerUtils

package/src/Shared/Stats/TeamKillTrackerUtils.lua

@@ -30,4 +30,4 @@ function TeamKillTrackerUtils.getTeamKillTracker(binder, team)
 	return BinderUtils.findFirstChild(binder, team)
 end
 
-return TeamKillTrackerUtils
+return TeamKillTrackerUtils

package/test/scripts/Client/ClientMain.client.lua

@@ -9,4 +9,4 @@ local serviceBag = require("ServiceBag").new()
 serviceBag:GetService(require("DeathReportServiceClient"))
 
 serviceBag:Init()
-serviceBag:Start()
+serviceBag:Start()

package/test/scripts/Server/ServerMain.server.lua

@@ -12,4 +12,3 @@ serviceBag:GetService(require("DeathReportService"))
 
 serviceBag:Init()
 serviceBag:Start()
-