@quenty/datastore 7.1.0 → 7.2.0

package/CHANGELOG.md

@@ -3,6 +3,22 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [7.2.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/datastore@7.1.0...@quenty/datastore@7.2.0) (2022-10-28)
+
+
+### Bug Fixes
+
+* Import maid ([638e529](https://github.com/Quenty/NevermoreEngine/commit/638e529d87b3ae4df73482e91153540f41baaf36))
+
+
+### Features
+
+* Free DataStore key after its writer GCs to allow future writers ([9b2e8a2](https://github.com/Quenty/NevermoreEngine/commit/9b2e8a29332aacb99ac47550af37708f58cd39e5))
+
+
+
+
+
 # [7.1.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/datastore@7.0.0...@quenty/datastore@7.1.0) (2022-10-11)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/datastore",
-  "version": "7.1.0",
+  "version": "7.2.0",
   "description": "Quenty's Datastore implementation for Roblox",
   "keywords": [
     "Roblox",
@@ -38,5 +38,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "69c2153865684748d0a8d6806f1ff999685c2e55"
+  "gitHead": "70aa9ff7fc254e98d1950a27a4b94751839e6b21"
 }

package/src/Server/Modules/DataStoreStage.lua

@@ -13,6 +13,7 @@ local require = require(script.Parent.loader).load(script)
 local BaseObject = require("BaseObject")
 local DataStoreDeleteToken = require("DataStoreDeleteToken")
 local DataStoreWriter = require("DataStoreWriter")
+local Maid = require("Maid")
 local Promise = require("Promise")
 local PromiseUtils = require("PromiseUtils")
 local Signal = require("Signal")
@@ -241,7 +242,7 @@ end
 	Whenever the ValueObject changes, stores the resulting value in that entry.
 	@param name string
 	@param valueObj Instance -- ValueBase object to store on
-	@return MaidTask
+	@return MaidTask -- Cleanup to remove this writer and free the key.
 ]=]
 function DataStoreStage:StoreOnValueChange(name, valueObj)
 	assert(type(name) == "string", "Bad name")
@@ -251,12 +252,18 @@ function DataStoreStage:StoreOnValueChange(name, valueObj)
 		error(("[DataStoreStage] - Already have a writer for %q"):format(name))
 	end
 
+	local maid = Maid.new()
+
 	self._takenKeys[name] = true
-	local conn = valueObj.Changed:Connect(function()
-		self:_doStore(name, valueObj.Value)
+	maid:GiveTask(function()
+		self._takenKeys[name] = nil
 	end)
-	self._maid:GiveTask(conn)
-	return conn
+
+	maid:GiveTask(valueObj.Changed:Connect(function()
+		self:_doStore(name, valueObj.Value)
+	end))
+
+	return maid
 end
 
 --[=[