@quenty/datastore 13.6.0 → 13.7.0

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [13.7.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/datastore@13.6.0...@quenty/datastore@13.7.0) (2024-09-12)
+
+
+### Features
+
+* Unedited all changes ([60e64e3](https://github.com/Quenty/NevermoreEngine/commit/60e64e3efce17c10c4b8965871187d231b338dd4))
+
+
+
+
+
 # [13.6.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/datastore@13.5.0...@quenty/datastore@13.6.0) (2024-08-09)
 
 **Note:** Version bump only for package @quenty/datastore

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/datastore",
-  "version": "13.6.0",
+  "version": "13.7.0",
   "description": "Quenty's Datastore implementation for Roblox",
   "keywords": [
     "Roblox",
@@ -26,21 +26,21 @@
     "Quenty"
   ],
   "dependencies": {
-    "@quenty/baseobject": "^10.3.0",
-    "@quenty/bindtocloseservice": "^8.4.0",
-    "@quenty/loader": "^10.3.0",
-    "@quenty/maid": "^3.2.0",
+    "@quenty/baseobject": "^10.4.0",
+    "@quenty/bindtocloseservice": "^8.5.0",
+    "@quenty/loader": "^10.4.0",
+    "@quenty/maid": "^3.3.0",
     "@quenty/math": "^2.7.0",
-    "@quenty/promise": "^10.3.0",
-    "@quenty/rx": "^13.4.0",
-    "@quenty/servicebag": "^11.4.0",
-    "@quenty/signal": "^7.3.0",
+    "@quenty/promise": "^10.4.0",
+    "@quenty/rx": "^13.5.0",
+    "@quenty/servicebag": "^11.5.0",
+    "@quenty/signal": "^7.4.0",
     "@quenty/symbol": "^3.1.0",
     "@quenty/table": "^3.5.0",
-    "@quenty/valueobject": "^13.4.0"
+    "@quenty/valueobject": "^13.5.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "ba466bdbc05c42fb607cf5e228c16339201d21d7"
+  "gitHead": "fb172906f3ee725269ec1e5f4daf9dca227e729d"
 }

package/src/Server/GameDataStoreService.lua

@@ -35,7 +35,7 @@ function GameDataStoreService:PromiseDataStore()
 			-- Live sync this stuff pretty frequently
 			local dataStore = DataStore.new(robloxDataStore, self:_getKey())
 			dataStore:SetSyncOnSave(true)
-			dataStore:SetAutoSaveTimeSeconds(15)
+			dataStore:SetAutoSaveTimeSeconds(5)
 
 			self._maid:GiveTask(self._bindToCloseService:RegisterPromiseOnCloseCallback(function()
 				return Promise.defer(function(resolve)

package/src/Server/Modules/DataStoreStage.lua

@@ -57,11 +57,8 @@ function DataStoreStage.new(loadName, loadParent)
 	self._loadName = loadName
 	self._loadParent = loadParent
 
-	self.Changed = GoodSignal.new() -- :Fire(viewSnapshot)
-	self._maid:GiveTask(self.Changed)
-
-	self.DataStored = GoodSignal.new()
-	self._maid:GiveTask(self.DataStored)
+	self.Changed = self._maid:Add(GoodSignal.new()) -- :Fire(viewSnapshot)
+	self.DataStored = self._maid:Add(GoodSignal.new())
 
 	-- Stores the actual data loaded and synced (but not pending written data)
 	self._saveDataSnapshot = nil
@@ -73,8 +70,7 @@ function DataStoreStage.new(loadName, loadParent)
 
 	self._savingCallbacks = {} -- [func, ...]
 
-	self._keySubscriptions = ObservableSubscriptionTable.new()
-	self._maid:GiveTask(self._keySubscriptions)
+	self._keySubscriptions = self._maid:Add(ObservableSubscriptionTable.new())
 
 	return self
 end
@@ -279,6 +275,7 @@ function DataStoreStage:Observe(key, defaultValue)
 		local maid = Maid.new()
 
 		maid:GiveTask(self._keySubscriptions:Observe(key):Subscribe(function(value)
+			print()
 			if value == nil then
 				sub:Fire(defaultValue)
 			else
@@ -610,7 +607,7 @@ function DataStoreStage:HasWritableData()
 
 	for name, store in pairs(self._stores) do
 		if not store.Destroy then
-			warn(("[DataStoreStage] - Substore %q destroyed"):format(name))
+			warn(string.format("[DataStoreStage] - Substore %q destroyed", name))
 			continue
 		end
 
@@ -799,7 +796,7 @@ function DataStoreStage:_updateViewSnapshot()
 			end
 		end
 
-		self.Changed:Fire(self._viewSnapshot)
+		self.Changed:Fire(newViewSnapshot)
 	end
 
 	self:_checkIntegrity()
@@ -844,11 +841,11 @@ function DataStoreStage:_updateViewSnapshotAtKey(key)
 
 	local newSnapshot = table.clone(self._viewSnapshot)
 	newSnapshot[key] = newValue
+	newSnapshot = table.freeze(newSnapshot)
 
-
-	self._viewSnapshot = table.freeze(newSnapshot)
+	self._viewSnapshot = newSnapshot
 	self._keySubscriptions:Fire(key, newValue)
-	self.Changed:Fire(self._viewSnapshot)
+	self.Changed:Fire(newSnapshot)
 
 	self:_checkIntegrity()
 end
@@ -886,7 +883,7 @@ function DataStoreStage:_computeNewViewSnapshot()
 		end
 
 		if next(newView) == nil and not (type(self._baseDataSnapshot) == "table" or type(self._saveDataSnapshot) == "table") then
-			-- We haev no reason to be a table, make sure we return nil
+			-- We have no reason to be a table, make sure we return nil
 			return nil
 		end
 

package/src/Server/Modules/DataStoreWriter.lua

@@ -173,11 +173,7 @@ function DataStoreWriter:_computeTableDiff(original, incoming)
 	if not DataStoreSnapshotUtils.isEmptySnapshot(diffSnapshot) then
 		return table.freeze(diffSnapshot)
 	else
-		if next(keys) then
-			return nil -- No delta
-		else
-			return DataStoreDeleteToken
-		end
+		return nil
 	end
 end
 

package/src/Server/PlayerDataStoreService.lua

@@ -21,13 +21,12 @@ PlayerDataStoreService.ServiceName = "PlayerDataStoreService"
 ]=]
 function PlayerDataStoreService:Init(serviceBag)
 	self._serviceBag = assert(serviceBag, "No serviceBag")
-
 	self._maid = Maid.new()
 
 	-- External
 	self._bindToCloseService = self._serviceBag:GetService(require("BindToCloseService"))
 
-	self._started = self._maid:Add(Promise.new())
+	self._promiseStarted = self._maid:Add(Promise.new())
 
 	self._dataStoreName = "PlayerData"
 	self._dataStoreScope = "SaveData"
@@ -38,7 +37,7 @@ end
 ]=]
 function PlayerDataStoreService:Start()
 	-- Give time for configuration
-	self._started:Resolve()
+	self._promiseStarted:Resolve()
 end
 
 --[=[
@@ -52,8 +51,8 @@ end
 ]=]
 function PlayerDataStoreService:SetDataStoreName(dataStoreName)
 	assert(type(dataStoreName) == "string", "Bad dataStoreName")
-	assert(self._started, "Not initialized")
-	assert(self._started:IsPending(), "Already started, cannot configure")
+	assert(self._promiseStarted, "Not initialized")
+	assert(self._promiseStarted:IsPending(), "Already started, cannot configure")
 
 	self._dataStoreName = dataStoreName
 end
@@ -69,8 +68,8 @@ end
 ]=]
 function PlayerDataStoreService:SetDataStoreScope(dataStoreScope)
 	assert(type(dataStoreScope) == "string", "Bad dataStoreScope")
-	assert(self._started, "Not initialized")
-	assert(self._started:IsPending(), "Already started, cannot configure")
+	assert(self._promiseStarted, "Not initialized")
+	assert(self._promiseStarted:IsPending(), "Already started, cannot configure")
 
 	self._dataStoreScope = dataStoreScope
 end
@@ -108,7 +107,7 @@ function PlayerDataStoreService:PromiseManager()
 		return self._dataStoreManagerPromise
 	end
 
-	self._dataStoreManagerPromise = self._started
+	self._dataStoreManagerPromise = self._promiseStarted
 		:Then(function()
 			return DataStorePromises.promiseDataStore(self._dataStoreName, self._dataStoreScope)
 		end)