@quenty/convexhull 4.9.1 → 4.9.2

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [4.9.2](https://github.com/Quenty/NevermoreEngine/compare/@quenty/convexhull@4.9.1...@quenty/convexhull@4.9.2) (2025-04-05)
+
+
+### Bug Fixes
+
+* Add types to packages ([2374fb2](https://github.com/Quenty/NevermoreEngine/commit/2374fb2b043cfbe0e9b507b3316eec46a4e353a0))
+
+
+
+
+
 ## [4.9.1](https://github.com/Quenty/NevermoreEngine/compare/@quenty/convexhull@4.9.0...@quenty/convexhull@4.9.1) (2025-03-21)
 
 **Note:** Version bump only for package @quenty/convexhull

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/convexhull",
-  "version": "4.9.1",
+  "version": "4.9.2",
   "description": "Convex hull computation algorithms",
   "keywords": [
     "Roblox",
@@ -26,13 +26,13 @@
     "Quenty"
   ],
   "dependencies": {
-    "@quenty/draw": "^7.8.1",
-    "@quenty/loader": "^10.8.0",
-    "@quenty/queue": "^2.3.0",
-    "@quenty/vector3utils": "^10.8.1"
+    "@quenty/draw": "^7.8.2",
+    "@quenty/loader": "^10.8.1",
+    "@quenty/queue": "^2.3.1",
+    "@quenty/vector3utils": "^10.8.2"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "6b7c3e15e60cdb185986207b574e2b5591261e7a"
+  "gitHead": "78c3ac0ab08dd18085b6e6e6e4f745e76ed99f68"
 }

package/src/Shared/ConvexHull2DUtils.lua

@@ -1,3 +1,4 @@
+--!strict
 --[=[
 	@class ConvexHull2DUtils
 ]=]
@@ -11,7 +12,7 @@ local ConvexHull2DUtils = {}
 ]=]
 function ConvexHull2DUtils.convexHull(points: { Vector2 }): { Vector2 }
 	table.sort(points, function(a, b)
-		return a.x < b.x
+		return a.X < b.X
 	end)
 
 	local pointOnHull = points[1]
@@ -22,7 +23,7 @@ function ConvexHull2DUtils.convexHull(points: { Vector2 }): { Vector2 }
 
 		local endpoint = points[1]
 
-		for i=1, #points do
+		for i = 1, #points do
 			local point = points[i]
 
 			-- endpoint == pointOnHull is a rare case and can happen only when j == 1 and a better endpoint has not yet been set for the loop
@@ -40,7 +41,7 @@ end
 	Retrns whether these 3 points are in a clockwise turn
 ]=]
 function ConvexHull2DUtils.isClockWiseTurn(p1: Vector2, p2: Vector2, p3: Vector2): boolean
-	return (p3.y - p1.y)*(p2.x - p1.x) < (p2.y - p1.y)*(p3.x - p1.x)
+	return (p3.Y - p1.Y) * (p2.X - p1.X) < (p2.Y - p1.Y) * (p3.X - p1.X)
 end
 
 --[=[
@@ -49,9 +50,9 @@ end
 function ConvexHull2DUtils.lineIntersect(a: Vector2, b: Vector2, c: Vector2, d: Vector2): Vector2 | nil
 	local r = b - a
 	local s = d - c
-	local dot = r.x * s.y - r.y * s.x
-	local u = ((c.x - a.x) * r.y - (c.y - a.y) * r.x) / dot
-	local t = ((c.x - a.x) * s.y - (c.y - a.y) * s.x) / dot
+	local dot = r.X * s.Y - r.Y * s.X
+	local u = ((c.X - a.X) * r.Y - (c.Y - a.Y) * r.X) / dot
+	local t = ((c.X - a.X) * s.Y - (c.Y - a.Y) * s.X) / dot
 	return (0 <= u and u <= 1 and 0 <= t and t <= 1) and a + t * r or nil
 end
 
@@ -64,21 +65,21 @@ function ConvexHull2DUtils.raycast(from: Vector2, to: Vector2, hull: { Vector2 }
 
 	for i = 1, n do
 		local current = hull[i]
-		local after = hull[i%n + 1]
+		local after = hull[i % n + 1]
 		local point = ConvexHull2DUtils.lineIntersect(current, after, from, to)
 		if point then
 			table.insert(candidates, {
-				point = point;
-				startPoint = current;
-				finishPoint = after;
+				point = point,
+				startPoint = current,
+				finishPoint = after,
 			})
 		end
 	end
 
 	local closest
 	local closestDist = math.huge
-	for _, data in pairs(candidates) do
-		local dist = (data.point - from).magnitude
+	for _, data in candidates do
+		local dist = (data.point - from).Magnitude
 		if dist < closestDist then
 			closest = data
 			closestDist = dist

package/src/Shared/ConvexHull3DUtils.lua

@@ -1,3 +1,4 @@
+--!strict
 --[=[
 	3D convex hull computation using gift wrappling algorithm
 
@@ -13,15 +14,17 @@ local Draw = require("Draw")
 
 local ConvexHull3DUtils = {}
 
+type Edge = { number }
+
 --[=[
 	Computes the convex hull for a given set of points
 
 	https://en.wikipedia.org/wiki/Gift_wrapping_algorithm
 
-	@param points Vector3
+	@param points { Vector3 }
 	@return { Vector3 }
 ]=]
-function ConvexHull3DUtils.convexHull(points)
+function ConvexHull3DUtils.convexHull(points: { Vector3 }): { Vector3 }
 	assert(type(points) == "table", "Bad points")
 
 	if #points <= 3 then
@@ -39,7 +42,7 @@ function ConvexHull3DUtils.convexHull(points)
 
 	local visited = {} -- Set to keep track of visited edges
 
-	local agenda = Queue.new() -- Queue to process edgeSet
+	local agenda: Queue.Queue<Edge> = Queue.new() -- Queue to process edgeSet
 	agenda:PushRight({ leftMost, secondPoint })
 
 	while not agenda:IsEmpty() do
@@ -59,20 +62,20 @@ function ConvexHull3DUtils.convexHull(points)
 	end
 
 	local vertices = {}
-	for index, _ in pairs(meshIndexSet) do
+	for index, _ in meshIndexSet do
 		table.insert(vertices, points[index])
 	end
 
 	return vertices
 end
 
-function ConvexHull3DUtils._pickMostConvex(points, edge)
+function ConvexHull3DUtils._pickMostConvex(points: { Vector3 }, edge: Edge): number
 	local bestIndex = 0
 	local bestAngle = -math.huge
-	local diffEdge = (points[edge[2]] - points[edge[1]]).unit
+	local diffEdge = (points[edge[2]] - points[edge[1]]).Unit
 
-	for index, point in pairs(points) do
-		local diff = (points[edge[2]] - point).unit
+	for index, point in points do
+		local diff = (points[edge[2]] - point).Unit
 		local angle = math.acos(diff:Dot(diffEdge))
 
 		if angle > bestAngle and angle < math.pi then
@@ -84,26 +87,26 @@ function ConvexHull3DUtils._pickMostConvex(points, edge)
 	return bestIndex
 end
 
-function ConvexHull3DUtils._pickLeftMost(points)
+function ConvexHull3DUtils._pickLeftMost(points: { Vector3 }): number
 	local leftmostIndex = 1
 	local leftMostX = math.huge
-	for index, point in pairs(points) do
-		if point.x < leftMostX then
+	for index, point in points do
+		if point.X < leftMostX then
 			leftmostIndex = index
-			leftMostX = point.x
+			leftMostX = point.X
 		end
 	end
 
 	return leftmostIndex
 end
 
-function ConvexHull3DUtils._pickSecondPoint(points, leftMost)
+function ConvexHull3DUtils._pickSecondPoint(points: { Vector3 }, leftMost: number): number
 	local v0 = Vector3.new(1, 0, 0)
 	local bestAngle = -math.huge
 	local bestIndex = 1
 
-	for index, point in pairs(points) do
-		local diff = (point - points[leftMost]).unit
+	for index, point in points do
+		local diff = (point - points[leftMost]).Unit
 		local angle = math.acos(diff:Dot(v0))
 
 		if angle > bestAngle and angle < math.pi then
@@ -115,16 +118,16 @@ function ConvexHull3DUtils._pickSecondPoint(points, leftMost)
 	return bestIndex
 end
 
-function ConvexHull3DUtils._edgeKey(edge)
+function ConvexHull3DUtils._edgeKey(edge: Edge): string
 	return edge[1] .. "-" .. edge[2]
 end
 
-function ConvexHull3DUtils.drawVertices(points, color)
+function ConvexHull3DUtils.drawVertices(points: { Vector3 }, color: Color3?): Folder
 	local folder = Instance.new("Folder")
 	folder.Name = "ConvexHullPoints"
 	folder.Archivable = false
 
-	for _, point in pairs(points) do
+	for _, point in points do
 		Draw.point(point, color, folder)
 	end
 

package/src/Shared/ConvexHull3DUtils.story.lua

@@ -41,7 +41,7 @@ local function drawBlockCast(cframe, size, direction)
 	box2.Parent = folder
 
 	local points = {}
-	for _, corner in pairs(CORNERS) do
+	for _, corner in CORNERS do
 		local beginPoint = beginCFrame:PointToWorldSpace(corner * size)
 		local finishPoint = finishCFrame:PointToWorldSpace(corner * size)