@quenty/cmdrservice 13.45.2 → 13.46.0

package/CHANGELOG.md

@@ -3,6 +3,12 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [13.46.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/cmdrservice@13.45.2...@quenty/cmdrservice@13.46.0) (2026-07-14)
+
+### Features
+
+- **cmdrservice:** convert package to --!strict ([b5662ad](https://github.com/Quenty/NevermoreEngine/commit/b5662adab31b5fad3e15977b45f50ee277c41299))
+
 ## [13.45.2](https://github.com/Quenty/NevermoreEngine/compare/@quenty/cmdrservice@13.45.1...@quenty/cmdrservice@13.45.2) (2026-06-03)
 
 ### Bug Fixes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/cmdrservice",
-  "version": "13.45.2",
+  "version": "13.46.0",
   "description": "Bridge between cmdr and Nevermore services using servicebag",
   "keywords": [
     "Roblox",
@@ -31,16 +31,16 @@
     "@quenty/loader": "10.11.0",
     "@quenty/maid": "3.9.0",
     "@quenty/nevermore-test-runner": "1.4.0",
-    "@quenty/permissionprovider": "14.38.2",
+    "@quenty/permissionprovider": "14.39.0",
     "@quenty/promise": "10.18.1",
     "@quenty/remoting": "12.32.1",
     "@quenty/servicebag": "11.18.1",
     "@quenty/string": "3.3.7",
-    "@quenty/templateprovider": "11.38.1",
+    "@quenty/templateprovider": "11.39.0",
     "@quentystudios/cmdr": "^1.12.0-quenty.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "1acafc712ce34f5dbaa70bb23b16da95e9cd3f82"
+  "gitHead": "13f0162f4971a77378e55e9b7236aea94f0dd3a8"
 }

package/src/Client/CmdrServiceClient.lua

@@ -1,4 +1,4 @@
---!nonstrict
+--!strict
 --[=[
 	Loads cmdr on the client. See [CmdrService] for the server equivalent.
 
@@ -23,19 +23,29 @@ local promiseChild = require("promiseChild")
 local CmdrServiceClient = {}
 CmdrServiceClient.ServiceName = "CmdrServiceClient"
 
+export type CmdrServiceClient = typeof(setmetatable(
+	{} :: {
+		_serviceBag: ServiceBag.ServiceBag,
+		_maid: Maid.Maid,
+		_permissionServiceClient: any,
+		_cmdrPromise: Promise.Promise<any>?,
+	},
+	{} :: typeof({ __index = CmdrServiceClient })
+))
+
 --[=[
 	Starts the cmdr service on the client. Should be done via [ServiceBag].
 	@param serviceBag ServiceBag
 ]=]
-function CmdrServiceClient:Init(serviceBag: ServiceBag.ServiceBag)
-	assert(not self._serviceBag, "Already initialized")
+function CmdrServiceClient.Init(self: CmdrServiceClient, serviceBag: ServiceBag.ServiceBag): ()
+	assert(not (self :: any)._serviceBag, "Already initialized")
 	self._serviceBag = assert(serviceBag, "No serviceBag")
 	self._maid = Maid.new()
 
 	self._permissionServiceClient = self._serviceBag:GetService(PermissionServiceClient)
 
 	self:PromiseCmdr():Then(function(cmdr)
-		cmdr.Registry:RegisterHook("BeforeRun", function(context)
+		cmdr.Registry:RegisterHook("BeforeRun", function(context): string?
 			-- allow!
 			if context.Executor == nil then
 				return nil
@@ -78,26 +88,23 @@ end
 --[=[
 	Starts the service. Should be done via [ServiceBag].
 ]=]
-function CmdrServiceClient:Start()
-	assert(self._serviceBag, "Not initialized")
-
-	self._maid
-		:GivePromise(PromiseUtils.all({
-			self:PromiseCmdr(),
-			self._maid:GivePromise(self._permissionServiceClient:PromisePermissionProvider()):Then(function(provider)
-				return provider:PromiseIsAdmin()
-			end),
-		}))
-		:Then(function(cmdr, isAdmin)
-			if isAdmin then
-				self:_setBindings(cmdr)
-			else
-				cmdr:SetActivationKeys({})
-			end
-		end)
+function CmdrServiceClient.Start(self: CmdrServiceClient): ()
+	assert(self._serviceBag, "Not initialized");
+	(self._maid:GivePromise(PromiseUtils.all({
+		self:PromiseCmdr(),
+		self._maid:GivePromise(self._permissionServiceClient:PromisePermissionProvider()):Then(function(provider)
+			return provider:PromiseIsAdmin()
+		end),
+	})) :: any):Then(function(cmdr: any, isAdmin: any)
+		if isAdmin then
+			self:_setBindings(cmdr)
+		else
+			cmdr:SetActivationKeys({})
+		end
+	end)
 end
 
-function CmdrServiceClient:_setBindings(cmdr)
+function CmdrServiceClient._setBindings(self: CmdrServiceClient, cmdr: any): ()
 	cmdr:SetActivationUnlocksMouse(true)
 	cmdr:SetActivationKeys({ Enum.KeyCode.F2 })
 
@@ -119,7 +126,7 @@ end
 	Retrieves the cmdr for the client.
 	@return Promise<CmdrClient>
 ]=]
-function CmdrServiceClient:PromiseCmdr()
+function CmdrServiceClient.PromiseCmdr(self: CmdrServiceClient): Promise.Promise<any>
 	assert(self._serviceBag, "Not initialized")
 
 	if self._cmdrPromise then
@@ -132,20 +139,21 @@ function CmdrServiceClient:PromiseCmdr()
 		timeout = 1e10
 	end
 
-	self._cmdrPromise = self._maid
+	local cmdrPromise = self._maid
 		:GivePromise(promiseChild(ReplicatedStorage, "CmdrClient", timeout))
 		:Then(function(cmdClient)
-			return Promise.spawn(function(resolve, _reject)
+			return (Promise :: any).spawn(function(resolve: any, _reject: any)
 				-- Requiring cmdr can yield
-				return resolve(require(cmdClient))
+				return resolve((require :: any)(cmdClient))
 			end)
 		end)
-	self._maid:GiveTask(self._cmdrPromise)
+	self._cmdrPromise = cmdrPromise
+	self._maid:GiveTask(cmdrPromise)
 
-	return self._cmdrPromise
+	return cmdrPromise
 end
 
-function CmdrServiceClient:Destroy()
+function CmdrServiceClient.Destroy(self: CmdrServiceClient): ()
 	self._maid:DoCleaning()
 end
 

package/src/Server/CmdrService.lua

@@ -1,4 +1,4 @@
---!nonstrict
+--!strict
 --[=[
 	Bridge to https://eryn.io/Cmdr/
 
@@ -36,19 +36,19 @@ export type CmdrService = typeof(setmetatable(
 	{} :: typeof({ __index = CmdrService })
 ))
 
-local GLOBAL_REGISTRY = setmetatable({}, { __mode = "kv" })
+local GLOBAL_REGISTRY: { [string]: CmdrService } = setmetatable({}, { __mode = "kv" }) :: any
 
 --[=[
 	Initializes the CmdrService. Should be done via [ServiceBag].
 	@param serviceBag ServiceBag
 ]=]
-function CmdrService.Init(self: CmdrService, serviceBag: ServiceBag.ServiceBag)
+function CmdrService.Init(self: CmdrService, serviceBag: ServiceBag.ServiceBag): ()
 	assert(not (self :: any)._serviceBag, "Already initialized")
 	self._maid = Maid.new()
 	self._serviceBag = assert(serviceBag, "No serviceBag")
 
 	-- External
-	self._permissionService = self._serviceBag:GetService(PermissionService)
+	self._permissionService = self._serviceBag:GetService(PermissionService) :: any
 
 	-- Internal
 	self._cmdrTemplateProviderServer = self._serviceBag:GetService(CmdrTemplateProviderServer)
@@ -79,7 +79,7 @@ function CmdrService.Init(self: CmdrService, serviceBag: ServiceBag.ServiceBag)
 			cmdr:RegisterDefaultCommands()
 		end)
 
-		cmdr.Registry:RegisterHook("BeforeRun", function(context)
+		cmdr.Registry:RegisterHook("BeforeRun", function(context): string?
 			-- allow!
 			if context.Executor == nil then
 				return nil
@@ -115,7 +115,7 @@ end
 	Returns cmdr
 	@return Promise<Cmdr>
 ]=]
-function CmdrService.PromiseCmdr(self: CmdrService)
+function CmdrService.PromiseCmdr(self: CmdrService): Promise.Promise<any>
 	assert(self._promiseCmdr, "Not initialized")
 
 	return self._promiseCmdr
@@ -197,13 +197,13 @@ end
 	@return CmdrService
 	@private
 ]=]
-function CmdrService.__getServiceFromId(_self: CmdrService, cmdrServiceId: string)
+function CmdrService.__getServiceFromId(_self: CmdrService, cmdrServiceId: string): CmdrService?
 	assert(type(cmdrServiceId) == "string", "Bad cmdrServiceId")
 
 	return GLOBAL_REGISTRY[cmdrServiceId]
 end
 
-function CmdrService.Destroy(self: CmdrService)
+function CmdrService.Destroy(self: CmdrService): ()
 	self._maid:DoCleaning()
 end
 

package/src/Server/CmdrTemplateProviderServer/CmdrExecutionTemplate.lua

@@ -1,23 +1,25 @@
---!nonstrict
+--!strict
 --[=[
 	Generic command definition template which we can use to
 	@class CmdrExecutionTemplate
 ]=]
 
-local function waitForValue(objectValue)
-	local value = objectValue.Value
+local function waitForValue(objectValue: Instance): any
+	local value = (objectValue :: any).Value
 	if value then
 		return value
 	end
 
-	return objectValue.Changed:Wait()
+	return (objectValue :: any).Changed:Wait()
 end
 
 local cmdrServiceId = waitForValue(script:WaitForChild("CmdrServiceId"))
 local cmdrCommandId = waitForValue(script:WaitForChild("CmdrCommandId"))
-local commandServiceDefinition = require(waitForValue(script:WaitForChild("CmdrServiceTarget")))
+local commandServiceDefinition = (require :: any)(
+	waitForValue(script:WaitForChild("CmdrServiceTarget")) :: ModuleScript
+)
 local cmdrService = commandServiceDefinition:__getServiceFromId(cmdrServiceId)
 
-return function(...)
+return function(...: any): any
 	return cmdrService:__executeCommand(cmdrCommandId, ...)
 end