@quenty/cmdrservice 13.22.3 → 13.22.4-canary.559.339cfa7.0

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [13.22.4-canary.559.339cfa7.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/cmdrservice@13.22.3...@quenty/cmdrservice@13.22.4-canary.559.339cfa7.0) (2025-05-10)
+
+
+### Bug Fixes
+
+* Additional type checking updates ([05ba29a](https://github.com/Quenty/NevermoreEngine/commit/05ba29a03efc9f3feed74b34f1d9dfb237496214))
+
+
+
+
+
 ## [13.22.3](https://github.com/Quenty/NevermoreEngine/compare/@quenty/cmdrservice@13.22.2...@quenty/cmdrservice@13.22.3) (2025-04-10)
 
 **Note:** Version bump only for package @quenty/cmdrservice

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/cmdrservice",
-  "version": "13.22.3",
+  "version": "13.22.4-canary.559.339cfa7.0",
   "description": "Bridge between cmdr and Nevermore services using servicebag",
   "keywords": [
     "Roblox",
@@ -25,18 +25,18 @@
     "Quenty"
   ],
   "dependencies": {
-    "@quenty/loader": "^10.8.3",
-    "@quenty/maid": "^3.4.3",
-    "@quenty/permissionprovider": "^14.19.3",
-    "@quenty/promise": "^10.10.4",
-    "@quenty/remoting": "^12.18.3",
-    "@quenty/servicebag": "^11.11.4",
-    "@quenty/string": "^3.3.3",
-    "@quenty/templateprovider": "^11.18.3",
+    "@quenty/loader": "10.8.4-canary.559.339cfa7.0",
+    "@quenty/maid": "3.4.4-canary.559.339cfa7.0",
+    "@quenty/permissionprovider": "14.19.4-canary.559.339cfa7.0",
+    "@quenty/promise": "10.10.5-canary.559.339cfa7.0",
+    "@quenty/remoting": "12.18.4-canary.559.339cfa7.0",
+    "@quenty/servicebag": "11.11.5-canary.559.339cfa7.0",
+    "@quenty/string": "3.3.3",
+    "@quenty/templateprovider": "11.18.4-canary.559.339cfa7.0",
     "@quentystudios/cmdr": "^1.12.0-quenty.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "b06c070ae91d5dab7bd8de6e290ad2caabb15d8f"
+  "gitHead": "339cfa778736f08768ed7305041f6221faa35bfc"
 }

package/src/Client/CmdrServiceClient.lua

@@ -7,17 +7,17 @@
 
 local require = require(script.Parent.loader).load(script)
 
-local ReplicatedStorage = game:GetService("ReplicatedStorage")
 local Players = game:GetService("Players")
+local ReplicatedStorage = game:GetService("ReplicatedStorage")
 local RunService = game:GetService("RunService")
 
 local Maid = require("Maid")
 local PermissionServiceClient = require("PermissionServiceClient")
 local Promise = require("Promise")
-local promiseChild = require("promiseChild")
 local PromiseUtils = require("PromiseUtils")
+local ServiceBag = require("ServiceBag")
 local String = require("String")
-local _ServiceBag = require("ServiceBag")
+local promiseChild = require("promiseChild")
 
 local CmdrServiceClient = {}
 CmdrServiceClient.ServiceName = "CmdrServiceClient"
@@ -26,7 +26,7 @@ CmdrServiceClient.ServiceName = "CmdrServiceClient"
 	Starts the cmdr service on the client. Should be done via [ServiceBag].
 	@param serviceBag ServiceBag
 ]=]
-function CmdrServiceClient:Init(serviceBag: _ServiceBag.ServiceBag)
+function CmdrServiceClient:Init(serviceBag: ServiceBag.ServiceBag)
 	assert(not self._serviceBag, "Already initialized")
 	self._serviceBag = assert(serviceBag, "No serviceBag")
 	self._maid = Maid.new()
@@ -80,20 +80,20 @@ end
 function CmdrServiceClient:Start()
 	assert(self._serviceBag, "Not initialized")
 
-	self._maid:GivePromise(PromiseUtils.all({
-		self:PromiseCmdr(),
-		self._maid:GivePromise(self._permissionServiceClient:PromisePermissionProvider())
-			:Then(function(provider)
+	self._maid
+		:GivePromise(PromiseUtils.all({
+			self:PromiseCmdr(),
+			self._maid:GivePromise(self._permissionServiceClient:PromisePermissionProvider()):Then(function(provider)
 				return provider:PromiseIsAdmin()
-			end)
-	}))
-	:Then(function(cmdr, isAdmin)
-		if isAdmin then
-			self:_setBindings(cmdr)
-		else
-			cmdr:SetActivationKeys({})
-		end
-	end)
+			end),
+		}))
+		:Then(function(cmdr, isAdmin)
+			if isAdmin then
+				self:_setBindings(cmdr)
+			else
+				cmdr:SetActivationKeys({})
+			end
+		end)
 end
 
 function CmdrServiceClient:_setBindings(cmdr)
@@ -107,7 +107,6 @@ function CmdrServiceClient:_setBindings(cmdr)
 		end
 	end))
 
-
 	-- Race condition
 	task.defer(function()
 		-- Default blink for debugging purposes
@@ -132,7 +131,8 @@ function CmdrServiceClient:PromiseCmdr()
 		timeout = 1e10
 	end
 
-	self._cmdrPromise = self._maid:GivePromise(promiseChild(ReplicatedStorage, "CmdrClient", timeout))
+	self._cmdrPromise = self._maid
+		:GivePromise(promiseChild(ReplicatedStorage, "CmdrClient", timeout))
 		:Then(function(cmdClient)
 			return Promise.spawn(function(resolve, _reject)
 				-- Requiring cmdr can yield
@@ -148,4 +148,4 @@ function CmdrServiceClient:Destroy()
 	self._maid:DoCleaning()
 end
 
-return CmdrServiceClient
+return CmdrServiceClient

package/src/Server/CmdrService.lua

@@ -12,11 +12,11 @@ local HttpService = game:GetService("HttpService")
 local RunService = game:GetService("RunService")
 
 local CmdrTemplateProviderServer = require("CmdrTemplateProviderServer")
-local Promise = require("Promise")
+local CmdrTypes = require("CmdrTypes")
 local Maid = require("Maid")
 local PermissionService = require("PermissionService")
-local _ServiceBag = require("ServiceBag")
-local _CmdrTypes = require("CmdrTypes")
+local Promise = require("Promise")
+local ServiceBag = require("ServiceBag")
 
 local CmdrService = {}
 CmdrService.ServiceName = "CmdrService"
@@ -24,13 +24,13 @@ CmdrService.ServiceName = "CmdrService"
 export type CmdrService = typeof(setmetatable(
 	{} :: {
 		_maid: Maid.Maid,
-		_serviceBag: _ServiceBag.ServiceBag,
+		_serviceBag: ServiceBag.ServiceBag,
 		_serviceId: string,
 		_promiseCmdr: Promise.Promise<any>,
 		_cmdrTemplateProviderServer: any,
 		_permissionService: PermissionService.PermissionService,
-		_definitionData: { [string]: _CmdrTypes.CommandDefinition },
-		_executeData: { [string]: (context: _CmdrTypes.CommandContext, ...any) -> string? },
+		_definitionData: { [string]: CmdrTypes.CommandDefinition },
+		_executeData: { [string]: (context: CmdrTypes.CommandContext, ...any) -> string? },
 	},
 	{} :: typeof({ __index = CmdrService })
 ))
@@ -41,7 +41,7 @@ local GLOBAL_REGISTRY = setmetatable({}, { __mode = "kv" })
 	Initializes the CmdrService. Should be done via [ServiceBag].
 	@param serviceBag ServiceBag
 ]=]
-function CmdrService.Init(self: CmdrService, serviceBag: _ServiceBag.ServiceBag)
+function CmdrService.Init(self: CmdrService, serviceBag: ServiceBag.ServiceBag)
 	assert(not (self :: any)._serviceBag, "Already initialized")
 	self._maid = Maid.new()
 	self._serviceBag = assert(serviceBag, "No serviceBag")
@@ -127,8 +127,8 @@ end
 ]=]
 function CmdrService.RegisterCommand(
 	self: CmdrService,
-	commandData: _CmdrTypes.CommandDefinition,
-	execute: (context: _CmdrTypes.CommandContext, ...any) -> string?
+	commandData: CmdrTypes.CommandDefinition,
+	execute: (context: CmdrTypes.CommandContext, ...any) -> string?
 ): ()
 	assert((self :: any)._promiseCmdr, "Not initialized")
 	assert(commandData, "No commandData")
@@ -206,4 +206,4 @@ function CmdrService.Destroy(self: CmdrService)
 	self._maid:DoCleaning()
 end
 
-return CmdrService
+return CmdrService

package/src/Server/CmdrTemplateProviderServer/CmdrCommandDefinitionTemplate.lua

@@ -6,4 +6,4 @@
 local HttpService = game:GetService("HttpService")
 
 local value = script:WaitForChild("CmdrJsonCommandData")
-return HttpService:JSONDecode(value.Value)
+return HttpService:JSONDecode(value.Value)

package/src/Server/CmdrTemplateProviderServer/CmdrExecutionTemplate.lua

@@ -19,4 +19,4 @@ local cmdrService = commandServiceDefinition:__getServiceFromId(cmdrServiceId)
 
 return function(...)
 	return cmdrService:__executeCommand(cmdrCommandId, ...)
-end
+end

package/src/Server/CmdrTemplateProviderServer/init.lua

@@ -7,4 +7,4 @@ local require = require(script.Parent.loader).load(script)
 
 local TemplateProvider = require("TemplateProvider")
 
-return TemplateProvider.new(script.Name, script)
+return TemplateProvider.new(script.Name, script)

package/src/Shared/CmdrTypes.lua

@@ -1,46 +1,46 @@
 --!strict
 
 export type NamedObject = {
-    Name: string
+	Name: string,
 }
 
 export type TypeDefinition<T> = {
-    DisplayName: string?,
-    Prefixes: string?,
-    Transform: ((string, Player) -> T)?,
-    Validate: ((T) -> (boolean, string?) | boolean)?,
-    ValidateOnce: ((T) -> (boolean, string?) | boolean)?,
-    Autocomplete: ((T) -> ({ string }, { IsPartial: boolean? }?) | { string })?,
-    Parse: (T) -> any,
-    Default: ((Player) -> string)?,
-    Listable: boolean?,
+	DisplayName: string?,
+	Prefixes: string?,
+	Transform: ((string, Player) -> T)?,
+	Validate: ((T) -> (boolean, string?) | boolean)?,
+	ValidateOnce: ((T) -> (boolean, string?) | boolean)?,
+	Autocomplete: ((T) -> ({ string }, { IsPartial: boolean? }?) | { string })?,
+	Parse: (T) -> any,
+	Default: ((Player) -> string)?,
+	Listable: boolean?,
 }
 
 export type CommandArgument = {
-    Type: string | TypeDefinition<any>,
-    Name: string,
-    Description: string,
-    Optional: boolean?,
-    Default: any?,
+	Type: string | TypeDefinition<any>,
+	Name: string,
+	Description: string,
+	Optional: boolean?,
+	Default: any?,
 }
 
 export type CommandContext = {
-    GetData: (self: CommandContext) -> any,
-    GetPlayer: (self: CommandContext) -> Player,
-    GetArgs: (self: CommandContext) -> { any },
-    GetCommandName: (self: CommandContext) -> string,
-    GetCommandId: (self: CommandContext) -> string,
+	GetData: (self: CommandContext) -> any,
+	GetPlayer: (self: CommandContext) -> Player,
+	GetArgs: (self: CommandContext) -> { any },
+	GetCommandName: (self: CommandContext) -> string,
+	GetCommandId: (self: CommandContext) -> string,
 }
 
 export type CommandDefinition = {
-    Name: string,
-    Aliases: { string }?,
-    Description: string,
-    Group: any?,
-    Args: { CommandArgument | (CommandContext) -> CommandArgument },
-    Data: ((CommandContext) -> any)?,
-    ClientRun: ((CommandContext, ...any) -> string?)?,
-    AutoExec: { string }?,
+	Name: string,
+	Aliases: { string }?,
+	Description: string,
+	Group: any?,
+	Args: { CommandArgument | (CommandContext) -> CommandArgument },
+	Data: ((CommandContext) -> any)?,
+	ClientRun: ((CommandContext, ...any) -> string?)?,
+	AutoExec: { string }?,
 }
 
-return {}
+return {}

package/test/scripts/Client/ClientMain.client.lua

@@ -9,4 +9,4 @@ local serviceBag = require("ServiceBag").new()
 serviceBag:GetService(require("CmdrServiceClient"))
 
 serviceBag:Init()
-serviceBag:Start()
+serviceBag:Start()

package/test/scripts/Server/ServerMain.server.lua

@@ -13,17 +13,17 @@ serviceBag:Init()
 serviceBag:Start()
 
 serviceBag:GetService(require("CmdrService")):RegisterCommand({
-	Name = "explode";
-	Aliases = { "boom" };
-	Description = "Makes players explode";
-	Group = "Admin";
+	Name = "explode",
+	Aliases = { "boom" },
+	Description = "Makes players explode",
+	Group = "Admin",
 	Args = {
 		{
-			Name = "Players";
-			Type = "players";
-			Description = "Victims";
+			Name = "Players",
+			Type = "players",
+			Description = "Victims",
 		},
-	};
+	},
 }, function(_context, players)
 	for _, player in players do
 		local humanoid = player.Character and player.Character:FindFirstChildWhichIsA("Humanoid")
@@ -36,4 +36,4 @@ serviceBag:GetService(require("CmdrService")):RegisterCommand({
 	end
 
 	return "Exploded!"
-end)
+end)