@quenty/clipcharacters 12.19.3 → 12.19.4-canary.11a5dcf.0

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [12.19.4-canary.11a5dcf.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/clipcharacters@12.19.3...@quenty/clipcharacters@12.19.4-canary.11a5dcf.0) (2025-05-10)
+
+
+### Bug Fixes
+
+* Additional type checking updates ([05ba29a](https://github.com/Quenty/NevermoreEngine/commit/05ba29a03efc9f3feed74b34f1d9dfb237496214))
+
+
+
+
+
 ## [12.19.3](https://github.com/Quenty/NevermoreEngine/compare/@quenty/clipcharacters@12.19.2...@quenty/clipcharacters@12.19.3) (2025-04-10)
 
 **Note:** Version bump only for package @quenty/clipcharacters

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/clipcharacters",
-  "version": "12.19.3",
+  "version": "12.19.4-canary.11a5dcf.0",
   "description": "Clip characters locally on the client of other clients so they don't interfer with physics.",
   "keywords": [
     "Roblox",
@@ -25,20 +25,20 @@
     "Quenty"
   ],
   "dependencies": {
-    "@quenty/baseobject": "^10.8.3",
-    "@quenty/brio": "^14.17.3",
-    "@quenty/characterutils": "^12.18.3",
-    "@quenty/loader": "^10.8.3",
-    "@quenty/maid": "^3.4.3",
-    "@quenty/playerutils": "^8.17.3",
-    "@quenty/remoting": "^12.18.3",
-    "@quenty/servicebag": "^11.11.4",
-    "@quenty/statestack": "^14.18.3",
-    "@quenty/table": "^3.7.4",
-    "@quenty/valueobject": "^13.17.3"
+    "@quenty/baseobject": "10.8.4-canary.11a5dcf.0",
+    "@quenty/brio": "14.17.4-canary.11a5dcf.0",
+    "@quenty/characterutils": "12.18.4-canary.11a5dcf.0",
+    "@quenty/loader": "10.8.4-canary.11a5dcf.0",
+    "@quenty/maid": "3.4.4-canary.11a5dcf.0",
+    "@quenty/playerutils": "8.17.4-canary.11a5dcf.0",
+    "@quenty/remoting": "12.18.4-canary.11a5dcf.0",
+    "@quenty/servicebag": "11.11.5-canary.11a5dcf.0",
+    "@quenty/statestack": "14.18.4-canary.11a5dcf.0",
+    "@quenty/table": "3.7.5-canary.11a5dcf.0",
+    "@quenty/valueobject": "13.17.4-canary.11a5dcf.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "b06c070ae91d5dab7bd8de6e290ad2caabb15d8f"
+  "gitHead": "11a5dcf7d4c7a0bfbf3337e97d30e8346ea09d3f"
 }

package/src/Client/ClipCharacters.lua

@@ -1,3 +1,4 @@
+--!strict
 --[=[
 	Clip characters locally on the client of other clients so they don't interfer with physics.
 	@class ClipCharacters
@@ -7,6 +8,7 @@ local require = require(script.Parent.loader).load(script)
 
 local BaseObject = require("BaseObject")
 local ClipCharactersServiceConstants = require("ClipCharactersServiceConstants")
+local Maid = require("Maid")
 local RxBrioUtils = require("RxBrioUtils")
 local RxCharacterUtils = require("RxCharacterUtils")
 local RxPlayerUtils = require("RxPlayerUtils")
@@ -15,45 +17,49 @@ local ClipCharacters = setmetatable({}, BaseObject)
 ClipCharacters.ClassName = "ClipCharacters"
 ClipCharacters.__index = ClipCharacters
 
+export type ClipCharacters = typeof(setmetatable({}, {} :: typeof({ __index = ClipCharacters }))) & BaseObject.BaseObject
+
 --[=[
 	Prevents characters from clipping together
 
 	@return ClipCharacters
 ]=]
-function ClipCharacters.new()
-	local self = setmetatable(BaseObject.new(), ClipCharacters)
-
-	self._maid:GiveTask(RxPlayerUtils.observePlayersBrio():Pipe({
-		RxBrioUtils.flatMapBrio(function(player)
-			return RxCharacterUtils.observeLastCharacterBrio(player)
-		end)
-	}):Subscribe(function(brio)
-		if brio:IsDead() then
-			return
-		end
-
-		local maid, character = brio:ToMaidAndValue()
-		self:_setupCharacter(maid, character)
-	end))
+function ClipCharacters.new(): ClipCharacters
+	local self = setmetatable(BaseObject.new() :: any, ClipCharacters)
+
+	self._maid:GiveTask(RxPlayerUtils.observePlayersBrio()
+		:Pipe({
+			RxBrioUtils.flatMapBrio(function(player)
+				return RxCharacterUtils.observeLastCharacterBrio(player)
+			end) :: any,
+		})
+		:Subscribe(function(brio)
+			if brio:IsDead() then
+				return
+			end
+
+			local maid, character = brio:ToMaidAndValue()
+			self:_setupCharacter(maid, character)
+		end))
 
 	return self
 end
 
-function ClipCharacters:_onDescendantAdded(originalTable, descendant)
+function ClipCharacters._onDescendantAdded(_self: ClipCharacters, originalTable, descendant: Instance)
 	if not originalTable[descendant] and descendant:IsA("BasePart") then
 		originalTable[descendant] = descendant.CollisionGroup
 		descendant.CollisionGroup = ClipCharactersServiceConstants.COLLISION_GROUP_NAME
 	end
 end
 
-function ClipCharacters:_onDescendantRemoving(originalTable, descendant)
+function ClipCharacters._onDescendantRemoving(_self: ClipCharacters, originalTable, descendant)
 	if originalTable[descendant] then
 		descendant.CollisionGroup = originalTable[descendant]
 		originalTable[descendant] = nil
 	end
 end
 
-function ClipCharacters:_setupCharacter(maid, character)
+function ClipCharacters._setupCharacter(self: ClipCharacters, maid: Maid.Maid, character: Model)
 	local originalTable = {}
 
 	maid:GiveTask(character.DescendantAdded:Connect(function(descendant)
@@ -77,4 +83,4 @@ function ClipCharacters:_setupCharacter(maid, character)
 	end
 end
 
-return ClipCharacters
+return ClipCharacters

package/src/Client/ClipCharactersServiceClient.lua

@@ -6,13 +6,13 @@ local require = require(script.Parent.loader).load(script)
 
 local ClipCharacters = require("ClipCharacters")
 local Maid = require("Maid")
+local ServiceBag = require("ServiceBag")
 local StateStack = require("StateStack")
-local _ServiceBag = require("ServiceBag")
 
 local ClipCharactersServiceClient = {}
 ClipCharactersServiceClient.ServiceName = "ClipCharactersServiceClient"
 
-function ClipCharactersServiceClient:Init(serviceBag: _ServiceBag.ServiceBag)
+function ClipCharactersServiceClient:Init(serviceBag: ServiceBag.ServiceBag)
 	assert(not self._serviceBag, "Already initialized")
 	self._serviceBag = assert(serviceBag, "No serviceBag")
 	self._maid = Maid.new()
@@ -29,20 +29,22 @@ function ClipCharactersServiceClient:PushDisableCharacterCollisionsWithDefault()
 end
 
 function ClipCharactersServiceClient:Start()
-	self._maid:GiveTask(self._disableCollisions:ObserveBrio(function(value)
-		return value
-	end):Subscribe(function(brio)
-		if brio:IsDead() then
-			return
-		end
-
-		local maid = brio:ToMaid()
-		maid:GiveTask(ClipCharacters.new())
-	end))
+	self._maid:GiveTask(self._disableCollisions
+		:ObserveBrio(function(value)
+			return value
+		end)
+		:Subscribe(function(brio)
+			if brio:IsDead() then
+				return
+			end
+
+			local maid = brio:ToMaid()
+			maid:GiveTask(ClipCharacters.new())
+		end))
 end
 
 function ClipCharactersServiceClient:Destroy()
 	self._maid:DoCleaning()
 end
 
-return ClipCharactersServiceClient
+return ClipCharactersServiceClient

package/src/Server/ClipCharactersService.lua

@@ -6,14 +6,14 @@ local require = require(script.Parent.loader).load(script)
 
 local PhysicsService = game:GetService("PhysicsService")
 
-local Maid = require("Maid")
 local ClipCharactersServiceConstants = require("ClipCharactersServiceConstants")
-local _ServiceBag = require("ServiceBag")
+local Maid = require("Maid")
+local ServiceBag = require("ServiceBag")
 
 local ClipCharactersService = {}
 ClipCharactersService.ServiceName = "ClipCharactersService"
 
-function ClipCharactersService:Init(serviceBag: _ServiceBag.ServiceBag)
+function ClipCharactersService:Init(serviceBag: ServiceBag.ServiceBag)
 	assert(not self._serviceBag, "Already initialized")
 	self._serviceBag = assert(serviceBag, "No serviceBag")
 	self._maid = Maid.new()
@@ -30,4 +30,4 @@ function ClipCharactersService:Destroy()
 	self._maid:DoCleaning()
 end
 
-return ClipCharactersService
+return ClipCharactersService

package/src/Shared/ClipCharactersServiceConstants.lua

@@ -7,5 +7,5 @@ local require = require(script.Parent.loader).load(script)
 local Table = require("Table")
 
 return Table.readonly({
-	COLLISION_GROUP_NAME = "ClipCharacters"
-})
+	COLLISION_GROUP_NAME = "ClipCharacters",
+})

package/test/scripts/Server/ServerMain.server.lua

@@ -9,4 +9,4 @@ local require = require(loader).bootstrapGame(ServerScriptService.clipcharacters
 local serviceBag = require("ServiceBag").new()
 serviceBag:GetService(require("ClipCharactersService"))
 serviceBag:Init()
-serviceBag:Start()
+serviceBag:Start()