@quenty/chatproviderservice 9.18.1-canary.520.d3b0387.0 → 9.19.0-canary.4db9577.0

package/CHANGELOG.md

@@ -3,13 +3,7 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-## [9.18.1-canary.520.d3b0387.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/chatproviderservice@9.18.0...@quenty/chatproviderservice@9.18.1-canary.520.d3b0387.0) (2024-11-14)
-
-
-### Bug Fixes
-
-* Create properties from metadata instead of caching ([f23602e](https://github.com/Quenty/NevermoreEngine/commit/f23602e73a41ce4135ca18bc4ab7f01e935b2cab))
-* pcall metadata in case it isn't a hex color ([0c6df93](https://github.com/Quenty/NevermoreEngine/commit/0c6df93f4e611dcdcf8c1fde454ee4bf7fa43ef0))
+# [9.19.0-canary.4db9577.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/chatproviderservice@9.18.0...@quenty/chatproviderservice@9.19.0-canary.4db9577.0) (2024-11-14)
 
 
 ### Features

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/chatproviderservice",
-  "version": "9.18.1-canary.520.d3b0387.0",
+  "version": "9.19.0-canary.4db9577.0",
   "description": "Provide wrapper around chat system to allow tags to be set",
   "keywords": [
     "Roblox",
@@ -55,5 +55,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "d3b0387eb1eb87f8edf968cea0253fbd745ded62"
+  "gitHead": "4db95775860f06b6e4cd9793c6a0e6457a27a0e1"
 }

package/src/Client/ChatProviderServiceClient.lua

@@ -19,6 +19,8 @@ function ChatProviderServiceClient:Init(serviceBag)
 	self._serviceBag = assert(serviceBag, "No serviceBag")
 	self._maid = Maid.new()
 
+	self._systemMessageColors = {}
+
 	-- State
 	self.MessageIncoming = self._maid:Add(Signal.new())
 
@@ -38,13 +40,10 @@ function ChatProviderServiceClient:Start()
 
 		local metadata = textChatMessage.Metadata
 		if metadata then
-			local isValidColor = pcall(function()
-				return Color3.fromHex(metadata)
-			end)
-
-			if isValidColor then
+			local systemColorProperties = self._systemMessageColors[metadata]
+			if systemColorProperties then
 				local overrideProperties = Instance.new("TextChatMessageProperties")
-				overrideProperties.Text = `<font color="#{metadata}">{textChatMessage.Text}</font>`
+				overrideProperties.Text = string.format(systemColorProperties.Text, textChatMessage.Text)
 
 				return overrideProperties
 			end
@@ -67,17 +66,25 @@ function ChatProviderServiceClient:Start()
 	end
 end
 
---[=[
-	Sends a system message to the provided TextChannel.
-	@param channel TextChannel
-	@param message string
-	@param color Color3?
-]=]
-function ChatProviderServiceClient:SendSystemMessage(channel: TextChannel, message: string, color: Color3?)
+function ChatProviderServiceClient:SendSystemMessage(channel, message, color)
+	if not message then
+		return
+	end
+
 	assert(typeof(channel) == "Instance" and channel.ClassName == "TextChannel", "[ChatProviderServiceClient.SendSystemMessage] - Bad channel")
-	assert(typeof(message) == "string", "[ChatProviderServiceClient.SendSystemMessage] - Bad message")
 	assert(typeof(color) == "Color3" or color == nil, "[ChatProviderServiceClient.SendSystemMessage] - Bad color")
 
+	if color then
+		local hex = color:ToHex()
+
+		if not self._systemMessageColors[hex] then
+			local overrideProperties = Instance.new("TextChatMessageProperties")
+			overrideProperties.Text = `<font color="#{hex}">%s</font>`
+
+			self._systemMessageColors[hex] = overrideProperties
+		end
+	end
+
 	channel:DisplaySystemMessage(message, color and color:ToHex())
 end