@quenty/camerastoryutils 10.10.4 → 10.10.5-canary.559.339cfa7.0

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [10.10.5-canary.559.339cfa7.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/camerastoryutils@10.10.4...@quenty/camerastoryutils@10.10.5-canary.559.339cfa7.0) (2025-05-10)
+
+
+### Bug Fixes
+
+* Additional type checking updates ([05ba29a](https://github.com/Quenty/NevermoreEngine/commit/05ba29a03efc9f3feed74b34f1d9dfb237496214))
+
+
+
+
+
 ## [10.10.4](https://github.com/Quenty/NevermoreEngine/compare/@quenty/camerastoryutils@10.10.3...@quenty/camerastoryutils@10.10.4) (2025-04-10)
 
 **Note:** Version bump only for package @quenty/camerastoryutils

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/camerastoryutils",
-  "version": "10.10.4",
+  "version": "10.10.5-canary.559.339cfa7.0",
   "description": "CameraStoryUtils - utility functions for 3D viewport hoarcekat stories.",
   "keywords": [
     "Roblox",
@@ -26,13 +26,13 @@
     "Quenty"
   ],
   "dependencies": {
-    "@quenty/insertserviceutils": "^10.10.4",
-    "@quenty/loader": "^10.8.3",
-    "@quenty/math": "^2.7.3",
-    "@quenty/promise": "^10.10.4"
+    "@quenty/insertserviceutils": "10.10.5-canary.559.339cfa7.0",
+    "@quenty/loader": "10.8.4-canary.559.339cfa7.0",
+    "@quenty/math": "2.7.3",
+    "@quenty/promise": "10.10.5-canary.559.339cfa7.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "b06c070ae91d5dab7bd8de6e290ad2caabb15d8f"
+  "gitHead": "339cfa778736f08768ed7305041f6221faa35bfc"
 }

package/src/Client/CameraStoryUtils.lua

@@ -1,3 +1,4 @@
+--!strict
 --[=[
 	Utility functions for hoacekat stories.
 	@class CameraStoryUtils
@@ -9,8 +10,9 @@ local RunService = game:GetService("RunService")
 local TextService = game:GetService("TextService")
 
 local InsertServiceUtils = require("InsertServiceUtils")
-local Promise = require("Promise")
+local Maid = require("Maid")
 local Math = require("Math")
+local Promise = require("Promise")
 
 local CameraStoryUtils = {}
 
@@ -20,7 +22,7 @@ local CameraStoryUtils = {}
 	@param topCamera Camera
 	@return Camera
 ]=]
-function CameraStoryUtils.reflectCamera(maid, topCamera: Camera)
+function CameraStoryUtils.reflectCamera(maid: Maid.Maid, topCamera: Camera): Camera
 	local camera = Instance.new("Camera")
 	camera.Name = "ReflectedCamera"
 	maid:GiveTask(camera)
@@ -43,7 +45,7 @@ end
 	@param target GuiBase
 	@return ViewportFrame
 ]=]
-function CameraStoryUtils.setupViewportFrame(maid, target: GuiBase)
+function CameraStoryUtils.setupViewportFrame(maid: Maid.Maid, target: GuiBase)
 	local viewportFrame = Instance.new("ViewportFrame")
 	viewportFrame.ZIndex = 0
 	viewportFrame.BorderSizePixel = 0
@@ -67,11 +69,15 @@ end
 	@param properties { [string}: any }
 	@return Promise<Instance>
 ]=]
-function CameraStoryUtils.promiseCrate(maid, viewportFrame, properties)
+function CameraStoryUtils.promiseCrate(
+	maid: Maid.Maid,
+	viewportFrame: ViewportFrame,
+	properties
+): Promise.Promise<Instance>
 	return maid:GivePromise(InsertServiceUtils.promiseAsset(182451181)):Then(function(model)
 		maid:GiveTask(model)
 
-		local crate = model:GetChildren()[1]
+		local crate = (model :: any):GetChildren()[1]
 		if not crate then
 			return Promise.rejected()
 		end
@@ -92,7 +98,7 @@ function CameraStoryUtils.promiseCrate(maid, viewportFrame, properties)
 			local camera = viewportFrame.CurrentCamera
 			if camera then
 				local cameraCFrame = camera.CFrame
-				local cframe = CFrame.new(cameraCFrame.Position + cameraCFrame.lookVector * 25)
+				local cframe = CFrame.new(cameraCFrame.Position + cameraCFrame.LookVector * 25)
 				crate:SetPrimaryPartCFrame(cframe)
 			end
 		end
@@ -111,7 +117,14 @@ end
 	@param toCFrame CFrame
 	@return (interpolate: function, color: Color3, label: string?, labelOffset: Vector2?) -> ()
 ]=]
-function CameraStoryUtils.getInterpolationFactory(maid, viewportFrame, low, high, period, toCFrame)
+function CameraStoryUtils.getInterpolationFactory(
+	maid: Maid.Maid,
+	viewportFrame: ViewportFrame,
+	low: number,
+	high: number,
+	period: number,
+	toCFrame: CFrame
+)
 	assert(maid, "Bad maid")
 	assert(viewportFrame, "Bad viewportFrame")
 	assert(type(low) == "number", "Bad low")
@@ -126,10 +139,9 @@ function CameraStoryUtils.getInterpolationFactory(maid, viewportFrame, low, high
 		labelOffset = labelOffset or Vector2.zero
 
 		maid:GivePromise(CameraStoryUtils.promiseCrate(maid, viewportFrame, {
-			Color = color;
-			Transparency = 0.5
-		}))
-			:Then(function(crate)
+			Color = color,
+			Transparency = 0.5,
+		})):Then(function(crate)
 			local label
 			if labelText then
 				local h, s, _ = Color3.toHSV(color)
@@ -170,7 +182,7 @@ function CameraStoryUtils.getInterpolationFactory(maid, viewportFrame, low, high
 				end
 			end
 
-				maid:GiveTask(RunService.RenderStepped:Connect(function()
+			maid:GiveTask(RunService.RenderStepped:Connect(function()
 				local t = (os.clock() / period % 2 / period) * period
 				if t >= 1 then
 					t = 1 - (t % 1)
@@ -185,22 +197,22 @@ function CameraStoryUtils.getInterpolationFactory(maid, viewportFrame, low, high
 					local camera = viewportFrame.CurrentCamera
 					local pos = camera:WorldToViewportPoint(cframe.p)
 					local viewportSize = viewportFrame.AbsoluteSize
-					local aspectRatio = viewportSize.x / viewportSize.y
-					if pos.z > 0 then
+					local aspectRatio = viewportSize.X / viewportSize.Y
+					if pos.Z > 0 then
 						label.Position =
-							UDim2.new((pos.x - 0.5) / aspectRatio + 0.5, labelOffset.x, pos.y, 0 + labelOffset.y)
+							UDim2.new((pos.X - 0.5) / aspectRatio + 0.5, labelOffset.X, pos.Y, 0 + labelOffset.Y)
 						label.Visible = true
 					else
 						label.Visible = false
 					end
 				end
 
-					for part, rel in relCFrame do
-						part.CFrame = cframe:toWorldSpace(rel)
-					end
-				end))
-			end)
+				for part, rel in relCFrame do
+					part.CFrame = cframe:toWorldSpace(rel)
+				end
+			end))
+		end)
 	end
 end
 
-return CameraStoryUtils
+return CameraStoryUtils