@quenty/brio 8.17.0 → 8.18.0

package/CHANGELOG.md

@@ -3,6 +3,22 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [8.18.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/brio@8.17.0...@quenty/brio@8.18.0) (2023-09-04)
+
+
+### Bug Fixes
+
+* Add versions to package ([104323f](https://github.com/Quenty/NevermoreEngine/commit/104323fb7f53b866282b2cdef9bf8a849cfb308c))
+
+
+### Features
+
+* Use GoodSignal and add :ToMaidAndValue helper method ([7dd9196](https://github.com/Quenty/NevermoreEngine/commit/7dd91960cc06977c6a13784d3109123b259010a5))
+
+
+
+
+
 # [8.17.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/brio@8.16.0...@quenty/brio@8.17.0) (2023-08-23)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/brio",
-  "version": "8.17.0",
+  "version": "8.18.0",
   "description": "Brios wrap an object and either are alive or dead",
   "keywords": [
     "Roblox",
@@ -28,10 +28,12 @@
   "dependencies": {
     "@quenty/loader": "^6.3.0",
     "@quenty/maid": "^2.6.0",
-    "@quenty/rx": "^7.15.0"
+    "@quenty/rx": "^7.15.0",
+    "@quenty/signal": "^2.4.0",
+    "@quenty/steputils": "^3.3.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "3b7e47e2180964b6b0b156d07814810e063ef7ed"
+  "gitHead": "fa0826fa54fabecb242d7c0753e2e7644ba02e11"
 }

package/src/Shared/Brio.lua

@@ -59,6 +59,7 @@
 local require = require(script.Parent.loader).load(script)
 
 local Maid = require("Maid")
+local GoodSignal = require("GoodSignal")
 
 local Brio = {}
 Brio.ClassName = "Brio"
@@ -136,11 +137,11 @@ function Brio:GetDiedSignal()
 	end
 
 	if self._diedEvent then
-		return self._diedEvent.Event
+		return self._diedEvent
 	end
 
-	self._diedEvent = Instance.new("BindableEvent")
-	return self._diedEvent.Event
+	self._diedEvent = GoodSignal.new()
+	return self._diedEvent
 end
 
 --[=[
@@ -205,6 +206,10 @@ function Brio:ToMaid()
 	return maid
 end
 
+function Brio:ToMaidAndValue()
+	return self:ToMaid(), self:GetValue()
+end
+
 --[=[
 	If the brio is not dead, will return the values unpacked from the brio.
 

package/src/Shared/RxBrioUtils.lua

@@ -699,7 +699,9 @@ end
 	@return (source: Observable<Brio<T> | T>) -> Observable<T | U>
 ]=]
 function RxBrioUtils.emitOnDeath(emitOnDeathValue)
-	return Rx.switchMap(RxBrioUtils.mapBrioToEmitOnDeathObservable(emitOnDeathValue));
+	return Rx.switchMap(function(brio)
+		return RxBrioUtils.toEmitOnDeathObservable(brio, emitOnDeathValue)
+	end);
 end
 
 --[=[

package/src/Shared/RxBrioUtils.spec.lua

@@ -63,18 +63,17 @@ return function()
 		local lastResult = nil
 		local fireCount = 0
 
+		local sub = observe:Subscribe(function(result)
+			lastResult = result
+			fireCount = fireCount + 1
+		end)
+
 		it("should execute immediately", function()
-			local sub = observe:Subscribe(function(result)
-				lastResult = result
-				fireCount = fireCount + 1
-			end)
 			expect(fireCount).to.equal(1)
 			expect(lastResult).to.be.a("table")
 			expect(Brio.isBrio(lastResult)).to.equal(false)
 			expect(lastResult.value).to.equal(5)
 			expect(lastResult.otherValue).to.equal(25)
-
-			sub:Destroy()
 		end)
 
 		it("should reset when the brio is killed", function()
@@ -112,5 +111,9 @@ return function()
 			expect(lastResult.value).to.equal(75)
 			expect(lastResult.otherValue).to.equal(25)
 		end)
+
+		it("should cleanup the sub", function()
+			sub:Destroy()
+		end)
 	end)
 end