@quenty/brio 8.11.0 → 8.12.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +11 -0
- package/package.json +2 -2
- package/src/Shared/RxBrioUtils.lua +14 -2
package/CHANGELOG.md
CHANGED
|
@@ -3,6 +3,17 @@
|
|
|
3
3
|
All notable changes to this project will be documented in this file.
|
|
4
4
|
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
|
|
5
5
|
|
|
6
|
+
# [8.12.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/brio@8.11.0...@quenty/brio@8.12.0) (2023-05-08)
|
|
7
|
+
|
|
8
|
+
|
|
9
|
+
### Bug Fixes
|
|
10
|
+
|
|
11
|
+
* With RxBrioUtils.toEmitOnDeathObservable(brio, emitOnDeathValue), if the observable dies from the firing of the brio, then we would error previously ([04a9890](https://github.com/Quenty/NevermoreEngine/commit/04a989040b1b7a44041baa21acf9df3b968ebfbb))
|
|
12
|
+
|
|
13
|
+
|
|
14
|
+
|
|
15
|
+
|
|
16
|
+
|
|
6
17
|
# [8.11.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/brio@8.10.1...@quenty/brio@8.11.0) (2023-04-10)
|
|
7
18
|
|
|
8
19
|
**Note:** Version bump only for package @quenty/brio
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@quenty/brio",
|
|
3
|
-
"version": "8.
|
|
3
|
+
"version": "8.12.0",
|
|
4
4
|
"description": "Brios wrap an object and either are alive or dead",
|
|
5
5
|
"keywords": [
|
|
6
6
|
"Roblox",
|
|
@@ -33,5 +33,5 @@
|
|
|
33
33
|
"publishConfig": {
|
|
34
34
|
"access": "public"
|
|
35
35
|
},
|
|
36
|
-
"gitHead": "
|
|
36
|
+
"gitHead": "2ad8cea7dd3ad79a39afd7d7b785b489b90553fd"
|
|
37
37
|
}
|
|
@@ -646,10 +646,22 @@ function RxBrioUtils.toEmitOnDeathObservable(brio, emitOnDeathValue)
|
|
|
646
646
|
sub:Complete()
|
|
647
647
|
else
|
|
648
648
|
sub:Fire(brio:GetValue())
|
|
649
|
-
|
|
649
|
+
|
|
650
|
+
-- Firing killed the subscription
|
|
651
|
+
if not sub:IsPending() then
|
|
652
|
+
return
|
|
653
|
+
end
|
|
654
|
+
|
|
655
|
+
-- Firing this event actually killed the brio
|
|
656
|
+
if brio:IsDead() then
|
|
650
657
|
sub:Fire(emitOnDeathValue)
|
|
651
658
|
sub:Complete()
|
|
652
|
-
|
|
659
|
+
else
|
|
660
|
+
return brio:GetDiedSignal():Connect(function()
|
|
661
|
+
sub:Fire(emitOnDeathValue)
|
|
662
|
+
sub:Complete()
|
|
663
|
+
end)
|
|
664
|
+
end
|
|
653
665
|
end
|
|
654
666
|
end)
|
|
655
667
|
end
|