@quenty/brio 4.0.0 → 5.1.0-canary.252.9753dcc.0

package/CHANGELOG.md

@@ -3,6 +3,25 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [5.1.0-canary.252.9753dcc.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/brio@5.0.0...@quenty/brio@5.1.0-canary.252.9753dcc.0) (2022-03-10)
+
+**Note:** Version bump only for package @quenty/brio
+
+
+
+
+
+# [5.0.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/brio@4.0.0...@quenty/brio@5.0.0) (2022-03-06)
+
+
+### Bug Fixes
+
+* Fix circular dependency, move createStateStack from Brio ([9568dd7](https://github.com/Quenty/NevermoreEngine/commit/9568dd78272e487e17e9fb08034a58275838add9))
+
+
+
+
+
 # [4.0.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/brio@3.8.0...@quenty/brio@4.0.0) (2022-01-17)
 
 **Note:** Version bump only for package @quenty/brio

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/brio",
-  "version": "4.0.0",
+  "version": "5.1.0-canary.252.9753dcc.0",
   "description": "Brios wrap an object and either are alive or dead",
   "keywords": [
     "Roblox",
@@ -26,13 +26,12 @@
     "Quenty"
   ],
   "dependencies": {
-    "@quenty/loader": "^3.4.0",
-    "@quenty/maid": "^2.1.0",
-    "@quenty/rx": "^3.8.0",
-    "@quenty/statestack": "^4.0.0"
+    "@quenty/loader": "4.0.0",
+    "@quenty/maid": "2.2.0-canary.252.9753dcc.0",
+    "@quenty/rx": "4.1.0-canary.252.9753dcc.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "cbd40cfd2fd23c14978a3154cad9d1e3d1c78edf"
+  "gitHead": "9753dcc02d4600d2706d8003cebb325ccfcde523"
 }

package/src/Shared/RxBrioUtils.lua

@@ -13,7 +13,6 @@ local BrioUtils = require("BrioUtils")
 local Maid = require("Maid")
 local Observable = require("Observable")
 local Rx = require("Rx")
-local StateStack= require("StateStack")
 
 local RxBrioUtils = {}
 
@@ -32,30 +31,6 @@ function RxBrioUtils.toBrio()
 	end)
 end
 
---[=[
-	Creates a state stack from the brio's value. The state stack holds the last
-	value seen that is valid.
-
-	@param observable Observable<Brio<T>>
-	@return StateStack<T>
-]=]
-function RxBrioUtils.createStateStack(observable)
-	local stateStack = StateStack.new(nil)
-
-	stateStack._maid:GiveTask(observable:Subscribe(function(value)
-		assert(Brio.isBrio(value), "Observable must emit brio")
-
-		if value:IsDead() then
-			return
-		end
-
-		local maid = value:ToMaid()
-		maid:GiveTask(stateStack:PushState(value:GetValue()))
-	end))
-
-	return stateStack
-end
-
 --[=[
 	Completes the observable on death
 
@@ -141,21 +116,23 @@ function RxBrioUtils.emitWhileAllDead(valueToEmitWhileAllDead)
 				updateBrios()
 			end
 
-			topMaid:GiveTask(source:Subscribe(function(brio)
-				if not Brio.isBrio(brio) then
-					warn(("[RxBrioUtils.emitWhileAllDead] - Not a brio, %q"):format(tostring(brio)))
-					topMaid._lastBrio = nil
-					sub:Fail("Not a brio")
-					return
-				end
+			topMaid:GiveTask(source:Subscribe(
+				function(brio)
+					if not Brio.isBrio(brio) then
+						warn(("[RxBrioUtils.emitWhileAllDead] - Not a brio, %q"):format(tostring(brio)))
+						topMaid._lastBrio = nil
+						sub:Fail("Not a brio")
+						return
+					end
 
-				handleNewBrio(brio)
-			end, function(...)
-				sub:Fail(...)
-			end,
-			function(...)
-				sub:Complete(...)
-			end))
+					handleNewBrio(brio)
+				end,
+				function(...)
+					sub:Fail(...)
+				end,
+				function(...)
+					sub:Complete(...)
+				end))
 
 			-- Make sure we emit an empty list if we discover nothing
 			if not fired then
@@ -235,22 +212,23 @@ function RxBrioUtils.reduceToAliveList(selectFromBrio)
 				updateBrios()
 			end
 
-			topMaid:GiveTask(source:Subscribe(function(brio)
-				if not Brio.isBrio(brio) then
-					warn(("[RxBrioUtils.mergeToAliveList] - Not a brio, %q"):format(tostring(brio)))
-					topMaid._lastBrio = nil
-					sub:Fail("Not a brio")
-					return
-				end
+			topMaid:GiveTask(source:Subscribe(
+				function(brio)
+					if not Brio.isBrio(brio) then
+						warn(("[RxBrioUtils.mergeToAliveList] - Not a brio, %q"):format(tostring(brio)))
+						topMaid._lastBrio = nil
+						sub:Fail("Not a brio")
+						return
+					end
 
-				handleNewBrio(brio)
-			end,
-			function(...)
-				sub:Fail(...)
-			end,
-			function(...)
-				sub:Complete(...)
-			end))
+					handleNewBrio(brio)
+				end,
+				function(...)
+					sub:Fail(...)
+				end,
+				function(...)
+					sub:Complete(...)
+				end))
 
 			-- Make sure we emit an empty list if we discover nothing
 			if not fired then
@@ -272,33 +250,34 @@ function RxBrioUtils.reemitLastBrioOnDeath()
 		return Observable.new(function(sub)
 			local maid = Maid.new()
 
-			maid:GiveTask(source:Subscribe(function(brio)
-				maid._conn = nil
+			maid:GiveTask(source:Subscribe(
+				function(brio)
+					maid._conn = nil
 
-				if not Brio.isBrio(brio) then
-					warn(("[RxBrioUtils.reemitLastBrioOnDeath] - Not a brio, %q"):format(tostring(brio)))
-					sub:Fail("Not a brio")
-					return
-				end
+					if not Brio.isBrio(brio) then
+						warn(("[RxBrioUtils.reemitLastBrioOnDeath] - Not a brio, %q"):format(tostring(brio)))
+						sub:Fail("Not a brio")
+						return
+					end
 
-				if brio:IsDead() then
-					sub:Fire(brio)
-					return
-				end
+					if brio:IsDead() then
+						sub:Fire(brio)
+						return
+					end
 
-				-- Setup conn!
-				maid._conn = brio:GetDiedSignal():Connect(function()
-					sub:Fire(brio)
-				end)
+					-- Setup conn!
+					maid._conn = brio:GetDiedSignal():Connect(function()
+						sub:Fire(brio)
+					end)
 
-				sub:Fire(brio)
-			end,
-			function(...)
-				sub:Fail(...)
-			end,
-			function(...)
-				sub:Complete(...)
-			end))
+					sub:Fire(brio)
+				end,
+				function(...)
+					sub:Fail(...)
+				end,
+				function(...)
+					sub:Complete(...)
+				end))
 
 			return maid
 		end)