@quenty/brio 14.7.0 → 14.8.0

package/CHANGELOG.md

@@ -3,6 +3,23 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [14.8.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/brio@14.7.0...@quenty/brio@14.8.0) (2024-10-04)
+
+
+### Bug Fixes
+
+* Brio values are fixed ([7170cb0](https://github.com/Quenty/NevermoreEngine/commit/7170cb0c5ec9cd9af7e298f6eb521cda04eebf34))
+
+
+### Performance Improvements
+
+* Avoid creating a new maid when needed ([cbbb482](https://github.com/Quenty/NevermoreEngine/commit/cbbb48295e602eddf20ee0d4ca3af98a7edac86e))
+* Brio wraps table.pack directly which reduces table count ([4bb32c0](https://github.com/Quenty/NevermoreEngine/commit/4bb32c0b2859762fb6400c2f0153092bc0e914c6))
+
+
+
+
+
 # [14.7.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/brio@14.6.0...@quenty/brio@14.7.0) (2024-09-25)
 
 **Note:** Version bump only for package @quenty/brio

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/brio",
-  "version": "14.7.0",
+  "version": "14.8.0",
   "description": "Brios wrap an object and either are alive or dead",
   "keywords": [
     "Roblox",
@@ -26,14 +26,14 @@
     "Quenty"
   ],
   "dependencies": {
-    "@quenty/loader": "^10.5.0",
-    "@quenty/maid": "^3.3.0",
-    "@quenty/rx": "^13.7.0",
-    "@quenty/signal": "^7.6.0",
+    "@quenty/loader": "^10.6.0",
+    "@quenty/maid": "^3.4.0",
+    "@quenty/rx": "^13.8.0",
+    "@quenty/signal": "^7.7.0",
     "@quenty/steputils": "^3.5.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "9b17fe79cddd071f0f06a9d35184e76b44bd6fe6"
+  "gitHead": "035abfa088c854a73e1c65b350267eaa17669646"
 }

package/src/Shared/Brio.lua

@@ -90,9 +90,7 @@ end
 	@return Brio
 ]=]
 function Brio.new(...) -- Wrap
-	return setmetatable({
-		_values = table.pack(...);
-	}, Brio)
+	return setmetatable(table.pack(...), Brio)
 end
 
 --[=[
@@ -159,7 +157,7 @@ end
 	@return boolean
 ]=]
 function Brio:IsDead()
-	return self._values == nil
+	return self.n == nil
 end
 
 --[=[
@@ -170,7 +168,7 @@ end
 	```
 ]=]
 function Brio:ErrorIfDead()
-	if not self._values then
+	if not self.n then
 		error("[Brio.ErrorIfDead] - Brio is dead")
 	end
 end
@@ -195,7 +193,7 @@ end
 	@return Maid
 ]=]
 function Brio:ToMaid()
-	assert(self._values ~= nil, "Brio is dead")
+	assert(self.n ~= nil, "Brio is dead")
 
 	local maid = Maid.new()
 
@@ -229,9 +227,9 @@ end
 	@return any
 ]=]
 function Brio:GetValue()
-	assert(self._values, "Brio is dead")
+	assert(self.n, "Brio is dead")
 
-	return unpack(self._values, 1, self._values.n)
+	return unpack(self, 1, self.n)
 end
 
 --[=[
@@ -241,9 +239,9 @@ end
 	@return { n: number, ... T }
 ]=]
 function Brio:GetPackedValues()
-	assert(self._values, "Brio is dead")
+	assert(self.n, "Brio is dead")
 
-	return self._values
+	return self
 end
 
 --[=[
@@ -262,16 +260,19 @@ end
 	```
 ]=]
 function Brio:Destroy()
-	if not self._values then
+	if not self.n then
 		return
 	end
 
-	self._values = nil
+	local diedEvent = self._diedEvent
 
-	if self._diedEvent then
-		self._diedEvent:Fire()
-		self._diedEvent:Destroy()
-		self._diedEvent = nil
+	table.clear(self)
+	table.freeze(self)
+
+	if diedEvent then
+		diedEvent:Fire()
+		diedEvent:Destroy()
+		diedEvent = nil
 	end
 end
 

package/src/Shared/BrioUtils.lua

@@ -26,9 +26,18 @@ function BrioUtils.clone(brio)
 
 	local newBrio = Brio.new(brio:GetValue())
 
-	newBrio:ToMaid():GiveTask(brio:GetDiedSignal():Connect(function()
+	local connection
+	local otherConnection
+	connection = brio:GetDiedSignal():Connect(function()
+		connection:Disconnect()
+		otherConnection:Disconnect()
 		newBrio:Kill()
-	end))
+	end)
+
+	otherConnection = newBrio:GetDiedSignal():Connect(function()
+		otherConnection:Disconnect()
+		connection:Disconnect()
+	end)
 
 	return newBrio
 end
@@ -164,7 +173,7 @@ function BrioUtils.extend(brio, ...)
 		return Brio.DEAD
 	end
 
-	local values = brio._values
+	local values = brio:GetPackedValues()
 	local current = {}
 	for i=1, values.n do
 		current[i] = values[i]
@@ -202,7 +211,7 @@ function BrioUtils.prepend(brio, ...)
 		return Brio.DEAD
 	end
 
-	local values = brio._values
+	local values = brio:GetPackedValues()
 	local current = {}
 	local otherValues = table.pack(...)
 	for i=1, otherValues.n do
@@ -241,13 +250,13 @@ function BrioUtils.merge(brio, otherBrio)
 		return Brio.DEAD
 	end
 
-	local values = brio._values
+	local values = brio:GetPackedValues()
 	local current = {}
 	for i=1, values.n do
 		current[i] = values[i]
 	end
 
-	local otherValues = otherBrio._values
+	local otherValues = otherBrio:GetPackedValues()
 	for i=1, otherValues.n do
 		current[values.n+i] = otherValues[i]
 	end

package/src/Shared/RxBrioUtils.lua

@@ -782,29 +782,24 @@ function RxBrioUtils.switchToBrio(predicate)
 			local topMaid = Maid.new()
 
 			topMaid:GiveTask(source:Subscribe(function(result, ...)
+				-- Always kill previous brio first
+				topMaid._last = nil
+
 				if Brio.isBrio(result) then
 					if result:IsDead() then
-						topMaid._last = nil
 						return
 					end
 
 					if predicate == nil or predicate(result:GetValue()) then
-						local maid = result:ToMaid()
-						local newBrio = maid:Add(Brio.new(result:GetValue()))
+						local newBrio = BrioUtils.clone(result)
+						topMaid._last = newBrio
 						sub:Fire(newBrio)
-
-						topMaid._last = maid
-					else
-						topMaid._last = nil
 					end
 				else
 					if predicate == nil or predicate(result, ...) then
 						local newBrio = Brio.new(result, ...)
-
 						topMaid._last = newBrio
 						sub:Fire(newBrio)
-					else
-						topMaid._last = nil
 					end
 				end
 			end, sub:GetFailComplete()))