@quenty/binder 4.6.0-canary.241.a4e8214.0 → 4.7.0

package/CHANGELOG.md

@@ -3,12 +3,23 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-# [4.6.0-canary.241.a4e8214.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/binder@4.5.2...@quenty/binder@4.6.0-canary.241.a4e8214.0) (2022-01-03)
+# [4.7.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/binder@4.6.0...@quenty/binder@4.7.0) (2022-01-07)
 
 
 ### Bug Fixes
 
-* Binder.isBinder(binder) does not error on child classes ([b8ae98f](https://github.com/Quenty/NevermoreEngine/commit/b8ae98fc2d85e9d517c9edadb778a353c15365c4))
+* Binders initialize properly and provider better warnings ([93b6ab1](https://github.com/Quenty/NevermoreEngine/commit/93b6ab1d4f8380124c1a0b3d95b6274c58fd4b30))
+
+
+
+
+
+# [4.6.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/binder@4.5.2...@quenty/binder@4.6.0) (2022-01-03)
+
+
+### Bug Fixes
+
+* Binder.isBinder(binder) does not error on child classes ([76f8bee](https://github.com/Quenty/NevermoreEngine/commit/76f8bee8898bd64c33695f828e64e99567e15abd))
 
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/binder",
-  "version": "4.6.0-canary.241.a4e8214.0",
+  "version": "4.7.0",
   "description": "Utility object to Bind a class to Roblox object, and associated helper methods",
   "keywords": [
     "Roblox",
@@ -25,18 +25,18 @@
     "Quenty"
   ],
   "dependencies": {
-    "@quenty/baseobject": "3.3.0-canary.241.a4e8214.0",
-    "@quenty/brio": "3.6.0-canary.241.a4e8214.0",
-    "@quenty/instanceutils": "3.6.0-canary.241.a4e8214.0",
-    "@quenty/linkutils": "3.6.0-canary.241.a4e8214.0",
-    "@quenty/loader": "3.2.0-canary.241.a4e8214.0",
-    "@quenty/maid": "2.0.2",
-    "@quenty/promise": "3.4.0-canary.241.a4e8214.0",
-    "@quenty/signal": "2.1.0-canary.241.a4e8214.0",
-    "@quenty/valueobject": "3.6.0-canary.241.a4e8214.0"
+    "@quenty/baseobject": "^3.4.0",
+    "@quenty/brio": "^3.7.0",
+    "@quenty/instanceutils": "^3.7.0",
+    "@quenty/linkutils": "^3.7.0",
+    "@quenty/loader": "^3.3.0",
+    "@quenty/maid": "^2.0.2",
+    "@quenty/promise": "^3.5.0",
+    "@quenty/signal": "^2.1.0",
+    "@quenty/valueobject": "^3.7.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "a4e821471f35998d63f38a4f4a578e07b4e79035"
+  "gitHead": "5a3f3fb6c908fd3874f5ceacc70b404780275119"
 }

package/src/Shared/BinderProvider.lua

@@ -36,15 +36,9 @@ BinderProvider.__index = BinderProvider
 function BinderProvider.new(initMethod)
 	local self = setmetatable({}, BinderProvider)
 
-	-- Pretty sure this is a bad idea
-	self._bindersAddedPromise = Promise.new()
-	self._startPromise = Promise.new()
-
 	self._initMethod = initMethod or error("No initMethod")
-
 	self._initialized = false
 	self._started = false
-	self._binders = {}
 
 	return self
 end
@@ -93,7 +87,13 @@ end
 function BinderProvider:Init(...)
 	assert(not self._initialized, "Already initialized")
 
+	self._binders = {}
 	self._initialized = true
+
+	-- Pretty sure this is a bad idea
+	self._bindersAddedPromise = Promise.new()
+	self._startPromise = Promise.new()
+
 	self._initMethod(self, ...)
 	self._bindersAddedPromise:Resolve()
 end
@@ -104,7 +104,7 @@ end
 	@return Promise
 ]=]
 function BinderProvider:PromiseBindersAdded()
-	return self._bindersAddedPromise
+	return assert(self._bindersAddedPromise, "Be sure to require via serviceBag")
 end
 
 --[=[
@@ -113,7 +113,7 @@ end
 	@return Promise
 ]=]
 function BinderProvider:PromiseBindersStarted()
-	return self._startPromise
+	return assert(self._startPromise, "Be sure to require via serviceBag")
 end
 
 --[=[
@@ -136,8 +136,7 @@ function BinderProvider:__index(index)
 		return BinderProvider[index]
 	end
 
-	assert(self._initialized, "Not initialized")
-	error(("%q Not a valid index"):format(tostring(index)))
+	error(("%q Not a valid binder"):format(tostring(index)))
 end
 
 --[=[

package/src/Shared/BinderProvider.spec.lua

@@ -0,0 +1,41 @@
+--[[
+	@class BinderProvider.spec.lua
+]]
+
+local require = require(game:GetService("ServerScriptService"):FindFirstChild("LoaderUtils", true).Parent).load(script)
+
+local BinderProvider = require("BinderProvider")
+local Binder = require("Binder")
+
+return function()
+	describe("BinderProvider.new()", function()
+		local provider
+		local initialized = false
+
+		it("should execute immediately", function()
+			provider = BinderProvider.new(function(self, arg)
+				initialized = true
+				assert(arg == 12345, "Bad arg")
+
+				self:Add(Binder.new("Test", function()
+					return { Destroy = function() end; }
+				end))
+			end)
+
+			expect(provider).to.be.a("table")
+		end)
+
+		it("should initialize", function()
+			expect(initialized).to.equal(false)
+			provider:Init(12345)
+			expect(initialized).to.equal(true)
+		end)
+
+		it("should contain the binder", function()
+			expect(provider.Test).to.be.a("table")
+		end)
+
+		provider:Destroy()
+	end)
+
+end