@quenty/binder 14.44.0 → 14.46.0

package/CHANGELOG.md

@@ -3,6 +3,16 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [14.46.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/binder@14.45.0...@quenty/binder@14.46.0) (2026-09-02)
+
+### Features
+
+- Add RxBinderUtils.observeBoundAncestor<T>() and make sure everything is using binder:ObserveInstance() for performance ([9236c34](https://github.com/Quenty/NevermoreEngine/commit/9236c343fb438d75d29bcfcbaae71025fd344b0e))
+
+# [14.45.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/binder@14.44.0...@quenty/binder@14.45.0) (2026-08-28)
+
+**Note:** Version bump only for package @quenty/binder
+
 # [14.44.0](https://github.com/Quenty/NevermoreEngine/compare/@quenty/binder@14.43.2...@quenty/binder@14.44.0) (2026-08-28)
 
 **Note:** Version bump only for package @quenty/binder

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@quenty/binder",
-  "version": "14.44.0",
+  "version": "14.46.0",
   "description": "Utility object to Bind a class to Roblox object, and associated helper methods",
   "keywords": [
     "Roblox",
@@ -29,10 +29,11 @@
   ],
   "dependencies": {
     "@quenty/baseobject": "10.16.0",
-    "@quenty/brio": "14.36.0",
+    "@quenty/brio": "14.37.0",
     "@quenty/canceltoken": "11.25.0",
-    "@quenty/instanceutils": "13.36.0",
-    "@quenty/linkutils": "13.37.0",
+    "@quenty/instanceutils": "13.37.0",
+    "@quenty/jestutils": "1.1.0",
+    "@quenty/linkutils": "13.38.0",
     "@quenty/loader": "10.11.1",
     "@quenty/maid": "3.12.0",
     "@quenty/nevermore-test-runner": "1.6.0",
@@ -41,11 +42,10 @@
     "@quenty/servicebag": "11.21.0",
     "@quenty/signal": "7.13.2",
     "@quenty/table": "3.9.2",
-    "@quenty/valueobject": "13.37.0",
     "@quentystudios/jest-lua": "3.10.0-quenty.2"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "f75f93d5b2ac51cf7da3b7599788dcce31fd8a29"
+  "gitHead": "278f4ca25486a8ba0601704b27a11da8c77499c9"
 }

package/src/Shared/Binder.Loading.spec.lua

@@ -49,6 +49,6 @@ describe("Binder load abandonment", function()
 		expect(binder:Get(inst)).toBeNil()
 		expect(constructed).toEqual(1)
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 end)

package/src/Shared/Binder.ObserveBrio.spec.lua

@@ -43,7 +43,7 @@ describe("Binder:ObserveBrio()", function()
 		expect(brios[1]:GetValue()).toEqual(class)
 
 		sub:Destroy()
-		controller.destroy()
+		controller:Destroy()
 	end)
 
 	it("emits immediately when the instance is already bound", function()
@@ -67,7 +67,7 @@ describe("Binder:ObserveBrio()", function()
 		expect(brios[1]:GetValue()).toEqual(class)
 
 		sub:Destroy()
-		controller.destroy()
+		controller:Destroy()
 	end)
 
 	it("kills the emitted brio when the instance unbinds", function()
@@ -93,7 +93,7 @@ describe("Binder:ObserveBrio()", function()
 		expect(brios[1]:IsDead()).toEqual(true)
 
 		sub:Destroy()
-		controller.destroy()
+		controller:Destroy()
 	end)
 
 	it("emits a fresh live brio when the instance rebinds", function()
@@ -125,7 +125,7 @@ describe("Binder:ObserveBrio()", function()
 		expect(brios[2]:GetValue()).toEqual(class)
 
 		sub:Destroy()
-		controller.destroy()
+		controller:Destroy()
 	end)
 end)
 
@@ -153,7 +153,7 @@ describe("Binder:ObserveAllBrio()", function()
 		expect(values[binder:Get(instB)]).toEqual(true)
 
 		sub:Destroy()
-		controller.destroy()
+		controller:Destroy()
 	end)
 
 	it("emits a brio when a new class is added", function()
@@ -178,7 +178,7 @@ describe("Binder:ObserveAllBrio()", function()
 		expect(brios[1]:GetValue()).toEqual(binder:Get(inst))
 
 		sub:Destroy()
-		controller.destroy()
+		controller:Destroy()
 	end)
 
 	it("kills the brio when the class is removed", function()
@@ -204,6 +204,6 @@ describe("Binder:ObserveAllBrio()", function()
 		expect(brios[1]:IsDead()).toEqual(true)
 
 		sub:Destroy()
-		controller.destroy()
+		controller:Destroy()
 	end)
 end)

package/src/Shared/Binder.spec.lua

@@ -58,7 +58,7 @@ describe("Binder.new()", function()
 		expect(class.a).toEqual("a")
 		expect(class.b).toEqual("b")
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 end)
 
@@ -109,7 +109,7 @@ describe("Binder constructor variants", function()
 		expect(class.kind).toEqual("function")
 		expect(class.instance).toEqual(inst)
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 
 	it("supports a class table with .new", function()
@@ -126,7 +126,7 @@ describe("Binder constructor variants", function()
 		assert(ok, "Never bound")
 		expect(class.instance).toEqual(inst)
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 
 	it("supports a provider table with :Create", function()
@@ -147,7 +147,7 @@ describe("Binder constructor variants", function()
 		assert(ok, "Never bound")
 		expect(class.kind).toEqual("provider")
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 end)
 
@@ -192,7 +192,7 @@ describe("Binder binding via ServiceBag", function()
 
 		expect(binder:Get(inst)).never.toBeNil()
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 
 	it("binds instances tagged after start", function()
@@ -207,7 +207,7 @@ describe("Binder binding via ServiceBag", function()
 		local ok = binder:Promise(inst):Yield()
 		expect(ok).toEqual(true)
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 end)
 
@@ -220,7 +220,7 @@ describe("Binder:Get()", function()
 
 		expect(binder:Get(controller.newInstance())).toBeNil()
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 
 	it("throws when passed a non-instance", function()
@@ -233,7 +233,7 @@ describe("Binder:Get()", function()
 			binder:Get(5 :: any)
 		end).toThrow()
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 end)
 
@@ -251,7 +251,7 @@ describe("Binder tagging", function()
 		binder:Untag(inst)
 		expect(binder:HasTag(inst)).toEqual(false)
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 
 	it("Bind tags and Unbind untags on the server", function()
@@ -270,7 +270,7 @@ describe("Binder tagging", function()
 		binder:Unbind(inst)
 		expect(binder:HasTag(inst)).toEqual(false)
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 end)
 
@@ -325,7 +325,7 @@ describe("Binder:GetAll() / GetAllSet()", function()
 		expect(set[binder:Get(instA)]).toEqual(true)
 		expect(set[binder:Get(instB)]).toEqual(true)
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 end)
 
@@ -340,7 +340,7 @@ describe("Binder signals", function()
 		expect(binder:GetClassRemovingSignal()).toEqual(binder:GetClassRemovingSignal())
 		expect(binder:GetClassRemovedSignal()).toEqual(binder:GetClassRemovedSignal())
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 
 	it("fires the added signal with the class and instance", function()
@@ -362,7 +362,7 @@ describe("Binder signals", function()
 		expect(firedInst).toEqual(inst)
 		expect(firedClass).toEqual(binder:Get(inst))
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 
 	it("fires removing then removed on unbind", function()
@@ -389,7 +389,7 @@ describe("Binder signals", function()
 		expect(order[1]).toEqual("removing")
 		expect(order[2]).toEqual("removed")
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 
 	it("destroys the bound class when it is removed", function()
@@ -408,7 +408,7 @@ describe("Binder signals", function()
 
 		expect(class.destroyed).toEqual(true)
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 end)
 
@@ -440,7 +440,7 @@ describe("Binder:ObserveInstance()", function()
 
 		cleanup()
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 
 	it("returns a cleanup that stops future callbacks", function()
@@ -462,7 +462,7 @@ describe("Binder:ObserveInstance()", function()
 
 		expect(count).toEqual(0)
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 
 	it("throws for a non-instance or non-function", function()
@@ -478,7 +478,7 @@ describe("Binder:ObserveInstance()", function()
 			binder:ObserveInstance(controller.newInstance(), 5 :: any)
 		end).toThrow()
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 end)
 
@@ -507,7 +507,7 @@ describe("Binder:Observe()", function()
 		expect(emissions[2].value).toEqual(binder:Get(inst))
 
 		sub:Destroy()
-		controller.destroy()
+		controller:Destroy()
 	end)
 end)
 
@@ -524,7 +524,7 @@ describe("Binder:Promise()", function()
 		local promise = binder:Promise(inst)
 		expect(promise:IsFulfilled()).toEqual(true)
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 
 	it("throws when passed a non-instance", function()
@@ -537,7 +537,7 @@ describe("Binder:Promise()", function()
 			binder:Promise(5 :: any)
 		end).toThrow()
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 end)
 
@@ -561,7 +561,7 @@ describe("Binder:_add() dedupe", function()
 
 		expect(constructed).toEqual(1)
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 end)
 
@@ -581,6 +581,6 @@ describe("Binder teardown", function()
 
 		expect(class.destroyed).toEqual(true)
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 end)

package/src/Shared/BinderGroup.spec.lua

@@ -8,6 +8,8 @@ local require = require(script.Parent.loader).load(script)
 local Binder = require("Binder")
 local BinderGroup = require("BinderGroup")
 local Jest = require("Jest")
+local JestUtils = require("JestUtils")
+local Maid = require("Maid")
 
 local describe = Jest.Globals.describe
 local expect = Jest.Globals.expect
@@ -16,6 +18,8 @@ local it = Jest.Globals.it
 local tagCounter = 0
 
 local function setup()
+	local maid = Maid.new()
+
 	local binders: { any } = {}
 
 	local function newBinder(): Binder.Binder<any>
@@ -27,16 +31,24 @@ local function setup()
 		return binder
 	end
 
-	return {
+	maid:GiveTask(function()
+		for _, binder in binders do
+			pcall(function()
+				binder:Destroy()
+			end)
+		end
+	end)
+
+	local controller = {
 		newBinder = newBinder,
-		destroy = function()
-			for _, binder in binders do
-				pcall(function()
-					binder:Destroy()
-				end)
-			end
+		Destroy = function(_self)
+			maid:DoCleaning()
 		end,
 	}
+
+	maid:GiveTask(JestUtils.afterThis(controller))
+
+	return controller
 end
 
 describe("BinderGroup.new()", function()
@@ -49,7 +61,7 @@ describe("BinderGroup.new()", function()
 
 		expect(#group:GetBinders()).toEqual(2)
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 
 	it("constructs empty", function()
@@ -68,7 +80,7 @@ describe("BinderGroup:Add()", function()
 
 		expect(group:GetBinders()[1]).toEqual(binder)
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 
 	it("fires BinderAdded with the added binder", function()
@@ -85,7 +97,7 @@ describe("BinderGroup:Add()", function()
 
 		expect(fired).toEqual(binder)
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 
 	it("throws when the value is not a binder", function()
@@ -111,7 +123,7 @@ describe("BinderGroup constructor validation", function()
 
 		expect(validated[1]).toEqual(binder:GetConstructor())
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 
 	it("throws when the constructor fails validation", function()
@@ -126,7 +138,7 @@ describe("BinderGroup constructor validation", function()
 			group:Add(binder)
 		end).toThrow()
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 end)
 
@@ -139,7 +151,7 @@ describe("BinderGroup:AddList()", function()
 
 		expect(#group:GetBinders()).toEqual(2)
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 
 	it("throws on a non-table argument", function()

package/src/Shared/BinderTestUtils.lua

@@ -7,7 +7,7 @@
 
 	Tags are global and the test place is shared across a batch run, so every binder gets a distinct
 	tag from a single module-level counter -- shared across every spec file that requires this module,
-	so tags never collide between files -- and each controller cleans up after itself via `destroy()`.
+	so tags never collide between files -- and each controller cleans up after itself via `Destroy()`.
 
 	@class BinderTestUtils
 ]=]
@@ -16,6 +16,8 @@ local require = require(script.Parent.loader).load(script)
 
 local Binder = require("Binder")
 local BinderProvider = require("BinderProvider")
+local JestUtils = require("JestUtils")
+local Maid = require("Maid")
 local ServiceBag = require("ServiceBag")
 
 local BinderTestUtils = {}
@@ -74,11 +76,11 @@ end
 --[=[
 	Builds the controller the Binder specs share. Register binders with `addBinder`, boot them all at
 	once through a ServiceBag with `boot`, create adornees with `newInstance`, and tear everything down
-	with `destroy` (or just the service bag with `destroyServiceBag`).
+	with `Destroy` (or just the service bag with `destroyServiceBag`).
 
 	Fields: `container`.
 	Builders: `addBinder(constructor, ...)` -> Binder, `newInstance(parent?, className?)` -> Instance.
-	Lifecycle: `boot()`, `destroyServiceBag()`, `destroy()`.
+	Lifecycle: `boot()`, `destroyServiceBag()`, `Destroy()`.
 	Helpers: `uniqueTag()` -> string.
 
 	@return { ... }
@@ -87,6 +89,8 @@ function BinderTestUtils.setup()
 	specCounter += 1
 	local suffix = specCounter
 
+	local maid = Maid.new()
+
 	local serviceBag = ServiceBag.new()
 	local serviceBagDestroyed = false
 
@@ -141,23 +145,31 @@ function BinderTestUtils.setup()
 		end
 	end
 
-	return {
+	maid:GiveTask(function()
+		destroyServiceBag()
+		for _, inst in instances do
+			pcall(function()
+				inst:Destroy()
+			end)
+		end
+		container:Destroy()
+	end)
+
+	local controller = {
 		container = container,
 		uniqueTag = uniqueTag,
 		addBinder = addBinder,
 		boot = boot,
 		newInstance = newInstance,
 		destroyServiceBag = destroyServiceBag,
-		destroy = function()
-			destroyServiceBag()
-			for _, inst in instances do
-				pcall(function()
-					inst:Destroy()
-				end)
-			end
-			container:Destroy()
+		Destroy = function(_self)
+			maid:DoCleaning()
 		end,
 	}
+
+	maid:GiveTask(JestUtils.afterThis(controller))
+
+	return controller
 end
 
 return BinderTestUtils

package/src/Shared/BinderUtils.spec.lua

@@ -9,6 +9,8 @@ local Binder = require("Binder")
 local BinderProvider = require("BinderProvider")
 local BinderUtils = require("BinderUtils")
 local Jest = require("Jest")
+local JestUtils = require("JestUtils")
+local Maid = require("Maid")
 local ServiceBag = require("ServiceBag")
 
 local describe = Jest.Globals.describe
@@ -29,6 +31,8 @@ local function makeClass()
 end
 
 local function setup()
+	local maid = Maid.new()
+
 	specCounter += 1
 	local suffix = specCounter
 
@@ -37,7 +41,7 @@ local function setup()
 	container.Name = "BinderUtilsSpecContainer"
 	container.Parent = workspace
 
-	local instances = {}
+	local instances: { Instance } = {}
 	local pendingBinders: { any } = {}
 	local tagCounter = 0
 	local booted = false
@@ -72,21 +76,29 @@ local function setup()
 		serviceBag:Start()
 	end
 
-	return {
+	maid:GiveTask(function()
+		serviceBag:Destroy()
+		for _, inst in instances do
+			pcall(function()
+				inst:Destroy()
+			end)
+		end
+		container:Destroy()
+	end)
+
+	local controller = {
 		container = container,
 		newBinder = newBinder,
 		newInstance = newInstance,
 		boot = boot,
-		destroy = function()
-			serviceBag:Destroy()
-			for _, inst in instances do
-				pcall(function()
-					inst:Destroy()
-				end)
-			end
-			container:Destroy()
+		Destroy = function(_self)
+			maid:DoCleaning()
 		end,
 	}
+
+	maid:GiveTask(JestUtils.afterThis(controller))
+
+	return controller
 end
 
 describe("BinderUtils.findFirstAncestor()", function()
@@ -104,7 +116,7 @@ describe("BinderUtils.findFirstAncestor()", function()
 
 		expect(BinderUtils.findFirstAncestor(binder, child)).toEqual(binder:Get(grandparent))
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 
 	it("returns nil when no ancestor is bound", function()
@@ -117,7 +129,7 @@ describe("BinderUtils.findFirstAncestor()", function()
 
 		expect(BinderUtils.findFirstAncestor(binder, child)).toBeNil()
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 
 	it("throws for a non-instance child", function()
@@ -129,7 +141,7 @@ describe("BinderUtils.findFirstAncestor()", function()
 			BinderUtils.findFirstAncestor(binder, 5 :: any)
 		end).toThrow()
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 end)
 
@@ -148,7 +160,7 @@ describe("BinderUtils.findFirstChild()", function()
 		expect(BinderUtils.findFirstChild(binder, parent)).toEqual(binder:Get(boundChild))
 		expect(binder:Get(unboundChild)).toBeNil()
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 
 	it("returns nil when no child is bound", function()
@@ -161,7 +173,7 @@ describe("BinderUtils.findFirstChild()", function()
 
 		expect(BinderUtils.findFirstChild(binder, parent)).toBeNil()
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 end)
 
@@ -181,7 +193,7 @@ describe("BinderUtils.getChildren()", function()
 
 		expect(#BinderUtils.getChildren(binder, parent)).toEqual(2)
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 
 	it("does not include bound descendants deeper than one level", function()
@@ -197,7 +209,7 @@ describe("BinderUtils.getChildren()", function()
 
 		expect(#BinderUtils.getChildren(binder, parent)).toEqual(0)
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 end)
 
@@ -216,7 +228,7 @@ describe("BinderUtils.getDescendants()", function()
 
 		expect(#BinderUtils.getDescendants(binder, parent)).toEqual(2)
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 end)
 
@@ -232,7 +244,7 @@ describe("BinderUtils.mapBinderListToTable()", function()
 		expect(map[binderA:GetTag()]).toEqual(binderA)
 		expect(map[binderB:GetTag()]).toEqual(binderB)
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 end)
 
@@ -253,7 +265,7 @@ describe("BinderUtils.getMappedFromList()", function()
 
 		expect(#objects).toEqual(2)
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 end)
 
@@ -273,7 +285,7 @@ describe("BinderUtils.getChildrenOfBinders()", function()
 
 		expect(#BinderUtils.getChildrenOfBinders({ binderA, binderB }, parent)).toEqual(2)
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 end)
 
@@ -295,7 +307,7 @@ describe("BinderUtils.getLinkedChildren()", function()
 		expect(#objects).toEqual(1)
 		expect(objects[1]).toEqual(binder:Get(target))
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 
 	it("ignores links whose name does not match", function()
@@ -313,7 +325,7 @@ describe("BinderUtils.getLinkedChildren()", function()
 
 		expect(#BinderUtils.getLinkedChildren(binder, "Link", parent)).toEqual(0)
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 
 	it("deduplicates when two links point to the same bound target", function()
@@ -333,6 +345,6 @@ describe("BinderUtils.getLinkedChildren()", function()
 
 		expect(#BinderUtils.getLinkedChildren(binder, "Link", parent)).toEqual(1)
 
-		controller.destroy()
+		controller:Destroy()
 	end)
 end)