@quenty/binder 14.40.0 → 14.42.0

package/src/Shared/Collection/BoundChildCollection.spec.lua

@@ -1,13 +1,5 @@
 --!strict
 --[[
-	Coverage for BoundChildCollection, which tracks the bound children of a parent instance.
-
-	The binder is booted through a ServiceBag (as production code does); the collection itself is a
-	plain BaseObject and is constructed directly. Everything lives under a workspace container so
-	CollectionService and ChildAdded/ChildRemoved signals fire. Children tagged before the service
-	bag starts bind synchronously; changes made after construction are awaited event-driven via the
-	collection's own ClassAdded/ClassRemoved signals rather than a fixed sleep.
-
 	@class BoundChildCollection.spec.lua
 ]]
 
@@ -100,19 +92,19 @@ end
 
 describe("BoundChildCollection construction", function()
 	it("counts children bound before construction without firing ClassAdded", function()
-		local env = setup()
+		local controller = setup()
 
-		local parent = env.newInstance()
-		local childA = env.newInstance(parent)
-		local childB = env.newInstance(parent)
-		env.newInstance(parent) -- unbound child
+		local parent = controller.newInstance()
+		local childA = controller.newInstance(parent)
+		local childB = controller.newInstance(parent)
+		controller.newInstance(parent) -- unbound child
 
-		env.binder:Tag(childA)
-		env.binder:Tag(childB)
-		env.boot()
+		controller.binder:Tag(childA)
+		controller.binder:Tag(childB)
+		controller.boot()
 
 		local fired = 0
-		local collection = env.track(BoundChildCollection.new(env.binder, parent))
+		local collection = controller.track(BoundChildCollection.new(controller.binder, parent))
 		collection.ClassAdded:Connect(function()
 			fired += 1
 		end)
@@ -120,25 +112,24 @@ describe("BoundChildCollection construction", function()
 		expect(collection:GetSize()).toEqual(2)
 		expect(fired).toEqual(0)
 		expect(#collection:GetClasses()).toEqual(2)
-		expect(collection:HasClass(env.binder:Get(childA))).toEqual(true)
+		expect(collection:HasClass(controller.binder:Get(childA))).toEqual(true)
 
-		env.destroy()
+		controller.destroy()
 	end)
 end)
 
 describe("BoundChildCollection dynamic updates", function()
 	it("fires ClassAdded when a bound child is reparented in", function()
-		local env = setup()
+		local controller = setup()
 
-		local parent = env.newInstance()
-		env.boot()
+		local parent = controller.newInstance()
+		controller.boot()
 
-		local collection = env.track(BoundChildCollection.new(env.binder, parent))
+		local collection = controller.track(BoundChildCollection.new(controller.binder, parent))
 
-		-- Bind an instance living elsewhere, then move it under the tracked parent.
-		local child = env.newInstance()
-		env.binder:Tag(child)
-		local ok, class = env.binder:Promise(child):Yield()
+		local child = controller.newInstance()
+		controller.binder:Tag(child)
+		local ok, class = controller.binder:Promise(child):Yield()
 		assert(ok, "child never bound")
 
 		local addedClass
@@ -155,18 +146,18 @@ describe("BoundChildCollection dynamic updates", function()
 		expect(addedClass).toEqual(class)
 		expect(collection:GetSize()).toEqual(1)
 
-		env.destroy()
+		controller.destroy()
 	end)
 
 	it("fires ClassRemoved when a tracked child is reparented out", function()
-		local env = setup()
+		local controller = setup()
 
-		local parent = env.newInstance()
-		local child = env.newInstance(parent)
-		env.binder:Tag(child)
-		env.boot()
+		local parent = controller.newInstance()
+		local child = controller.newInstance(parent)
+		controller.binder:Tag(child)
+		controller.boot()
 
-		local collection = env.track(BoundChildCollection.new(env.binder, parent))
+		local collection = controller.track(BoundChildCollection.new(controller.binder, parent))
 		expect(collection:GetSize()).toEqual(1)
 
 		local removedClass
@@ -174,8 +165,8 @@ describe("BoundChildCollection dynamic updates", function()
 			removedClass = c
 		end)
 
-		local class = env.binder:Get(child)
-		child.Parent = env.container
+		local class = controller.binder:Get(child)
+		child.Parent = controller.container
 		if collection:GetSize() == 1 then
 			collection.ClassRemoved:Wait()
 		end
@@ -184,22 +175,22 @@ describe("BoundChildCollection dynamic updates", function()
 		expect(removedClass).toEqual(class)
 		expect(collection:GetSize()).toEqual(0)
 
-		env.destroy()
+		controller.destroy()
 	end)
 
 	it("fires ClassRemoved when a tracked child is unbound", function()
-		local env = setup()
+		local controller = setup()
 
-		local parent = env.newInstance()
-		local child = env.newInstance(parent)
-		env.binder:Tag(child)
-		env.boot()
+		local parent = controller.newInstance()
+		local child = controller.newInstance(parent)
+		controller.binder:Tag(child)
+		controller.boot()
 
-		local collection = env.track(BoundChildCollection.new(env.binder, parent))
+		local collection = controller.track(BoundChildCollection.new(controller.binder, parent))
 		expect(collection:GetSize()).toEqual(1)
 
 		local conn = collection.ClassRemoved:Connect(function() end)
-		env.binder:Untag(child)
+		controller.binder:Untag(child)
 		if collection:GetSize() == 1 then
 			collection.ClassRemoved:Wait()
 		end
@@ -207,6 +198,6 @@ describe("BoundChildCollection dynamic updates", function()
 
 		expect(collection:GetSize()).toEqual(0)
 
-		env.destroy()
+		controller.destroy()
 	end)
 end)

package/src/Shared/Promise/promiseBoundClass.spec.lua

@@ -1,11 +1,5 @@
 --!strict
 --[[
-	Coverage for promiseBoundClass, a thin wrapper that delegates to Binder:Promise after
-	validating its arguments.
-
-	The binder is booted through a ServiceBag; the instance is tagged before start so it binds
-	synchronously and the promise resolves immediately.
-
 	@class promiseBoundClass.spec.lua
 ]]
 
@@ -85,51 +79,51 @@ end
 
 describe("promiseBoundClass()", function()
 	it("resolves with the bound class", function()
-		local env = setup()
+		local controller = setup()
 
-		local inst = env.newInstance()
-		env.binder:Tag(inst)
-		env.boot()
+		local inst = controller.newInstance()
+		controller.binder:Tag(inst)
+		controller.boot()
 
-		local ok, class = promiseBoundClass(env.binder, inst):Yield()
+		local ok, class = promiseBoundClass(controller.binder, inst):Yield()
 		assert(ok, "Never bound")
-		expect(class).toEqual(env.binder:Get(inst))
+		expect(class).toEqual(controller.binder:Get(inst))
 
-		env.destroy()
+		controller.destroy()
 	end)
 
 	it("resolves once an instance is bound after start", function()
-		local env = setup()
+		local controller = setup()
 
-		env.boot()
-		local inst = env.newInstance()
-		env.binder:Tag(inst)
+		controller.boot()
+		local inst = controller.newInstance()
+		controller.binder:Tag(inst)
 
-		local ok = promiseBoundClass(env.binder, inst):Yield()
+		local ok = promiseBoundClass(controller.binder, inst):Yield()
 		expect(ok).toEqual(true)
 
-		env.destroy()
+		controller.destroy()
 	end)
 
 	it("throws when the binder is not a binder", function()
-		local env = setup()
-		env.boot()
+		local controller = setup()
+		controller.boot()
 
 		expect(function()
-			promiseBoundClass({} :: any, env.newInstance())
+			promiseBoundClass({} :: any, controller.newInstance())
 		end).toThrow()
 
-		env.destroy()
+		controller.destroy()
 	end)
 
 	it("throws when the instance is not an Instance", function()
-		local env = setup()
-		env.boot()
+		local controller = setup()
+		controller.boot()
 
 		expect(function()
-			promiseBoundClass(env.binder, 5 :: any)
+			promiseBoundClass(controller.binder, 5 :: any)
 		end).toThrow()
 
-		env.destroy()
+		controller.destroy()
 	end)
 end)

package/src/Shared/Trackers/BoundAncestorTracker.spec.lua

@@ -1,13 +1,5 @@
 --!strict
 --[[
-	Coverage for BoundAncestorTracker, which exposes the bound class of a child's nearest bound
-	ancestor.
-
-	The binder is booted through a ServiceBag; the tracker is a plain BaseObject constructed
-	directly. Instances live under a workspace container so ancestry and CollectionService signals
-	fire. Ancestry changes and late binds are awaited event-driven via the tracker's Class.Changed
-	signal rather than a fixed sleep.
-
 	@class BoundAncestorTracker.spec.lua
 ]]
 
@@ -108,68 +100,68 @@ end
 
 describe("BoundAncestorTracker tracking", function()
 	it("exposes the nearest bound ancestor's class", function()
-		local env = setup()
+		local controller = setup()
 
-		local grandparent = env.newInstance()
-		local parent = env.newInstance(grandparent)
-		local child = env.newInstance(parent)
-		env.binder:Tag(grandparent)
-		env.boot()
+		local grandparent = controller.newInstance()
+		local parent = controller.newInstance(grandparent)
+		local child = controller.newInstance(parent)
+		controller.binder:Tag(grandparent)
+		controller.boot()
 
-		local tracker = env.track(BoundAncestorTracker.new(env.binder, child))
-		expect(tracker.Class.Value).toEqual(env.binder:Get(grandparent))
+		local tracker = controller.track(BoundAncestorTracker.new(controller.binder, child))
+		expect(tracker.Class.Value).toEqual(controller.binder:Get(grandparent))
 
-		env.destroy()
+		controller.destroy()
 	end)
 
 	it("has no value when no ancestor is bound", function()
-		local env = setup()
+		local controller = setup()
 
-		local parent = env.newInstance()
-		local child = env.newInstance(parent)
-		env.boot()
+		local parent = controller.newInstance()
+		local child = controller.newInstance(parent)
+		controller.boot()
 
-		local tracker = env.track(BoundAncestorTracker.new(env.binder, child))
+		local tracker = controller.track(BoundAncestorTracker.new(controller.binder, child))
 		expect(tracker.Class.Value).toBeNil()
 
-		env.destroy()
+		controller.destroy()
 	end)
 
 	it("updates when an ancestor becomes bound", function()
-		local env = setup()
+		local controller = setup()
 
 		-- The tracker resolves ancestors above the child's direct parent, so bind the grandparent.
-		local ancestor = env.newInstance()
-		local parent = env.newInstance(ancestor)
-		local child = env.newInstance(parent)
-		env.boot()
+		local ancestor = controller.newInstance()
+		local parent = controller.newInstance(ancestor)
+		local child = controller.newInstance(parent)
+		controller.boot()
 
-		local tracker = env.track(BoundAncestorTracker.new(env.binder, child))
+		local tracker = controller.track(BoundAncestorTracker.new(controller.binder, child))
 		expect(tracker.Class.Value).toBeNil()
 
-		env.binder:Tag(ancestor)
-		local value = env.awaitChange(tracker, nil)
-		expect(value).toEqual(env.binder:Get(ancestor))
+		controller.binder:Tag(ancestor)
+		local value = controller.awaitChange(tracker, nil)
+		expect(value).toEqual(controller.binder:Get(ancestor))
 
-		env.destroy()
+		controller.destroy()
 	end)
 
 	it("clears the value when the child leaves the bound ancestry", function()
-		local env = setup()
+		local controller = setup()
 
-		local ancestor = env.newInstance()
-		local parent = env.newInstance(ancestor)
-		local child = env.newInstance(parent)
-		env.binder:Tag(ancestor)
-		env.boot()
+		local ancestor = controller.newInstance()
+		local parent = controller.newInstance(ancestor)
+		local child = controller.newInstance(parent)
+		controller.binder:Tag(ancestor)
+		controller.boot()
 
-		local tracker = env.track(BoundAncestorTracker.new(env.binder, child))
-		local class = env.binder:Get(ancestor)
+		local tracker = controller.track(BoundAncestorTracker.new(controller.binder, child))
+		local class = controller.binder:Get(ancestor)
 		expect(tracker.Class.Value).toEqual(class)
 
-		child.Parent = env.container
-		expect(env.awaitChange(tracker, class)).toBeNil()
+		child.Parent = controller.container
+		expect(controller.awaitChange(tracker, class)).toBeNil()
 
-		env.destroy()
+		controller.destroy()
 	end)
 end)

package/src/Shared/Trackers/BoundParentTracker.spec.lua

@@ -1,12 +1,5 @@
 --!strict
 --[[
-	Coverage for BoundParentTracker, which exposes the bound class on a child's direct parent.
-
-	The binder is booted through a ServiceBag; the tracker is a plain BaseObject constructed
-	directly. Instances live under a workspace container so parent-change and CollectionService
-	signals fire. Parent changes and unbinds are awaited event-driven via the tracker's
-	Class.Changed signal rather than a fixed sleep.
-
 	@class BoundParentTracker.spec.lua
 ]]
 
@@ -74,7 +67,6 @@ local function setup()
 		serviceBag:Start()
 	end
 
-	-- Blocks until the tracker's value moves off `previous`.
 	local function awaitChange(tracker, previous)
 		if tracker.Class.Value == previous then
 			tracker.Class.Changed:Wait()
@@ -116,52 +108,52 @@ end)
 
 describe("BoundParentTracker tracking", function()
 	it("exposes the bound class of the direct parent", function()
-		local env = setup()
+		local controller = setup()
 
-		local parent = env.newInstance()
-		local child = env.newInstance(parent)
-		env.binder:Tag(parent)
-		env.boot()
+		local parent = controller.newInstance()
+		local child = controller.newInstance(parent)
+		controller.binder:Tag(parent)
+		controller.boot()
 
-		local tracker = env.track(BoundParentTracker.new(env.binder, child))
-		expect(tracker.Class.Value).toEqual(env.binder:Get(parent))
+		local tracker = controller.track(BoundParentTracker.new(controller.binder, child))
+		expect(tracker.Class.Value).toEqual(controller.binder:Get(parent))
 
-		env.destroy()
+		controller.destroy()
 	end)
 
 	it("clears the value when the child is reparented off the bound parent", function()
-		local env = setup()
+		local controller = setup()
 
-		local parent = env.newInstance()
-		local child = env.newInstance(parent)
-		env.binder:Tag(parent)
-		env.boot()
+		local parent = controller.newInstance()
+		local child = controller.newInstance(parent)
+		controller.binder:Tag(parent)
+		controller.boot()
 
-		local tracker = env.track(BoundParentTracker.new(env.binder, child))
-		local class = env.binder:Get(parent)
+		local tracker = controller.track(BoundParentTracker.new(controller.binder, child))
+		local class = controller.binder:Get(parent)
 		expect(tracker.Class.Value).toEqual(class)
 
-		child.Parent = env.container
-		expect(env.awaitChange(tracker, class)).toBeNil()
+		child.Parent = controller.container
+		expect(controller.awaitChange(tracker, class)).toBeNil()
 
-		env.destroy()
+		controller.destroy()
 	end)
 
 	it("clears the value when the parent's class is unbound", function()
-		local env = setup()
+		local controller = setup()
 
-		local parent = env.newInstance()
-		local child = env.newInstance(parent)
-		env.binder:Tag(parent)
-		env.boot()
+		local parent = controller.newInstance()
+		local child = controller.newInstance(parent)
+		controller.binder:Tag(parent)
+		controller.boot()
 
-		local tracker = env.track(BoundParentTracker.new(env.binder, child))
-		local class = env.binder:Get(parent)
+		local tracker = controller.track(BoundParentTracker.new(controller.binder, child))
+		local class = controller.binder:Get(parent)
 		expect(tracker.Class.Value).toEqual(class)
 
-		env.binder:Untag(parent)
-		expect(env.awaitChange(tracker, class)).toBeNil()
+		controller.binder:Untag(parent)
+		expect(controller.awaitChange(tracker, class)).toBeNil()
 
-		env.destroy()
+		controller.destroy()
 	end)
 end)